Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-11 Thread wm4
On Mon, 10 Jul 2017 23:10:35 +0200 Michael Niedermayer wrote: > On Mon, Jul 10, 2017 at 10:37:46AM +0200, wm4 wrote: > > On Sun, 9 Jul 2017 22:03:21 +0200 > > Reimar Döffinger wrote: > > > > > On 09.07.2017, at 16:08, "Ronald S. Bultje" wrote: > > > > Hi, > > > > > > > > On Sun, Jul 9, 20

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-10 Thread Michael Niedermayer
On Mon, Jul 10, 2017 at 10:37:46AM +0200, wm4 wrote: > On Sun, 9 Jul 2017 22:03:21 +0200 > Reimar Döffinger wrote: > > > On 09.07.2017, at 16:08, "Ronald S. Bultje" wrote: > > > Hi, > > > > > > On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger > > > > > > wrote: > > > > > >> On 09.07.2017,

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-10 Thread wm4
On Mon, 10 Jul 2017 09:29:31 -0300 James Almer wrote: > On 7/10/2017 5:37 AM, wm4 wrote: > > On Sun, 9 Jul 2017 22:03:21 +0200 > > Reimar Döffinger wrote: > > > >> On 09.07.2017, at 16:08, "Ronald S. Bultje" wrote: > >>> Hi, > >>> > >>> On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-10 Thread James Almer
On 7/10/2017 5:37 AM, wm4 wrote: > On Sun, 9 Jul 2017 22:03:21 +0200 > Reimar Döffinger wrote: > >> On 09.07.2017, at 16:08, "Ronald S. Bultje" wrote: >>> Hi, >>> >>> On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger >>> wrote: >>> On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: >>

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-10 Thread wm4
On Sun, 9 Jul 2017 22:03:21 +0200 Reimar Döffinger wrote: > On 09.07.2017, at 16:08, "Ronald S. Bultje" wrote: > > Hi, > > > > On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger > > wrote: > > > >> On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: > >>> On Sat, Jul 8, 2017 at 5:17 PM, Mic

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Ivan Kalvachev
On 7/9/17, Ronald S. Bultje wrote: > Hi, > > On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger > wrote: > >> On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: >> > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer >> >> > wrote: >> > >> >> >> >> Does anyone object to this patch ? >> >> Or doe

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 16:08, "Ronald S. Bultje" wrote: > Hi, > > On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger > wrote: > >> On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: >>> On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer >> >>> wrote: >>> Does anyone object to this patch

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Michael Niedermayer
On Sun, Jul 09, 2017 at 10:08:50AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger > wrote: > > > On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: > > > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > > > > > wrote: > > > > > >> > > >> Does any

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Ronald S. Bultje
Hi, On Sun, Jul 9, 2017 at 4:39 AM, Reimar Döffinger wrote: > On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: > > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > > > wrote: > > > >> > >> Does anyone object to this patch ? > >> Or does anyone have a better idea on how to fix this ? > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Ivan Kalvachev
On 7/9/17, Ronald S. Bultje wrote: > Hi, > > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > wrote: > >> On Mon, Jul 03, 2017 at 01:37:09AM +0200, Michael Niedermayer wrote: >> > On Sun, Jul 02, 2017 at 02:24:53PM +0100, Rostislav Pehlivanov wrote: >> > > On 2 July 2017 at 03:28, Michael Ni

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-09 Thread Reimar Döffinger
On 09.07.2017, at 02:52, "Ronald S. Bultje" wrote: > On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer > wrote: > >> >> Does anyone object to this patch ? >> Or does anyone have a better idea on how to fix this ? >> if not id like to apply it > > > I think Rostislav's point is: why fix it,

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-08 Thread Ronald S. Bultje
Hi, On Sat, Jul 8, 2017 at 5:17 PM, Michael Niedermayer wrote: > On Mon, Jul 03, 2017 at 01:37:09AM +0200, Michael Niedermayer wrote: > > On Sun, Jul 02, 2017 at 02:24:53PM +0100, Rostislav Pehlivanov wrote: > > > On 2 July 2017 at 03:28, Michael Niedermayer > wrote: > > > > > > > Fixes: runtim

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-08 Thread Michael Niedermayer
On Mon, Jul 03, 2017 at 01:37:09AM +0200, Michael Niedermayer wrote: > On Sun, Jul 02, 2017 at 02:24:53PM +0100, Rostislav Pehlivanov wrote: > > On 2 July 2017 at 03:28, Michael Niedermayer wrote: > > > > > Fixes: runtime error: signed integer overflow: 1965219850 + 995792909 > > > cannot be repr

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-02 Thread Michael Niedermayer
On Sun, Jul 02, 2017 at 02:24:53PM +0100, Rostislav Pehlivanov wrote: > On 2 July 2017 at 03:28, Michael Niedermayer wrote: > > > Fixes: runtime error: signed integer overflow: 1965219850 + 995792909 > > cannot be represented in type 'int' > > Fixes: part of 2096/clusterfuzz-testcase-minimized-49

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-02 Thread Rostislav Pehlivanov
On 2 July 2017 at 03:28, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: 1965219850 + 995792909 > cannot be represented in type 'int' > Fixes: part of 2096/clusterfuzz-testcase-minimized-4901566068817920 > > Found-by: continuous fuzzing process https://github.com/googl

[FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

2017-07-01 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: 1965219850 + 995792909 cannot be represented in type 'int' Fixes: part of 2096/clusterfuzz-testcase-minimized-4901566068817920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael