Re: [FFmpeg-devel] [PATCH V1] lavc/mpeg4audio: add chan_config check to avoid indeterminate channels

2019-09-27 Thread James Almer
On 9/21/2019 8:29 AM, Jun Zhao wrote: > From: Jun Zhao > > add chan_config check to avoid indeterminate channels. > > Signed-off-by: Jun Zhao > --- > libavcodec/mpeg4audio.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/libavcodec/mpeg4audio.c

Re: [FFmpeg-devel] [PATCH V1] lavc/mpeg4audio: add chan_config check to avoid indeterminate channels

2019-09-21 Thread James Almer
On 9/21/2019 8:29 AM, Jun Zhao wrote: > From: Jun Zhao > > add chan_config check to avoid indeterminate channels. > > Signed-off-by: Jun Zhao > --- > libavcodec/mpeg4audio.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/libavcodec/mpeg4audio.c

Re: [FFmpeg-devel] [PATCH V1] lavc/mpeg4audio: add chan_config check to avoid indeterminate channels

2019-09-21 Thread James Almer
On 9/21/2019 10:07 AM, Moritz Barsnick wrote: > On Sat, Sep 21, 2019 at 19:29:47 +0800, Jun Zhao wrote: >> +else { >> +av_log(NULL, AV_LOG_ERROR, "Invalid chan_config %d\n", >> c->chan_config); >> +return -1; >> +} > > I know the function definition says it returns -1 on

Re: [FFmpeg-devel] [PATCH V1] lavc/mpeg4audio: add chan_config check to avoid indeterminate channels

2019-09-21 Thread Moritz Barsnick
On Sat, Sep 21, 2019 at 19:29:47 +0800, Jun Zhao wrote: > +else { > +av_log(NULL, AV_LOG_ERROR, "Invalid chan_config %d\n", > c->chan_config); > +return -1; > +} I know the function definition says it returns -1 on error, but that's already not the case: It can return

[FFmpeg-devel] [PATCH V1] lavc/mpeg4audio: add chan_config check to avoid indeterminate channels

2019-09-21 Thread Jun Zhao
From: Jun Zhao add chan_config check to avoid indeterminate channels. Signed-off-by: Jun Zhao --- libavcodec/mpeg4audio.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/libavcodec/mpeg4audio.c b/libavcodec/mpeg4audio.c index 2197147..0ada239 100644 ---