Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-25 Thread John Cox
On Sun, 23 Jul 2023 17:04:55 -0300, you wrote: >On 7/23/2023 4:40 PM, Paul B Mahol wrote: >> On Sun, Jul 23, 2023 at 9:26?PM Nicolas George wrote: >> >>> James Almer (12023-07-23): What about when FF_FILTER_FLAG_HWFRAME_AWARE filters are present in the graph? hw_frames_ctx from

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-24 Thread James Almer
On 7/24/2023 6:07 AM, Paul B Mahol wrote: On Mon, Jul 24, 2023 at 10:21 AM Nicolas George wrote: Paul B Mahol (12023-07-23): Your comment is extremely rude and unhelpful. I am sorry for any perceived rudeness. Shall I point each time I find your comments to me extremely rude and/or

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-24 Thread Kieran Kunhya
> What is the benefit of supporting a custom allocator for all filters in > the chain? Internally, it's already using a very optimized buffer pool. > The caller only cares about how what they get out of buffersink is > You may want to reuse a larger existing pool instead of FFmpeg have its own.

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-24 Thread Paul B Mahol
On Mon, Jul 24, 2023 at 10:21 AM Nicolas George wrote: > Paul B Mahol (12023-07-23): > > Your comment is extremely rude and unhelpful. > > I am sorry for any perceived rudeness. Shall I point each time I find > your comments to me extremely rude and/or unhelpful too? > > > The patch at best only

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-24 Thread Nicolas George
Paul B Mahol (12023-07-23): > Your comment is extremely rude and unhelpful. I am sorry for any perceived rudeness. Shall I point each time I find your comments to me extremely rude and/or unhelpful too? > The patch at best only replaces last get_buffer call of buffersink. Yes, indeed, that is

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread James Almer
On 7/23/2023 4:40 PM, Paul B Mahol wrote: On Sun, Jul 23, 2023 at 9:26 PM Nicolas George wrote: James Almer (12023-07-23): What about when FF_FILTER_FLAG_HWFRAME_AWARE filters are present in the graph? hw_frames_ctx from AVFilterLink can't be accessed from outside lavfi. Is vf_hwdownload

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread Paul B Mahol
On Sun, Jul 23, 2023 at 9:36 PM Nicolas George wrote: > Paul B Mahol (12023-07-23): > > - missing audio support > > You realize that direct rendering is order of magnitude more useful for > video frames than for audio, right? > That does not make patch more complete. > > > - missing full

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread Paul B Mahol
On Sun, Jul 23, 2023 at 9:36 PM Nicolas George wrote: > Paul B Mahol (12023-07-23): > > - missing audio support > > You realize that direct rendering is order of magnitude more useful for > video frames than for audio, right? > > > - missing full internal buffers allocation replacement support >

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread Nicolas George
Paul B Mahol (12023-07-23): > - missing audio support You realize that direct rendering is order of magnitude more useful for video frames than for audio, right? > - missing full internal buffers allocation replacement support Nonsense. > - missing/untested hardware acceleration support

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread Paul B Mahol
On Sun, Jul 23, 2023 at 9:26 PM Nicolas George wrote: > James Almer (12023-07-23): > > What about when FF_FILTER_FLAG_HWFRAME_AWARE filters are present in the > > graph? hw_frames_ctx from AVFilterLink can't be accessed from outside > lavfi. > > Is vf_hwdownload meant to be added to the graph

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread Nicolas George
James Almer (12023-07-23): > What about when FF_FILTER_FLAG_HWFRAME_AWARE filters are present in the > graph? hw_frames_ctx from AVFilterLink can't be accessed from outside lavfi. > Is vf_hwdownload meant to be added to the graph before buffersink? I do not know how hardware acceleration works at

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread James Almer
On 7/23/2023 4:06 PM, Nicolas George wrote: James Almer (12023-07-23): Does the AVBuffersinkAllocVideoFrameFunc function have access to the AVFilterLink ff_default_get_video_buffer() gets? I assume it'd be needed to get values like pixel format. If so, it should be documented how, but maybe

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread Nicolas George
James Almer (12023-07-23): > Does the AVBuffersinkAllocVideoFrameFunc function have access to the > AVFilterLink ff_default_get_video_buffer() gets? I assume it'd be needed to > get values like pixel format. If so, it should be documented how, but maybe > it's easier to just pass link here instead

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread John Cox
Hi >On 7/22/2023 2:03 PM, John Cox wrote: >> Add a callback to enable user allocation of video frames on the final >> stage of a filter chain. >> >> Signed-off-by: John Cox >> --- >> libavfilter/buffersink.c | 21 + >> libavfilter/buffersink.h | 27

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread James Almer
On 7/22/2023 2:03 PM, John Cox wrote: Add a callback to enable user allocation of video frames on the final stage of a filter chain. Signed-off-by: John Cox --- libavfilter/buffersink.c | 21 + libavfilter/buffersink.h | 27 +++

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread Andreas Rheinhardt
John Cox: > On Sat, 22 Jul 2023 21:14:24 +0200, you wrote: > >> John Cox: >>> Add a callback to enable user allocation of video frames on the final >>> stage of a filter chain. >>> >>> Signed-off-by: John Cox >>> --- >>> libavfilter/buffersink.c | 21 + >>>

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-23 Thread John Cox
On Sat, 22 Jul 2023 21:14:24 +0200, you wrote: >John Cox: >> Add a callback to enable user allocation of video frames on the final >> stage of a filter chain. >> >> Signed-off-by: John Cox >> --- >> libavfilter/buffersink.c | 21 + >> libavfilter/buffersink.h | 27

Re: [FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-22 Thread Andreas Rheinhardt
John Cox: > Add a callback to enable user allocation of video frames on the final > stage of a filter chain. > > Signed-off-by: John Cox > --- > libavfilter/buffersink.c | 21 + > libavfilter/buffersink.h | 27 +++ > libavfilter/version.h| 2 +- >

[FFmpeg-devel] [PATCH v3 1/1] avfilter/buffersink: Add video frame allocation callback

2023-07-22 Thread John Cox
Add a callback to enable user allocation of video frames on the final stage of a filter chain. Signed-off-by: John Cox --- libavfilter/buffersink.c | 21 + libavfilter/buffersink.h | 27 +++ libavfilter/version.h| 2 +- 3 files changed, 49