still lgtm
If nobody objects, i'll push later today.
Timo
signature.asc
Description: OpenPGP digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 9/21/15, Timo Rothenpieler wrote:
>> Benefit would be to save 2 branching and 2 div (the div can already be
>> replaced by a shift here though - which would have a benefit since x & y
>> are signed) and keep the code generic.
>
> Changed it to a shift and moved the if() out of the loop.
> No ob
> Benefit would be to save 2 branching and 2 div (the div can already be
> replaced by a shift here though - which would have a benefit since x & y
> are signed) and keep the code generic.
Changed it to a shift and moved the if() out of the loop.
No observable performance benefit though.
+
On Mon, Sep 21, 2015 at 03:51:37PM +0200, Timo Rothenpieler wrote:
> >> +if (frame->format == AV_PIX_FMT_YUVA420P || frame->format ==
> >> AV_PIX_FMT_YUVA422P)
> >> +x /= 2;
> >> +
> >> +if (frame->format == AV_PIX_FMT_YUVA420P)
> >> +y /= 2;
> >
> > Why not use the usual
>> +if (frame->format == AV_PIX_FMT_YUVA420P || frame->format ==
>> AV_PIX_FMT_YUVA422P)
>> +x /= 2;
>> +
>> +if (frame->format == AV_PIX_FMT_YUVA420P)
>> +y /= 2;
>
> Why not use the usual subsampling mechanism? (using vsub/hsub etc)
That seemed more complex to me, as th
On Fri, Sep 18, 2015 at 04:27:54PM +0200, Timo Rothenpieler wrote:
> ---
> Changelog | 1 +
> MAINTAINERS| 1 +
> doc/filters.texi | 45 +++
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/version.h
Hi,
I know the docs is similar to colorkey, but I have a few short
suggestions.
On Fri, 18 Sep 2015 16:27:54 +0200, Timo Rothenpieler wrote:
[...]
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 4a55e59..0446204 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -3556,6 +35
On 9/18/15, Timo Rothenpieler wrote:
> ---
> Changelog | 1 +
> MAINTAINERS| 1 +
> doc/filters.texi | 45 +++
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/version.h | 2 +-
> libavfilter/v
---
Changelog | 1 +
MAINTAINERS| 1 +
doc/filters.texi | 45 +++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/version.h | 2 +-
libavfilter/vf_chromakey.c | 198 ++
