Another batch of different issues.
Christophe Gisquet (4):
wavpackenc: fix number of samples per block
wavpackenc: make assert more thorough
wavpack: check number of channels
wavpackenc: reset trailer info on block encoding
libavcodec/wavpack.c| 5 -
libavcodec/wavpackenc.c | 7
It was only validating that normal data wasn't filling the buffer.
However, extra data may be written afterwards.
---
libavcodec/wavpackenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/wavpackenc.c b/libavcodec/wavpackenc.c
index 169836a..299a035 100644
---
This means container and codec disagree. The codec is supposed to
know better so this could be an error instead.
---
libavcodec/wavpack.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c
index 9f72ebe..1ad3901 100644
---
In some cases, in particular if several blocks are needed because of
the channel layout (e.g. 2.1), the information used to write the
trailing bits terminating the sample data was not reset.
This would cause potential desync on the decoder, although decoded
samples were actually mostly fine.
Patch okay.
Mickaël
Le 4 août 2014 à 10:31, Christophe Gisquet christophe.gisq...@gmail.com a
écrit :
Hi,
2014-08-02 14:48 GMT+02:00 Michael Niedermayer michae...@gmx.at:
seems to fail with
libavcodec/x86/hevc_mc.asm:1258: error: (add:2) cannot reference symbol
`MAX_PB_SIZE' in
On Fri, Aug 22, 2014 at 09:31:42AM +, Christophe Gisquet wrote:
Currently, the encoder will try to reduce it down to 15, but the
decoder will complain starting at 131072 (WV_MAX_SAMPLES). Therefore,
change the loop limit.
Fixes ticket #3881.
---
libavcodec/wavpackenc.c | 2 +-
1
On Fri, Aug 22, 2014 at 09:31:43AM +, Christophe Gisquet wrote:
It was only validating that normal data wasn't filling the buffer.
However, extra data may be written afterwards.
---
libavcodec/wavpackenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
applied
thanks
[...]
--
On Fri, Aug 22, 2014 at 11:40:17AM +0200, Mickaël Raulet wrote:
Patch okay.
patch applied
just to make sure i dont misunderstand, that okay was just for this
patch or the whole patchset ?
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In fact, the
for the whole patchset.
Mickaël
Le 22 août 2014 à 13:25, Michael Niedermayer michae...@gmx.at a écrit :
On Fri, Aug 22, 2014 at 11:40:17AM +0200, Mickaël Raulet wrote:
Patch okay.
patch applied
just to make sure i dont misunderstand, that okay was just for this
patch or the whole
On 8/22/14, Christophe Gisquet christophe.gisq...@gmail.com wrote:
This means container and codec disagree. The codec is supposed to
know better so this could be an error instead.
---
libavcodec/wavpack.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
On 8/22/14, Christophe Gisquet christophe.gisq...@gmail.com wrote:
In some cases, in particular if several blocks are needed because of
the channel layout (e.g. 2.1), the information used to write the
trailing bits terminating the sample data was not reset.
This would cause potential desync
On Mon, Jul 28, 2014 at 05:17:25PM +, Christophe Gisquet wrote:
---
libavcodec/hevc.h| 1 -
libavcodec/hevcdsp.h | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
applied
thanks
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code
On Mon, Jul 28, 2014 at 05:17:26PM +, Christophe Gisquet wrote:
The dststride parameter is always MAX_PB_SIZE.
---
libavcodec/hevc.c | 4 ++--
libavcodec/hevcdsp.h | 4 ++--
libavcodec/hevcdsp_template.c | 27 +--
libavcodec/x86/hevc_mc.asm
On Mon, Aug 04, 2014 at 06:46:17PM +0200, Christophe Gisquet wrote:
2014-07-28 19:17 GMT+02:00 Christophe Gisquet christophe.gisq...@gmail.com:
---
libavcodec/hevc.c | 8 +++
libavcodec/hevcdsp.h | 8 +++
libavcodec/hevcdsp_template.c | 56
On Mon, Jul 28, 2014 at 05:17:28PM +, Christophe Gisquet wrote:
The stride for some buffers is known.
---
libavcodec/x86/hevc_mc.asm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
applied
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
On Fri, Aug 22, 2014 at 02:04:36PM +0200, Mickaël Raulet wrote:
for the whole patchset.
all applied
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by
Hi,
2014-08-22 1:21 GMT+02:00 Christophe Gisquet christophe.gisq...@gmail.com:
Maybe all that side data stuff should be moved to the end of the
function first (but before the last thread-related line), and fixed,
then you also add this hunk there?
Not a good thing to do either, after
Hi,
following [PATCH] h264: Move AFD to side data to match MPEG-2, it
was mentioned making sidedata allocation failures non-fatal.
This patch is a proposal for this.
--
Christophe
From 7092da22cf0efbdb0988810bd30c279d18388fdc Mon Sep 17 00:00:00 2001
From: Christophe Gisquet
Changes in the parameter mapping for libvpx to support the constant
quality mode in VP9. The assumption in the patch is that if crf is
provided but bitrate is 0, then the 'constant quality' mode of VP9
is used. However if both are present, the 'constrained quality' mode
is used as before.
---
Sets aq_mode in the [0, 3] range for the libvpx encode wrapper.
0: none
1: variance aq
2: complexity aq
3: cyclic refresh aq
---
doc/encoders.texi | 5 -
libavcodec/libvpxenc.c | 9 +
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/doc/encoders.texi
On Fri, Aug 22, 2014 at 10:53 AM, Deb Mukherjee debar...@google.com wrote:
[...]
@@ -311,7 +316,7 @@ static av_cold int vpx_init(AVCodecContext *avctx,
} else {
if (enccfg.rc_end_usage == VPX_CQ) {
enccfg.rc_target_bitrate = 100;
-} else {
+}
On Thu, Aug 21, 2014 at 07:12:10PM -0700, Timothy Gu wrote:
Signed-off-by: Timothy Gu timothyg...@gmail.com
---
libavfilter/vidstabutils.h | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
both patches applied
[...]
--
Michael GnuPG fingerprint:
Handles new VP9 profiles 1-3 with different color sampling and
bit-depths.
---
libavcodec/libvpxdec.c | 69 +++---
1 file changed, 60 insertions(+), 9 deletions(-)
diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c
index 94e1e4d..7c397fb
On Aug 22, 2014 1:29 PM, Debargha Mukherjee debar...@google.com wrote:
Unless the codec is VP9, VPX_Q will not be set. So the behavior does not
change for VP8.
If it's not set, then the code won't compile with older libvpx.
Timothy
___
ffmpeg-devel
On Thu, Aug 21, 2014 at 10:07:23PM -0700, Timothy Gu wrote:
On Aug 21, 2014 10:14 AM, Christophe Gisquet christophe.gisq...@gmail.com
wrote:
Hi,
2014-08-21 3:06 GMT+02:00 Michael Niedermayer michae...@gmx.at:
heres a narrower solution for this file
not sure its better
i can
On 22.08.2014, at 22:31, Deb Mukherjee debar...@google.com wrote:
+// returns 0 on success, 1 on unsupported
Please choose one of the standard ways, either 1 for success and 0 failure, or
negative failure, 0 or positive success. This variant, at least in the context
of FFmpeg, is just
On 22/08/14 5:31 PM, Deb Mukherjee wrote:
Handles new VP9 profiles 1-3 with different color sampling and
bit-depths.
---
libavcodec/libvpxdec.c | 69
+++---
1 file changed, 60 insertions(+), 9 deletions(-)
diff --git a/libavcodec/libvpxdec.c
On Thu, Aug 21, 2014 at 7:33 AM, Muhammad Faiz mfc...@gmail.com wrote:
On Thu, Aug 21, 2014 at 3:49 AM, Clément Bœsch u...@pkh.me wrote:
On Wed, Aug 20, 2014 at 07:10:56AM +0700, Muhammad Faiz wrote:
[...]
+static double r_func(void *p, double x)
+{
+x = av_clipd(x, 0.0, 1.0);
+
On Fri, Aug 22, 2014 at 04:57:35PM +0200, Christophe Gisquet wrote:
Hi,
following [PATCH] h264: Move AFD to side data to match MPEG-2, it
was mentioned making sidedata allocation failures non-fatal.
This patch is a proposal for this.
--
Christophe
h264.c | 16 +++-
1
On 22/08/14 3:25 PM, Deb Mukherjee wrote:
@@ -803,6 +807,11 @@ static const AVOption vp9_options[] = {
{ tile-columns,Number of tile columns to use, log2,
OFFSET(tile_columns),AV_OPT_TYPE_INT, {.i64 = -1}, -1, 6, VE},
{ tile-rows, Number of tile rows to use,
Derived from deflate code.
Requires liblzma.
Signed-off-by: James Almer jamr...@gmail.com
---
Changelog | 1 +
configure | 5 +++-
libavcodec/tiff.c | 85 +--
3 files changed, 88 insertions(+), 3 deletions(-)
diff --git
31 matches
Mail list logo
