Re: [FFmpeg-devel] [PATCH] mmaldec: Set the output pix_fmt after detecting format

2015-10-21 Thread wm4
On Wed, 21 Oct 2015 15:55:09 +0200 Julian Scheel wrote: > Wait for the first decoded frame to be returned by mmal before setting > pix_fmt. This is important for avformat probing to work properly as it is one > of the criterions to decide whether to decode a frame or not for

[FFmpeg-devel] [PATCH] mmaldec: Set the output pix_fmt after detecting format

2015-10-21 Thread Julian Scheel
Wait for the first decoded frame to be returned by mmal before setting pix_fmt. This is important for avformat probing to work properly as it is one of the criterions to decide whether to decode a frame or not for probing. Signed-off-by: Julian Scheel --- libavcodec/mmaldec.c |

Re: [FFmpeg-devel] [PATCH] mmaldec: Add mpeg2 decoding support

2015-10-21 Thread wm4
On Wed, 21 Oct 2015 15:54:39 +0200 Julian Scheel wrote: > Register mmaldec as mpeg2 decoder. Supporting mpeg2 in mmaldec is just a > matter of setting the correct MMAL_ENCODING on the input port. To ease the > addition of further supported mmal codecs a macro is introduced to

Re: [FFmpeg-devel] [PATCH] mmaldec: Add mpeg2 decoding support

2015-10-21 Thread Hendrik Leppkes
On Wed, Oct 21, 2015 at 3:54 PM, Julian Scheel wrote: > Register mmaldec as mpeg2 decoder. Supporting mpeg2 in mmaldec is just a > matter of setting the correct MMAL_ENCODING on the input port. To ease the > addition of further supported mmal codecs a macro is introduced to

[FFmpeg-devel] [PATCH] mmaldec: Add mpeg2 decoding support

2015-10-21 Thread Julian Scheel
Register mmaldec as mpeg2 decoder. Supporting mpeg2 in mmaldec is just a matter of setting the correct MMAL_ENCODING on the input port. To ease the addition of further supported mmal codecs a macro is introduced to generate the decoder and decoder class structs. Signed-off-by: Julian Scheel

Re: [FFmpeg-devel] [PATCH] mmaldec: Set the output pix_fmt after detecting format

2015-10-21 Thread wm4
On Wed, 21 Oct 2015 16:07:08 +0200 Hendrik Leppkes wrote: > On Wed, Oct 21, 2015 at 3:55 PM, Julian Scheel wrote: > > Wait for the first decoded frame to be returned by mmal before setting > > pix_fmt. This is important for avformat probing to work properly

[FFmpeg-devel] [PATCHv2] mmaldec: Add mpeg2 decoding support

2015-10-21 Thread Julian Scheel
Register mmaldec as mpeg2 decoder. Supporting mpeg2 in mmaldec is just a matter of setting the correct MMAL_ENCODING on the input port. To ease the addition of further supported mmal codecs a macro is introduced to generate the decoder and decoder class structs. Signed-off-by: Julian Scheel

Re: [FFmpeg-devel] [PATCH] mmaldec: Add mpeg2 decoding support

2015-10-21 Thread Julian Scheel
Am 21.10.2015 um 16:09 schrieb Hendrik Leppkes: On Wed, Oct 21, 2015 at 3:54 PM, Julian Scheel wrote: Register mmaldec as mpeg2 decoder. Supporting mpeg2 in mmaldec is just a matter of setting the correct MMAL_ENCODING on the input port. To ease the addition of further

Re: [FFmpeg-devel] [PATCH] mmaldec: Set the output pix_fmt after detecting format

2015-10-21 Thread Julian Scheel
Am 21.10.2015 um 16:18 schrieb wm4: On Wed, 21 Oct 2015 16:07:08 +0200 Hendrik Leppkes wrote: On Wed, Oct 21, 2015 at 3:55 PM, Julian Scheel wrote: Wait for the first decoded frame to be returned by mmal before setting pix_fmt. This is important for

Re: [FFmpeg-devel] [PATCH] avformat/electronicarts: support ADPCM PSX

2015-10-21 Thread Peter Ross
On Wed, Oct 21, 2015 at 11:14:02PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/electronicarts.c | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/libavformat/electronicarts.c

[FFmpeg-devel] [PATCH 00/11] MXF decoder fixes/improvements.

2015-10-21 Thread Alexis Ballier
Main patch is patch 4/11 fixing 2 tickets. Patches 5+ are not very useful by themselves but since I wrote the code for them trying to understand the issue, I thought I'd just send them anyway. Those can be dropped without any problem. Alexis Ballier (11): libavformat/mxfdec.c: klv_read_packet:

[FFmpeg-devel] [PATCH 08/11] libavformat/mxfdec.c: Parse track position.

2015-10-21 Thread Alexis Ballier
--- libavformat/mxfdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 2b776f6..5c224ef 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -161,6 +161,7 @@ typedef struct { int intra_only; uint64_t sample_count;

[FFmpeg-devel] [PATCH 06/11] libavformat/mxfdec.c: Parse source clip data_definition_ul.

2015-10-21 Thread Alexis Ballier
--- libavformat/mxfdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index e16c678..1320fad 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -722,6 +722,9 @@ static int mxf_read_source_clip(void *arg, AVIOContext *pb, int tag,

[FFmpeg-devel] [PATCH 07/11] libavformat/mxfdec.c: Parse timecode component data_definition_ul and duration.

2015-10-21 Thread Alexis Ballier
--- libavformat/mxfdec.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 1320fad..2b776f6 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -121,6 +121,8 @@ typedef struct MXFSequence { typedef struct

Re: [FFmpeg-devel] [PATCH] mmaldec: Set the output pix_fmt after detecting format

2015-10-21 Thread Julian Scheel
Am 21.10.2015 um 17:24 schrieb wm4: On Wed, 21 Oct 2015 17:15:14 +0200 Julian Scheel wrote: Am 21.10.2015 um 16:18 schrieb wm4: On Wed, 21 Oct 2015 16:07:08 +0200 Hendrik Leppkes wrote: On Wed, Oct 21, 2015 at 3:55 PM, Julian Scheel

[FFmpeg-devel] [PATCH 11/11] libavformat/mxfdec.c: Log unknown metadata tags. This should help in seeing missing features.

2015-10-21 Thread Alexis Ballier
--- libavformat/mxfdec.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 020294d..606afe6 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -727,6 +727,8 @@ static int mxf_read_content_storage(void *arg,

[FFmpeg-devel] [PATCH 10/11] libavformat/mxfdec.c: Parse index table segment DeltaEntryArray.

2015-10-21 Thread Alexis Ballier
--- libavformat/mxfdec.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 75858fc..020294d 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -192,6 +192,12 @@ typedef struct MXFDescriptor {

[FFmpeg-devel] [PATCH 09/11] libavformat/mxfdec.c: Parse index table segment slice_count.

2015-10-21 Thread Alexis Ballier
--- libavformat/mxfdec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 5c224ef..75858fc 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -198,6 +198,7 @@ typedef struct MXFIndexTableSegment { int

[FFmpeg-devel] [PATCH 01/11] libavformat/mxfdec.c: klv_read_packet: Properly check klv_decode_ber_length return value.

2015-10-21 Thread Alexis Ballier
klv_decode_ber_length cannot return -1, but can return AVERROR_INVALIDDATA. Store its return value in a signed integer (instead of unsigned KLVPacket.length) and forward the error appropriately. --- libavformat/mxfdec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH 02/11] libavformat/mxfdec.c: cosmetics: Add missing space after '?' in log message.

2015-10-21 Thread Alexis Ballier
--- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 94a953b..0ae7ce6 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2959,7 +2959,7 @@ static int mxf_read_packet_old(AVFormatContext *s,

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread James Darnley
On 2015-10-21 12:18, wm4 wrote: > with size_t/ptrdiff_t > being 128 bit, and a new "long long long int" type (I swear, they will > do it, even if that type name looks horrible). Please no! Just require a C99 style uint128_t/int128_t type. signature.asc Description: OpenPGP digital signature

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread James Darnley
On 2015-10-21 14:44, Clément Bœsch wrote: > On Wed, Oct 21, 2015 at 06:00:21AM -0400, Ganesh Ajjanagadde wrote: > [...] >> why don't you spend 5 minutes trying to outline to beginners like me >> what is "actually important" in your view? >> > > According to the first 100 answers of the survey,

[FFmpeg-devel] [PATCH 05/11] libavformat/mxfdec.c: Fix typo in named struct definition.

2015-10-21 Thread Alexis Ballier
typedef struct MXFTrack { ... } MXFTimecodeComponent; -> typedef struct MXFTimecodeComponent { ... } MXFTimecodeComponent; --- libavformat/mxfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 526eca6..e16c678 100644 ---

[FFmpeg-devel] [PATCH 04/11] libavformat/mxfdec.c: Try to increment current edit before rejecting a klv that spans onto next edit unit.

2015-10-21 Thread Alexis Ballier
Some files such as those from tickets #2817 & #2776 claim to have constant edit unit size but, in fact, have some of them that are smaller. This confuses the demuxer that tries to infer the current edit unit from the position in the file. By trying to increment the current edit unit before

[FFmpeg-devel] [PATCH 03/11] libavformat/mxfdec.c: Report dark metadata keys only when they match no parser at all, not everytime they fail to match one.

2015-10-21 Thread Alexis Ballier
--- libavformat/mxfdec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 0ae7ce6..593604e 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2767,13 +2767,13 @@ static int mxf_read_header(AVFormatContext

Re: [FFmpeg-devel] [PATCH] mmaldec: Set the output pix_fmt after detecting format

2015-10-21 Thread Hendrik Leppkes
On Wed, Oct 21, 2015 at 3:55 PM, Julian Scheel wrote: > Wait for the first decoded frame to be returned by mmal before setting > pix_fmt. This is important for avformat probing to work properly as it is one > of the criterions to decide whether to decode a frame or not for

Re: [FFmpeg-devel] [PATCH] mmaldec: Set the output pix_fmt after detecting format

2015-10-21 Thread wm4
On Wed, 21 Oct 2015 17:15:14 +0200 Julian Scheel wrote: > Am 21.10.2015 um 16:18 schrieb wm4: > > On Wed, 21 Oct 2015 16:07:08 +0200 > > Hendrik Leppkes wrote: > > > >> On Wed, Oct 21, 2015 at 3:55 PM, Julian Scheel wrote: > >>> Wait

Re: [FFmpeg-devel] [PATCH] vc1dsp: Port ff_vc1_put_ver_16b_shift2_mmx to yasm

2015-10-21 Thread Christophe Gisquet
Hi, 2015-10-18 2:47 GMT+02:00 Timothy Gu : > This function is only used within other inline asm functions, hence the > HAVE_MMX_INLINE guard. Per recent discussions, we should not worry about > the performance of inline asm-only builds. On a quick glance, looks good. >

Re: [FFmpeg-devel] [PATCH] mmaldec: Set the output pix_fmt after detecting format

2015-10-21 Thread wm4
On Wed, 21 Oct 2015 18:48:42 +0200 Julian Scheel wrote: > Am 21.10.2015 um 17:24 schrieb wm4: > > On Wed, 21 Oct 2015 17:15:14 +0200 > > Julian Scheel wrote: > > > >> Am 21.10.2015 um 16:18 schrieb wm4: > >>> On Wed, 21 Oct 2015 16:07:08 +0200 > >>> Hendrik

Re: [FFmpeg-devel] [PATCH] mmaldec: Set the output pix_fmt after detecting format

2015-10-21 Thread Julian Scheel
On 21.10.15 19:11, wm4 wrote: On Wed, 21 Oct 2015 18:48:42 +0200 Julian Scheel wrote: Am 21.10.2015 um 17:24 schrieb wm4: On Wed, 21 Oct 2015 17:15:14 +0200 Julian Scheel wrote: Am 21.10.2015 um 16:18 schrieb wm4: On Wed, 21 Oct 2015 16:07:08 +0200

Re: [FFmpeg-devel] [PATCH] avfilter/vf_ssim: Add support for writing stats to stdout

2015-10-21 Thread Paul B Mahol
On 10/21/15, Tobias Rapp wrote: > Analogous to my previous patch to vf_psnr.c the attached patch > implements writing SSIM frame stats to standard output if the filename > is "-". > > Regards, > Tobias > lgtm ___ ffmpeg-devel

Re: [FFmpeg-devel] Encoding with QSV at an API level.

2015-10-21 Thread Paul Knopf
I just realized that I was also getting an error on the stdout. [h264_qsv @ 00c7e6d8e680] Specified pixel format yuv420p is invalid or not supported On Wed, Oct 21, 2015 at 3:13 PM, Paul Knopf wrote: > Hey guys, > > Is there an example somewhere, using the

[FFmpeg-devel] Encoding with QSV at an API level.

2015-10-21 Thread Paul Knopf
Hey guys, Is there an example somewhere, using the "h264_qsv" encoder at an API level? Let's say I have an application that encodes and muxes a file to mp4, using libx264. Is it possible to just switch encoders? Will other things have to change, like pixel formats? I switched the encoders just

Re: [FFmpeg-devel] [PATCH] huffyuvencdsp: Add ff_diff_bytes_{sse2, avx2}

2015-10-21 Thread Timothy Gu
On Wed, Oct 21, 2015 at 10:32 AM Timothy Gu wrote: > On Tue, Oct 20, 2015 at 7:36 PM James Almer wrote: > >> On 10/20/2015 10:32 PM, Timothy Gu wrote: >> > > +; mov type used for src1q, dstq, first reg, second reg >> > +%macro DIFF_BYTES_LOOP_CORE 4 >>

Re: [FFmpeg-devel] [PATCH] avfilter/vf_ssim: Add support for writing stats to stdout

2015-10-21 Thread Michael Niedermayer
On Wed, Oct 21, 2015 at 09:35:39PM +0200, Paul B Mahol wrote: > On 10/21/15, Tobias Rapp wrote: > > Analogous to my previous patch to vf_psnr.c the attached patch > > implements writing SSIM frame stats to standard output if the filename > > is "-". > > > > Regards, > >

Re: [FFmpeg-devel] [PATCH 02/11] libavformat/mxfdec.c: cosmetics: Add missing space after '?' in log message.

2015-10-21 Thread Tomas Härdin
On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > --- > libavformat/mxfdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 94a953b..0ae7ce6 100644 > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c >

Re: [FFmpeg-devel] Encoding with QSV at an API level.

2015-10-21 Thread Hendrik Leppkes
On Wed, Oct 21, 2015 at 9:42 PM, Paul Knopf wrote: > I just realized that I was also getting an error on the stdout. > > [h264_qsv @ 00c7e6d8e680] Specified pixel format yuv420p is > invalid or not supported > Which probably means you also get an error return from

[FFmpeg-devel] [PATCH] avformat/electronicarts: support ADPCM PSX

2015-10-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/electronicarts.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c index c0b6d6e..12eec80 100644 --- a/libavformat/electronicarts.c +++

Re: [FFmpeg-devel] [PATCH 01/11] libavformat/mxfdec.c: klv_read_packet: Properly check klv_decode_ber_length return value.

2015-10-21 Thread Tomas Härdin
On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > klv_decode_ber_length cannot return -1, but can return AVERROR_INVALIDDATA. > Store its return value in a signed integer (instead of unsigned > KLVPacket.length) and forward the error appropriately. > --- > libavformat/mxfdec.c | 6

Re: [FFmpeg-devel] [PATCH 04/11] libavformat/mxfdec.c: Try to increment current edit before rejecting a klv that spans onto next edit unit.

2015-10-21 Thread Tomas Härdin
On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > Some files such as those from tickets #2817 & #2776 claim to have constant > edit unit size but, > in fact, have some of them that are smaller. This confuses the demuxer that > tries to infer the > current edit unit from the position in

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/mxfenc.c: Fix segfault when writing an audio packet when there has not been a video one.

2015-10-21 Thread Tomas Härdin
On Tue, 2015-10-20 at 16:43 +0200, Marton Balint wrote: > On Mon, 19 Oct 2015, Tomas Härdin wrote: > > > On Mon, 2015-10-19 at 11:40 +0200, Alexis Ballier wrote: > >> On Mon, 19 Oct 2015 10:30:00 +0200 > >> Michael Niedermayer wrote: > >> > >>> On Fri, Oct 16, 2015 at

[FFmpeg-devel] Nvidia nevec presets

2015-10-21 Thread Rifat Maswadeh
Thanks for all , if you add "*Streaming*" *Presets* To Nvidia Nevec Presets , like this : Automatic Low Latency Low Latency 2Pass HQ Low Latency 2Pass Lossless HP lossless Thanks -- *Best Regards ,* *Rifat Maswadeh* *Technical Support Department.* *Zaytona For **Communications.*

Re: [FFmpeg-devel] [PATCH] avcodec: drop 2 suffix from avpriv_ac3_parse_header2

2015-10-21 Thread Andreas Cadhalpun
On 21.10.2015 01:46, Michael Niedermayer wrote: > On Wed, Oct 21, 2015 at 12:36:59AM +0200, Andreas Cadhalpun wrote: >> avpriv_ac3_parse_header was removed in commit 3dfb643. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/ac3_parser.c | 4 ++-- >>

Re: [FFmpeg-devel] [PATCH] avcodec: rename avpriv_color_frame to ff_color_frame

2015-10-21 Thread Andreas Cadhalpun
On 21.10.2015 11:48, Michael Niedermayer wrote: > On Wed, Oct 14, 2015 at 01:50:33AM +0200, Andreas Cadhalpun wrote: >> It is only used inside libavcodec. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/h264_slice.c | 2 +- >> libavcodec/internal.h

Re: [FFmpeg-devel] [PATCH 03/11] libavformat/mxfdec.c: Report dark metadata keys only when they match no parser at all, not everytime they fail to match one.

2015-10-21 Thread Michael Niedermayer
On Wed, Oct 21, 2015 at 11:31:48PM +0200, Tomas Härdin wrote: > On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > > --- > > libavformat/mxfdec.c | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > > index

Re: [FFmpeg-devel] [PATCH 02/11] libavformat/mxfdec.c: cosmetics: Add missing space after '?' in log message.

2015-10-21 Thread Michael Niedermayer
On Wed, Oct 21, 2015 at 11:31:45PM +0200, Tomas Härdin wrote: > On Wed, 2015-10-21 at 18:00 +0200, Alexis Ballier wrote: > > --- > > libavformat/mxfdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > > index

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-21 Thread Dale Curtis
On Tue, Oct 20, 2015 at 11:50 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > > the last element to be written should be checked, so that if > initialization is done by 2 threads at the same time, neither can > return from this function without initialization having finished > > also

Re: [FFmpeg-devel] [PATCH] huffyuvencdsp: Add ff_diff_bytes_{sse2, avx2}

2015-10-21 Thread Timothy Gu
On Tue, Oct 20, 2015 at 7:36 PM James Almer wrote: > On 10/20/2015 10:32 PM, Timothy Gu wrote: > > +; mov type used for src1q, dstq, first reg, second reg > > +%macro DIFF_BYTES_LOOP_CORE 4 > > +%if regsize != 16 > > %if mmsize != 16 > > By checking regsize you're using the

Re: [FFmpeg-devel] [PATCH] mmaldec: Fix avpriv_atomic_get usage

2015-10-21 Thread Michael Niedermayer
On Wed, Oct 21, 2015 at 11:04:39AM +0200, wm4 wrote: > On Wed, 21 Oct 2015 09:00:33 +0200 > Julian Scheel wrote: > > > There is no avpriv_atomic_get, instead avpriv_atomic_int_get is to be used > > for > > integers. This fixes building mmaldec. > > > > Signed-off-by: Julian

Re: [FFmpeg-devel] [PATCH] avformat/electronicarts: fix demuxing of certain .eam files

2015-10-21 Thread Peter Ross
On Mon, Oct 19, 2015 at 11:35:15AM +0200, Paul B Mahol wrote: > Such files have empty gaps between chunks. > > Signed-off-by: Paul B Mahol > --- > libavformat/electronicarts.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git

[FFmpeg-devel] [PATCH] libavformat/electronicarts: also demux mpeg audio layer 2

2015-10-21 Thread Peter Ross
Signed-off-by: Peter Ross http://wiki.multimedia.cx/index.php?title=Electronic_Arts_SCxl --- libavformat/electronicarts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c index 5d21d49..335a635 100644 ---

Re: [FFmpeg-devel] [PATCH] vc1dsp: Port ff_vc1_put_ver_16b_shift2_mmx to yasm

2015-10-21 Thread Timothy Gu
On Wed, Oct 21, 2015 at 10:46 AM Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > 2015-10-18 2:47 GMT+02:00 Timothy Gu : > > This function is only used within other inline asm functions, hence the > > HAVE_MMX_INLINE guard. Per recent discussions, we should not

[FFmpeg-devel] [PATCH] ffmpeg: fix ffmpeg.h trailing whitespace

2015-10-21 Thread Marton Balint
How this passed through the commit hook? Signed-off-by: Marton Balint --- ffmpeg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ffmpeg.h b/ffmpeg.h index 5722816..8c232f3 100644 --- a/ffmpeg.h +++ b/ffmpeg.h @@ -273,7 +273,7 @@ typedef struct

Re: [FFmpeg-devel] [PATCHv2 1/5] ffmpeg: log failed av_write_trailer

2015-10-21 Thread Marton Balint
On Mon, 19 Oct 2015, Michael Niedermayer wrote: On Sun, Oct 18, 2015 at 12:07:34PM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- ffmpeg.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 36a68fb..252bc0d 100644

Re: [FFmpeg-devel] [PATCH 2/5] ffmpeg: exit on av_write_trailer failure if exit_on_error is set

2015-10-21 Thread Marton Balint
On Sun, 18 Oct 2015, Michael Niedermayer wrote: On Sun, Oct 18, 2015 at 12:38:51AM +0200, Michael Niedermayer wrote: On Sun, Oct 18, 2015 at 12:24:04AM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- ffmpeg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH 3/5] ffmpeg: factorize checking decoder result

2015-10-21 Thread Marton Balint
On Sun, 18 Oct 2015, Michael Niedermayer wrote: On Sun, Oct 18, 2015 at 12:24:05AM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- ffmpeg.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) LGTM thanks Applied, thanks.

Re: [FFmpeg-devel] [PATCHv2 4/5] ffmpeg: exit on corrupt packets or decoded frames if exit_on_error flag is present

2015-10-21 Thread Marton Balint
On Mon, 19 Oct 2015, Michael Niedermayer wrote: On Mon, Oct 19, 2015 at 01:57:31AM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- ffmpeg.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) should be ok Applied, thanks. Marton

Re: [FFmpeg-devel] [PATCH] avutil/wchar_filename: add av_warn_unused_result

2015-10-21 Thread Ganesh Ajjanagadde
On Thu, Oct 15, 2015 at 8:01 PM, Ganesh Ajjanagadde wrote: > Current code is fine, this just adds robustness. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavutil/wchar_filename.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] libavformat/electronicarts: also demux mpeg audio layer 2

2015-10-21 Thread Paul B Mahol
On 10/22/15, Peter Ross wrote: > Signed-off-by: Peter Ross > > http://wiki.multimedia.cx/index.php?title=Electronic_Arts_SCxl > --- > libavformat/electronicarts.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/electronicarts.c

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-21 Thread Michael Niedermayer
On Tue, Oct 20, 2015 at 04:57:49PM -0700, Dale Curtis wrote: > Minor waste and more annoyingly triggers race detectors when the > re-initialization happens across multiple threads. cos(0) == 1 and by > default statics initialize to 0, so this check is safe. > > Signed-off-by: Dale Curtis

[FFmpeg-devel] [PATCH] mmaldec: Fix avpriv_atomic_get usage

2015-10-21 Thread Julian Scheel
There is no avpriv_atomic_get, instead avpriv_atomic_int_get is to be used for integers. This fixes building mmaldec. Signed-off-by: Julian Scheel --- libavcodec/mmaldec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmaldec.c

Re: [FFmpeg-devel] [PATCH] rtsp protocol : teardown packet not sent

2015-10-21 Thread Nicolas Adenis-Lamarre
>> Any I/O can cause delay. When the user close the window, they want it to >> close immediately, not in five seconds. Can you confirm that the problem is blocking io, and more generally blocking system calls more than just io ? (i mean, we must take no risk to have to wait, versus doing some non

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread Ganesh Ajjanagadde
On Wed, Oct 21, 2015 at 1:24 AM, Timothy Gu wrote: > On Tue, Oct 20, 2015 at 7:09 PM Ganesh Ajjanagadde wrote: > >> Hi all, >> >> It is known that there exist at least certain parts of the codebase >> that do not work correctly if ints are 64 bits. One of

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-21 Thread Hendrik Leppkes
On Wed, Oct 21, 2015 at 11:44 AM, Gwenole Beauchesne wrote: > 2015-10-21 11:27 GMT+02:00 Hendrik Leppkes : >> On Sat, Oct 17, 2015 at 9:28 PM, Hendrik Leppkes wrote: >>> On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread Carl Eugen Hoyos
Ganesh Ajjanagadde mit.edu> writes: > Since you seem to be an "expert" on what things > affect this decade, why don't you spend 5 minutes > trying to outline to beginners like me what is > "actually important" in your view? Important is whatever you want to work on. That can be DTS-XLL or

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread Ganesh Ajjanagadde
On Wed, Oct 21, 2015 at 6:18 AM, wm4 wrote: > On Wed, 21 Oct 2015 06:00:21 -0400 > Ganesh Ajjanagadde wrote: > >> I don't "expect support" from anyone. Frankly, I have dealt with >> enough mud from you, who seems to take great pleasure in criticizing >>

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-21 Thread Gwenole Beauchesne
2015-10-21 11:27 GMT+02:00 Hendrik Leppkes : > On Sat, Oct 17, 2015 at 9:28 PM, Hendrik Leppkes wrote: >> On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes wrote: >>> --- >>> libavcodec/utils.c | 6 ++ >>> 1 file changed, 6

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread Ganesh Ajjanagadde
On Wed, Oct 21, 2015 at 5:31 AM, Hendrik Leppkes wrote: > On Wed, Oct 21, 2015 at 11:10 AM, Ganesh Ajjanagadde wrote: >> On Wed, Oct 21, 2015 at 1:24 AM, Timothy Gu wrote: >>> On Tue, Oct 20, 2015 at 7:09 PM Ganesh Ajjanagadde

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread wm4
On Wed, 21 Oct 2015 06:00:21 -0400 Ganesh Ajjanagadde wrote: > I don't "expect support" from anyone. Frankly, I have dealt with > enough mud from you, who seems to take great pleasure in criticizing > or otherwise derailing every patch/discussion of mine to not care > about

[FFmpeg-devel] [PATCH] aacdec: fix strict prototype warning

2015-10-21 Thread Hendrik Leppkes
Function protoypes without arguments require a void argument in C, instead of an empty list. --- libavcodec/aacdec_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c index aabd3f0..c279510 100644 ---

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-21 Thread Hendrik Leppkes
On Sat, Oct 17, 2015 at 9:28 PM, Hendrik Leppkes wrote: > On Sat, Oct 17, 2015 at 9:27 PM, Hendrik Leppkes wrote: >> --- >> libavcodec/utils.c | 6 ++ >> 1 file changed, 6 insertions(+) >> > > Above patch is submitted as an RFC, however I strongly

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread Hendrik Leppkes
On Wed, Oct 21, 2015 at 11:10 AM, Ganesh Ajjanagadde wrote: > On Wed, Oct 21, 2015 at 1:24 AM, Timothy Gu wrote: >> On Tue, Oct 20, 2015 at 7:09 PM Ganesh Ajjanagadde wrote: >> >>> Hi all, >>> >>> It is known that there exist at least

Re: [FFmpeg-devel] [PATCH] avcodec: rename avpriv_color_frame to ff_color_frame

2015-10-21 Thread Michael Niedermayer
On Wed, Oct 14, 2015 at 01:50:33AM +0200, Andreas Cadhalpun wrote: > It is only used inside libavcodec. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/h264_slice.c | 2 +- > libavcodec/internal.h | 2 +- > libavcodec/utils.c | 2 +- > 3 files

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread Ganesh Ajjanagadde
On Wed, Oct 21, 2015 at 6:10 AM, Carl Eugen Hoyos wrote: > Ganesh Ajjanagadde mit.edu> writes: > >> Since you seem to be an "expert" on what things >> affect this decade, why don't you spend 5 minutes >> trying to outline to beginners like me what is >> "actually important" in

Re: [FFmpeg-devel] [PATCH] Added QSV based VPP filter

2015-10-21 Thread Sven Dueking
> -Ursprüngliche Nachricht- > Von: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] Im Auftrag > von Moritz Barsnick > Gesendet: Mittwoch, 14. Oktober 2015 11:23 > An: FFmpeg development discussions and patches > Betreff: Re: [FFmpeg-devel] [PATCH] Added QSV based VPP filter > > On

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: disallow hwaccel with frame threads

2015-10-21 Thread wm4
On Wed, 21 Oct 2015 11:53:46 +0200 Hendrik Leppkes wrote: > On Wed, Oct 21, 2015 at 11:44 AM, Gwenole Beauchesne > wrote: > > 2015-10-21 11:27 GMT+02:00 Hendrik Leppkes : > >> On Sat, Oct 17, 2015 at 9:28 PM, Hendrik Leppkes

[FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

2015-10-21 Thread Hendrik Leppkes
This implementation does not support TLS listen sockets and loading CA/Certs from files. The Windows API does not support loading PEM certs, and would either require a manual loader or instead be limited to loading Windows PFX certificates TLS listen sockets would have to be implemented quite

Re: [FFmpeg-devel] Trac Outage - Notification of planned works

2015-10-21 Thread Kieran Kunhya
Please note this is tonight - Don't say you weren't told! Kieran On 9 October 2015 at 07:37, Kieran Kunhya wrote: > Hello, > > Please note there will be a trac outage owing to the rerouting of fibre as > part of the London Underground extension. > > Regards, > Kieran Kunhya > >

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread Clément Bœsch
On Wed, Oct 21, 2015 at 06:00:21AM -0400, Ganesh Ajjanagadde wrote: [...] > why don't you spend 5 minutes trying to outline to beginners like me > what is "actually important" in your view? > According to the first 100 answers of the survey, the majority of the users want... speed optimisation

Re: [FFmpeg-devel] [PATCH] aacdec: fix strict prototype warning

2015-10-21 Thread Paul B Mahol
On 10/21/15, Hendrik Leppkes wrote: > Function protoypes without arguments require a void argument in C, > instead of an empty list. > --- > libavcodec/aacdec_template.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/aacdec_template.c

[FFmpeg-devel] [PATCH] avfilter/vf_ssim: Add support for writing stats to stdout

2015-10-21 Thread Tobias Rapp
Analogous to my previous patch to vf_psnr.c the attached patch implements writing SSIM frame stats to standard output if the filename is "-". Regards, Tobias >From 55077db04d9d843b25b560b8c4cee8924064e443 Mon Sep 17 00:00:00 2001 From: Tobias Rapp Date: Tue, 20 Oct 2015

Re: [FFmpeg-devel] [PATCH] pixblockdsp: Use memcpy for get_pixels_16_c

2015-10-21 Thread Michael Niedermayer
On Tue, Oct 20, 2015 at 01:20:03PM -0700, Timothy Gu wrote: > Before: > 15543 decicycles in get_pixels, 4193214 runs, 1090 skips > After: >5713 decicycles in get_pixels, 8387564 runs, 1044 skips > --- > libavcodec/pixblockdsp.c | 36 ++- >

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-21 Thread wm4
On Tue, 20 Oct 2015 16:57:49 -0700 Dale Curtis wrote: > Minor waste and more annoyingly triggers race detectors when the > re-initialization happens across multiple threads. cos(0) == 1 and by > default statics initialize to 0, so this check is safe. > > Signed-off-by:

Re: [FFmpeg-devel] forcing ints to be 64 bits, possible new FATE client idea

2015-10-21 Thread Ganesh Ajjanagadde
On Wed, Oct 21, 2015 at 1:14 AM, Mark Harris wrote: > On Tue, Oct 20, 2015 at 7:08 PM, Ganesh Ajjanagadde wrote: >> Hi all, >> >> It is known that there exist at least certain parts of the codebase >> that do not work correctly if ints are 64 bits. One of