Re: [FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

2016-01-06 Thread wm4
On Tue, 5 Jan 2016 23:41:35 -0800 Aman Gupta wrote: > From: Aman Gupta > > new option defaults to true, to preserve existing behavior. by flipping > the option to false, subtitle events are emitted as soon as they are > received and have an infinite duration. >

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Paul B Mahol
On 1/6/16, wm4 wrote: > On Wed, 6 Jan 2016 04:33:16 +0100 > Mats Peterson wrote: > >> At least in this case, MPlayer seems to look at the codec tag rather >> than the codec ID in order to determine the codec. Therefore, the >> 'fourcc'

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:06 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: [...] The patch is ok, the commit message not: This is not related to MPlayer but old lavf producing broken files. The codec_tag SMI does not exist, SVQ3 should be exported. Carl Eugen

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: > You're welcome to fix this issue on the MPlayer side, > since it seems you've done that before. If there were a fourcc (or codec_tag) "SMI " this would be trivial to fix in MPlayer. But this codec_tag does not exist, FFmpeg used to write broken mkv files

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-06 Thread Hendrik Leppkes
On Wed, Jan 6, 2016 at 4:01 AM, James Almer wrote: > On 1/5/2016 11:51 PM, Michael Niedermayer wrote: >> On Tue, Jan 05, 2016 at 11:44:04PM -0300, James Almer wrote: >>> On 1/5/2016 11:35 PM, Michael Niedermayer wrote: On Tue, Jan 05, 2016 at 11:27:25PM -0300, James Almer

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:26 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: You're welcome to fix this issue on the MPlayer side, since it seems you've done that before. If there were a fourcc (or codec_tag) "SMI " this would be trivial to fix in MPlayer. But this codec_tag does not

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:26 AM, Carl Eugen Hoyos wrote: But this codec_tag does not exist, FFmpeg used to write broken mkv files that contained only part of the stsd atom. FFmpeg still writes broken mkv files, for the record. It doesn't include the palette, if any, in the stsd atom. But that's a

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 12:22 PM, Mats Peterson wrote: order to procuce a working Matroska file from a QuickTime file. Produce, not procuce. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2016-01-06 Thread Matthias Hunstock
Am 06.01.2016 um 04:08 schrieb Michael Niedermayer: > any patch that was forgotten and should be applied ? > just asking as your comment sounds a bit in that direction Yes, there was some discussion but no further action. But this is the first patch submitted by me, so I don't fully know the

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 10:41 AM, wm4 wrote: On Wed, 6 Jan 2016 04:33:16 +0100 Mats Peterson wrote: At least in this case, MPlayer seems to look at the codec tag rather than the codec ID in order to determine the codec. Therefore, the 'fourcc' variable needs to be set

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Carl Eugen Hoyos
Mats Peterson ffmpeg.org> writes: [...] The patch is ok, the commit message not: This is not related to MPlayer but old lavf producing broken files. The codec_tag SMI does not exist, SVQ3 should be exported. Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:53 AM, Mats Peterson wrote: FFmpeg still writes broken mkv files, for the record. It doesn't include the palette, if any, in the stsd atom. But that's a later issue, one that I'm currently not concerned about since I use mkvmerge to remux. That's just one of the QuickTime to

[FFmpeg-devel] [PATCH v2] Enable dash output to work when the output isn't a local file

2016-01-06 Thread Raymond Hilseth
Use avpriv_io_move instead of ff_rename to support more than only the file protocol. Enabled the implementation of file_move in libavformat/file.c for systems not having unistd.h since it only requires the rename function from os_support.h. Signed-off-by: Raymond Hilseth ---

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread wm4
On Wed, 6 Jan 2016 11:20:25 +0100 Mats Peterson wrote: > On 01/06/2016 11:16 AM, Mats Peterson wrote: > > On 01/06/2016 11:12 AM, Mats Peterson wrote: > >> On 01/06/2016 11:06 AM, Carl Eugen Hoyos wrote: > >>> Mats Peterson ffmpeg.org> writes: > >>> > >>>

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread wm4
On Wed, 6 Jan 2016 04:33:16 +0100 Mats Peterson wrote: > At least in this case, MPlayer seems to look at the codec tag rather > than the codec ID in order to determine the codec. Therefore, the > 'fourcc' variable needs to be set to 'SVQ3' as well, which is

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:16 AM, Mats Peterson wrote: On 01/06/2016 11:12 AM, Mats Peterson wrote: On 01/06/2016 11:06 AM, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: [...] The patch is ok, the commit message not: This is not related to MPlayer but old lavf producing broken files. The

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:32 AM, wm4 wrote: Uh. You know, they accept patches, just like FFmpeg. You don't say. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 10:53 AM, Paul B Mahol wrote: Yes, fix broken MPlayer instead. Me? :) Hardly. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2016-01-06 Thread Moritz Barsnick
On Tue, Jan 05, 2016 at 21:36:20 +0100, Moritz Barsnick wrote: > This is not the first of your filters where you describe a parameter as > a "percentage", but expect a float value [0, 1]. That is extremely > confusing, if not even wrong. To me, a percentage covers [0, 100]. You > need to find a

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Michael Niedermayer
On Wed, Jan 06, 2016 at 10:26:08AM +, Carl Eugen Hoyos wrote: > Mats Peterson ffmpeg.org> writes: > > > You're welcome to fix this issue on the MPlayer side, > > since it seems you've done that before. > > If there were a fourcc (or codec_tag) "SMI " this > would be trivial to fix in

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 02:45 PM, Michael Niedermayer wrote: On Wed, Jan 06, 2016 at 10:26:08AM +, Carl Eugen Hoyos wrote: Mats Peterson ffmpeg.org> writes: You're welcome to fix this issue on the MPlayer side, since it seems you've done that before. If there were a fourcc (or codec_tag) "SMI "

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: SMI to SVQ3

2016-01-06 Thread Mats Peterson
On 01/06/2016 11:53 AM, Mats Peterson wrote: FFmpeg still writes broken mkv files, for the record. It doesn't include the palette, if any, in the stsd atom. But that's a later issue, one that I'm currently not concerned about since I use mkvmerge to remux. To be perfectly clear, the private

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of formats on error

2016-01-06 Thread Michael Niedermayer
On Tue, Jan 05, 2016 at 01:39:48PM -0800, Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 12:11 PM, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libavfilter/formats.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of formats on error

2016-01-06 Thread Nicolas George
Le septidi 17 nivôse, an CCXXIV, Michael Niedermayer a écrit : > i think it would be better to libavfilter cleanup instead of each > filter duplicating cleanup code. This is already done: allocated data that was successfully stored in the structure is freed, in this instance in the free_link()

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

2016-01-06 Thread Matthieu Bouron
On Wed, Jan 6, 2016 at 3:45 PM, Derek Buitenhuis wrote: > On 1/5/2016 9:58 AM, Carl Eugen Hoyos wrote: > > So perhaps libstagefright should be removed once your > > patch hits the git repo? > > I would like to push this today if people are OK with it. > > Personally

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

2016-01-06 Thread Derek Buitenhuis
On 1/5/2016 9:58 AM, Carl Eugen Hoyos wrote: > So perhaps libstagefright should be removed once your > patch hits the git repo? I would like to push this today if people are OK with it. Personally I think it's better to push it before, since, as per paragraph #2, it promotes incorrect info /

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of formats on error

2016-01-06 Thread Paul B Mahol
On 1/5/16, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/formats.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavfilter/formats.c b/libavfilter/formats.c > index a2b19e7..f12dcf4 100644 > --- a/libavfilter/formats.c

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

2016-01-06 Thread Ronald S. Bultje
Hi, On Wed, Jan 6, 2016 at 9:45 AM, Derek Buitenhuis wrote: > On 1/5/2016 9:58 AM, Carl Eugen Hoyos wrote: > > So perhaps libstagefright should be removed once your > > patch hits the git repo? > > I would like to push this today if people are OK with it. I think

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

2016-01-06 Thread Daniel Serpell
Hi!, El Tue, Jan 05, 2016 at 09:01:40PM -0800, Ganesh Ajjanagadde escribio: > On Tue, Jan 5, 2016 at 10:46 AM, Ganesh Ajjanagadde wrote: > > On Tue, Jan 5, 2016 at 10:10 AM, Daniel Serpell wrote: > >> Hi!, > >> > >> El Tue, Jan 05, 2016 at 08:08:35AM -0800,

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-06 Thread foo86
On Wed, Jan 06, 2016 at 12:28:00AM +0100, Hendrik Leppkes wrote: > So that leaves us with a bunch of positive comments, on this side > anyway, and noone opposed yet. > > Arguments for a switch include: > - Nearly complete coverage of all DTS features, well tested and > confirmed bit-exact (only

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-06 Thread Carl Eugen Hoyos
foo86 gmail.com> writes: > 1. Should I remove old decoder files in separate > commit first Please do that, it makes the diff much easier to read afaict, > 2. Is it OK to leave arch-specific dca code as > well as dcadsp.c untouched for now? Only if you believe that this makes your future

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-06 Thread James Almer
On 1/6/2016 2:32 PM, foo86 wrote: > On Wed, Jan 06, 2016 at 12:28:00AM +0100, Hendrik Leppkes wrote: >> So that leaves us with a bunch of positive comments, on this side >> anyway, and noone opposed yet. >> >> Arguments for a switch include: >> - Nearly complete coverage of all DTS features, well

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-06 Thread Christophe Gisquet
Hi, 2016-01-06 18:32 GMT+01:00 foo86 : > dca dca2libdcadec > System 1: 0:11.90 0:11.16 0:19.73 > System 2: 0:57.00 0:55.23 1:21.33 > System 3: 7:41.31 7:00.84 13:16.70 Just to be sure, because I won't check myself: is

Re: [FFmpeg-devel] [PATCH v5 1/4] mips: improve detection of ISAs, FPU and ASEs (DSP, MSA)

2016-01-06 Thread Michael Niedermayer
On Wed, Jan 06, 2016 at 04:55:26PM +, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v4 -> v5: > - Check for msa.h and disable msa if not found. > > Changes v3 -> v4: > - Nothing. > > Changes v2 -> v3: > - Nothing. > >

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

2016-01-06 Thread Derek Buitenhuis
On 1/6/2016 3:51 PM, Matthieu Bouron wrote: > I'm OK with that. Pushed with commit message changed, as per Martin. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v4 11/14] mips: do not disable any feature for generic cores

2016-01-06 Thread Vicente Olivert Riera
Dear Andreas Cadhalpun and Michael Niedermayer, On 30/12/15 21:02, Andreas Cadhalpun wrote: On 30.12.2015 20:35, Michael Niedermayer wrote: On Fri, Dec 04, 2015 at 03:48:27PM +, Vicente Olivert Riera wrote: We don't know which features are available when the user selects a generic core,

Re: [FFmpeg-devel] [PATCH] avfilter/formats: fix leak of formats on error

2016-01-06 Thread Ganesh Ajjanagadde
On Wed, Jan 6, 2016 at 6:43 AM, Nicolas George wrote: > Le septidi 17 nivôse, an CCXXIV, Michael Niedermayer a écrit : >> i think it would be better to libavfilter cleanup instead of each >> filter duplicating cleanup code. > > This is already done: allocated data that was

[FFmpeg-devel] [PATCH v5 3/4] mips: add support for R6

2016-01-06 Thread Vicente Olivert Riera
Understanding the mips32r6 and mips64r6 ISAs in the configure script is not enough. In order to have full support for MIPS R6 in FFmpeg we need to be able to build it, and for that we need to make sure we don't use incompatible assembler code which makes the build fail. Ifdefing the offending code

[FFmpeg-devel] [PATCH v5 4/4] mips: display a warning message when using an unknown CPU

2016-01-06 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v4 -> v5: - Nothing. Changes v3 -> v4: - Use a more accurate warning message. Changes v2 -> v3: - This patch has been added for v3. Changes v1 -> v2: - This patch didn't exist at that point. configure | 2 ++ 1

Re: [FFmpeg-devel] [PATCHv2] lavc/cbrt_tablegen: speed up tablegen

2016-01-06 Thread Ganesh Ajjanagadde
On Wed, Jan 6, 2016 at 7:38 AM, Daniel Serpell wrote: > Hi!, > > El Tue, Jan 05, 2016 at 09:01:40PM -0800, Ganesh Ajjanagadde escribio: >> On Tue, Jan 5, 2016 at 10:46 AM, Ganesh Ajjanagadde wrote: >> > On Tue, Jan 5, 2016 at 10:10 AM, Daniel Serpell

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-06 Thread foo86
On Tue, Jan 05, 2016 at 10:46:19PM +0100, Andreas Cadhalpun wrote: > OK. This decoder seems to be quite robust in handling fuzzed samples, > so from a security point of view it should be fine to replace the > old dca decoder with this one. Out of interest, did you disable CRC checks in the

[FFmpeg-devel] [PATCH v5 2/4] mips: do not disable any feature for generic cores

2016-01-06 Thread Vicente Olivert Riera
We don't know which features are available when the user selects a generic core, so don't disable anything by default and let the user decide. Signed-off-by: Vicente Olivert Riera --- Changes v4 -> v5: - Nothing. Changes v3 -> v4: - Minor change in the commit log:

[FFmpeg-devel] [PATCH v5 1/4] mips: improve detection of ISAs, FPU and ASEs (DSP, MSA)

2016-01-06 Thread Vicente Olivert Riera
Signed-off-by: Vicente Olivert Riera --- Changes v4 -> v5: - Check for msa.h and disable msa if not found. Changes v3 -> v4: - Nothing. Changes v2 -> v3: - Nothing. Changes v1 -> v2: - Add a block of code for mipsdspr2 which was previously placed in the first

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2016-01-06 Thread Ganesh Ajjanagadde
On Wed, Jan 6, 2016 at 5:36 AM, Moritz Barsnick wrote: > On Tue, Jan 05, 2016 at 21:36:20 +0100, Moritz Barsnick wrote: >> This is not the first of your filters where you describe a parameter as >> a "percentage", but expect a float value [0, 1]. That is extremely >> confusing,

[FFmpeg-devel] A53 Closed Captions in mpeg2video

2016-01-06 Thread Zach Swena
Hi, What is the current status of closed captions for mpeg2 video outputs? I know caption pass through is supposed to work for libx264, but most ATSC broadcast is still in mpeg2. Do we have any timeline on when this part will be done yet? Zach ___

Re: [FFmpeg-devel] [RFC] avcodec: Add native DCA decoder based on libdcadec.

2016-01-06 Thread Andreas Cadhalpun
On 06.01.2016 18:32, foo86 wrote: > On Tue, Jan 05, 2016 at 10:46:19PM +0100, Andreas Cadhalpun wrote: >> OK. This decoder seems to be quite robust in handling fuzzed samples, >> so from a security point of view it should be fine to replace the >> old dca decoder with this one. > > Out of

Re: [FFmpeg-devel] [PATCH 03/10] libavcodec/ccaption_dec: add calculate_duration option

2016-01-06 Thread Aman Gupta
The new "calculate_duration" option in this patch defaults to true, to preserve the existing behavior. You can set it to false to get the new realtime behavior. This seems a little backwards, so if someone has a better name for this new behavior I'd be interested to hear it. Maybe the option can

[FFmpeg-devel] [PATCH] x86/intmath: add sse optimized av_clipf and av_clipd

2016-01-06 Thread James Almer
Signed-off-by: James Almer --- I could also include stdlib.h inside the __GNU__ section if that's prefered, since other compilers don't need it. libavutil/x86/intmath.h | 33 + 1 file changed, 33 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] x86/vf_w3fdif: simplify w3fdif_simple_high

2016-01-06 Thread Hendrik Leppkes
On Mon, Oct 12, 2015 at 1:21 AM, James Almer wrote: > On 10/11/2015 3:11 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Oct 11, 2015 at 1:17 PM, James Almer wrote: >> >>> On 10/11/2015 4:31 AM, Paul B Mahol wrote: On 10/11/15, James Almer

Re: [FFmpeg-devel] [RFC v5] libavcodec: add a native Daala decoder

2016-01-06 Thread Ganesh Ajjanagadde
On Wed, Jan 6, 2016 at 5:22 PM, Ronald S. Bultje wrote: > Hello, > [...] > >> +#define DAALA_QM_SCALE (1 << 15) >> +#define DAALA_QM_SCALE_MAX (DAALA_QM_SCALE - 1) >> +#define DAALA_QM_SCALE_UNIT (1.0f/DAALA_QM_SCALE_MAX) >> +#define DAALA_QM_INV_SCALE (1 << 12) >> +#define

[FFmpeg-devel] [PATCH] x86/intmath: add sse optimized av_clipf and av_clipd

2016-01-06 Thread James Almer
Signed-off-by: James Almer --- libavutil/x86/intmath.h | 32 1 file changed, 32 insertions(+) diff --git a/libavutil/x86/intmath.h b/libavutil/x86/intmath.h index 611ef88..e1cd596 100644 --- a/libavutil/x86/intmath.h +++

Re: [FFmpeg-devel] [RFC v5] libavcodec: add a native Daala decoder

2016-01-06 Thread Ronald S. Bultje
Hello, On Sat, Jan 2, 2016 at 12:56 PM, Rostislav Pehlivanov wrote: > @@ -864,6 +865,7 @@ OBJS-$(CONFIG_BMP_PARSER) += bmp_parser.o > OBJS-$(CONFIG_CAVSVIDEO_PARSER)+= cavs_parser.o > OBJS-$(CONFIG_COOK_PARSER) += cook_parser.o >

Re: [FFmpeg-devel] [PATCH v5] lavf/matroskadec: A_QUICKTIME and AV_CODEC_ID_NONE

2016-01-06 Thread Mats Peterson
On 01/06/2016 04:32 AM, Mats Peterson wrote: In many older QuickTime files, the audio format, or "fourcc", is 0x (AV_CODEC_ID_NONE). The QuickTime File Format Specification states the following regarding this situation: "This format descriptor should not be used, but may be found in

Re: [FFmpeg-devel] [PATCH] x86/intmath: add sse optimized av_clipf and av_clipd

2016-01-06 Thread Michael Niedermayer
On Wed, Jan 06, 2016 at 10:09:45PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavutil/x86/intmath.h | 32 > 1 file changed, 32 insertions(+) seems failing to build CC libavcodec/proresdec_lgpl.o In file included

Re: [FFmpeg-devel] [PATCH 3/3] ffmdec: change type of len to ptrdiff_t

2016-01-06 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 04:52:25PM +0100, Andreas Cadhalpun wrote: > It is used to store the difference between pointers, so ptrdiff_t is the > correct type. > > This prevents potential overflows. > > Signed-off-by: Andreas Cadhalpun > --- >

Re: [FFmpeg-devel] [PATCH v2] lavf/matroskadec: A_QUICKTIME and AV_CODEC_ID_NONE

2016-01-06 Thread Mats Peterson
On 01/04/2016 10:49 PM, Mats Peterson wrote: In many older QuickTime files, the audio format, or "fourcc", is 0x (AV_CODEC_ID_NONE). The QuickTime File Format Specification states the following regarding this situation: "This format descriptor should not be used, but may be found in

[FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-06 Thread Ganesh Ajjanagadde
In the spirit of commit a956840cbc. Simple method to reproduce: pass -vstats_file /dev/full to ffmpeg. All raw fclose usages in ffmpeg.c taken care of here. Signed-off-by: Ganesh Ajjanagadde --- ffmpeg.c | 13 ++--- 1 file changed, 10 insertions(+), 3

[FFmpeg-devel] [PATCH] x86/vf_w3fdif: 32-bit compatibility for w3fdif_simple_high

2016-01-06 Thread Hendrik Leppkes
--- Based on an idea from Ronald mentioend in an earlier thread about this function. It works and passes FATE, however I'm sure some aspects can be done easier or cleaner, so please let me know. libavfilter/x86/vf_w3fdif.asm| 37 ++---

Re: [FFmpeg-devel] [PATCH 2/2] x86/vf_w3fdif: simplify w3fdif_simple_high

2016-01-06 Thread Hendrik Leppkes
On Thu, Jan 7, 2016 at 3:13 AM, Hendrik Leppkes wrote: > On Mon, Oct 12, 2015 at 1:21 AM, James Almer wrote: >> On 10/11/2015 3:11 PM, Ronald S. Bultje wrote: >>> Hi, >>> >>> On Sun, Oct 11, 2015 at 1:17 PM, James Almer wrote: >>>

Re: [FFmpeg-devel] [PATCH v2] lavf/matroskadec: A_QUICKTIME and AV_CODEC_ID_NONE

2016-01-06 Thread Mats Peterson
On 01/07/2016 04:13 AM, Mats Peterson wrote: On 01/04/2016 10:49 PM, Mats Peterson wrote: In many older QuickTime files, the audio format, or "fourcc", is 0x (AV_CODEC_ID_NONE). The QuickTime File Format Specification states the following regarding this situation: "This format

Re: [FFmpeg-devel] [PATCH v2] lavf/mov: Audio and AV_CODEC_ID_NONE

2016-01-06 Thread Mats Peterson
On 01/05/2016 06:45 AM, Mats Peterson wrote: Simplified the patch somewhat. Description follows: In many older QuickTime files, the audio format, or "fourcc", is 0x (AV_CODEC_ID_NONE). The QuickTime File Format Specification states the following regarding this situation: "This format

Re: [FFmpeg-devel] [PATCH] x86/intmath: add sse optimized av_clipf and av_clipd

2016-01-06 Thread James Almer
On 1/7/2016 12:19 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, Jan 6, 2016 at 8:09 PM, James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavutil/x86/intmath.h | 32 >> 1 file changed, 32 insertions(+) >> >>

Re: [FFmpeg-devel] [PATCH] ffmpeg: check fclose return values

2016-01-06 Thread Ganesh Ajjanagadde
On Wed, Jan 6, 2016 at 9:00 PM, Ganesh Ajjanagadde wrote: > In the spirit of commit a956840cbc. Simple method to reproduce: > pass -vstats_file /dev/full to ffmpeg. > > All raw fclose usages in ffmpeg.c taken care of here. > > Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] x86/intmath: add sse optimized av_clipf and av_clipd

2016-01-06 Thread Ronald S. Bultje
Hi, On Wed, Jan 6, 2016 at 8:09 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavutil/x86/intmath.h | 32 > 1 file changed, 32 insertions(+) > > diff --git a/libavutil/x86/intmath.h

Re: [FFmpeg-devel] [PATCH] x86/vf_w3fdif: 32-bit compatibility for w3fdif_simple_high

2016-01-06 Thread James Almer
On 1/6/2016 11:54 PM, Hendrik Leppkes wrote: > --- > Based on an idea from Ronald mentioend in an earlier thread about this > function. > > It works and passes FATE, however I'm sure some aspects can be done easier or > cleaner, so please let me know. > > > libavfilter/x86/vf_w3fdif.asm|

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2016-01-06 Thread Ganesh Ajjanagadde
On Wed, Jan 6, 2016 at 1:25 PM, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 09:51:15PM -0800, Ganesh Ajjanagadde wrote: >> On Tue, Jan 5, 2016 at 4:57 PM, Michael Niedermayer >> wrote: >> > On Tue, Jan 05, 2016 at 01:57:09PM -0800, Ganesh

Re: [FFmpeg-devel] [PATCH] ffmpeg: replace log2 by faster variant

2016-01-06 Thread Ganesh Ajjanagadde
On Tue, Jan 5, 2016 at 7:03 PM, Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 6:44 PM, Michael Niedermayer > wrote: >> On Mon, Jan 04, 2016 at 05:38:46PM -0800, Ganesh Ajjanagadde wrote: >>> On Sat, Jan 2, 2016 at 7:59 AM, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

2016-01-06 Thread Michael Niedermayer
On Tue, Jan 05, 2016 at 10:26:05PM -0800, Aman Gupta wrote: > On Tue, Jan 5, 2016 at 6:24 PM, Michael Niedermayer > wrote: > > > On Tue, Jan 05, 2016 at 09:34:35PM +0100, Clément Bœsch wrote: > > > On Mon, Jan 04, 2016 at 07:28:02PM -0800, Aman Gupta wrote: > > > > From:

[FFmpeg-devel] [PATCH 1/5] asfdec_o: check avio_skip in asf_read_simple_index

2016-01-06 Thread Andreas Cadhalpun
The loop can be very long, even though the file is very short. Signed-off-by: Andreas Cadhalpun --- libavformat/asfdec_o.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavformat/asfdec_o.c b/libavformat/asfdec_o.c index

[FFmpeg-devel] [PATCH 3/5] asfdec_o: make sure packet_size is non-zero before seeking

2016-01-06 Thread Andreas Cadhalpun
This fixes infinite loops due to seeking back. --- libavformat/asfdec_o.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/asfdec_o.c b/libavformat/asfdec_o.c index b81519f..4a3c815 100644 --- a/libavformat/asfdec_o.c +++ b/libavformat/asfdec_o.c @@ -1287,6 +1287,10 @@ static

[FFmpeg-devel] [PATCH 2/5] asfdec_o: prevent overflow causing seekback

2016-01-06 Thread Andreas Cadhalpun
This fixes infinite loops. Signed-off-by: Andreas Cadhalpun --- libavformat/asfdec_o.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/asfdec_o.c b/libavformat/asfdec_o.c index bc168d3..b81519f 100644 --- a/libavformat/asfdec_o.c

[FFmpeg-devel] [PATCH 5/5] asfdec_o: check for too small size in asf_read_unknown

2016-01-06 Thread Andreas Cadhalpun
This fixes infinite loops due to seeking back. --- libavformat/asfdec_o.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/asfdec_o.c b/libavformat/asfdec_o.c index ca4a066..bc79f10 100644 --- a/libavformat/asfdec_o.c +++ b/libavformat/asfdec_o.c @@ -190,8

[FFmpeg-devel] [PATCH 4/5] asfdec_o: break if EOF is reached after asf_read_packet_header

2016-01-06 Thread Andreas Cadhalpun
asf_read_payload can unset eof_reached, so check it also before calling that function. This fixes infinite loops. Signed-off-by: Andreas Cadhalpun --- libavformat/asfdec_o.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/asfdec_o.c

[FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: rename to screen_changed to screen_reaped

2016-01-06 Thread Aman Gupta
From: Aman Gupta --- libavcodec/ccaption_dec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 6dff761..706da16 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: in realtime mode, emit new ASS events every 200ms

2016-01-06 Thread Aman Gupta
From: Aman Gupta --- libavcodec/ccaption_dec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 706da16..737c3f6 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -159,6

[FFmpeg-devel] [PATCH 3/3] libavcodec/ccaption_dec: emit blank ASS events only in realtime mode

2016-01-06 Thread Aman Gupta
From: Aman Gupta --- libavcodec/ccaption_dec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 737c3f6..8e3008d 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@ -345,7

Re: [FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: rename to screen_changed to screen_reaped

2016-01-06 Thread Moritz Barsnick
On Wed, Jan 06, 2016 at 11:35:10 -0800, Aman Gupta wrote: > Subject: [FFmpeg-devel] [PATCH 1/3] libavcodec/ccaption_dec: rename to > screen_changed to screen_reaped There's a "to" too many in the commit message (the first one). Moritz ___

Re: [FFmpeg-devel] [PATCH v5 4/4] mips: display a warning message when using an unknown CPU

2016-01-06 Thread Michael Niedermayer
On Wed, Jan 06, 2016 at 04:55:29PM +, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera > --- > Changes v4 -> v5: > - Nothing. > > Changes v3 -> v4: > - Use a more accurate warning message. > > Changes v2 -> v3: > - This patch has been added

Re: [FFmpeg-devel] [FFmpeg-cvslog] mips: display a warning message when using an unknown CPU

2016-01-06 Thread Clément Bœsch
On Wed, Jan 06, 2016 at 09:28:33PM +0100, Vicente Olivert Riera wrote: > ffmpeg | branch: master | Vicente Olivert Riera | > Wed Jan 6 16:55:29 2016 +| [6282bdc2bf36ce492d233db38bce219a1a976cfe] | > committer: Michael Niedermayer > > mips: display a warning

Re: [FFmpeg-devel] [FFmpeg-cvslog] mips: display a warning message when using an unknown CPU

2016-01-06 Thread Michael Niedermayer
On Wed, Jan 06, 2016 at 09:44:51PM +0100, Clément Bœsch wrote: > On Wed, Jan 06, 2016 at 09:28:33PM +0100, Vicente Olivert Riera wrote: > > ffmpeg | branch: master | Vicente Olivert Riera > > | Wed Jan 6 16:55:29 2016 +| > >

Re: [FFmpeg-devel] [PATCHv2] avformat/mp3dec, rmdec: check return value of ffio_ensure_seekback

2016-01-06 Thread Michael Niedermayer
On Tue, Jan 05, 2016 at 09:51:15PM -0800, Ganesh Ajjanagadde wrote: > On Tue, Jan 5, 2016 at 4:57 PM, Michael Niedermayer > wrote: > > On Tue, Jan 05, 2016 at 01:57:09PM -0800, Ganesh Ajjanagadde wrote: > >> On Tue, Jan 5, 2016 at 11:01 AM, wm4