Re: [FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-03-07 Thread Hendrik Leppkes
On Tue, Mar 7, 2017 at 7:26 PM, wm4 wrote: > On Tue, 21 Feb 2017 17:35:53 -0500 > Vittorio Giovara wrote: > >> --- >> libavformat/matroskadec.c | 64 >> -- >> tests/ref/fate/matroska-spherical-mono

Re: [FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-03-07 Thread James Almer
On 3/7/2017 5:38 PM, Hendrik Leppkes wrote: > On Tue, Mar 7, 2017 at 7:26 PM, wm4 wrote: >> On Tue, 21 Feb 2017 17:35:53 -0500 >> Vittorio Giovara wrote: >> >>> --- >>> libavformat/matroskadec.c | 64 >>>

Re: [FFmpeg-devel] [PATCH]lsws/input: Do not define unused functions

2017-03-07 Thread Paul B Mahol
On 3/7/17, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a few warnings when compiling with newer gcc. > > Please comment, Carl Eugen > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] swresample/resample: use uniform normalization

2017-03-07 Thread Muhammad Faiz
On Mon, Mar 6, 2017 at 5:06 PM, Muhammad Faiz wrote: > On Fri, Mar 3, 2017 at 3:58 PM, Muhammad Faiz wrote: >> On Wed, Mar 1, 2017 at 10:24 PM, Muhammad Faiz wrote: >>> this gives better frequency response >>> >>> update swresample fate and

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread wm4
On Tue, 7 Mar 2017 16:01:58 +0700 Muhammad Faiz wrote: > use ff_thread_once > > Suggested-by: wm4 > Signed-off-by: Muhammad Faiz > --- > libavcodec/allcodecs.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-)

[FFmpeg-devel] [PATCH v2 2/4] avfilter/allformats: make av_register_all thread safe

2017-03-07 Thread Muhammad Faiz
use ff_thread_once Suggested-by: wm4 Signed-off-by: Muhammad Faiz --- libavformat/allformats.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index 35869e3..132e58b

[FFmpeg-devel] [PATCH v2 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread Muhammad Faiz
use ff_thread_once Suggested-by: wm4 Signed-off-by: Muhammad Faiz --- libavcodec/allcodecs.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index eee322b..6ec7e79

[FFmpeg-devel] [PATCH v2 4/4] avdevice/alldevices: make avdevice_register_all thread safe

2017-03-07 Thread Muhammad Faiz
use ff_thread_once Suggested-by: wm4 Signed-off-by: Muhammad Faiz --- libavdevice/alldevices.c | 16 +--- libavdevice/avdevice.h | 1 - 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/libavdevice/alldevices.c

[FFmpeg-devel] [PATCH v2 3/4] avfilter/allfilters: make avfilter_register_all thread safe

2017-03-07 Thread Muhammad Faiz
use ff_thread_once Suggested-by: wm4 Signed-off-by: Muhammad Faiz --- libavfilter/allfilters.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index

Re: [FFmpeg-devel] [PATCH] avutil/tests/lfg.c: added proper normality test

2017-03-07 Thread Thomas Turner
On Mar 6, 2017 11:47 PM, "Carl Eugen Hoyos" wrote: 2017-03-07 6:36 GMT+01:00 Thomas Turner : > ./configure command worked without ccache: > > ./configure --enable-debug=3 --arch=x86_32 --target-os=linux > --extra-cflags=-m32 --extra-ldflags=-m32

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vp8: remove redundant check

2017-03-07 Thread Paul B Mahol
On 3/7/17, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp8.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c > index 8039e7817e..a3d057d62e 100644 > ---

[FFmpeg-devel] [PATCH] avcodec: fix uninitialized variable read

2017-03-07 Thread wm4
This cna happen if the user tries to call the new decode API for subtitles. Fixes CID 1402071. --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index db3adb18d4..31586d51c5 100644 --- a/libavcodec/utils.c +++

Re: [FFmpeg-devel] [PATCH] avutil/tests/lfg.c: added proper normality test

2017-03-07 Thread Carl Eugen Hoyos
2017-03-07 9:28 GMT+01:00 Thomas Turner : > On Mar 6, 2017 11:47 PM, "Carl Eugen Hoyos" wrote: > > 2017-03-07 6:36 GMT+01:00 Thomas Turner : >> ./configure command worked without ccache: >> >> ./configure --enable-debug=3

Re: [FFmpeg-devel] [PATCH]lavc/avpacket: Make pkt parameter of av_packet_get_side_data() const

2017-03-07 Thread Carl Eugen Hoyos
2017-02-26 12:04 GMT+01:00 Carl Eugen Hoyos : > 2017-02-26 11:51 GMT+01:00 Nicolas George : >>> -uint8_t* av_packet_get_side_data(AVPacket *pkt, enum AVPacketSideDataType >>> type, >> >>> +uint8_t* av_packet_get_side_data( >>> +#if FF_API_CONST_GET_SIDE_DATA

Re: [FFmpeg-devel] [PATCH]lavc/xface: Reorder conditions to silence a gcc warning

2017-03-07 Thread Carl Eugen Hoyos
2017-02-26 11:07 GMT+01:00 Carl Eugen Hoyos : > I believe attached patch does not change the logic of the conditions > but silences a (9 times shown, long-time) gcc warning. Ping. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Fix off-by-few crasher in ff_h2645_extract_rbsp function

2017-03-07 Thread Carl Eugen Hoyos
2017-03-07 11:55 GMT+01:00 Michał Krasowski : > @Michael Niedermayer > I have read the documentation, namely > > /** > * @ingroup lavc_decoding > * Required number of additionally allocated bytes at the end of the input > bitstream for decoding. > * This is mainly needed

Re: [FFmpeg-devel] [PATCH] Fix off-by-few crasher in ff_h2645_extract_rbsp function

2017-03-07 Thread Hendrik Leppkes
On Tue, Mar 7, 2017 at 11:55 AM, Michał Krasowski wrote: > @Michael Niedermayer > I have read the documentation, namely > > /** > * @ingroup lavc_decoding > * Required number of additionally allocated bytes at the end of the input > bitstream for decoding. > * This is

[FFmpeg-devel] End of involvement (was: [PATCH] Cinepak: speed up decoding several-fold...)

2017-03-07 Thread u-9iep
Now it has been more than a month since the initial submission of the Cinepak decoder speedup patch (not counting the proof of concept posted two months ago). Since then, more and more of the oftentimes ignorant discussion was dedicated to the perceived design/development policy conformance

Re: [FFmpeg-devel] [PATCH] Fix off-by-few crasher in ff_h2645_extract_rbsp function

2017-03-07 Thread wm4
On Tue, 7 Mar 2017 11:55:23 +0100 Michał Krasowski wrote: > @Michael Niedermayer > I have read the documentation, namely > > /** > * @ingroup lavc_decoding > * Required number of additionally allocated bytes at the end of the input > bitstream for decoding. > * This is

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264, videotoolbox: fix crash after VT decoder fails

2017-03-07 Thread wm4
On Thu, 2 Mar 2017 09:58:28 -0800 Aman Gupta wrote: > On Thu, Mar 2, 2017 at 1:34 AM, wm4 wrote: > > > On Tue, 21 Feb 2017 13:40:08 -0800 > > Aman Gupta wrote: > > > > > On Tue, Feb 21, 2017 at 1:04 PM, Ronald S. Bultje

Re: [FFmpeg-devel] [PATCH] Fix off-by-few crasher in ff_h2645_extract_rbsp function

2017-03-07 Thread Michael Niedermayer
On Tue, Mar 07, 2017 at 11:55:23AM +0100, Michał Krasowski wrote: > @Michael Niedermayer > I have read the documentation, namely > > /** > * @ingroup lavc_decoding > * Required number of additionally allocated bytes at the end of the input > bitstream for decoding. > * This is mainly needed

Re: [FFmpeg-devel] [PATCH] Fix off-by-few crasher in ff_h2645_extract_rbsp function

2017-03-07 Thread Michał Krasowski
>> This email may contain Opera confidential information > >Please remove this, Carl Eugen Ah, yes, default footer, sorry. >> There are few things that are still not clear to me: >> * Why is the 32 bit padding used when the doc says that >> 64 bit offset may also be needed? > >I don't

Re: [FFmpeg-devel] [PATCH] Fix off-by-few crasher in ff_h2645_extract_rbsp function

2017-03-07 Thread Michał Krasowski
@Michael Niedermayer I have read the documentation, namely /** * @ingroup lavc_decoding * Required number of additionally allocated bytes at the end of the input bitstream for decoding. * This is mainly needed because some optimized bitstream readers read * 32 or 64 bit at once and could read

Re: [FFmpeg-devel] [PATCH] Fix off-by-few crasher in ff_h2645_extract_rbsp function

2017-03-07 Thread Carl Eugen Hoyos
2017-03-07 12:30 GMT+01:00 Michał Krasowski : >>> There are few things that are still not clear to me: >>> * Why is the 32 bit padding used when the doc says that >>> 64 bit offset may also be needed? >> >>I don't understand your question but you may want to >>send an

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread wm4
On Tue, 7 Mar 2017 14:37:27 +0100 Michael Niedermayer wrote: > On Tue, Mar 07, 2017 at 07:44:43AM +0100, wm4 wrote: > > On Tue, 7 Mar 2017 02:47:36 +0700 > > Muhammad Faiz wrote: > > > > > Signed-off-by: Muhammad Faiz > > > --- >

[FFmpeg-devel] [PATCH v3 2/3] avcodec: estimate output bitrate for uncompressed video codecs

2017-03-07 Thread Tobias Rapp
Allows to get a more realistic total bitrate (and estimated file size) in avi_write_header. Previously a static default value of 200k was assumed. Adds an internal helper function for bitrate guessing. Signed-off-by: Tobias Rapp --- libavcodec/internal.h

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread Michael Niedermayer
On Tue, Mar 07, 2017 at 07:44:43AM +0100, wm4 wrote: > On Tue, 7 Mar 2017 02:47:36 +0700 > Muhammad Faiz wrote: > > > Signed-off-by: Muhammad Faiz > > --- > > libavcodec/allcodecs.c | 13 ++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/vp568: Check that there is enough data for ff_vp56_init_range_decoder()

2017-03-07 Thread Ronald S. Bultje
Hi, On Mon, Mar 6, 2017 at 8:41 PM, Michael Niedermayer wrote: > -void ff_vp56_init_range_decoder(VP56RangeCoder *c, const uint8_t *buf, > int buf_size) > +int ff_vp56_init_range_decoder(VP56RangeCoder *c, const uint8_t *buf, > int buf_size) > { > c->high = 255; >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread Paul B Mahol
On 3/7/17, Michael Niedermayer wrote: > On Tue, Mar 07, 2017 at 07:44:43AM +0100, wm4 wrote: >> On Tue, 7 Mar 2017 02:47:36 +0700 >> Muhammad Faiz wrote: >> >> > Signed-off-by: Muhammad Faiz >> > --- >> > libavcodec/allcodecs.c | 13

Re: [FFmpeg-devel] [PATCH v2 2/3] avcodec: estimate output bitrate for ffv1/huffyuv codecs

2017-03-07 Thread Tobias Rapp
On 03.03.2017 16:14, Michael Niedermayer wrote: On Mon, Feb 06, 2017 at 01:33:19PM +0100, Tobias Rapp wrote: Allows to get a more realistic total bitrate (and estimated file size) in avi_write_header. Previously a static default value of 200k was assumed. Signed-off-by: Tobias Rapp

[FFmpeg-devel] [PATCH v3 3/3] avcodec: estimate output bitrate for ffv1/huffyuv codecs

2017-03-07 Thread Tobias Rapp
Allows to get a more realistic total bitrate (and estimated file size) in avi_write_header. Previously a static default value of 200k was assumed. Signed-off-by: Tobias Rapp --- libavcodec/ffv1enc.c | 3 +++ libavcodec/huffyuvenc.c

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread Muhammad Faiz
On Tue, Mar 7, 2017 at 4:17 PM, wm4 wrote: > On Tue, 7 Mar 2017 16:01:58 +0700 > Muhammad Faiz wrote: > >> use ff_thread_once >> >> Suggested-by: wm4 >> Signed-off-by: Muhammad Faiz >> --- >>

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread wm4
On Tue, 7 Mar 2017 20:48:13 +0700 Muhammad Faiz wrote: > On Tue, Mar 7, 2017 at 4:17 PM, wm4 wrote: > > On Tue, 7 Mar 2017 16:01:58 +0700 > > Muhammad Faiz wrote: > > > >> use ff_thread_once > >> > >> Suggested-by: wm4

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread James Almer
On 3/7/2017 11:05 AM, wm4 wrote: > On Tue, 7 Mar 2017 20:48:13 +0700 > Muhammad Faiz wrote: > >> On Tue, Mar 7, 2017 at 4:17 PM, wm4 wrote: >>> On Tue, 7 Mar 2017 16:01:58 +0700 >>> Muhammad Faiz wrote: >>> use ff_thread_once

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread wm4
On Tue, 7 Mar 2017 11:09:19 -0300 James Almer wrote: > On 3/7/2017 11:05 AM, wm4 wrote: > > On Tue, 7 Mar 2017 20:48:13 +0700 > > Muhammad Faiz wrote: > > > >> On Tue, Mar 7, 2017 at 4:17 PM, wm4 wrote: > >>> On Tue, 7 Mar 2017

[FFmpeg-devel] [PATCH v3 1/3] ffmpeg: set the encoding framerate when the output is CFR

2017-03-07 Thread Tobias Rapp
From: Anton Khirnov (cherry picked from Libav commit d10102d23c9467d4eb84f58e0cd12be284b982f6) Signed-off-by: Tobias Rapp --- ffmpeg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.c index 79c91ff..4117b64 100644 ---

[FFmpeg-devel] [PATCH v3 0/3] estimate output bitrate for some video codecs

2017-03-07 Thread Tobias Rapp
This patch-set tries to implement observations/suggestions from the discussions in https://ffmpeg.org/pipermail/ffmpeg-devel/2017-January/205902.html https://ffmpeg.org/pipermail/ffmpeg-devel/2017-January/206428.html Changes since version 2: - replaced own patch with Libav commit for setting

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/allcodecs: make avcodec_register_all thread safe

2017-03-07 Thread Michael Niedermayer
On Tue, Mar 07, 2017 at 03:04:14PM +0100, wm4 wrote: > On Tue, 7 Mar 2017 14:37:27 +0100 > Michael Niedermayer wrote: > > > On Tue, Mar 07, 2017 at 07:44:43AM +0100, wm4 wrote: [...] > > The real problem behind all this is of course more complex and a > > combination of

Re: [FFmpeg-devel] [PATCH] avcodec/exr

2017-03-07 Thread Dzung Hoang
I uploaded rle_grayscale_noffset.exr using the videolan file uploader. The rle_grayscale_nooffset.exr image was modified from https://trac.ffmpeg.org/raw-attachment/ticket/5621/rle_grayscale.exr by zeroing out the line offset table. The modified file is viewable with Adobe Photoshop but results

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/vp568: Check that there is enough data for ff_vp56_init_range_decoder()

2017-03-07 Thread Michael Niedermayer
On Tue, Mar 07, 2017 at 08:35:33AM -0500, Ronald S. Bultje wrote: > Hi, > > On Mon, Mar 6, 2017 at 8:41 PM, Michael Niedermayer > wrote: > > > -void ff_vp56_init_range_decoder(VP56RangeCoder *c, const uint8_t *buf, > > int buf_size) > > +int

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vp8: remove redundant check

2017-03-07 Thread Michael Niedermayer
On Tue, Mar 07, 2017 at 09:20:09AM +0100, Paul B Mahol wrote: > On 3/7/17, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vp8.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] configure: convert MSVC ident to utf-8 if possible

2017-03-07 Thread Timo Rothenpieler
Am 01.03.2017 um 13:28 schrieb Timo Rothenpieler: --- configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 0199fec..398d530 100755 --- a/configure +++ b/configure @@ -4095,7 +4095,11 @@ probe_cc(){ disable stripping elif

[FFmpeg-devel] [PATCH 1/2] avcodec/vp568: Check that there is enough data for ff_vp56_init_range_decoder()

2017-03-07 Thread Michael Niedermayer
Fixes: timeout in 730/clusterfuzz-testcase-5265113739165696 (part 1 of 2) Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp5.c | 5 - libavcodec/vp56.h| 2

[FFmpeg-devel] [PATCH 2/2] avcodec/vp8: Check for the bitstream end per MB in decode_mb_row_no_filter()

2017-03-07 Thread Michael Niedermayer
Fixes: timeout in 730/clusterfuzz-testcase-5265113739165696 (part 2 of 2) Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp8.c | 2 ++ 1 file changed, 2 insertions(+)

[FFmpeg-devel] [PATCH] avutil/tests/lfg.c: added proper normality test

2017-03-07 Thread Thomas Turner
The Chen-Shapiro(CS) test was used to test normality for Lagged Fibonacci PRNG. Normality Hypothesis Test: The null hypothesis formally tests if the population the sample represents is normally-distributed. For CS, when the normality hypothesis is True, the distribution of QH will have a mean

[FFmpeg-devel] fate: Do not report side data size

2017-03-07 Thread Vittorio Giovara
This should address the mismatch between different archs Please CC. -- Vittorio 0001-fate-Do-not-report-side-data-size.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] matroskadec: cosmetics: Rearrange checks for projection-depedendent properties

2017-03-07 Thread Vittorio Giovara
--- ... and this chunk for matroska too. Vittorio libavformat/matroskadec.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index fdc3f268aa..fdb23ab05e 100644 --- a/libavformat/matroskadec.c +++

Re: [FFmpeg-devel] [PATCH 1/2] libx264: remove the "x264opts" AVOption

2017-03-07 Thread Michael Niedermayer
On Tue, Mar 07, 2017 at 10:08:59AM -0900, Lou Logan wrote: > On Tue, 7 Mar 2017 04:24:23 +0100, Michael Niedermayer wrote: > > > its a long time ago but i faintly remember that the option you are > > about to remove worked while the one remaining had bugs > > Can you provide a reproducible case?

Re: [FFmpeg-devel] [PATCH] mov: Fix checking layout and loading padding for cubemaps

2017-03-07 Thread James Almer
On 3/7/2017 7:31 PM, Vittorio Giovara wrote: > --- > I missed this chunk of review in this version of the set, > sorry, here is the proper patch. > Vittorio > > libavformat/mov.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH 1/2] libx264: remove the "x264opts" AVOption

2017-03-07 Thread Jan Ekstrom
On Wed, Mar 8, 2017 at 1:01 AM, Michael Niedermayer wrote: > the fast pskip i mentioned yesterday > > ./ffmpeg -y -i ~/videos/matrixbench_mpeg2.mpg -vcodec libx264 -x264-params > fast-pskip -vframes 15 -an ref-p.nut > ./ffmpeg -y -i ~/videos/matrixbench_mpeg2.mpg -vcodec

[FFmpeg-devel] [PATCH] mov: Fix checking layout and loading padding for cubemaps

2017-03-07 Thread Vittorio Giovara
--- I missed this chunk of review in this version of the set, sorry, here is the proper patch. Vittorio libavformat/mov.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index cc098cd977..d5c3949050 100644 --- a/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH] matroskadec: cosmetics: Rearrange checks for projection-depedendent properties

2017-03-07 Thread James Almer
On 3/7/2017 7:35 PM, Vittorio Giovara wrote: > --- > ... and this chunk for matroska too. > Vittorio > > libavformat/matroskadec.c | 21 + > 1 file changed, 9 insertions(+), 12 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vp568: Check that there is enough data for ff_vp56_init_range_decoder()

2017-03-07 Thread Michael Niedermayer
On Tue, Mar 07, 2017 at 07:09:38PM +0100, Michael Niedermayer wrote: > Fixes: timeout in 730/clusterfuzz-testcase-5265113739165696 (part 1 of 2) > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH] lavc/movtextenc: fix incorrect offset calculation for UTF-8 characters

2017-03-07 Thread Erik Bråthen Solem
The 3GPP Timed Text (TTXT / tx3g / mov_text) specification counts multibyte UTF-8 characters as one single character, ffmpeg currently counts bytes. This produces files where style boxes have incorrect offsets. This patch introduces: 1. a separate variable that keeps track of the byte count 2. a

[FFmpeg-devel] [PATCH] lavc/movtextdec: fix incorrect offset calculation for UTF-8 characters

2017-03-07 Thread Erik Bråthen Solem
The 3GPP Timed Text (TTXT / tx3g / mov_text) specification counts multibyte UTF-8 characters as one single character, ffmpeg currently counts bytes. This patch inserts an if test such that: 1. continuation bytes are not counted during decoding 2. style boxes will not split these characters

Re: [FFmpeg-devel] libavcodec/psd : add support for rgb/gray float

2017-03-07 Thread Dzung Hoang
I implemented a 32-bit float GBRAP/GBRP pixel format and used it in vf_zscale.c and vf_overlay.c. I also implemented an EXR encoder using miniexr that uses the new float pixel format. I can contribute this if there is interest. I used the above mods to do HDR video processing that includes

Re: [FFmpeg-devel] [PATCH V2] vf_hwupload: Add missing return value check

2017-03-07 Thread Jun Zhao
ping ? On 2017/3/3 9:35, Jun Zhao wrote: > V2: Fix the potential memory leak.2 > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec: Add AV_CODEC_FLAG2_DONT_SPLIT_SIDE_DATA

2017-03-07 Thread Michael Niedermayer
This allows to test or use the code without av_packet_split_side_data() or allows applications to separate the side data handling out not running it automatically. It also makes it easier to change the default behavior Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH 1/2] libx264: remove the "x264opts" AVOption

2017-03-07 Thread Michael Niedermayer
On Wed, Mar 08, 2017 at 01:41:38AM +0200, Jan Ekstrom wrote: > On Wed, Mar 8, 2017 at 1:01 AM, Michael Niedermayer > wrote: > > the fast pskip i mentioned yesterday > > > > ./ffmpeg -y -i ~/videos/matrixbench_mpeg2.mpg -vcodec libx264 -x264-params > > fast-pskip -vframes

Re: [FFmpeg-devel] [PATCH] Revert "lavu/atomic: add support for the new memory model aware gcc built-ins"

2017-03-07 Thread James Almer
On 3/7/2017 3:47 AM, wm4 wrote: > On Tue, 7 Mar 2017 00:29:53 -0300 > James Almer wrote: > >> This reverts commit faa9d2982969c999ab0e443a226eff116f7f8e4b. >> >> This change became superfluous when support for C11 atomics was introduced. >> Reverting it will make the removal

Re: [FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-03-07 Thread wm4
On Tue, 7 Mar 2017 21:38:52 +0100 Hendrik Leppkes wrote: > On Tue, Mar 7, 2017 at 7:26 PM, wm4 wrote: > > On Tue, 21 Feb 2017 17:35:53 -0500 > > Vittorio Giovara wrote: > > > >> --- > >> libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH] avcodec: Add AV_CODEC_FLAG2_DONT_SPLIT_SIDE_DATA

2017-03-07 Thread wm4
On Wed, 8 Mar 2017 02:57:50 +0100 Michael Niedermayer wrote: > This allows to test or use the code without av_packet_split_side_data() or > allows applications to separate the side data handling out not > running it automatically. > > It also makes it easier to change

Re: [FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-03-07 Thread James Almer
On 2/28/2017 3:06 PM, Vittorio Giovara wrote: > On Tue, Feb 28, 2017 at 12:46 PM, Vittorio Giovara > wrote: >>> >>> I think this'll look better as >>> >>> >>> case MATROSKA_VIDEO_PROJECTION_TYPE_EQUIRECTANGULAR: >>> projection =

Re: [FFmpeg-devel] [PATCHv3 2/3] mov: Export bounds and padding from spherical metadata

2017-03-07 Thread James Almer
On 2/28/2017 1:24 PM, Vittorio Giovara wrote: > On Tue, Feb 28, 2017 at 10:58 AM, James Almer wrote: >> On 2/21/2017 8:07 PM, James Almer wrote: >>> On 2/21/2017 7:35 PM, Vittorio Giovara wrote: Update the fate test as needed. --- libavformat/mov.c

Re: [FFmpeg-devel] libavcodec/psd : add support for rgb/gray float

2017-03-07 Thread Martin Vignali
Hello @Carl : I make some tests in order to avoid temp buffer, but i have some strange result, when i not use a temp buffer. > Time to think about a float pixfmt? I find it weird that we support > excessively obscure pixfmts like AV_PIX_FMT_BGR4_BYTE, but then have > hacks like this one if the

[FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-07 Thread Martin Vignali
Hello, In attach patch for decoding uint32 channels in exr files. Following previous comments, i doesn't use float/color transformation for this kind of pixel data in this new version. Comments welcome Martin Vignali Jokyo Images 0001-libavcodec-exr-add-support-for-uint32.patch Description:

Re: [FFmpeg-devel] [PATCH 1/2] libx264: remove the "x264opts" AVOption

2017-03-07 Thread Jan Ekstrom
On Tue, Mar 7, 2017 at 5:24 AM, Michael Niedermayer wrote: > On Tue, Mar 07, 2017 at 12:20:20AM +0200, Jan Ekström wrote: >> x264-params does the same thing and this leaves us with a single >> option that is name-matched with x265-params available in the >> libx265

Re: [FFmpeg-devel] [PATCHv3 3/3] mkv: Export bounds and padding from spherical metadata

2017-03-07 Thread wm4
On Tue, 21 Feb 2017 17:35:53 -0500 Vittorio Giovara wrote: > --- > libavformat/matroskadec.c | 64 > -- > tests/ref/fate/matroska-spherical-mono | 6 +++- > 2 files changed, 66 insertions(+), 4 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH 1/2] libx264: remove the "x264opts" AVOption

2017-03-07 Thread Lou Logan
On Tue, 7 Mar 2017 04:24:23 +0100, Michael Niedermayer wrote: > its a long time ago but i faintly remember that the option you are > about to remove worked while the one remaining had bugs Can you provide a reproducible case? I will try as well. > also this would break scripts I've never liked