Re: [FFmpeg-devel] [PATCH v2] mdct15: add inverse transform postrotation SIMD

On 30 July 2017 at 02:30, James Almer wrote: > > > Maybe poke Hendrik for his opinion, but it seems to work, so LGTM. > > Managed to simplify the code and the crazy alignment requirements alot by just iterating over the buffer in reverse. There the overlapping in the middle

Re: [FFmpeg-devel] [PATCH 7/7] lavfi/vf_stack: move to activate design.

Le primidi 11 thermidor, an CCXXV, Paul B Mahol a écrit : > When this and others gonna be applied? As soon as I have time and motivation to work on it, rebase it, check I have no fix staged, re-run fate, etc. Regards, -- Nicolas George signature.asc Description: Digital signature

[FFmpeg-devel] [PATCH 2/2] WIP lavfi/vf_overlay: move to framesync2.

Signed-off-by: Nicolas George --- libavfilter/vf_overlay.c | 81 ++-- 1 file changed, 50 insertions(+), 31 deletions(-) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index ad292a61c1..b08be28a4b 100644 ---

[FFmpeg-devel] [PATCH 1/2] WIP lavfi/framesync2: add dualinput helper function.

Signed-off-by: Nicolas George --- libavfilter/framesync2.c | 20 libavfilter/framesync2.h | 14 ++ 2 files changed, 34 insertions(+) Both patches work in progress. They work, but the code needs to be enhanced, otherwise the other filters will

[FFmpeg-devel] [PATCH 2/2] lavfi/vf_overlay: move to framesync2.

Signed-off-by: Nicolas George --- libavfilter/vf_overlay.c | 69 ++-- 1 file changed, 38 insertions(+), 31 deletions(-) diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c index ad292a61c1..c1d2a21c05 100644 ---

[FFmpeg-devel] [PATCH 1/2] lavfi/framesync2: add dualinput helper functions.

Signed-off-by: Nicolas George --- libavfilter/framesync2.c | 78 +--- libavfilter/framesync2.h | 20 + 2 files changed, 80 insertions(+), 18 deletions(-) Ok, this one actually works. There was a bug in framesync2

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

Le duodi 12 thermidor, an CCXXV, Clement Boesch a écrit : > > ./libavcodec/htmlsubtitles.c: In function ‘ff_htmlmarkup_to_ass’: > > ./libavcodec/htmlsubtitles.c:112:12: warning: missing braces around > > initializer [-Wmissing-braces] > Ah, I don't have that warning. IIRC it is an obsolete

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

On Sun, Jul 30, 2017 at 10:31:40AM +0200, Nicolas George wrote: > Le duodi 12 thermidor, an CCXXV, Clement Boesch a écrit : > > > ./libavcodec/htmlsubtitles.c: In function ‘ff_htmlmarkup_to_ass’: > > > ./libavcodec/htmlsubtitles.c:112:12: warning: missing braces around > > > initializer

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

Le duodi 12 thermidor, an CCXXV, Michael Niedermayer a écrit : > maybe but the compiler doesnt complain about them > i think the difference is the number of nested {} Yes and no. This construct is valid, otherwise the gcc developers would not have removed the warning. The construct with the

Re: [FFmpeg-devel] [PATCH 01/10] lavfi/vf_threshold: move to activate design.

Le nonidi 9 thermidor, an CCXXV, Paul B Mahol a écrit : > Whole set LGTM. Framework and changes to the filters pushed. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] examples/vaapi_enc: Add a VAAPI encoding example.

On Fri, Jul 28, 2017 at 14:01:37 +0800, Jun Zhao wrote: It doesn't really matter much functionally, but I consider it good style to report errors properly, especially in an example which will be used by others: > +fin = fopen(input_file, "r"); > +fout = fopen(output_file, "w+b"); > +

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

On Sun, Jul 30, 2017 at 04:34:16AM +0200, Michael Niedermayer wrote: [...] > > +struct font_tag stack[16] = {0}; > > this seems to produce a compiler warning: > > ./libavcodec/htmlsubtitles.c: In function ‘ff_htmlmarkup_to_ass’: > ./libavcodec/htmlsubtitles.c:112:12: warning: missing braces

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: set field order via codecpar

On Mon, 24 Jul 2017, Marton Balint wrote: Signed-off-by: Marton Balint --- libavdevice/decklink_dec.cpp | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index

Re: [FFmpeg-devel] [PATCH 4/4] lavfi/vf_overlay: use framesync2 options.

2017-07-31 6:51 GMT+08:00 Nicolas George : > Signed-off-by: Nicolas George > --- > libavfilter/vf_overlay.c | 45 - > 1 file changed, 4 insertions(+), 41 deletions(-) > > > For the other dualinput filters, I will

[FFmpeg-devel] [PATCH 4/4] lavfi/vf_overlay: use framesync2 options.

Signed-off-by: Nicolas George --- libavfilter/vf_overlay.c | 45 - 1 file changed, 4 insertions(+), 41 deletions(-) For the other dualinput filters, I will probably do the conversion and that in a single patch. diff --git

[FFmpeg-devel] [PATCH 2/4] lavfi: search options on child objects.

The child objects must be allocated and inited in the preinit() callback. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index

[FFmpeg-devel] [PATCH 3/4] lavfi/framesync2: add common options.

Also add functions and macros to help filters chaining these options to their own. Signed-off-by: Nicolas George --- libavfilter/framesync2.c | 55 ++-- libavfilter/framesync2.h | 44 +- 2 files

[FFmpeg-devel] [PATCH 1/4] lavfi: add a preinit callback to filters.

It is necessary for filters with child objects, to set the class and default options values. Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 8 libavfilter/avfilter.h | 15 +++ 2 files changed, 23 insertions(+) With this patch and the next, I

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

On Sun, Jul 30, 2017 at 03:47:39PM -0300, James Almer wrote: > On 7/30/2017 5:25 AM, Clément Bœsch wrote: > > On Sun, Jul 30, 2017 at 04:34:16AM +0200, Michael Niedermayer wrote: > > [...] > >>> +struct font_tag stack[16] = {0}; > >> > >> this seems to produce a compiler warning: > >> > >>

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

On Sun, Jul 30, 2017 at 05:09:11PM +0200, Nicolas George wrote: > Le duodi 12 thermidor, an CCXXV, Michael Niedermayer a écrit : > > this is true for many warnings > > still warnings like this can "hide" real issues by one not seeing them > > in a wood of meaningless warnings. > > That is i think

Re: [FFmpeg-devel] [PATCH] avfilter: add VIF filter

Hi, On Sun, Jul 30, 2017 at 1:46 PM, Ashish Pratap Singh wrote: > On Sat, Jul 29, 2017 at 3:15 PM, Moritz Barsnick wrote: > > On Sat, Jul 29, 2017 at 14:16:29 +0530, Ashish Pratap Singh wrote: > > > +av_log(ctx, AV_LOG_ERROR, "error: av_malloc

Re: [FFmpeg-devel] [Patch] Auto Insert of hwupload_cuda filter

On 26/07/17 10:18, Philip Langdale wrote: > On 2017-07-25 09:41, Yogender Gupta wrote: >> Currently combining CPU and CUDA filters requires insertion of >> hwupload and download filters. I am trying to simply this by auto >> insertion of these filters. This patch is for hwupload_cuda, but I >>

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

On 7/30/2017 9:55 PM, Michael Niedermayer wrote: > On Sun, Jul 30, 2017 at 03:47:39PM -0300, James Almer wrote: >> On 7/30/2017 5:25 AM, Clément Bœsch wrote: >>> On Sun, Jul 30, 2017 at 04:34:16AM +0200, Michael Niedermayer wrote: >>> [...] > +struct font_tag stack[16] = {0};

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

On 7/30/2017 5:25 AM, Clément Bœsch wrote: > On Sun, Jul 30, 2017 at 04:34:16AM +0200, Michael Niedermayer wrote: > [...] >>> +struct font_tag stack[16] = {0}; >> >> this seems to produce a compiler warning: >> >> ./libavcodec/htmlsubtitles.c: In function ‘ff_htmlmarkup_to_ass’: >>

Re: [FFmpeg-devel] [PATCH] Implement NewTek NDI support

Hi, Some comments below. >From f40b87b4c7e08ccf23ee896923459e5901ae1086 Mon Sep 17 00:00:00 2001 From: Maksym Veremeyenko Date: Wed, 26 Jul 2017 03:22:20 -0400 Subject: [PATCH] lavd: implement NewTek NDI muxer/demuxer support lavd: implement NewTek NDI input/output device

[FFmpeg-devel] [PATCH] Fix branch 3 digits misspelling

Hi all! Attached is a patch for ffmpeg-web. Please consider applying it. Regards, Shlomi Fish -- - Shlomi Fish http://www.shlomifish.org/ https://is.gd/MQHVF3 - The Atom Text Editors edits a 2,000,001b file Chuck

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

On Sun, Jul 30, 2017 at 12:31:57PM +0200, Nicolas George wrote: > Le duodi 12 thermidor, an CCXXV, Michael Niedermayer a écrit : > > maybe but the compiler doesnt complain about them > > i think the difference is the number of nested {} > > Yes and no. This construct is valid, otherwise the gcc

[FFmpeg-devel] [PATCH] avfilter: add floodfill filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 37 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_floodfill.c | 360 + 4 files changed, 399 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

On Fri, Jul 28, 2017 at 3:26 PM, Nicolas George wrote: > Le decadi 10 thermidor, an CCXXV, Paras Chadha a écrit : > > Signed-off-by: Paras Chadha > > --- > > > > Made all the changes suggested. > > Nice. There are a few nitpicks, but I like these

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/framesync2: add dualinput helper functions.

On Sun, Jul 30, 2017 at 03:32:40PM +0200, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/framesync2.c | 78 > +--- > libavfilter/framesync2.h | 20 + > 2 files changed, 80 insertions(+), 18

Re: [FFmpeg-devel] [PATCH 1/2] lavfi/framesync2: add dualinput helper functions.

Le duodi 12 thermidor, an CCXXV, Clement Boesch a écrit : > Sorry I haven't followed your patchset closely: can you confirm that it > can be applied before these filters are updated? In theory, yes. In practice, I have just found an infinite loop with repeatlast=0, so I need to fix it. > Do you

Re: [FFmpeg-devel] [PATCH 1/5] lavc/htmlsubtitles: improve handling broken garbage

Le duodi 12 thermidor, an CCXXV, Michael Niedermayer a écrit : > this is true for many warnings > still warnings like this can "hide" real issues by one not seeing them > in a wood of meaningless warnings. > That is i think we should disable this type of warning or if we cant > then do the

Re: [FFmpeg-devel] [PATCH] Add FITS Decoder

On Fri, Jul 28, 2017 at 3:26 PM, Nicolas George wrote: > Le decadi 10 thermidor, an CCXXV, Paras Chadha a écrit : > > Signed-off-by: Paras Chadha > > --- > > Changelog | 1 + > > doc/general.texi| 2 + > > libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH] avfilter: add VIF filter

Hi, On Sat, Jul 29, 2017 at 3:15 PM, Moritz Barsnick wrote: > On Sat, Jul 29, 2017 at 14:16:29 +0530, Ashish Pratap Singh wrote: > > > +Both input videos must have the same resolution and pixel format for > > +this filter to work correctly. Also it assumes that both inputs > >

Re: [FFmpeg-devel] [PATCH 1/2] fate: add fate-sws-pixdesc-query

On Mon, Jul 24, 2017 at 08:02:25PM +0200, Carl Eugen Hoyos wrote: > 2017-07-24 17:03 GMT+02:00 Clément Bœsch : > > On Mon, Jul 24, 2017 at 01:55:40AM +0200, Carl Eugen Hoyos wrote: > >> 2017-03-19 15:00 GMT+01:00 Clément Bœsch : > >> > Test the pixel format querying

[FFmpeg-devel] [PATCH v2 1/2] lavfi/framesync2: add dualinput helper functions.

Signed-off-by: Nicolas George --- libavfilter/framesync2.c | 84 libavfilter/framesync2.h | 20 2 files changed, 83 insertions(+), 21 deletions(-) Small fix for EXT_NULL (repeatlast=0). diff --git

Re: [FFmpeg-devel] [PATCH] Fix branch 3 digits misspelling

On Sun, Jul 30, 2017 at 09:06:15PM +0300, Shlomi Fish wrote: > Hi all! > > Attached is a patch for ffmpeg-web. Please consider applying it. > > Regards, > > Shlomi Fish > applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State

Re: [FFmpeg-devel] [PATCH] examples/vaapi_enc: Add a VAAPI encoding example.

On 2017/7/30 18:45, Moritz Barsnick wrote: > On Fri, Jul 28, 2017 at 14:01:37 +0800, Jun Zhao wrote: > > It doesn't really matter much functionally, but I consider it good > style to report errors properly, especially in an example which will be > used by othe> >> +fin = fopen(input_file,

Re: [FFmpeg-devel] [PATCH] examples/vaapi_enc: Add a VAAPI encoding example.

On 2017/7/30 8:07, Mark Thompson wrote: > On 28/07/17 07:01, Jun Zhao wrote: >> From d5414b451012b3a0169740a26f452785eb44cce5 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Fri, 28 Jul 2017 01:39:27 -0400 >> Subject: [PATCH] examples/vaapi_enc: Add a VAAPI encoding

[FFmpeg-devel] [PATCH] avformat/hlsenc: support fmp4 single file mode

add byterange mode of the hls fmp4 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 72 1 file changed, 44 insertions(+), 28 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index f98f041..cfc28d2