Re: [FFmpeg-devel] [PATCH 1/4] cbs_h265: read/write HEVC PREFIX SEI

2018-05-03 Thread Xiang, Haihao
On Thu, 2018-05-03 at 22:32 +0100, Mark Thompson wrote: > On 03/05/18 04:07, Haihao Xiang wrote: > > Similar to H264, cbs_h265_{read, write}_nal_unit() can handle HEVC > > prefix SEI NAL units. Currently mastering display colour volume SEI > > message is added only, we may add more SEI message if

[FFmpeg-devel] [PATCH] cbs_h264: Need [] in the name when subscript is required

2018-05-03 Thread Haihao Xiang
Otherwise it will hit an assert in the function ff_cbs_trace_syntax_element() in cbs.c, line 400. Signed-off-by: Haihao Xiang --- libavcodec/cbs_h264_syntax_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 0/3] WebM in dashenc

2018-05-03 Thread Jeyapal, Karthick
On 4/27/18 6:21 AM, Jan Ekström wrote: > Personally I would be for removal of the WebM muxing feature in dashenc > altogether, since the dashenc feature has never seemingly worked, and > since there is a whole separate WebM-specific DASH meta muxer in > webmdashenc. > > But these patches should

Re: [FFmpeg-devel] [PATCH 4/4] vaapi_encode_h265: Insert content light level information

2018-05-03 Thread Xiang, Haihao
On Thu, 2018-05-03 at 11:07 +0800, Haihao Xiang wrote: > Signed-off-by: Haihao Xiang > --- > libavcodec/vaapi_encode_h265.c | 29 - > 1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_encode_h265.c

Re: [FFmpeg-devel] [PATCH v2 4/4] avcodec/mediacodecdec: add workaround for buggy amlogic mpeg2 decoder

2018-05-03 Thread Matthieu Bouron
On Wed, May 02, 2018 at 07:25:00PM -0700, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/mediacodecdec.c | 22 +++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c > index

Re: [FFmpeg-devel] [PATCH v2 3/4] avcodec/mediacodecdec: wait on first frame after input buffers are full

2018-05-03 Thread Matthieu Bouron
On Wed, May 02, 2018 at 07:24:59PM -0700, Aman Gupta wrote: > From: Aman Gupta > > The output_buffer_count==0 special case is no longer required, and > can cause spurious EAGAIN to surface to the user when input buffers > are filled up. Since the caller now knows if the decoder is

[FFmpeg-devel] [PATCH v4]avocdec/nvenc: Reconfigure bitrate on the fly

2018-05-03 Thread pkv.stream
Hi, in previous versions ReconfigureEncoder was called at each frame once bitrate was changed. Fixed that. The patch was rebased against https://github.com/BtbN/FFmpeg/commit/4e8265e3a63a71a40730e8eb575d8aa760bdcddc Sorry about the back and forth. Regards From

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/mediacodecdec: restructure mediacodec_receive_frame

2018-05-03 Thread Matthieu Bouron
On Wed, May 02, 2018 at 07:24:58PM -0700, Aman Gupta wrote: > From: Aman Gupta > > The new logic follows a recommendation by @rcombs to use > dequeueInputBuffer with a timeout of 0 as a way to detect > whether the codec wants more data. The dequeued buffer index is > kept in

[FFmpeg-devel] [PATCH] libavcodec/cuviddec A53CC closed captions support added to cuviddec & nvenc

2018-05-03 Thread Roman Arzumanyan
-- BR, Roman Arzumanyan --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited.

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_libvmaf.c The libvmaf filter tried to join on an invalid thread id

2018-05-03 Thread Kevin Wheatley
Following up my own email with another question or so: Could somebody point me at a suitable method of testing this within the Fate framework? I've started to try unpick how the fate tests are run, etc What I need is a prototypical example which presumably would need to factor in (what I

Re: [FFmpeg-devel] [PATCH] libavcodec/cuviddec A53CC closed captions support added to cuviddec & nvenc

2018-05-03 Thread Andrey Turkin
NVENC side of things should be ok now that drivers are fixed and SEI is reordered together with frames, but on CUVID side it is still pretty bad. I find it funny that NVIDIA developer submits someone's hackish patch instead of fixing cuvid parser API and implementing this properly. I mean,

Re: [FFmpeg-devel] [PATCH] libavcodec/cuviddec A53CC closed captions support added to cuviddec & nvenc

2018-05-03 Thread Timo Rothenpieler
The nvenc side looks ok except for one or two minor nits which I will correct locally and push it with my next batch of patches. I'm not so sure on the cuvid side of things. A53 support is already provided via the new nvdec hwaccel, which supports it natively through the ffmpeg codec parsers.

Re: [FFmpeg-devel] [PATCH] libavcodec/cuviddec A53CC closed captions support added to cuviddec & nvenc

2018-05-03 Thread Andrey Turkin
cuvid decoder has one advantage over nvdec: it has a hardware deinterlacer support. BTW not sure if this patch takes that into account. So cuvid is the only way to get GPU-deinterlaced frames until someone makes CUDA-based deinterlace filter. 2018-05-03 12:03 GMT+03:00 Timo Rothenpieler

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-03 Thread Jan Ekström
On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: > On Thu, May 3, 2018 at 7:50 PM, Alex Converse wrote: >> From: Alex Converse >> >> --- >> libavformat/flvenc.c | 10 +- >> 1 file changed, 5 insertions(+), 5 deletions(-)

[FFmpeg-devel] [PATCH] avfilter/vf_lut3d: add planar rgb support

2018-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_lut3d.c | 114 +++-- 1 file changed, 111 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_lut3d.c b/libavfilter/vf_lut3d.c index c9b72249aa..2f8fc723b7 100644 ---

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: add planar rgb support

2018-05-03 Thread James Almer
On 5/3/2018 3:08 PM, Paul B Mahol wrote: > +#define DEFINE_INTERP_FUNC_PLANAR(name, nbits, depth) >\ > +static int interp_##nbits##_##name##_p##depth(AVFilterContext *ctx, void > *arg, int jobnr, int nb_jobs) \ > +{

Re: [FFmpeg-devel] [PATCH] libavcodec/cuviddec A53CC closed captions support added to cuviddec & nvenc

2018-05-03 Thread wm4
On Thu, 3 May 2018 12:11:56 +0300 Andrey Turkin wrote: > cuvid decoder has one advantage over nvdec: it has a hardware deinterlacer > support. BTW not sure if this patch takes that into account. So cuvid is > the only way to get GPU-deinterlaced frames until someone

Re: [FFmpeg-devel] [PATCH v2 4/4] avcodec/mediacodecdec: add workaround for buggy amlogic mpeg2 decoder

2018-05-03 Thread Aman Gupta
On Thu, May 3, 2018 at 12:37 AM, Matthieu Bouron wrote: > On Wed, May 02, 2018 at 07:25:00PM -0700, Aman Gupta wrote: > > From: Aman Gupta > > > > --- > > libavcodec/mediacodecdec.c | 22 +++--- > > 1 file changed, 19 insertions(+), 3

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/mediacodecdec: restructure mediacodec_receive_frame

2018-05-03 Thread Aman Gupta
On Thu, May 3, 2018 at 12:33 AM, Matthieu Bouron wrote: > On Wed, May 02, 2018 at 07:24:58PM -0700, Aman Gupta wrote: > > From: Aman Gupta > > > > The new logic follows a recommendation by @rcombs to use > > dequeueInputBuffer with a timeout of 0 as a

Re: [FFmpeg-devel] [PATCH] libavcodec/cuviddec A53CC closed captions support added to cuviddec & nvenc

2018-05-03 Thread Timo Rothenpieler
Slightly refactored nvenc part can be found here: https://github.com/BtbN/FFmpeg/commit/e5d85ac3382cef35dc5ba799f026d6aa0a792a39 Will push tomorrow if no issue with it comes up. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-03 Thread Jan Ekström
On Thu, May 3, 2018 at 7:50 PM, Alex Converse wrote: > From: Alex Converse > > --- > libavformat/flvenc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c > index

Re: [FFmpeg-devel] [PATCH] avfilter/vf_lut3d: add planar rgb support

2018-05-03 Thread Paul B Mahol
On 5/3/18, James Almer wrote: > On 5/3/2018 3:08 PM, Paul B Mahol wrote: >> +#define DEFINE_INTERP_FUNC_PLANAR(name, nbits, depth) >> \ >> +static int interp_##nbits##_##name##_p##depth(AVFilterContext *ctx, void >> *arg, int jobnr, int nb_jobs) \

Re: [FFmpeg-devel] [PATCH v4]avocdec/nvenc: Reconfigure bitrate on the fly

2018-05-03 Thread Timo Rothenpieler
Am 03.05.2018 um 09:51 schrieb pkv.stream: Hi, in previous versions ReconfigureEncoder was called at each frame once bitrate was changed. Fixed that. The patch was rebased against https://github.com/BtbN/FFmpeg/commit/4e8265e3a63a71a40730e8eb575d8aa760bdcddc Slightly modified the approach

Re: [FFmpeg-devel] [GSOC] [PATCH] SRCNN filter

2018-05-03 Thread Pedro Arthur
2018-04-10 14:16 GMT-03:00 Sergey Lavrushkin : > 2018-03-29 3:55 GMT+03:00 Michael Niedermayer : > >> On Wed, Mar 28, 2018 at 11:17:40AM +0300, Sergey Lavrushkin wrote: >> > > [...] >> > > > +#define OFFSET(x) offsetof(SRCNNContext, x) >> > > > +#define

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_edgedetect: add canny mode

2018-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 3 +++ libavfilter/vf_edgedetect.c | 5 + 2 files changed, 8 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 218f30ef5f..29b5a5b15f 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_edgedetect: add more formats support to canny mode

2018-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_edgedetect.c | 48 ++--- 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/libavfilter/vf_edgedetect.c b/libavfilter/vf_edgedetect.c index 6f86115d23..55c4cc3b5a 100644 ---

[FFmpeg-devel] [PATCH 2/3] avfilter/vf_edgedetect: add planes option

2018-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi| 4 +++- libavfilter/vf_edgedetect.c | 25 + 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 29b5a5b15f..245326154c 100644 ---

Re: [FFmpeg-devel] [PATCH v4]avocdec/nvenc: Reconfigure bitrate on the fly

2018-05-03 Thread pkv.stream
Le 03/05/2018 à 7:43 PM, Timo Rothenpieler a écrit : Am 03.05.2018 um 09:51 schrieb pkv.stream: Hi, in previous versions ReconfigureEncoder was called at each frame once bitrate was changed. Fixed that. The patch was rebased against

Re: [FFmpeg-devel] [PATCH]lavf/isom: Recognize fourcc HEVC

2018-05-03 Thread James Almer
On 5/2/2018 6:12 PM, Carl Eugen Hoyos wrote: > 2018-05-02 22:50 GMT+02:00, Hendrik Leppkes : > >> If anything at all, this should most definitely not go into movvideo >> tags. This is about AVI files, so if it should go anywhere, it should >> be in ff_codec_bmp_tags. But of

Re: [FFmpeg-devel] HLS Questions

2018-05-03 Thread Ronak
Hi all, Are these issues being tracked somewhere already? I would like to have this fixed. I'm happy to send pull requests, but I'll also have to get familiar with the AAC muxer code. Where can I start learning that? Is that the best place to look for these issues? Ronak > On May 2, 2018,

Re: [FFmpeg-devel] [PATCH] avfilter/drawutils: add support for full range

2018-05-03 Thread Paul B Mahol
On 5/2/18, Paul B Mahol wrote: > On 5/2/18, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/drawutils.c | 11 --- >> libavfilter/drawutils.h | 1 + >> libavutil/colorspace.h|

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/mpeg4videode: Eliminate out of loop VOP startcode reading for studio profile

2018-05-03 Thread Michael Niedermayer
On Thu, May 03, 2018 at 12:58:56AM +, Kieran Kunhya wrote: > > > > About the past, it appears to me that there is a deeply rooted aversion by > > some people toward some code. This just doesnt belong here. > > > > Correct, mpeg4video decoding is some of the least understandable and >

Re: [FFmpeg-devel] [PATCH]lavf/isom: Recognize fourcc HEVC

2018-05-03 Thread Michael Niedermayer
Hi On Wed, May 02, 2018 at 04:26:07PM -0300, James Almer wrote: > On 5/2/2018 3:59 PM, Carl Eugen Hoyos wrote: > > 2018-05-02 20:52 GMT+02:00, James Almer : > >> On 5/2/2018 3:44 PM, Carl Eugen Hoyos wrote: > > > >>> Attached patch fixes ticket #7110 for me. > >> > >> hevc in

Re: [FFmpeg-devel] [PATCH]lavf/isom: Recognize fourcc HEVC

2018-05-03 Thread James Almer
On 5/3/2018 4:31 PM, Michael Niedermayer wrote: > Hi > > On Wed, May 02, 2018 at 04:26:07PM -0300, James Almer wrote: >> On 5/2/2018 3:59 PM, Carl Eugen Hoyos wrote: >>> 2018-05-02 20:52 GMT+02:00, James Almer : On 5/2/2018 3:44 PM, Carl Eugen Hoyos wrote: >>> >

[FFmpeg-devel] [PATCH 2/3] swscale: add gray14 support

2018-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/raw.c | 2 ++ libavformat/nut.c| 3 +++ libswscale/input.c | 2 ++ libswscale/swscale_unscaled.c| 1 + libswscale/utils.c | 4

[FFmpeg-devel] [PATCH 1/3] avutil: add gray14 pixel format

2018-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavutil/pixdesc.c | 21 + libavutil/pixfmt.h | 4 2 files changed, 25 insertions(+) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index df03b3372d..ff5c20d50e 100644 --- a/libavutil/pixdesc.c +++

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_extractplanes: add support for extracting planes with 14 depth

2018-05-03 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_extractplanes.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/vf_extractplanes.c b/libavfilter/vf_extractplanes.c index fc676a25fa..cbd0c422a2 100644 --- a/libavfilter/vf_extractplanes.c +++

Re: [FFmpeg-devel] [PATCH] avfilter/drawutils: add support for full range

2018-05-03 Thread Michael Niedermayer
On Wed, May 02, 2018 at 02:02:24PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/drawutils.c | 11 --- > libavfilter/drawutils.h | 1 + > libavutil/colorspace.h| 12 >

Re: [FFmpeg-devel] [GSOC] [PATCH] SRCNN filter

2018-05-03 Thread Michael Niedermayer
On Thu, May 03, 2018 at 03:17:11PM -0300, Pedro Arthur wrote: > 2018-04-10 14:16 GMT-03:00 Sergey Lavrushkin : > > 2018-03-29 3:55 GMT+03:00 Michael Niedermayer : > > > >> On Wed, Mar 28, 2018 at 11:17:40AM +0300, Sergey Lavrushkin wrote: > >> > > [...] >

[FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-03 Thread Alex Converse
From: Alex Converse --- libavformat/flvenc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index e8af48cb64..827d798a61 100644 --- a/libavformat/flvenc.c +++ b/libavformat/flvenc.c @@ -480,7 +480,7

Re: [FFmpeg-devel] [PATCH 0/3] WebM in dashenc

2018-05-03 Thread Jan Ekström
On Fri, Apr 27, 2018 at 3:51 AM, Jan Ekström wrote: > Personally I would be for removal of the WebM muxing feature in dashenc > altogether, since the dashenc feature has never seemingly worked, and > since there is a whole separate WebM-specific DASH meta muxer in > webmdashenc.

Re: [FFmpeg-devel] [PATCH 2/4] vaapi_encode_h265: Insert mastering display colour colume if needed

2018-05-03 Thread Mark Thompson
On 03/05/18 04:07, Haihao Xiang wrote: > '-sei xxx' is added to control SEI insertion, so far only mastering > display colour colume is available for testing. Typo: "colume" (also in the commit title). > v2: use the mastering display parameters from > AVMasteringDisplayMetadata, set

Re: [FFmpeg-devel] [PATCH] vaapi_encode_h264: Take VAAPIEncodeH264Context::sei_needed as an ORed value

2018-05-03 Thread Mark Thompson
On 03/05/18 06:51, Haihao Xiang wrote: > We may check priv->sei_needed only when writing SEI messages. > > Signed-off-by: Haihao Xiang > --- > libavcodec/vaapi_encode_h264.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/4] cbs_h265: read/write HEVC PREFIX SEI

2018-05-03 Thread Mark Thompson
On 03/05/18 04:07, Haihao Xiang wrote: > Similar to H264, cbs_h265_{read, write}_nal_unit() can handle HEVC > prefix SEI NAL units. Currently mastering display colour volume SEI > message is added only, we may add more SEI message if needed later > > v2: Fix coding style and rebase the code > >

Re: [FFmpeg-devel] [PATCH 3/4] cbs_h265: read/write content light level information SEI message

2018-05-03 Thread Mark Thompson
On 03/05/18 04:07, Haihao Xiang wrote: > Signed-off-by: Haihao Xiang > --- > libavcodec/cbs_h2645.c| 1 + > libavcodec/cbs_h265.h | 6 ++ > libavcodec/cbs_h265_syntax_template.c | 17 + > 3 files changed, 24

Re: [FFmpeg-devel] [PATCH 4/4] vaapi_encode_h265: Insert content light level information

2018-05-03 Thread Mark Thompson
On 03/05/18 04:07, Haihao Xiang wrote: > Signed-off-by: Haihao Xiang > --- > libavcodec/vaapi_encode_h265.c | 29 - > 1 file changed, 28 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/vaapi_encode_h265.c

Re: [FFmpeg-devel] [PATCH]lavf/isom: Recognize fourcc HEVC

2018-05-03 Thread Carl Eugen Hoyos
2018-05-03 22:26 GMT+02:00, James Almer : > On 5/2/2018 6:12 PM, Carl Eugen Hoyos wrote: >> 2018-05-02 22:50 GMT+02:00, Hendrik Leppkes : >> >>> If anything at all, this should most definitely not go into >>> movvideo tags. This is about AVI files, so if it

Re: [FFmpeg-devel] [PATCH v2] avformat/mxfenc: add h264 profiles

2018-05-03 Thread Thomas Mundt
Hi, this is a better version of the patch. 10 bit and TFF are mandatory for AVC Intra only. Other profiles differ. Regards, Thomas 0001-avformat-mxfenc-add-h264-profiles.patch Description: Binary data ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] avcodec/flac_parser: Fix infinite loop

2018-05-03 Thread Michael Niedermayer
Fixes: crbug/827204 Reported-by: Frank Liberato Reviewed-by: Frank Liberato Signed-off-by: Michael Niedermayer --- libavcodec/flac_parser.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] flvenc: Fix sequence header update timestamps

2018-05-03 Thread Steven Liu
> On 4 May 2018, at 02:00, Jan Ekström wrote: > > On Thu, May 3, 2018 at 8:58 PM, Jan Ekström wrote: >> On Thu, May 3, 2018 at 7:50 PM, Alex Converse >> wrote: >>> From: Alex Converse >>> >>> --- >>>

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_libvmaf.c The libvmaf filter tried to join on an invalid thread id

2018-05-03 Thread Kevin Wheatley
On Thu, May 3, 2018 at 12:38 PM, Ronald S. Bultje wrote: > Why? > > Your patch fixes a bug, I don't think we test bugs in fate, just features. I am perhaps making an incorrect assumption that the code has a bug because it is never tested and that by adding a test that simply

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_libvmaf.c The libvmaf filter tried to join on an invalid thread id

2018-05-03 Thread Ronald S. Bultje
Hi, On Thu, May 3, 2018 at 4:41 AM, Kevin Wheatley wrote: > Following up my own email with another question or so: > > Could somebody point me at a suitable method of testing this within > the Fate framework? Why? Your patch fixes a bug, I don't think we test bugs