Re: [FFmpeg-devel] [PATCH v3 4/5] vaapi_encode: Add ROI support

2019-06-25 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Tuesday, June 04, 2019 7:19 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v3 4/5] vaapi_encode: Add ROI support > > +// For overlapping

Re: [FFmpeg-devel] [PATCH] avformat/vividas: check length in read_vblock()

2019-06-25 Thread Michael Niedermayer
On Wed, Jun 12, 2019 at 03:23:59PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 15166/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5731062396747776 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/xpmdec: Do not use context dimensions as temporary variables

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 01:20:17AM +0200, Michael Niedermayer wrote: > Fixes: Integer overflow > Fixes: > 15134/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XPM_fuzzer-5722635939348480 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Fix integer overflow with num_tile_rows and num_tile_columns

2019-06-25 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type 'int' Fixes: 14880/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5130977304641536 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aacpsdsp_template: Fix integer overflow in ps_hybrid_analysis_c()

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 08:32:33PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1539565182 + -798086761 cannot be > represented in type 'int' > Fixes: > 14807/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-564925382682214 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-25 Thread Jeyapal, Karthick
On 6/24/19 4:23 PM, Alfred E. Heggestad wrote: > On 24/06/2019 11:24, Jeyapal, Karthick wrote: >> >> On 6/20/19 3:00 PM, Alfred E. Heggestad wrote: >>> >>> >>> On 20/06/2019 05:19, Jeyapal, Karthick wrote: On 6/19/19 3:08 PM, Alfred E. Heggestad wrote: > On 19/06/2019 07:21,

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/fitsdec: Check data_min/max

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 04:29:54PM +0200, Moritz Barsnick wrote: > On Thu, Jun 13, 2019 at 01:20:20 +0200, Michael Niedermayer wrote: > > +if (header->data_min == header->data_max) { > > Just a note: > Equality comparison of floats/doubles may trigger a warning. (Possibly > needs to be

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-25 Thread Shivam
On 6/25/19 2:12 AM, Michael Niedermayer wrote: On Mon, Jun 24, 2019 at 09:18:13PM +0530, Shivam wrote: Hi!     The code is to add DICOM Support. The patch is only for uncompressed dicom files using explicit value representation. I would extend it, once i clarify some doubts. As dicom

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 20, 2019 at 01:04:45AM -0300, James Almer wrote: > On 6/19/2019 3:59 PM, James Almer wrote: > > On 6/19/2019 3:13 PM, Michael Niedermayer wrote: > >> On Wed, Jun 19, 2019 at 12:54:25PM -0300, James Almer wrote: > >>> On 6/19/2019 6:22 AM, Michael Niedermayer wrote: > On Mon, Jun

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/fitsdec: Fix division be 0 in size check

2019-06-25 Thread Michael Niedermayer
On Fri, Jun 14, 2019 at 09:46:17AM +0200, Moritz Barsnick wrote: > On Thu, Jun 13, 2019 at 20:32:35 +0200, Michael Niedermayer wrote: > > > avcodec/fitsdec: Fix division be 0 in size check > Nit:^ by will push without the typo thanks [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH v3 3/5] libx265: Update ROI behaviour to match documentation

2019-06-25 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Guo, Yejun > Sent: Tuesday, June 04, 2019 2:46 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v3 3/5] libx265: Update ROI behaviour to > match

Re: [FFmpeg-devel] [PATCH 2/4] avformat/img2dec: Fix probe_buffer leak in ff_img_read_header()

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 01:20:18AM +0200, Michael Niedermayer wrote: > Fixes: memleak > Fixes: > 15171/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5683881644130304 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/truemotion2: Fix integer overflow in last loop in tm2_update_block()

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 08:32:36PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1727985666 - 538976288 cannot be represented > in type 'int' > Fixes: > 15031/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5100228035739648 > > Signed-off-by: Michael

[FFmpeg-devel] [PATCH v2] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-25 Thread Jacob Siddall
The previous calculation code did not account for the fact that the copy_offset for the start of the frame array is at index 0, yet the scan line number from the rfc4175 RTP header starts at 1. This caused 2 issues to appear: - The first scan line was being copied into the array where the second

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-25 Thread Michael Niedermayer
On Wed, Jun 19, 2019 at 03:59:47PM -0300, James Almer wrote: > On 6/19/2019 3:13 PM, Michael Niedermayer wrote: > > On Wed, Jun 19, 2019 at 12:54:25PM -0300, James Almer wrote: > >> On 6/19/2019 6:22 AM, Michael Niedermayer wrote: > >>> On Mon, Jun 17, 2019 at 07:55:45PM -0300, James Almer wrote:

[FFmpeg-devel] [PATCH 2/2] avcodec/hevc_ps: Change num_tile_rows/columns checks to sps->ctb_height/weight

2019-06-25 Thread Michael Niedermayer
Suggested-by: James Almer Signed-off-by: Michael Niedermayer --- libavcodec/hevc_ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index 07d220a5c8..f6e80e1609 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec/hevc_ps.c @@

[FFmpeg-devel] [PATCH] avcodec/fitsdec: Check data_min/max

2019-06-25 Thread Michael Niedermayer
Fixes: division by 0 Fixes: 15206/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FITS_fuzzer-5657260212092928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/fitsdec.c | 8 1 file

Re: [FFmpeg-devel] [PATCH] dash: change default MP4 extension to .m4s

2019-06-25 Thread Alfred E. Heggestad
On 25/06/2019 11:43, Jeyapal, Karthick wrote: On 6/24/19 4:23 PM, Alfred E. Heggestad wrote: Hi Karthick, here is the rebased patch as an attachment. please review and apply if it looks okay. Thanks. I have applied it. Thanks for applying it :) /alfred

Re: [FFmpeg-devel] [PATCH v14 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-06-25 Thread Carl Eugen Hoyos
Am Di., 25. Juni 2019 um 12:17 Uhr schrieb Jing Sun : > diff --git a/libavcodec/version.h b/libavcodec/version.h > index 2709163..3583499 100644 > --- a/libavcodec/version.h > +++ b/libavcodec/version.h > @@ -29,7 +29,7 @@ > > #define LIBAVCODEC_VERSION_MAJOR 58 > #define

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/motionpixels: Check for vlc error in mp_get_vlc()

2019-06-25 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 12:00:52AM +0200, Michael Niedermayer wrote: > Fixes: > 15246/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOTIONPIXELS_fuzzer-5168534407086080 > Fixes: runtime error: index -1 out of bounds for type 'HuffCode [16]' > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/loco: Limit lossy parameter so it is sane and does not overflow

2019-06-25 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 12:00:54AM +0200, Michael Niedermayer wrote: > Fixes: > 15248/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5087440458481664 > Fixes: signed integer overflow: 3 + 2147483647 cannot be represented in type > 'int' > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avformat/mov: Set fragment.found_tfhd only after TFHD has been parsed

2019-06-25 Thread Michael Niedermayer
On Sat, Jun 15, 2019 at 03:51:54PM +0200, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: crbug971646.mp4 > > Reported-by: Matt Wolenetz > Reviewed-by: Matt Wolenetz > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 3 +-- > 1 file changed, 1 insertion(+), 2

[FFmpeg-devel] [PATCH v14 2/2] doc: Add libsvt_hevc encoder docs

2019-06-25 Thread Jing Sun
Add docs for libsvt_hevc encoder in encoders.texi and general.texi Signed-off-by: Jun Zhao Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jing Sun --- doc/encoders.texi | 149 ++ doc/general.texi | 8 +++ 2 files

[FFmpeg-devel] [PATCH v14 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-06-25 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 501 +++

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevc_ps: Change num_tile_rows/columns checks to sps->ctb_height/weight

2019-06-25 Thread James Almer
On 6/25/2019 5:55 AM, Michael Niedermayer wrote: > Suggested-by: James Almer > > Signed-off-by: Michael Niedermayer > --- > libavcodec/hevc_ps.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > index

Re: [FFmpeg-devel] [PATCH v2] libavfilter: Add derain filter changeLog

2019-06-25 Thread Steven Liu
> 在 2019年6月13日,18:56,Xuewei Meng 写道: > > Signed-off-by: Xuewei Meng > --- > Changelog | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Changelog b/Changelog > index 0e4e9eb7b9..086f36b966 100644 > --- a/Changelog > +++ b/Changelog > @@ -32,6 +32,7 @@ version : > - asr filter > -

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Fix integer overflow with num_tile_rows and num_tile_columns

2019-06-25 Thread James Almer
On 6/25/2019 5:55 AM, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type > 'int' > Fixes: > 14880/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5130977304641536 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Fix integer overflow with num_tile_rows and num_tile_columns

2019-06-25 Thread James Almer
On 6/25/2019 10:30 AM, James Almer wrote: > On 6/25/2019 5:55 AM, Michael Niedermayer wrote: >> +num_tile_columns_minus1 >= sps->width - 1) { > > Should be sps->ctb_width > > From 7.4.3.3.1: > > "num_tile_columns_minus1 plus 1 specifies the number of tile columns > partitioning the

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-06-25 Thread Chris Cunningham
Friendly ping. On Thu, Jun 20, 2019 at 11:17 AM Chris Cunningham wrote: > On Thu, Feb 28, 2019 at 9:13 AM James Almer wrote: > >> On 2/26/2019 10:18 PM, Chris Cunningham wrote: >> > On Thu, Feb 21, 2019 at 4:46 PM Chris Cunningham >> > mailto:chcunning...@chromium.org>> wrote: >> > >> >

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-06-25 Thread James Almer
On 6/25/2019 1:44 PM, Chris Cunningham wrote: > Friendly ping. > > On Thu, Jun 20, 2019 at 11:17 AM Chris Cunningham > wrote: > >> On Thu, Feb 28, 2019 at 9:13 AM James Almer wrote: >> >>> On 2/26/2019 10:18 PM, Chris Cunningham wrote: On Thu, Feb 21, 2019 at 4:46 PM Chris Cunningham

Re: [FFmpeg-devel] [PATCH v4] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-06-25 Thread Phil Burr
It's been a month, no replies. Is this commit going to be committed, or is there something further I need to do to move this along? Should I post a rebased version? Thanks, Phil On Tue, May 21, 2019 at 8:40 AM Phillip Burr wrote: > Minimal support for ATSC PSIP tables. Does not support STT

[FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-25 Thread Andreas Håkon
Example of use: ffmpeg -f mpegts -i INPUT.ts -map i:101 -c:v copy -map i:102 -bsf:a delayer=offset=3600 -c:a copy -f mpegts OUTPUT.ts You can use it with VIDEO, AUDIO or DATA streams. Regards. A.H. ---From 414a3c78dfa208b8253448d5c09fde9a8bee56cb Mon Sep 17 00:00:00 2001 From: Andreas Hakon

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-25 Thread Gyan
On 26-06-2019 12:58 AM, Gyan wrote: On 26-06-2019 12:47 AM, Andreas Håkon wrote: Example of use: ffmpeg -f mpegts -i INPUT.ts -map i:101 -c:v copy -map i:102 -bsf:a delayer=offset=3600 -c:a copy -f mpegts OUTPUT.ts You can use it with VIDEO, AUDIO or DATA streams. What's the advantage

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-25 Thread Andreas Rheinhardt
Andreas Håkon: > Example of use: > > ffmpeg -f mpegts -i INPUT.ts -map i:101 -c:v copy -map i:102 -bsf:a > delayer=offset=3600 -c:a copy -f mpegts OUTPUT.ts > > You can use it with VIDEO, AUDIO or DATA streams. > > Regards. > A.H. > > --- > > >

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-25 Thread Gyan
On 26-06-2019 12:47 AM, Andreas Håkon wrote: Example of use: ffmpeg -f mpegts -i INPUT.ts -map i:101 -c:v copy -map i:102 -bsf:a delayer=offset=3600 -c:a copy -f mpegts OUTPUT.ts You can use it with VIDEO, AUDIO or DATA streams. What's the advantage over output_ts_offset? Gyan

[FFmpeg-devel] print pts as min:sec

2019-06-25 Thread Ulf Zibis
Hi, is there a functionality in the ffmpeg library to print AVFrame pts values in respect to AVRational time_base in human readable form? Thanks -Ulf ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] frame->display_picture_number is always 0

2019-06-25 Thread Ulf Zibis
Hi, in a filter context I'm reading AVFrame field display_picture_number. It is always 0. How can I get this field filled with valid data? The field AVFrame->coded_picture_number has valid data, but the numbers are slightly unordered, so I want to use field display_picture_number. Thanks, -Ulf

[FFmpeg-devel] [PATCH 2/3] avcodec/simple_idct_template: Fix integer overflow in idctSparseCol()

2019-06-25 Thread Michael Niedermayer
Fixes: signed integer overflow: -1027919784 + -1120041624 cannot be represented in type 'int' Fixes: 15406/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3_fuzzer-5700646528876544 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [PATCH 1/3] avcodec/svq3: Use ff_set_dimension()

2019-06-25 Thread Michael Niedermayer
Fixes: OOM Fixes: 15410/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SVQ3_fuzzer-5659464805384192 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/svq3.c | 36

[FFmpeg-devel] [PATCH 3/3] avcodec/simple_idct_template: Fix integer overflow in idctSparseColAdd()

2019-06-25 Thread Michael Niedermayer
Fixes: signed integer overflow: 1106434976 + 1041773512 cannot be represented in type 'int' Fixes: 15421/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV2_fuzzer-5669209314426880 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH v14 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-06-25 Thread Sun, Jing A
-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl Eugen Hoyos Sent: Tuesday, June 25, 2019 9:07 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v14 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

Re: [FFmpeg-devel] print pts as min:sec

2019-06-25 Thread greg Luce
> > is there a functionality in the ffmpeg library to print AVFrame pts > values in respect to AVRational time_base in human readable form? I wonder if vf_drawtext might have an example of what you’re looking for with the pts keyword? > ___

Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-25 Thread greg Luce
Hello, Just wondering if there’s anything else I should do to get this in Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH v2 4/9] vp9_parser: Return stream properties

2019-06-25 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Li, Zhong > Sent: Friday, May 31, 2019 3:23 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH v2 4/9] vp9_parser: Return stream > properties > > > From: ffmpeg-devel

[FFmpeg-devel] [PATCH v15 2/2] doc: Add libsvt_hevc encoder docs

2019-06-25 Thread Jing Sun
Add docs for libsvt_hevc encoder in encoders.texi and general.texi Signed-off-by: Jun Zhao Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jing Sun --- doc/encoders.texi | 149 ++ doc/general.texi | 8 +++ 2 files

[FFmpeg-devel] [PATCH v15 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-06-25 Thread Jing Sun
Signed-off-by: Zhengxu Huang Signed-off-by: Hassene Tmar Signed-off-by: Jun Zhao Signed-off-by: Jing Sun --- configure| 4 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/libsvt_hevc.c | 501 +++