Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-08-20 Thread Gyan
On 19-08-2019 07:15 PM, Ilinca Tudose wrote: Hi Marton, I want to confirm that we get correctly synced TCs when leaving out the format_code parameter and using an ffmpeg build from head (not with Gyan's patch). However, I was under the impression that we need the format_code so that we can

Re: [FFmpeg-devel] [PATCH] libavcodec: add editpts bitstream filter [v4]

2019-08-20 Thread Andreas Håkon
Ping! ‐‐‐ Original Message ‐‐‐ On Friday, 16 de August de 2019 12:19, Andreas Håkon wrote: > Hi, > > The latest version ready to merge of the bitstream filter "editpts". > Implements all requests. > > This supersedes: > > https://patchwork.ffmpeg.org/patch/14302/ > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-20 Thread Thilo Borgmann
Am 19.08.19 um 23:22 schrieb Michael Niedermayer: > On Mon, Aug 19, 2019 at 05:09:37PM +0200, Thilo Borgmann wrote: >> Am 19.08.19 um 14:27 schrieb Michael Niedermayer: >>> On Mon, Aug 19, 2019 at 07:41:43AM +0200, Thilo Borgmann wrote: Am 19.08.19 um 01:30 schrieb Michael Niedermayer: >

Re: [FFmpeg-devel] [PATCH v2] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-08-20 Thread Andreas Rheinhardt
Hello, I have not looked at the *PS and the SEI stuff yet, but here is already my review of the general code. Andriy Gelman: > From: Andriy Gelman > > Fixes #7799 > > Currently, the mp4toannexb filter always inserts the same extradata at > the start of the first IRAP unit. As in ticket #7799,

[FFmpeg-devel] [PATCH 1/2] avcodec/vp5/6/8: use vpX_rac_is_end()

2019-08-20 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/vp5.c | 2 +- libavcodec/vp6.c | 2 +- libavcodec/vp8.c | 8 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/vp5.c b/libavcodec/vp5.c index 49988b8b76..0fca282918 100644 --- a/libavcodec/vp5.c +++

[FFmpeg-devel] [PATCH] small v360 improvements

2019-08-20 Thread Paul B Mahol
Hi, patches attached. 0001-doc-filters-fix-v360-options-names.patch Description: Binary data 0002-add-v360-to-Changelog.patch Description: Binary data 0003-doc-filters-fix-typos.patch Description: Binary data 0004-avfilter-vf_v360-improve-comments-above-headers.patch Description: Binary

[FFmpeg-devel] [PATCH 2/2] avcodec/vp56rac: delay signaling an error on truncated input

2019-08-20 Thread Michael Niedermayer
A threshold of 1 is sufficient for simple_dump_cut.webm, 10 is used just to be sure the next truncated file doesnt cause the same issue Obvious alternative fixes are to simply accept that the file is broken or to write some advanced error concealment or to simply accept that the decoder wont stop

[FFmpeg-devel] [PATCH 2/3] dnn: change .model file format to put layer number at the end of file

2019-08-20 Thread Guo, Yejun
currently, the layer number is at the beginning of the .model file, so we have to scan twice in python script, the first scan to get the layer number. Only one scan needed after put the layer number at the end of .model file. Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_native.c

[FFmpeg-devel] [PATCH 1/3] dnn: introduce dnn operand (in c code) to hold operand infos within network

2019-08-20 Thread Guo, Yejun
the info can be saved in dnn operand object without regenerating again and again, and it is also needed for layer split/merge, and for memory reuse. to make things step by step, this patch just focuses on c code, the change within python script will be added later. Signed-off-by: Guo, Yejun

Re: [FFmpeg-devel] [CALL] New FFmpeg developers meeting

2019-08-20 Thread Paul B Mahol
Hi, Because of current overall toxic situation in FFmpeg, meeting will not be held until situation improves considerably. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH 1/1] avformat/matroska: fully parse stsd atom in v_quicktime tracks

2019-08-20 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 12:32:03PM +0200, Stanislav Ionascu wrote: > Hi, > > thanks for looking into this. > > On Sun, Aug 18, 2019 at 4:55 AM Andreas Rheinhardt > wrote: > > > > Hello, > > > > I am no expert on mov (and so this should definitely be looked at from > > someone who is), but I

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support decoding ACELP.KELVIN

2019-08-20 Thread Paul B Mahol
Do not use full caps name for short name. On Mon, Aug 19, 2019 at 11:38 PM Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes tickets #4799 and #8081, thanks to Paul for his help. > > Please comment, Carl Eugen > ___ > ffmpeg-devel mailing list >

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-20 Thread Paul B Mahol
On Mon, Aug 19, 2019 at 11:31 PM James Almer wrote: > On 8/13/2019 10:14 PM, Eugene Lyapustin wrote: > > Signed-off-by: Eugene Lyapustin > > --- > > doc/filters.texi | 137 +++ > > libavfilter/Makefile |1 + > > libavfilter/allfilters.c |1 + > > libavfilter/vf_v360.c|

[FFmpeg-devel] [PATCH 3/3] dnn: export operand info in python script and load in c code

2019-08-20 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- libavfilter/dnn/dnn_backend_native.c| 49 +++--- libavfilter/dnn/dnn_backend_native.h| 2 +- libavfilter/dnn_interface.h | 2 +- tools/python/convert_from_tensorflow.py | 111 +--- 4 files changed, 142

[FFmpeg-devel] [PATCH v1 1/2] avcodec/videotoolboxenc: add H264 Extended profile and level

2019-08-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/videotoolboxenc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index d76bb7f646..b16b056f6c 100644 --- a/libavcodec/videotoolboxenc.c +++

[FFmpeg-devel] [PATCH v1 2/2] avcodec/videotoolboxenc: return error for invalid/unsupport profile or level

2019-08-20 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/videotoolboxenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c index b16b056f6c..52fc531af3 100644 --- a/libavcodec/videotoolboxenc.c +++ b/libavcodec/videotoolboxenc.c

Re: [FFmpeg-devel] [PATCH]lavc/g729dec: Support decoding ACELP.KELVIN

2019-08-20 Thread Carl Eugen Hoyos
Am Di., 20. Aug. 2019 um 10:30 Uhr schrieb Paul B Mahol : > > Do not use full caps name for short name. New patch attached. Thank you, Carl Eugen From 8af0b279ad0c25425d075498f60b0770528687a2 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 19 Aug 2019 23:34:37 +0200 Subject: [PATCH]

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Kieran Kunhya
On Tue, 20 Aug 2019 at 18:06, Michael Niedermayer wrote: > On Tue, Aug 20, 2019 at 05:09:51PM +0100, Kieran Kunhya wrote: > > On Tue, 20 Aug 2019 at 14:16, Carl Eugen Hoyos > wrote: > > > > > Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol < > one...@gmail.com > > > >: > > > > > > > I

[FFmpeg-devel] [PATCH v2] tools/target_dec_fuzzer: use refcounted packets

2019-08-20 Thread James Almer
Should reduce date copying considerably. Signed-off-by: James Almer --- Fixed a stupid mistake when checking the return value for av_new_packet(). Still untested. tools/target_dec_fuzzer.c | 71 --- 1 file changed, 21 insertions(+), 50 deletions(-) diff

Re: [FFmpeg-devel] [PATCH V3] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-20 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > James Zern > Sent: Wednesday, August 21, 2019 8:47 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V3] avcodec/libvpxenc: add ROI-based > encoding

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Michael Niedermayer
On Tue, Aug 20, 2019 at 06:13:49PM -0300, James Almer wrote: > On 8/20/2019 3:32 PM, Michael Niedermayer wrote: > > On Tue, Aug 20, 2019 at 02:52:49PM -0300, James Almer wrote: > >> On 8/20/2019 2:46 PM, Michael Niedermayer wrote: > >>> On Tue, Aug 20, 2019 at 02:49:13PM +0200, Paul B Mahol wrote:

[FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: use refcounted packets

2019-08-20 Thread James Almer
Should help reduce date copying. Signed-off-by: James Almer --- Untested. tools/target_dec_fuzzer.c | 71 --- 1 file changed, 21 insertions(+), 50 deletions(-) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index d83039417c..c3232e8d80

Re: [FFmpeg-devel] [PATCH] lavf/vf_deinterlace_vaapi: flush queued frame in field mode

2019-08-20 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Wednesday, August 21, 2019 04:49 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] lavf/vf_deinterlace_vaapi: flush > queued frame in field mode > > On

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=28.

2019-08-20 Thread Elliott Karpilovsky
I believe the documentation is out of date. I added some debug statements and verified that variable was being used to pull CRF values when AOM_Q mode is set. I have https://aomedia-review.googlesource.com/c/aom/+/94104 out to update the documentation. On Fri, Aug 16, 2019 at 10:59 AM James Zern

Re: [FFmpeg-devel] [PATCH v2] avcodec/h264_parse: retry decoding SPS with complete NAL

2019-08-20 Thread Jun Li
On Mon, Aug 19, 2019 at 7:24 PM Jun Li wrote: > Fix #6591 > The content has no rbsp_stop_one_bit for ending the SPS, that > causes the decoding SPS failure, results decoding frame failure as well. > > The patch is just adding a retry with complete NALU, copied from the retry > in

Re: [FFmpeg-devel] [PATCH V3] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-20 Thread James Zern
Hi, On Tue, Aug 13, 2019 at 8:29 PM Guo, Yejun wrote: > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 197 >

Re: [FFmpeg-devel] [PATCH 0/3] AVEncodeInfo and extractqp changes

2019-08-20 Thread Juan De León
On Mon, Aug 19, 2019 at 4:37 PM Juan De León wrote: > Proposed changes to use AVEncodeInfoFrame and AVencodeInfoBlock > data types as AVFrameSideData, including the changes tothe h264 > decoder as well as a filter to output the data extracted. > > Filter can be called using: > ffmpeg -debug

[FFmpeg-devel] [PATCH v1 2/3] avformat/hlsenc: fix memleak of filename

2019-08-20 Thread Steven Liu
CID: 1452445 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index fbc6554b97..689e29edcc 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2580,9 +2580,8 @@ static

[FFmpeg-devel] [PATCH v1 3/3] avformat/hlsenc: remove unused value

2019-08-20 Thread Steven Liu
CID: 1452644 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 689e29edcc..6b0f49c3b7 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2786,7 +2786,6 @@ static int

[FFmpeg-devel] [PATCH v1 1/3] avformat/hlsenc: fix memleak in hls_write_trailer

2019-08-20 Thread Steven Liu
fix CID: 1426931 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 836e290eea..fbc6554b97 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2539,6 +2539,7 @@ static int

Re: [FFmpeg-devel] [PATCH] lavf: Add DICOM demuxer, lavc: Add DICOM decoder

2019-08-20 Thread Michael Niedermayer
On Tue, Aug 20, 2019 at 08:53:43PM +0530, Shivam wrote: > Sorry, for my previous mail, i forgot to attach the patch. > > The patch contains support for Dicom files. The below features are supported > yet:- > Uncompressed DICOM files using any of the Implicit and Explicit VR formats. > Multiframe

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread James Almer
On 8/20/2019 3:32 PM, Michael Niedermayer wrote: > On Tue, Aug 20, 2019 at 02:52:49PM -0300, James Almer wrote: >> On 8/20/2019 2:46 PM, Michael Niedermayer wrote: >>> On Tue, Aug 20, 2019 at 02:49:13PM +0200, Paul B Mahol wrote: Hi, I kindly ask that following commit:

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Michael Niedermayer
On Tue, Aug 20, 2019 at 02:49:13PM +0200, Paul B Mahol wrote: > Hi, > > I kindly ask that following commit: d702769213487923c0fb0abe4b61f4d9ebddb88b > is reverted as it does contradicts with reference decoder. Noone is listed in MAINTAINERs for scpr.c the main author of scpr.c is you, so i

Re: [FFmpeg-devel] [PATCH v2 1/3] avfilter: add v360 filter

2019-08-20 Thread James Almer
On 8/20/2019 5:29 AM, Paul B Mahol wrote: > On Mon, Aug 19, 2019 at 11:31 PM James Almer wrote: > >> On 8/13/2019 10:14 PM, Eugene Lyapustin wrote: >>> Signed-off-by: Eugene Lyapustin >>> --- >>> doc/filters.texi | 137 +++ >>> libavfilter/Makefile |1 + >>>

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Michael Niedermayer
On Tue, Aug 20, 2019 at 02:52:49PM -0300, James Almer wrote: > On 8/20/2019 2:46 PM, Michael Niedermayer wrote: > > On Tue, Aug 20, 2019 at 02:49:13PM +0200, Paul B Mahol wrote: > >> Hi, > >> > >> I kindly ask that following commit: > >> d702769213487923c0fb0abe4b61f4d9ebddb88b > >> is reverted

Re: [FFmpeg-devel] [PATCH] lavf/vf_deinterlace_vaapi: flush queued frame in field mode

2019-08-20 Thread Mark Thompson
On 02/08/2019 10:53, Linjie Fu wrote: > Add deint_vaapi_request_frame for deinterlace_vaapi, send NULL frame > to flush the queued frame. > > Fix the frame drop issue in field mode: > > ffmpeg -hwaccel vaapi -vaapi_device /dev/dri/renderD128 -v verbose -c:v > h264 -i ./input.h264 -vf

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Michael Niedermayer
On Tue, Aug 20, 2019 at 05:09:51PM +0100, Kieran Kunhya wrote: > On Tue, 20 Aug 2019 at 14:16, Carl Eugen Hoyos wrote: > > > Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol > >: > > > > > I kindly ask that following commit: > > d702769213487923c0fb0abe4b61f4d9ebddb88b > > > > I still

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread James Almer
On 8/20/2019 2:46 PM, Michael Niedermayer wrote: > On Tue, Aug 20, 2019 at 02:49:13PM +0200, Paul B Mahol wrote: >> Hi, >> >> I kindly ask that following commit: d702769213487923c0fb0abe4b61f4d9ebddb88b >> is reverted as it does contradicts with reference decoder. > > Noone is listed in

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Michael Niedermayer
On Tue, Aug 20, 2019 at 09:18:09PM +0100, Kieran Kunhya wrote: > On Tue, 20 Aug 2019 at 18:06, Michael Niedermayer > wrote: > > > On Tue, Aug 20, 2019 at 05:09:51PM +0100, Kieran Kunhya wrote: > > > On Tue, 20 Aug 2019 at 14:16, Carl Eugen Hoyos > > wrote: > > > > > > > Am Di., 20. Aug. 2019 um

Re: [FFmpeg-devel] [PATCH v2 1/2] vaapi_encode: ensure correct VBR bitrate is used in h264 SPS

2019-08-20 Thread Mark Thompson
On 13/08/2019 02:04, Aman Gupta wrote: > From: Aman Gupta > > This is a regression from 2562dd9e7831743ba6dc5680501fb7d26a2ec62c > which surfaces a pathological bug in some Intel hardware encoders, > causing very low bitrates to be generated whenever VBR mode is used. > > /cc

[FFmpeg-devel] [PATCH] lavf: Add DICOM demuxer, lavc: Add DICOM decoder

2019-08-20 Thread Shivam
Sorry, for my previous mail, i forgot to attach the patch. The patch contains support for Dicom files. The below features are supported yet:- Uncompressed DICOM files using any of the Implicit and Explicit VR formats. Multiframe files are also supported. To extract the metadata or info about

[FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Paul B Mahol
Hi, I kindly ask that following commit: d702769213487923c0fb0abe4b61f4d9ebddb88b is reverted as it does contradicts with reference decoder. Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v1] lavf/dump: dump the vbv_delay with N/A instead of 18446744073709551615

2019-08-20 Thread Michael Niedermayer
On Sun, Aug 18, 2019 at 10:31:20PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/dump.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavformat/dump.c b/libavformat/dump.c > index

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/alsdec: Fix integer overflow in decode_var_block_data()

2019-08-20 Thread Michael Niedermayer
On Mon, Aug 19, 2019 at 07:41:56AM +0200, Thilo Borgmann wrote: > Am 19.08.19 um 01:30 schrieb Michael Niedermayer: > > Fixes: signed integer overflow: 1927975249 - -514719744 cannot be > > represented in type 'int' > > Fixes: > >

[FFmpeg-devel] [PATCH] lavf: ad DICOM demuxer, lavc: add DICOM decoder

2019-08-20 Thread Shivam
The patch contains support for Dicom files. I have added the below features:- Uncompressed DICOM files using any of the Implicit and Explicit VR formats are supported. Multiframe files are also supported. To extract the metadata or info about the procedure, I have added an option "-metadata."

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Carl Eugen Hoyos
Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol : > I kindly ask that following commit: d702769213487923c0fb0abe4b61f4d9ebddb88b I still believe what the patch does is a very good idea and a revert would hurt FFmpeg. Carl Eugen ___

Re: [FFmpeg-devel] [PATCH v2] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-08-20 Thread Andriy Gelman
Andreas, On Tue, 20. Aug 07:54, Andreas Rheinhardt wrote: > Hello, > > I have not looked at the *PS and the SEI stuff yet, but here is > already my review of the general code. > > Andriy Gelman: > > From: Andriy Gelman > > > > Fixes #7799 > > > > Currently, the mp4toannexb filter always

[FFmpeg-devel] [PATCH v15 12/15] lavc/mjpegdec: Skip unknown APPx marker on bayer images

2019-08-20 Thread Nick Renieris
Samples: - Embedded JPEG images in the DNG images here: https://www.photographyblog.com/previews/pentax_k1_photos Signed-off-by: Nick Renieris --- libavcodec/mjpegdec.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/libavcodec/mjpegdec.c

[FFmpeg-devel] [PATCH v15 14/15] lavc/tiff: Default-initialize WhiteLevel DNG tag value

2019-08-20 Thread Nick Renieris
Initialized to `(2 ^ BitsPerSample) - 1` as per the DNG Specification. Also make sure that `BlackLevel < WhiteLevel`. This fixes decoding for "X7 CinemaDNG" samples here: - https://www.dji.com/gr/zenmuse-x7/info#downloads Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 22

[FFmpeg-devel] [PATCH v15 08/15] lavc/tiff: Force DNG pixel data endianness on an edge case

2019-08-20 Thread Nick Renieris
Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 12 1 file changed, 12 insertions(+) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 1ca9a59dbf..d9750891d4 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1038,6 +1038,18 @@ static int init_image(TiffContext

[FFmpeg-devel] [PATCH v15 15/15] lavc/tiff: Enable decoding of LinearRaw images

2019-08-20 Thread Nick Renieris
"LinearRaw" is a value that the PhotometricInterpretation tag can be set to on DNG images that contain color information for all channels instead of being bayer-encoded ("CFA" value). The DNG decoder is complete enough that we can enable this now. Sample: -

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Limit maximum channels to 64

2019-08-20 Thread Michael Niedermayer
On Tue, Aug 20, 2019 at 09:12:36AM +0200, Thilo Borgmann wrote: > Am 19.08.19 um 23:22 schrieb Michael Niedermayer: > > On Mon, Aug 19, 2019 at 05:09:37PM +0200, Thilo Borgmann wrote: > >> Am 19.08.19 um 14:27 schrieb Michael Niedermayer: > >>> On Mon, Aug 19, 2019 at 07:41:43AM +0200, Thilo

[FFmpeg-devel] [PATCH v15 01/15] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs

2019-08-20 Thread Nick Renieris
Main image data in DNGs is usually comprised of tiles, each of which is a Huffman-encoded lossless JPEG. Tested for ljpeg regressions with: `ffmpeg -f lavfi -i testsrc=d=1 -vcodec ljpeg test.avi` `ffmpeg test.avi out.avi` The modified code in ljpeg_decode_rgb_scan runs without issues.

[FFmpeg-devel] [PATCH v15 03/15] lavc/tiff: Convert DNGs to sRGB color space

2019-08-20 Thread Nick Renieris
Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 4c6b835afe..a2102f32b5 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -731,14 +731,23

[FFmpeg-devel] [PATCH v15 13/15] lavc/tiff: Support DNGs with striped (non-tiled) JPEGs images

2019-08-20 Thread Nick Renieris
DNG samples here can now be decoded: - https://www.photographyblog.com/previews/pentax_k1_photos Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 61 --- 1 file changed, 37 insertions(+), 24 deletions(-) diff --git a/libavcodec/tiff.c

[FFmpeg-devel] [PATCH v15 05/15] lavc/jpegtables: Handle multiple mappings to the same value

2019-08-20 Thread Nick Renieris
Some JPEGs [1] have incorrect DHT entries that map 2 codes to the same value. The second (last) mapping does not ever actually appear in the code stream, therefore ignoring any mappings after the first one fixes this. Without this, an "mjpeg_decode_dc: bad vlc: 0:0" error is thrown. In all

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/alsdec: Limit maximum channels to 512

2019-08-20 Thread Thilo Borgmann
Am 20.08.19 um 16:52 schrieb Michael Niedermayer: > There seems to be no limit in the specification and upto 64k could be stored > 512 is choosen as limit as thats the maximum in a conformance sample > > An alternative to this patch would be a max_channels variable > > Fixes: OOM > Fixes: >

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Kieran Kunhya
On Tue, 20 Aug 2019 at 14:16, Carl Eugen Hoyos wrote: > Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol >: > > > I kindly ask that following commit: > d702769213487923c0fb0abe4b61f4d9ebddb88b > > I still believe what the patch does is a very good idea and a revert would > hurt FFmpeg. >

[FFmpeg-devel] [PATCH v15 10/15] lavc/tiff: Support decoding of DNGs with single-component JPEGs

2019-08-20 Thread Nick Renieris
This enables decoding of DNG images generated by the 'DJI Zenmuse X7' digital camera Samples: https://www.dji.com/gr/zenmuse-x7/info#downloads Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 61 +++ 1 file changed, 51 insertions(+), 10

[FFmpeg-devel] [PATCH v15 11/15] lavc/tiff: Decode 10-bit and 14-bit DNG images

2019-08-20 Thread Nick Renieris
10-bit sample: http://www.rawsamples.ch/raws/phones/RAW_ONEPLUS_ONE-A0001.DNG 14-bit sample: https://drive.google.com/open?id=0B4JyRT3Lth5HVndyOTVOdWktM3J4TFEydTk1MnY3RWlpSzVB Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 23 +++ 1 file changed, 15 insertions(+), 8

[FFmpeg-devel] [PATCH v15 06/15] lavc/tiff: Fix edge case with full-length/width tiles

2019-08-20 Thread Nick Renieris
In an image [1], the height was equal to the tile length (full-height tile) and after `height % tile_length` was applied to them with the current code, it resulted in the operating tile_length to be 0. This commit makes this leftover logic only applies if it's necessary. Signed-off-by: Nick

[FFmpeg-devel] [PATCH 2/2] avcodec/internal: Bump sane_nb_chanels

2019-08-20 Thread Michael Niedermayer
This allows decoding more als reference samples Suggested-by: Thilo Borgmann Signed-off-by: Michael Niedermayer --- libavcodec/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index 5096ffa1d9..5f964148fd 100644 ---

[FFmpeg-devel] [LDP] FFmpeg at LinuxDays 2019 in Prague

2019-08-20 Thread Thilo Borgmann
Hi all, FFmpeg has been accepted again for a booth at the LinuxDays 2019 in Prague, Czech Republic from October 5th to 6th! Like last year, we hope to have a great conference with many users and fellow open-source projects attending! Find detailed information here:

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-08-20 Thread Devin Heitmueller
> A couple of follow-up Qs: > > Is auto-detection available for all Decklink devices? No, but AFAIK it is for all devices which support SDI. Generally it's the older analog capture devices which don't support it. > For those for which it is available, are there any edge cases in which > it sets

[FFmpeg-devel] [PATCH v15 09/15] lavc/mjpegdec: Enable decoding of single-component bayer images

2019-08-20 Thread Nick Renieris
Also, ensure no false positives when determining DNG bayer images, by setting them in tiff.c instead of relying on a heuristic. There's no way to determine this just from the JPEG data, so we have to pass this information from outside the MJPEG decoder. Signed-off-by: Nick Renieris ---

[FFmpeg-devel] [PATCH v15 04/15] lavc/tiff: Apply color scaling to uncompressed DNGs

2019-08-20 Thread Nick Renieris
Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index a2102f32b5..dd1295fad6 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -556,6 +556,7 @@ static

[FFmpeg-devel] [PATCH v15 02/15] lavc/tiff: Decode embedded JPEGs in DNG images

2019-08-20 Thread Nick Renieris
Used a technique similar to lavc/tdsc.c for invoking the MJPEG decoder. This commit adds support for: - DNG tiles - DNG tile huffman lossless JPEG decoding - DNG 8-bpp ("packed" as dcraw calls it) decoding - DNG color scaling [1] - LinearizationTable tag - BlackLevel tag [1]: As specified in

[FFmpeg-devel] [PATCH v15 07/15] lavc/tiff: Don't apply strips-related logic to tiled images

2019-08-20 Thread Nick Renieris
Signed-off-by: Nick Renieris --- libavcodec/tiff.c | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 257230c386..1ca9a59dbf 100644 --- a/libavcodec/tiff.c +++ b/libavcodec/tiff.c @@ -1780,7

[FFmpeg-devel] [PATCH 1/2] avcodec/alsdec: Limit maximum channels to 512

2019-08-20 Thread Michael Niedermayer
There seems to be no limit in the specification and upto 64k could be stored 512 is choosen as limit as thats the maximum in a conformance sample An alternative to this patch would be a max_channels variable Fixes: OOM Fixes:

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Paul B Mahol
On Tue, Aug 20, 2019 at 3:16 PM Carl Eugen Hoyos wrote: > Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol >: > > > I kindly ask that following commit: > d702769213487923c0fb0abe4b61f4d9ebddb88b > > I still believe what the patch does is a very good idea and a revert would > hurt FFmpeg.