[FFmpeg-devel] [PATCH 1/1] avdevice/gdigrab remove CAPTUREBLT flag

2020-01-21 Thread fgodtdev
From: FgoDt Remove CAPTUREBLT flag, CAPTUREBLT flag may make mouse flicker. Discussion details see:https://patchwork.ffmpeg.org/project/ffmpeg/patch/hk2pr03mb4596ab273414d034c0f0d34ec6...@hk2pr03mb4596.apcprd03.prod.outlook.com/ Signed-off-by: fgodt --- libavdevice/gdigrab.c | 2 +- 1 file

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-21 Thread Zane van Iperen
22/1/20 9:52 am, Carl Eugen Hoyos пишет: > > Am Mi., 22. Jan. 2020 um 00:33 Uhr schrieb Zane van Iperen > : >> >> 21/1/20 11:14 pm, Carl Eugen Hoyos пишет: >>> >>> Am Di., 21. Jan. 2020 um 11:09 Uhr schrieb Zane van Iperen >>> : >>> +static int argo_asf_probe(const AVProbeData *p) +{

Re: [FFmpeg-devel] [PATCH] avformat/utils: log corrupt packets

2020-01-21 Thread Gyan
On 26-12-2019 09:03 pm, Gyan wrote: On 26-12-2019 08:30 pm, Andreas Rheinhardt wrote: On Thu, Dec 26, 2019 at 3:55 PM Gyan Doshi wrote: ---   libavformat/utils.c | 15 +--   1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c

Re: [FFmpeg-devel] [PATCH 3/3] swscale/output: Fix several invalid shifts in yuv2rgb_full_1_c_template()

2020-01-21 Thread Andreas Rheinhardt
On Tue, Jan 21, 2020 at 11:24 PM Michael Niedermayer wrote: > Fixes: Invalid shifts > Fixes: #8320 > > Signed-off-by: Michael Niedermayer > --- > libswscale/output.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libswscale/output.c b/libswscale/output.c > index

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-21 Thread Carl Eugen Hoyos
Am Mi., 22. Jan. 2020 um 00:33 Uhr schrieb Zane van Iperen : > > 21/1/20 11:14 pm, Carl Eugen Hoyos пишет: > > > > Am Di., 21. Jan. 2020 um 11:09 Uhr schrieb Zane van Iperen > > : > > > >> +static int argo_asf_probe(const AVProbeData *p) > >> +{ > >> +int score; > >> +ArgoASFFileHeader

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-21 Thread Mark Thompson
On 10/01/2020 21:05, Lynne wrote: > From 1e3a50fbe4399f76c0ab0f62bf6d6c65b8565db4 Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Sun, 27 Oct 2019 14:47:18 + > Subject: [PATCH 7/9] lavfi: add an avgblur_vulkan filter > > This commit adds a fast avgblur Vulkan filter. > This will reset Intel

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-21 Thread Carl Eugen Hoyos
Am Mi., 22. Jan. 2020 um 01:41 Uhr schrieb Zane van Iperen : > > 22/1/20 10:30 am, Carl Eugen Hoyos пишет: > > > > Am Mi., 22. Jan. 2020 um 01:13 Uhr schrieb Zane van Iperen > > : > > > >> Ah, sorry I misunderstood. How's this? > >> > >> >if (hdr.magic != ASF_TAG) > >> >return 0; >

[FFmpeg-devel] [PATCH v4 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-21 Thread Zane van Iperen
Adds support for the custom ASF container used by some Argonaut Games' games, such as 'Croc! Legend of the Gobbos', and 'Croc 2'. Can also handle the sample files in: https://samples.ffmpeg.org/game-formats/brender/part2.zip Signed-off-by: Zane van Iperen --- Changelog| 1 +

[FFmpeg-devel] [PATCH v4 1/2] avcodec: add decoder for argonaut games' adpcm codec

2020-01-21 Thread Zane van Iperen
Adds support for the ADPCM variant used by some Argonaut Games' games, such as 'Croc! Legend of the Gobbos', and 'Croc 2'. Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 152

[FFmpeg-devel] [PATCH v4 0/2] Argonaut Games ASF and ADPCM decoding support

2020-01-21 Thread Zane van Iperen
Hi all, This patchset adds support for the ASF container and ADPCM variant used by some Argonaut Software games such as 'Croc! Legend of the Gobbos' and 'Croc 2'. It has been tested against: - ANISOUND/*.ASFfrom Croc 1 - music/*.asf from Croc 2 - FIGHT/SOUND/*.ASF from

Re: [FFmpeg-devel] [PATCH 2/3] swscale/swscale: Fix several invalid shifts related to vChrDrop

2020-01-21 Thread Andreas Rheinhardt
On Tue, Jan 21, 2020 at 11:24 PM Michael Niedermayer wrote: > Fixes: Invalid shifts > Fixes: #8166 > > Signed-off-by: Michael Niedermayer > --- > libswscale/swscale.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libswscale/swscale.c b/libswscale/swscale.c >

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-21 Thread Carl Eugen Hoyos
Am Mi., 22. Jan. 2020 um 01:13 Uhr schrieb Zane van Iperen : > Ah, sorry I misunderstood. How's this? > > >if (hdr.magic != ASF_TAG) > >return 0; > > > >if (!argo_asf_is_known_version()) > >return 25; > > > >return (AVPROBE_SCORE_MAX / 2) + 1; I like this much

Re: [FFmpeg-devel] [PATCH V1] libavcodec/aacdec: fix HE-AAC decoder dirty date (for sbr) when flush

2020-01-21 Thread Carl Eugen Hoyos
Am Mi., 1. Jan. 2020 um 06:34 Uhr schrieb Jun Zhao : > > From: qoroliang > > aac decoder only do the window overlapping data buffer flush but > without sbr related buffer flush, that will cause dirty data in > the first output frame after flush. > > Signed-off-by: qoroliang > --- >

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-21 Thread Zane van Iperen
22/1/20 10:30 am, Carl Eugen Hoyos пишет: > > Am Mi., 22. Jan. 2020 um 01:13 Uhr schrieb Zane van Iperen > : > >> Ah, sorry I misunderstood. How's this? >> >> >if (hdr.magic != ASF_TAG) >> >return 0; >> > >> >if (!argo_asf_is_known_version()) >> >return 25; >>

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-21 Thread James Zern
On Fri, Jan 17, 2020 at 1:50 PM Wonkap Jang wrote: > > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offline

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avcodec: Add codec_tags array to AVCodec

2020-01-21 Thread Michael Niedermayer
On Tue, Jan 21, 2020 at 07:48:38PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2019-12-30 00:38:17) > > This allows the fuzzer to target meaningfull codec tags instead > > of hunting the 4gb space, which it seems to have problems with. > > > > Suggested-by: James > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avcodec: Add codec_tags array to AVCodec

2020-01-21 Thread James Almer
On 1/21/2020 4:30 PM, Michael Niedermayer wrote: > On Tue, Jan 21, 2020 at 07:48:38PM +0100, Anton Khirnov wrote: >> Quoting Michael Niedermayer (2019-12-30 00:38:17) >>> This allows the fuzzer to target meaningfull codec tags instead >>> of hunting the 4gb space, which it seems to have problems

[FFmpeg-devel] [PATCH 1/2] configure: Check for GetStdHandle in addition to SetConsoleTextAttribute

2020-01-21 Thread Martin Storsjö
SetConsoleTextAttribute used to be unavailable for Windows Store apps, but is available to them now. But GetStdHandle still is unavailable, thus make sure to check for both functions before using code that requires both. --- Alternatively we could check for just GetStdHandle instead of

[FFmpeg-devel] [PATCH 2/2] libavutil: x86: Include stdlib.h before using _byteswap_ulong

2020-01-21 Thread Martin Storsjö
When clang works in MSVC mode, it does have the _byteswap_ulong builtin, but one has to include stdlib.h before using it. --- libavutil/x86/bswap.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/x86/bswap.h b/libavutil/x86/bswap.h index ffa59e4c82..b2f18b6c93 100644 ---

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avcodec: Add codec_tags array to AVCodec

2020-01-21 Thread Michael Niedermayer
On Tue, Jan 21, 2020 at 04:39:10PM -0300, James Almer wrote: > On 1/21/2020 4:30 PM, Michael Niedermayer wrote: > > On Tue, Jan 21, 2020 at 07:48:38PM +0100, Anton Khirnov wrote: > >> Quoting Michael Niedermayer (2019-12-30 00:38:17) > >>> This allows the fuzzer to target meaningfull codec tags

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avcodec: Add codec_tags array to AVCodec

2020-01-21 Thread James Almer
On 1/21/2020 5:39 PM, Michael Niedermayer wrote: > On Tue, Jan 21, 2020 at 04:39:10PM -0300, James Almer wrote: >> On 1/21/2020 4:30 PM, Michael Niedermayer wrote: >>> On Tue, Jan 21, 2020 at 07:48:38PM +0100, Anton Khirnov wrote: Quoting Michael Niedermayer (2019-12-30 00:38:17) > This

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-21 Thread Lynne
Jan 21, 2020, 18:22 by an...@khirnov.net: > Quoting Lynne (2020-01-21 18:51:22) > >> Jan 21, 2020, 12:08 by an...@khirnov.net: >> >> > Quoting Lynne (2020-01-10 22:05:21) >> > >> >> /** >> >> * Activated physical device >> >> */ >> >> VkDevice act_dev; >> >> >> > >> > Where is this

Re: [FFmpeg-devel] [PATCH 02/11] avformat: Remove unnecessary av_packet_unref()

2020-01-21 Thread Andreas Rheinhardt
On Mon, Jan 13, 2020 at 4:45 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > On Tue, Jan 7, 2020 at 2:56 PM Andreas Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > >> Since bae8844e the packet will always be unreferenced when a demuxer >> returns an error, so that a lot of

[FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: add extra_hw_frames support

2020-01-21 Thread Linjie Fu
While using scale_qsv together with lookahead, extra_hw_frames is required to allocate enough memory. Fix #8379. Signed-off-by: Linjie Fu --- libavfilter/vf_scale_qsv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c index

[FFmpeg-devel] [PATCH] lavc/qsvenc: add NULL pointer check for frame before use

2020-01-21 Thread Linjie Fu
Null Frame would be sent to MSDK to flush the encoder, hence add a NULL check before using frame->interlaced_frame to prevent the potential crash, regardless of the return value of MFXVideoENCODE_EncodeFrameAsync(). Signed-off-by: Linjie Fu --- libavcodec/qsvenc.c | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH] lavc/qsv: refine return value check for MFXQueryIMPL

2020-01-21 Thread Linjie Fu
Signed-off-by: Linjie Fu --- libavcodec/qsv.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index db98c75..563b780 100644 --- a/libavcodec/qsv.c +++ b/libavcodec/qsv.c @@ -391,7 +391,10 @@ int

[FFmpeg-devel] [PATCH] lavfi/qsvvpp: check return value for av_frame_copy_props

2020-01-21 Thread Linjie Fu
Signed-off-by: Linjie Fu --- libavfilter/qsvvpp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index 8d5ff2e..0006f48 100644 --- a/libavfilter/qsvvpp.c +++ b/libavfilter/qsvvpp.c @@ -311,12 +311,11 @@ static QSVFrame

[FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: fix the class_name in help for scale_qsv

2020-01-21 Thread Linjie Fu
Class name is used in show_help_children(avfilter_get_class(),...) to prompt the available filters. $ ffmpeg -h full Before: qsvscale AVOptions: After: scale_qsv AVOptions: Signed-off-by: Linjie Fu --- libavfilter/vf_scale_qsv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adxenc: Avoid undefined left shift of negative numbers

2020-01-21 Thread Michael Niedermayer
On Mon, Jan 20, 2020 at 08:20:42PM +0100, Andreas Rheinhardt wrote: > Replace "((a << shift) + b) >> shift" by "a + (b >> shift)". This avoids > a left shift which also happens to trigger undefined behaviour in case "a" > is negative. This affected the FATE-tests acodec-adpcm-adx and >

Re: [FFmpeg-devel] [PATCH v3] avcodec/adpcm: Fix undefined left shifts of negative numbers

2020-01-21 Thread Michael Niedermayer
On Mon, Jan 20, 2020 at 04:56:55PM +0100, Andreas Rheinhardt wrote: > Affected the adpcm-afc, adpcm-ea-1, adpcm-ea-2, adpcm-ea-maxis-xa, > adpcm-thp and ea-cdata FATE-tests. Also fixes ticket #8487. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/adpcm.c | 16 > 1 file

Re: [FFmpeg-devel] [PATCH V8 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

2020-01-21 Thread Michael Niedermayer
On Sun, Jan 19, 2020 at 11:51:03AM +0800, Ting Fu wrote: > The original inline assembly and nasm code have the same fps when called by > command. > NASM code almost has no impact on the perfromance. > > Signed-off-by: Ting Fu > --- > V8: > Remove all reindention to make review easier. >

Re: [FFmpeg-devel] [PATCH] lavc/pthread_frame: Update user context in ff_frame_thread_free

2020-01-21 Thread Fu, Linjie
Hi, > -Original Message- > From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Monday, January 6, 2020 17:24 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] lavc/pthread_frame: Update user > context in ff_frame_thread_free > >

Re: [FFmpeg-devel] [PATCH] [fateserver] Include slot owner in summary hash

2020-01-21 Thread Michael Niedermayer
On Mon, Jan 20, 2020 at 09:46:16PM +0200, Martin Storsjo wrote: > From: Mans Rullgard > > --- > I think this should allow filtering on the owner by doing > /index.cgi?query=owner:, but as I don't have access to the > actual fate server, I'd appreciate if someone could try it out. > --- >

[FFmpeg-devel] [PATCH v3 1/2] avcodec: add decoder for argonaut games' adpcm codec

2020-01-21 Thread Zane van Iperen
Adds support for the ADPCM variant used by some Argonaut Games' games, such as 'Croc! Legend of the Gobbos', and 'Croc 2'. Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 152

[FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-21 Thread Zane van Iperen
Adds support for the custom ASF container used by some Argonaut Games' games, such as 'Croc! Legend of the Gobbos', and 'Croc 2'. Can also handle the sample files in: https://samples.ffmpeg.org/game-formats/brender/part2.zip Signed-off-by: Zane van Iperen --- Changelog| 1 +

[FFmpeg-devel] [PATCH v3 0/2] Argonaut Games ASF and ADPCM decoding support

2020-01-21 Thread Zane van Iperen
Hi all, This patchset adds support for the ASF container and ADPCM variant used by some Argonaut Software games such as 'Croc! Legend of the Gobbos' and 'Croc 2'. It has been tested against: - ANISOUND/*.ASFfrom Croc 1 - music/*.asf from Croc 2 - FIGHT/SOUND/*.ASF from

[FFmpeg-devel] [PATCHv2] Include slot owner in summary hash

2020-01-21 Thread Martin Storsjö
From: Mans Rullgard Signed-off-by: Martin Storsjö --- Does this look ok? I removed the [fateserver] disambiguation tag and added my own Signed-off-by to it. --- FATE.pm| 14 +- report.cgi | 8 +--- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/FATE.pm

Re: [FFmpeg-devel] [PATCHv2] Include slot owner in summary hash

2020-01-21 Thread Michael Niedermayer
On Tue, Jan 21, 2020 at 12:13:42PM +0200, Martin Storsjö wrote: > From: Mans Rullgard > > Signed-off-by: Martin Storsjö > --- > Does this look ok? I removed the [fateserver] disambiguation tag > and added my own Signed-off-by to it. yes, applied thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCHv2] Include slot owner in summary hash

2020-01-21 Thread Martin Storsjö
On Tue, 21 Jan 2020, Michael Niedermayer wrote: On Tue, Jan 21, 2020 at 12:13:42PM +0200, Martin Storsjö wrote: From: Mans Rullgard Signed-off-by: Martin Storsjö --- Does this look ok? I removed the [fateserver] disambiguation tag and added my own Signed-off-by to it. yes, applied

Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: fix the class_name in help for scale_qsv

2020-01-21 Thread myp...@gmail.com
On Tue, Jan 21, 2020 at 4:51 PM Linjie Fu wrote: > > Class name is used in show_help_children(avfilter_get_class(),...) > to prompt the available filters. > > $ ffmpeg -h full > > Before: > qsvscale AVOptions: > > After: > scale_qsv AVOptions: > > Signed-off-by: Linjie Fu > --- >

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

2020-01-21 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-01-16 17:51:28) > Compared to ad-hoc if(printed) ... code this allows the user to disable > it with a flag and see all repeated messages, it is also simpler That flag is global state - it should be deprecated and removed, not embedded further into the API. > >

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-21 Thread Jon Cook
Hi Zhong, Thanks for your reply. > IMHO If you set the aligned value, FrameInfo.Width/Height shoule > be changed to be: > >q->param.mfx.FrameInfo.Width = FFALIGN(avctx->width, q->width_align); >q->param.mfx.FrameInfo.Height = FFALIGN(avctx->height, q->height_align); Makes sense. I'll

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-21 Thread Anton Khirnov
Quoting Lynne (2020-01-10 22:05:21) > commit d5f1bbc61fab452803443511b1241931169359b7 > Author: Lynne > Date:   Wed Aug 28 21:58:10 2019 +0100 > >     lavu: add Vulkan hwcontext code >     >     This commit adds the necessary code to initialize and use a Vulkan device >     within the hwcontext

[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-21 Thread Jon Cook
From: JonCookCubic Setting FrameInfo.Width and Height as per review comments Signed-off-by: JonCookCubic --- libavcodec/qsvenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 9e416500e9..40904af388 100644 --- a/libavcodec/qsvenc.c

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-21 Thread Jon Cook
Updated patch with FrameInfo.Width and Height set as per review comments Jon On Tue, 21 Jan 2020 at 11:47, Jon Cook wrote: > Hi Zhong, > > Thanks for your reply. > > > IMHO If you set the aligned value, FrameInfo.Width/Height shoule > > be changed to be: > > > >q->param.mfx.FrameInfo.Width

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-21 Thread Jon Cook
Giving up on how to update the patch. Going to delete this ticket and create a new one! Jon On Tue, 21 Jan 2020 at 12:30, Jon Cook wrote: > Updated patch with FrameInfo.Width and Height set as per review comments > > Jon > > On Tue, 21 Jan 2020 at 11:47, Jon Cook wrote: > >> Hi Zhong, >> >>

[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when encoding with mjpeg_qsv

2020-01-21 Thread Jon Cook
From: JonCookCubic Currently width_align and height_align are zero when encoding with mjpeg_qsv which causes "Error submitting the frame for encoding". This patch sets the alignments. There is a little bit more about the problem here

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-21 Thread Carl Eugen Hoyos
Am Di., 21. Jan. 2020 um 11:09 Uhr schrieb Zane van Iperen : > +static int argo_asf_probe(const AVProbeData *p) > +{ > +int score; > +ArgoASFFileHeader hdr; > + > +av_assert0(AVPROBE_PADDING_SIZE >= ASF_FILE_HEADER_SIZE); > + > +argo_asf_parse_file_header(, p->buf); > + > +if

Re: [FFmpeg-devel] [PATCH]lavc/mpegvideo_enc: Do not write an extra RST tag after final jpeg slice

2020-01-21 Thread Michael Niedermayer
On Mon, Jan 20, 2020 at 11:59:18PM +0100, Carl Eugen Hoyos wrote: > Am Mo., 20. Jan. 2020 um 23:34 Uhr schrieb Michael Niedermayer > : > > > > On Mon, Jan 20, 2020 at 11:15:31PM +0100, Carl Eugen Hoyos wrote: > > > Am Mo., 20. Jan. 2020 um 22:51 Uhr schrieb Michael Niedermayer > > > : > > > > > >

Re: [FFmpeg-devel] [PATCH]lavc/mpegvideo_enc: Do not write an extra RST tag after final jpeg slice

2020-01-21 Thread Carl Eugen Hoyos
Am Di., 21. Jan. 2020 um 14:19 Uhr schrieb Michael Niedermayer : > > mjpegenc_common.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > 5c76a5298352eb275764526ebe2d7312c98d1c26 > > 0001-lavc-mjpegenc-Fix-not-writing-RST-tag-after-final-sl.patch > > From

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/j2kenc: Fix undefined shifts of negative numbers

2020-01-21 Thread Michael Niedermayer
On Tue, Jan 21, 2020 at 01:23:47AM +0100, Andreas Rheinhardt wrote: > Also add parentheses to some lines to make the operator precedence > clearer. > > This affected the FATE-tests vsynth*-jpeg2000 and vsynth*-jpeg2000-97 > (where * ranges over { 1, 2, 3, _lena }) as well as ticket #7983. > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/libzmq: Replace fail statements with goto

2020-01-21 Thread Michael Niedermayer
On Mon, Jan 20, 2020 at 09:24:30PM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship: All citizens are under surveillance, all their steps and actions recorded, for the politicians to enforce control.

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

2020-01-21 Thread Michael Niedermayer
On Tue, Jan 21, 2020 at 12:24:50PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-01-16 17:51:28) > > Compared to ad-hoc if(printed) ... code this allows the user to disable > > it with a flag and see all repeated messages, it is also simpler > > That flag is global state - it

[FFmpeg-devel] [PATCH] avutil/log: Move log_level_offset_offset code from av_log() to v_log()

2020-01-21 Thread Michael Niedermayer
Suggested-by: Anton Signed-off-by: Michael Niedermayer --- libavutil/log.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/log.c b/libavutil/log.c index e8a0db7716..c3e65f0470 100644 --- a/libavutil/log.c +++ b/libavutil/log.c @@ -362,19 +362,19 @@ static

Re: [FFmpeg-devel] headers for gapless playback

2020-01-21 Thread Kaplan, John
> > As far as control, I'll need to add a config switch to control adding gapless data or not. > Why wouldn't it always be added? If that's the consensus, then sure. But other tools I've seen have gapless metadata output controlled by a switch and not put in by default. > Please

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-21 Thread Lynne
Jan 21, 2020, 12:08 by an...@khirnov.net: > Quoting Lynne (2020-01-10 22:05:21) > >> /** >> * Activated physical device >> */ >> VkDevice act_dev; >> > > Where is this 'activated' terminology from? From what I can see, the > spec calls this a 'logical' device. Would be nice to be consistent

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-01-21 Thread Lynne
Jan 20, 2020, 08:42 by kavea...@gmail.com: > Ping > https://ffmpeg.org/pipermail/ffmpeg-devel/2019-August/248836.html I've okayed it, its just not been pushed yet. You'll need to add the vectors to the block struct. int16_t [2] will do. ___

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-21 Thread Anton Khirnov
Quoting Lynne (2020-01-21 18:51:22) > Jan 21, 2020, 12:08 by an...@khirnov.net: > > > Quoting Lynne (2020-01-10 22:05:21) > > > >> /** > >> * Activated physical device > >> */ > >> VkDevice act_dev; > >> > > > > Where is this 'activated' terminology from? From what I can see, the > > spec

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avcodec: Add codec_tags array to AVCodec

2020-01-21 Thread Michael Niedermayer
On Mon, Dec 30, 2019 at 10:38:11AM +0100, Nicolas George wrote: > Michael Niedermayer (12019-12-30): > > This allows the fuzzer to target meaningfull codec tags instead > > of hunting the 4gb space, which it seems to have problems with. > > > > Suggested-by: James > > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 4/5] tools/target_dec_fuzzer: Also Fuzz with CPU optimizations disabled

2020-01-21 Thread Michael Niedermayer
On Sun, Dec 29, 2019 at 08:23:38PM +0100, Michael Niedermayer wrote: > This should improve coverage of *_c() > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 2 ++ > 1 file changed, 2 insertions(+) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 1/2] avutil/log: Add av_log_once() for printing a message just once per instance

2020-01-21 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-01-21 15:43:48) > On Tue, Jan 21, 2020 at 12:24:50PM +0100, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2020-01-16 17:51:28) > > > Compared to ad-hoc if(printed) ... code this allows the user to disable > > > it with a flag and see all repeated messages,

Re: [FFmpeg-devel] [PATCH 1/5] tools/target_dec_fuzzer: Fuzz idct_algo value

2020-01-21 Thread Michael Niedermayer
On Sun, Dec 29, 2019 at 08:23:35PM +0100, Michael Niedermayer wrote: > This should improve coverage > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 2 ++ > 1 file changed, 2 insertions(+) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 3/5] tools/target_dec_fuzzer: Fuzz private options of AC3/E-AC3

2020-01-21 Thread Michael Niedermayer
On Sun, Dec 29, 2019 at 08:23:37PM +0100, Michael Niedermayer wrote: > This should improve AC-3 coverage > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 19 +-- > 1 file changed, 17 insertions(+), 2 deletions(-) will apply [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/avcodec: Add codec_tags array to AVCodec

2020-01-21 Thread Anton Khirnov
Quoting Michael Niedermayer (2019-12-30 00:38:17) > This allows the fuzzer to target meaningfull codec tags instead > of hunting the 4gb space, which it seems to have problems with. > > Suggested-by: James > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h | 6 ++ > 1 file

Re: [FFmpeg-devel] [PATCHv2] avutil/thread: Add pthread_cond_timedwait function

2020-01-21 Thread Marton Balint
On Mon, 20 Jan 2020, Matt Oliver wrote: On Mon, 20 Jan 2020 at 11:14, Marton Balint wrote: From: Matt Oliver v2: fix calculating milisecond times and use SleepConditionVariableSRW. Signed-off-by: Matt Oliver --- compat/os2threads.h | 25 + compat/w32pthreads.h

[FFmpeg-devel] [PATCH] avformat/libsrt: add missing SRT_VERSION_VALUE check

2020-01-21 Thread Marton Balint
This was missed in d7e2a2bb35e394287b3e3dc27744830bf0b7ca99. Signed-off-by: Marton Balint --- libavformat/libsrt.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 443df5bee8..d7faa603f5 100644 --- a/libavformat/libsrt.c +++

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

2020-01-21 Thread Carl Eugen Hoyos
Am Di., 21. Jan. 2020 um 22:56 Uhr schrieb Marton Balint : > > > > On Fri, 17 Jan 2020, Michael Niedermayer wrote: > > > On Thu, Jan 16, 2020 at 01:20:16AM +0100, Marton Balint wrote: > >> It is not supported by every threading implementation, and the only thing > >> we > >> gain with it is an

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

2020-01-21 Thread Marton Balint
On Fri, 17 Jan 2020, Michael Niedermayer wrote: On Thu, Jan 16, 2020 at 01:20:16AM +0100, Marton Balint wrote: It is not supported by every threading implementation, and the only thing we gain with it is an immediate shutdown of receiving packets on close and avoiding the poll call before

[FFmpeg-devel] [PATCH 1/3] swscale/input: Fix several invalid shifts related to rgb2yuv constants

2020-01-21 Thread Michael Niedermayer
Fixes: Invalid shifts Fixes: #8140 Fixes: #8146 Signed-off-by: Michael Niedermayer --- libswscale/input.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswscale/input.c b/libswscale/input.c index 064f8da314..159f70307d 100644 --- a/libswscale/input.c +++

[FFmpeg-devel] [PATCH 3/3] swscale/output: Fix several invalid shifts in yuv2rgb_full_1_c_template()

2020-01-21 Thread Michael Niedermayer
Fixes: Invalid shifts Fixes: #8320 Signed-off-by: Michael Niedermayer --- libswscale/output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/output.c b/libswscale/output.c index d192ea854b..439de04a05 100644 --- a/libswscale/output.c +++ b/libswscale/output.c

[FFmpeg-devel] [PATCH 2/3] swscale/swscale: Fix several invalid shifts related to vChrDrop

2020-01-21 Thread Michael Niedermayer
Fixes: Invalid shifts Fixes: #8166 Signed-off-by: Michael Niedermayer --- libswscale/swscale.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 4ecfa88ff7..8436f056d4 100644 --- a/libswscale/swscale.c +++

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-21 Thread Mark Thompson
On 10/01/2020 21:05, Lynne wrote: > From 04c1836f89d89dcdc892cef66ee82afbcfda9f2d Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Sun, 27 Oct 2019 14:44:00 + > Subject: [PATCH 4/9] lavfi: add Vulkan filtering framework > > This commit adds a Vulkan filtering infrastructure for libavfilter. >

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-21 Thread Mark Thompson
On 19/01/2020 16:51, Philip Langdale wrote: > On Sat, 18 Jan 2020 20:23:00 + > Mark Thompson wrote: > >>> typedef struct AVHWDeviceInternal AVHWDeviceInternal; >>> diff --git a/libavutil/hwcontext_cuda.c b/libavutil/hwcontext_cuda.c >>> index 30611b1912..18abb87bbd 100644 >>> ---

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix hls_ts_options with mpegts

2020-01-21 Thread Marton Balint
Was broken since cdbf8847ea97a985dfd55432e1384bb7fe5d2d3b. Signed-off-by: Marton Balint --- libavformat/hlsenc.c | 36 +--- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 2b3d3742d9..87b861d437

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-21 Thread Mark Thompson
On 19/01/2020 16:41, Philip Langdale wrote: > On Sat, 18 Jan 2020 20:27:12 + > Mark Thompson wrote: > >> On 10/01/2020 21:05, Lynne wrote: >>> This is modelled as a transfer, as we have today, but where both >>> the src and the dst are hardware frames with hw contexts. We need >>> to be

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for argonaut games' ASF format

2020-01-21 Thread Zane van Iperen
21/1/20 11:14 pm, Carl Eugen Hoyos пишет: > > Am Di., 21. Jan. 2020 um 11:09 Uhr schrieb Zane van Iperen > : > >> +static int argo_asf_probe(const AVProbeData *p) >> +{ >> +int score; >> +ArgoASFFileHeader hdr; >> + >> +av_assert0(AVPROBE_PADDING_SIZE >= ASF_FILE_HEADER_SIZE); >> +

Re: [FFmpeg-devel] [PATCH] Vulkan hwcontext and filters

2020-01-21 Thread Mark Thompson
On 19/01/2020 13:11, Lynne wrote: > Jan 18, 2020, 20:23 by s...@jkqxz.net: > >> On 10/01/2020 21:05, Lynne wrote: >> >> The CUDA parts look like they could be split off into a separate commit? >> (It's already huge.) >> > > I don't really want broken commits or commits with dead code.