Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpeg12dec: Fix got_output

2020-06-07 Thread Michael Niedermayer
On Thu, May 28, 2020 at 02:12:34PM +0200, Michael Niedermayer wrote: > Fixes: assertion failure > Fixes: > 22178/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-5664234440753152 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/lzf: Consider the needed size in reallocation

2020-06-07 Thread Michael Niedermayer
On Thu, May 28, 2020 at 06:20:56PM +0200, Michael Niedermayer wrote: > Fixes: NULL pointer dereference > Fixes: > 22381/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NOTCHLC_fuzzer-5659879921680384.fuzz > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-07 Thread Carl Eugen Hoyos
Am Sa., 6. Juni 2020 um 23:40 Uhr schrieb Lewis Fox : > libavformat/flac_picture.c | 112 +- > libavformat/flac_picture.h | 6 +- > libavformat/flacdec.c| 4 +- > libavformat/flacenc.c| 100 + Moving flac_write_picture() should be a separate patch. Carl

Re: [FFmpeg-devel] [PATCH 1/3] avformat/4xm: Cleanup on GET_LIST_HEADER() failure

2020-06-07 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: memleak > Fixes: > 23142/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5932860820422656 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavformat/4xm.c

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mlvdec: fail reading a packet with 0 streams

2020-06-07 Thread Michael Niedermayer
On Mon, Jun 01, 2020 at 11:51:41PM +0200, Michael Niedermayer wrote: > On Sun, May 31, 2020 at 07:07:11PM -0300, James Almer wrote: > > On 5/31/2020 6:48 PM, Michael Niedermayer wrote: > > > On Sun, May 31, 2020 at 10:58:16AM -0300, James Almer wrote: > > >> On 5/31/2020 10:50 AM, Michael

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/ac3dec_fixed: Remove some temporary variables from scale_coefs()

2020-06-07 Thread Michael Niedermayer
On Sun, Feb 02, 2020 at 01:16:39AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ac3dec_fixed.c | 30 -- > 1 file changed, 8 insertions(+), 22 deletions(-) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-07 Thread LRFLEW
>$ make SAMPLES=fate-suite fate-rsync >$ make SAMPLES=fate-suite fate That explains it. The "Contribute" documentation just says "make fate", so I didn't realize I wasn't running the entire suite. I re-ran the tests, and saw a different test fail, being lavf-fate-vp3.ogg. Looking at the hex

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h2645: keep separate parameter set lists for reading and writing

2020-06-07 Thread James Almer
On 6/7/2020 12:20 PM, James Almer wrote: > On 6/7/2020 11:45 AM, Michael Niedermayer wrote: >> On Sun, Jun 07, 2020 at 10:27:37AM -0300, James Almer wrote: >>> Similar logic as 4e2bef6a82. In scearios where an Access Unit is written >>> right >>> after reading it using the same CBS context

[FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for lagarith

2020-06-07 Thread Michael Niedermayer
Fixes: Timeout (3minute 49 sec -> 3sec) Fixes: 22020/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LAGARITH_fuzzer-5708544679870464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer ---

[FFmpeg-devel] [PATCH 1/3] avformat/4xm: Cleanup on GET_LIST_HEADER() failure

2020-06-07 Thread Michael Niedermayer
Fixes: memleak Fixes: 23142/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5932860820422656 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/4xm.c | 8 +--- 1 file changed, 5

[FFmpeg-devel] [PATCH 3/3] avcodec/lossless_audiodsp: Fix undefined overflows in scalarproduct_and_madd_int16_c()

2020-06-07 Thread Michael Niedermayer
Fixes: signed integer overflow: 2142077091 + 6881070 cannot be represented in type 'int' Fixes: 22737/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-595839681920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpeg12dec: Fix got_output

2020-06-07 Thread Kieran Kunhya
Needs some more explanation IMO Sent from my mobile device On Sun, 7 Jun 2020, 21:27 Michael Niedermayer, wrote: > On Thu, May 28, 2020 at 02:12:34PM +0200, Michael Niedermayer wrote: > > Fixes: assertion failure > > Fixes: >

[FFmpeg-devel] [PATCH] lavdevice: Add AudioToolbox output device.

2020-06-07 Thread Thilo Borgmann
Hi, $subject. Enables native audio output on OSX. OSX accepts numerous formats, so there are several output devices. -Thilo From bdabbc6a919ccff20d6ae16acff1a5d0f8ca46b8 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Mon, 8 Jun 2020 00:20:25 +0200 Subject: [PATCH] lavdevice: Add

[FFmpeg-devel] [PATCH] lavdevice: Add VideoToolbox output device.

2020-06-07 Thread Thilo Borgmann
Hi, $subject. Enables native audio output on OSX. OSX accepts numerous formats, so there are several output devices. -Thilo From bdabbc6a919ccff20d6ae16acff1a5d0f8ca46b8 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Mon, 8 Jun 2020 00:20:25 +0200 Subject: [PATCH] lavdevice: Add

Re: [FFmpeg-devel] [PATCH] lavdevice: Add VideoToolbox output device.

2020-06-07 Thread Nicolas George
Thilo Borgmann (12020-06-08): > OSX accepts numerous formats, so there are several output devices. The other audio output devices support all formats in a single device. Why does Apple need to be different again? Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-07 Thread Andreas Rheinhardt
LRFLEW: >> seems to break fate > >> --- ./tests/ref/fate/limited_input_seek-copyts    2020-05-28 >> 14:46:23.971547831 +0200 >> +++ tests/data/fate/limited_input_seek-copyts    2020-06-07 >> 22:10:38.303050886 +0200 >> @@ -1 +1 @@ >> -ffe8a674bdf38e4f650f91963debc654 >>

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpeg12dec: Fix got_output

2020-06-07 Thread Michael Niedermayer
On Sun, Jun 07, 2020 at 11:07:13PM +0100, Kieran Kunhya wrote: > Needs some more explanation IMO If you look at the code which sets the outputed picture in slice_end() if (s->pict_type == AV_PICTURE_TYPE_B || s->low_delay) { int ret = av_frame_ref(pict, s->current_picture_ptr->f); ... }

Re: [FFmpeg-devel] [PATCH] lavdevice: Add VideoToolbox output device.

2020-06-07 Thread Nicolas George
Thilo Borgmann (12020-06-08): > Not sure if you don't mix it with Video screw me... Oh, that's why you re-sent the patch. I could not spot the difference. > For Audio, I cannot find another device handling more than one format in one > device. > I'd appreciate a better way to do it than

[FFmpeg-devel] [PATCH] tools/target_dem_fuzzer: Implement AVSEEK_SIZE

2020-06-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tools/target_dem_fuzzer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 409599636d..cc097da0d7 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools/target_dem_fuzzer.c @@ -70,6 +70,8 @@

Re: [FFmpeg-devel] [PATCH] avformat/fifo: add timeshift option to delay output

2020-06-07 Thread Marton Balint
On Tue, 26 May 2020, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/muxers.texi | 5 libavformat/fifo.c| 59 ++- libavformat/version.h | 2 +- 3 files changed, 64 insertions(+), 2 deletions(-) Ping, will apply soon. Thanks,

Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-07 Thread Carl Eugen Hoyos
Am So., 7. Juni 2020 um 22:54 Uhr schrieb LRFLEW : > I had noticed this on Patchwork. It shows errors for "limited_input_seek" > and "limited_input_seek-copyts". https://patchwork.ffmpeg.org/check/11651/ > However, I've run "make fate" multiple times locally now and it always > passed for me.

Re: [FFmpeg-devel] [PATCH] libavutil/timestamp.h: Fix loss of precision in silencedetect timestamps for long files

2020-06-07 Thread Michael Niedermayer
On Sat, Jun 06, 2020 at 09:32:18PM +, Allan Cady wrote: > [Repeat submission. I really don't know my way around git tools... this time > I'm using "git imap-send" in hopes this will better please the ffmpeg > submission gods. Thank you for your patience.] > > When the silencedetect filter

Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-07 Thread Michael Niedermayer
On Sat, Jun 06, 2020 at 04:37:54PM -0500, Lewis Fox wrote: > Signed-off-by: Lewis Fox > --- > This is an implementation for #4448, adding support for embedding attached > cover art to OGG files. I had a need for the feature for a setup I was using, > and had written a patch for it about half a

[FFmpeg-devel] Error while using libopenjpeg

2020-06-07 Thread Gautam Ramakrishnan
Hi, I am trying to decode the p1_03.j2k reference file. However, while trying to use libopenjpeg instead of the native decoder, I get the following error, [libopenjpeg @ 0x55f249d7e180] Unable to determine pixel format. The exact command run was: ffmpeg -vcodec libopenjpeg -i p1_03.j2k -f

Re: [FFmpeg-devel] Error while using libopenjpeg

2020-06-07 Thread Michael Niedermayer
On Sun, Jun 07, 2020 at 10:36:38PM +0530, Gautam Ramakrishnan wrote: > Hi, > > I am trying to decode the p1_03.j2k reference file. However, while > trying to use libopenjpeg instead of the native decoder, I get the > following error, > [libopenjpeg @ 0x55f249d7e180] Unable to determine pixel

Re: [FFmpeg-devel] [PATCH 2/4] avformat/thp: Check compcount

2020-06-07 Thread Michael Niedermayer
On Sun, May 31, 2020 at 03:50:18PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 22520/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5100297658826752 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/adpcm: XA: Check shift similar to filter

2020-06-07 Thread Michael Niedermayer
On Sun, May 31, 2020 at 03:50:20PM +0200, Michael Niedermayer wrote: > Fixes: negative shift > Fixes: > 22499/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_XA_fuzzer-5765452130418688 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-07 Thread LRFLEW
>seems to break fate >--- ./tests/ref/fate/limited_input_seek-copyts    2020-05-28 >14:46:23.971547831 +0200 >+++ tests/data/fate/limited_input_seek-copyts    2020-06-07 22:10:38.303050886 >+0200 >@@ -1 +1 @@ >-ffe8a674bdf38e4f650f91963debc654 >+aae5603508b268cbb456b633b84a48af >Test

Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-07 Thread Andreas Rheinhardt
Lewis Fox: > Signed-off-by: Lewis Fox > --- > This is an implementation for #4448, adding support for embedding attached > cover art to OGG files. I had a need for the feature for a setup I was using, > and had written a patch for it about half a year ago. I had forgotten to > submit it back

Re: [FFmpeg-devel] [PATCH] lavdevice: Add VideoToolbox output device.

2020-06-07 Thread Thilo Borgmann
Am 08.06.20 um 00:28 schrieb Nicolas George: > Thilo Borgmann (12020-06-08): >> OSX accepts numerous formats, so there are several output devices. > > The other audio output devices support all formats in a single device. > Why does Apple need to be different again? Not sure if you don't mix it

Re: [FFmpeg-devel] [PATCH] lavdevice: Add VideoToolbox output device.

2020-06-07 Thread Thilo Borgmann
Am 08.06.20 um 00:35 schrieb Nicolas George: > Thilo Borgmann (12020-06-08): >> Not sure if you don't mix it with Video screw me... > > Oh, that's why you re-sent the patch. I could not spot the difference. > >> For Audio, I cannot find another device handling more than one format in one >>

[FFmpeg-devel] [PATCH] avcodec/cbs_h2645: keep separate parameter set lists for reading and writing

2020-06-07 Thread James Almer
Similar logic as 4e2bef6a82. In scearios where an Access Unit is written right after reading it using the same CBS context (hevc_metadata), the list of parsed parameters sets used by the writer must not be the one that's the result of the reader having already parsed the current Access Unit in

[FFmpeg-devel] Transcoding journey

2020-06-07 Thread GOUJON Évan
Hi everyone, Let me first congrats all of you for this great project. Working on multimedia data is really challenging (math complexity, time constraints, broken formats) and you did it so you deserve many many thanks for that. I'm currently developing an application that transcodes to

[FFmpeg-devel] [PATCH v4 1/4] ffbuild: Refine MIPS handling

2020-06-07 Thread Jiaxun Yang
To enable runtime detection for MIPS, we need to refine ffbuild part to support buildding these feature together. Firstly, we fixed configure, let it probe native ability of toolchain to decide wether a feature can to be enabled, also clearly marked the conflictions between loongson2 & loongson3

[FFmpeg-devel] [PATCH v4 0/4] MIPS MSA & MMI Runtime detection support

2020-06-07 Thread Jiaxun Yang
This series adds MIPS MSA & MMI runtime detection support Please review. Thanks! v2: - Add CPUCFG support. - Add "-mloongson-ext" to MMIFLAGS for Loongson-3 as well. (Loongson2F don't need this flag) v3: - Address reveiew suggestions from Shiyou Yin and Weixi Gu. v4: - Disable DSP

[FFmpeg-devel] [PATCH v4 4/4] libavcodec: Enable runtime detection for MIPS MMI & MSA

2020-06-07 Thread Jiaxun Yang
Apply optimized functions according to cpuflags. MSA is always put after MMI as it's usually faster than MMI. Signed-off-by: Jiaxun Yang --- libavcodec/mips/blockdsp_init_mips.c| 22 +- libavcodec/mips/cabac.h | 2 +-

[FFmpeg-devel] [PATCH v4 3/4] libavutil: Detect MMI and MSA flags for MIPS

2020-06-07 Thread Jiaxun Yang
Add MMI & MSA runtime detection for MIPS. Basically there are two code pathes. For systems that natively support CPUCFG instruction or kernel emulated that instruction, we'll sense this feature from HWCAP and report the flags according to values grab from CPUCFG. For systems that have no CPUCFG

Re: [FFmpeg-devel] [PATCH v3 1/4] ffbuild: Refine MIPS handling

2020-06-07 Thread Jiaxun Yang
在 2020/6/6 17:48, Shiyou Yin 写道: -Original Message- From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Jiaxun Yang Sent: Saturday, June 6, 2020 3:34 PM To: ffmpeg-devel@ffmpeg.org Cc: yinshi...@loongson.cn; Jiaxun Yang Subject: [FFmpeg-devel]

[FFmpeg-devel] [PATCH v4 2/4] libavutils: Add parse_r helper for MIPS

2020-06-07 Thread Jiaxun Yang
That helper grab from kernel code can allow us to inline newer instructions (not implemented by the assembler) in a elegant manner. Signed-off-by: Jiaxun Yang --- libavutil/mips/asmdefs.h | 42 1 file changed, 42 insertions(+) diff --git

Re: [FFmpeg-devel] Error while using libopenjpeg

2020-06-07 Thread Gautam Ramakrishnan
On Mon, Jun 8, 2020 at 1:25 AM Michael Niedermayer wrote: > > On Sun, Jun 07, 2020 at 10:36:38PM +0530, Gautam Ramakrishnan wrote: > > Hi, > > > > I am trying to decode the p1_03.j2k reference file. However, while > > trying to use libopenjpeg instead of the native decoder, I get the > >

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h2645: keep separate parameter set lists for reading and writing

2020-06-07 Thread Michael Niedermayer
On Sun, Jun 07, 2020 at 10:27:37AM -0300, James Almer wrote: > Similar logic as 4e2bef6a82. In scearios where an Access Unit is written right > after reading it using the same CBS context (hevc_metadata), the list of > parsed > parameters sets used by the writer must not be the one that's the

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h2645: keep separate parameter set lists for reading and writing

2020-06-07 Thread James Almer
On 6/7/2020 11:45 AM, Michael Niedermayer wrote: > On Sun, Jun 07, 2020 at 10:27:37AM -0300, James Almer wrote: >> Similar logic as 4e2bef6a82. In scearios where an Access Unit is written >> right >> after reading it using the same CBS context (hevc_metadata), the list of >> parsed >> parameters