Re: [FFmpeg-devel] [PATCH] http: make caching of redirect url optional

2021-11-07 Thread Eran Kornblau
> > On Tue, 2 Nov 2021, Eran Kornblau wrote: > > > Hi all, > > > > The attached patch makes the default behavior of caching HTTP redirects > > optional. > > Is caching a redirected URL allowed per the HTTP spec? If not, then no > caching should tak

[FFmpeg-devel] Calculating audio frame rate

2020-03-02 Thread Eran Kornblau
Hi all, First, I apologize for asking a question not directly related to ffmpeg development, but hope you can still help me... I'm looking for some code to calculate the frame rate of audio, based on parameters such as the codec id, sampling rate, channels, codec private data etc. For example,

Re: [FFmpeg-devel] Calculating audio frame rate

2020-03-03 Thread Eran Kornblau
> > > -Original Message- > From: ffmpeg-devel On Behalf Of Hendrik > Leppkes > Sent: Tuesday, March 3, 2020 11:08 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Calculating audio frame rate > > On Tue, Mar 3, 2020 at 8

Re: [FFmpeg-devel] Calculating audio frame rate

2020-03-03 Thread Eran Kornblau
> > -Original Message- > From: ffmpeg-devel On Behalf Of Anton > Khirnov > Sent: Tuesday, March 3, 2020 1:11 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] Calculating audio frame rate > > There is av_get_audio_frame_duration[2]() in libavcodec, but i

Re: [FFmpeg-devel] About SAMPLE-AES encryption for m3u8

2020-06-20 Thread Eran Kornblau
> Been trying to figure out how to decrypt SAMPLE-AES and eventually hit an > issue with my lack of understanding how H264 and ffmpeg work. > > Example > > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fd3iki3eydrtvsa.cloudfront.net%2FChernobyl_20200618213021%2FHLS%2FChernobyl

Re: [FFmpeg-devel] [PATCH] libavformat/movenc: Support encryption of H265 stream in AnnexB format

2021-06-04 Thread Eran Kornblau
> > -Original Message- > From: ffmpeg-devel On Behalf Of ? > ? > Sent: Friday, June 4, 2021 9:27 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] libavformat/movenc: Support encryption of > H265 stream in AnnexB format > > > Ping. > > This change is

[FFmpeg-devel] Match source video timestamp

2017-03-28 Thread Eran Kornblau
Hi all, I'm trying to transcode some video file (MP4/h264 baseline vfr/AAC) with ffmpeg, and I would like to have the frame timestamps in the transcoded file perfectly match the source video. This is in order to have them both play together adaptively without issues (from my experience, DASH is

Re: [FFmpeg-devel] Match source video timestamp

2017-04-03 Thread Eran Kornblau
Ping From: Eran Kornblau Sent: Tuesday, March 28, 2017 3:13 PM To: FFmpeg development discussions and patches Subject: Match source video timestamp Hi all, I'm trying to transcode some video file (MP4/h264 baseline vfr/AAC) with ffmpeg, and I would like to have the frame timestamps i

Re: [FFmpeg-devel] Match source video timestamp

2017-04-10 Thread Eran Kornblau
Pinging again... Thanks Eran From: Eran Kornblau Sent: Monday, April 3, 2017 12:29 PM To: 'FFmpeg development discussions and patches' Subject: RE: Match source video timestamp Ping From: Eran Kornblau Sent: Tuesday, March 28, 2017 3:13 PM To: FFmpeg development discussions a

Re: [FFmpeg-devel] Match source video timestamp

2017-04-23 Thread Eran Kornblau
> Hi all, > > I'm trying to transcode some video file (MP4/h264 baseline vfr/AAC) with > ffmpeg, and I would like to have the > frame timestamps in the transcoded file perfectly match the source video. > This is in order to have them both > play together adaptively without issues (from my exper

Re: [FFmpeg-devel] Match source video timestamp

2017-04-30 Thread Eran Kornblau
Ping, re-attaching the same patch Eran -Original Message- From: Eran Kornblau Sent: Sunday, April 23, 2017 12:32 PM To: 'FFmpeg development discussions and patches' Subject: RE: Match source video timestamp > Hi all, > > I'm trying to transcode some video fil

Re: [FFmpeg-devel] Match source video timestamp

2017-04-30 Thread Eran Kornblau
gt; 2017-04-30 13:09 GMT+02:00 Eran Kornblau : > > >> I'm trying to transcode some video file (MP4/h264 baseline vfr/AAC) > >> with ffmpeg, and I would like to have the frame timestamps in the > >> transcoded file perfectly match the source video. > >

Re: [FFmpeg-devel] Match source video timestamp

2017-05-03 Thread Eran Kornblau
stamp > > Le primidi 11 floréal, an CCXXV, Eran Kornblau a écrit : > > Ping, re-attaching the same patch > > Hi. Thanks for the bug report and patch. I do not know the issue well enough > to address the core validity in principle, but I have a few design comments > that w

Re: [FFmpeg-devel] Match source video timestamp

2017-05-08 Thread Eran Kornblau
Ping Eran -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Eran Kornblau Sent: Wednesday, May 3, 2017 11:59 AM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] Match source video timestamp [This sender failed our

[FFmpeg-devel] mp4 encryption with time code track

2017-05-17 Thread Eran Kornblau
Hi all, We bumped into an issue with the mp4 encryption support we submitted a while ago - in case ffmpeg decides to write a timecode track in the output mp4, it crashes. The reason is that mov_create_timecode_track calls ff_mov_write_packet on a track that doesn't have 'cenc' initialized, this

Re: [FFmpeg-devel] mp4 encryption with time code track

2017-05-24 Thread Eran Kornblau
Ping Eran From: Eran Kornblau Sent: Wednesday, May 17, 2017 12:50 PM To: FFmpeg development discussions and patches Subject: mp4 encryption with time code track Hi all, We bumped into an issue with the mp4 encryption support we submitted a while ago - in case ffmpeg decides to write a

[FFmpeg-devel] hev1 vs. hvc1

2017-06-18 Thread Eran Kornblau
Hi all, We're trying to make ffmpeg output a format tag of 'hvc1' for HEVC, since it seems that only hvc1 works in iOS 11 beta. We saw that '-tag:v hvc1' does the trick, but it only works in 'mov' format, and not in 'mp4' format (we're using mp4 format for all our videos) The reason is that ff_c

Re: [FFmpeg-devel] hev1 vs. hvc1

2017-06-19 Thread Eran Kornblau
> > > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > liyoubdu > Sent: Monday, June 19, 2017 11:20 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] hev1 vs. hvc1 > > >> > i think mov is mp4

[FFmpeg-devel] HEVC parser - few small bugs and style issues

2017-10-24 Thread Eran Kornblau
Hi all, I did some work around parsing HEVC headers, and while looking at ffmpeg's implementation, I noticed a few bugs and a few style issues. I'm not submitting a patch, since my familiarity with the decoder is very limited, but hopefully the maintainers will go over the list below and change

[FFmpeg-devel] Support seek in encrypted MP4

2016-02-22 Thread Eran Kornblau
Hi all, Found out today that my patch for supporting encrypted MP4's does not support seek... Patch attached Thanks, Eran 0001-mov-support-seek-in-encrypted-mp4.patch Description: 0001-mov-support-seek-in-encrypted-mp4.patch ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-02-28 Thread Eran Kornblau
Bumping... same patch attached Thanks Eran 0001-mov-support-seek-in-encrypted-mp4.patch Description: 0001-mov-support-seek-in-encrypted-mp4.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Libavcodec consulting

2016-03-04 Thread Eran Kornblau
> > Thanks for that clarification. Unfortunately the http server is a third > party camera that broadcasts a WiFi hotspot. Therefore we don't really > have control over the underlying server. However, what I do know is > that the ffmpeg command I quoted previously seems to be able to > grab a chun

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Eran Kornblau
Ping Thanks Eran 0001-mov-support-seek-in-encrypted-mp4.patch Description: 0001-mov-support-seek-in-encrypted-mp4.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Eran Kornblau
> > can you create a fate test for this ? > maybe seek-test could be simply used? > Sure, can you point me to some existing test that is similar enough for me to use as a reference ? I read the Wiki page about adding a test, but not quite sure how to apply it here > thanks > > [...] > -- > M

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-08 Thread Eran Kornblau
> > check tests/fate/seek.mak > also you can pass parameters to seek-test see fate-seek-cache-pipe > i dont know if there is anything else special needed for this > Thanks Michael, I looked at this some more, and there's one thing that I'm still missing - where do I get the sample encrypted file f

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-15 Thread Eran Kornblau
> > > > > > check tests/fate/seek.mak > > > also you can pass parameters to seek-test see fate-seek-cache-pipe > > > i dont know if there is anything else special needed for this > > > > > Thanks Michael, I looked at this some more, and there's one thing that I'm > > still > > missing - where do

[FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-05 Thread Eran Kornblau
Hi all, We found today that this change: https://github.com/FFmpeg/FFmpeg/commit/ca6cae73db207f17a0d5507609de12842d8f0ca3 can break the decryption of MP4s encrypted with common encryption. I would like to submit a patch for that, but wanted to consult first about the best approach. The problem

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-12 Thread Eran Kornblau
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Sasi > Inguva > Sent: Friday, January 6, 2017 8:25 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] mov: support for multiple edits and cenc > decryption > >

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-30 Thread Eran Kornblau
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Sasi > Inguva > Sent: Wednesday, January 18, 2017 3:30 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] mov: support for multiple edits and cenc > decryption >

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-01-31 Thread Eran Kornblau
> inconsistet in git > > some say: > Author: erankor > > some say: > Author: Eran Kornblau > > Is the way the patches are intended ? > Just double checking as it cannot be changed later > Thanks Michael & Sasi! My GitHub user is erankor, that's t

Re: [FFmpeg-devel] mov: support for multiple edits and cenc decryption

2017-02-01 Thread Eran Kornblau
> > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Wednesday, February 1, 2017 3:53 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] mov: support for multiple edits and cenc > d

Re: [FFmpeg-devel] [PATCH] lavc: Add filter_units bitstream filter

2018-03-25 Thread Eran Kornblau
265 stream. > >> --- > >> On 06/03/18 17:27, Hendrik Leppkes wrote: > >>> On Tue, Mar 6, 2018 at 3:51 PM, Eran Kornblau > >>> wrote: > >>>> Hi all, > >>>> > >>>> The attached patch adds a parameter that enables t

[FFmpeg-devel] avformat/movenc: add param for filtering nal types

2018-03-06 Thread Eran Kornblau
Hi all, The attached patch adds a parameter that enables the user to choose which AVC/HEVC NAL units to include in the output. The parameter is supplied as a bitmask in order to keep things simple. A short background on why we need it - in our transcoding process, we partition the video in chun

[FFmpeg-devel] [PATCH] http: support retry on connection error

2020-10-25 Thread Eran Kornblau
Hi, This patch adds 2 options to http: - reconnect_on_status - a list of http status codes that should be retried. the list can contain explicit status codes or the strings 4xx/5xx. - reconnect_on_err - reconnects on arbitrary errors during connect, e.g. ECONNRESET/ETIMEDOUT. The retry employs

Re: [FFmpeg-devel] [PATCH] http: support retry on connection error

2020-11-01 Thread Eran Kornblau
Ping Thanks, Eran From: Eran Kornblau Sent: Sunday, October 25, 2020 3:40 PM To: FFmpeg development discussions and patches Subject: [PATCH] http: support retry on connection error Hi, This patch adds 2 options to http: - reconnect_on_status - a list of http status codes that should be

Re: [FFmpeg-devel] [PATCH] http: support retry on connection error

2020-11-07 Thread Eran Kornblau
Pinging again... Thanks, Eran From: Eran Kornblau Sent: Sunday, October 25, 2020 3:40 PM To: FFmpeg development discussions and patches mailto:ffmpeg-devel@ffmpeg.org>> Subject: [PATCH] http: support retry on connection error Hi, This patch adds 2 options to http: - reconnect_on_stat

Re: [FFmpeg-devel] [PATCH] http: support retry on connection error

2020-11-17 Thread Eran Kornblau
Another ping... would be great to have some feedback on this... Eran From: Eran Kornblau Sent: Sunday, November 8, 2020 8:59 AM To: FFmpeg development discussions and patches Subject: RE: [PATCH] http: support retry on connection error Pinging again... Thanks, Eran From: Eran Kornblau Sent

[FFmpeg-devel] [PATCH] libx265: support ATSC A/53 captions

2022-10-17 Thread Eran Kornblau
Hi, The attached patch adds rendering of ATSC A/53 captions as HEVC SEI messages. The option name/implementation is aligned with the corresponding libx264 feature. Thanks Eran 0001-libx265-support-ATSC-A-53-captions.patch Description: 0001-libx265-support-ATSC-A-53-captions.patch ___

Re: [FFmpeg-devel] [PATCH] libx265: support ATSC A/53 captions

2022-10-24 Thread Eran Kornblau
Ping From: Eran Kornblau Sent: Monday, 17 October 2022 19:29 To: FFmpeg development discussions and patches Subject: [PATCH] libx265: support ATSC A/53 captions Hi, The attached patch adds rendering of ATSC A/53 captions as HEVC SEI messages. The option name/implementation is aligned with the

Re: [FFmpeg-devel] [PATCH] libx265: support ATSC A/53 captions

2022-11-01 Thread Eran Kornblau
Another ping… From: Eran Kornblau Sent: Monday, 17 October 2022 19:29 To: FFmpeg development discussions and patches mailto:ffmpeg-devel@ffmpeg.org>> Subject: [PATCH] libx265: support ATSC A/53 captions Hi, The attached patch adds rendering of ATSC A/53 captions as HEVC SEI message

Re: [FFmpeg-devel] [PATCH] libx265: support ATSC A/53 captions

2022-11-07 Thread Eran Kornblau
Trying again… From: Eran Kornblau Sent: Monday, 17 October 2022 19:29 To: FFmpeg development discussions and patches mailto:ffmpeg-devel@ffmpeg.org>> Subject: [PATCH] libx265: support ATSC A/53 captions Hi, The attached patch adds rendering of ATSC A/53 captions as HEVC SEI message

Re: [FFmpeg-devel] [PATCH] libx265: support ATSC A/53 captions

2022-11-08 Thread Eran Kornblau
> > -Original Message- > From: ffmpeg-devel On Behalf Of Timo > Rothenpieler > Sent: Tuesday, 8 November 2022 13:33 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] libx265: support ATSC A/53 captions > > > > > The attached patch adds rendering of ATSC A/53 captions a

Re: [FFmpeg-devel] [PATCH] libx265: support ATSC A/53 captions

2022-11-08 Thread Eran Kornblau
> > On 08.11.2022 15:25, Eran Kornblau wrote: > >> > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> Timo Rothenpieler > >> Sent: Tuesday, 8 November 2022 13:33 > >> To: ffmpeg-devel@ffmpeg.org > &g

Re: [FFmpeg-devel] [PATCH] http: support retry on connection error

2020-12-03 Thread Eran Kornblau
Hi Marton, Thank you for the feedback, and sorry for my late reply :) Please see my responses inline, updated patch attached. Thanks Eran > -Original Message- > From: ffmpeg-devel On Behalf Of Marton > Balint > Sent: Wednesday, November 18, 2020 10:46 PM > To: FFmpeg development discus

Re: [FFmpeg-devel] [PATCH] http: support retry on connection error

2020-12-09 Thread Eran Kornblau
Resending... -Original Message- From: Eran Kornblau Sent: Thursday, December 3, 2020 10:52 AM To: FFmpeg development discussions and patches Subject: RE: [FFmpeg-devel] [PATCH] http: support retry on connection error Hi Marton, Thank you for the feedback, and sorry for my late reply

[FFmpeg-devel] FW: [PATCH] http: support retry on connection error

2020-12-16 Thread Eran Kornblau
Ping... -Original Message- From: Eran Kornblau Sent: Thursday, December 10, 2020 8:25 AM To: FFmpeg development discussions and patches Subject: RE: [FFmpeg-devel] [PATCH] http: support retry on connection error Resending... -Original Message- From: Eran Kornblau Sent

[FFmpeg-devel] FW: [PATCH] http: support retry on connection error

2020-12-23 Thread Eran Kornblau
Pinging again... hope this can be merged... -Original Message- From: Eran Kornblau Sent: Wednesday, December 16, 2020 9:18 PM To: FFmpeg development discussions and patches Subject: FW: [FFmpeg-devel] [PATCH] http: support retry on connection error Ping... -Original Message

[FFmpeg-devel] FW: [PATCH] http: support retry on connection error

2020-12-30 Thread Eran Kornblau
It's been 2 months since I submitted this patch (25/10), got a single reply to which I answered below... Can this be merged? Thanks, Eran -Original Message- From: Eran Kornblau Sent: Wednesday, December 23, 2020 8:14 PM To: FFmpeg development discussions and patches Subjec

[FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-11-24 Thread Eran Kornblau
Hi all, We're thinking about adding support for MP4 files encrypted using the CENC scheme to ffmpeg (such as the ones supported by GPAC - https://gpac.wp.mines-telecom.fr/mp4box/encryption/common-encryption/) The motivation is to be able to transcode files without having the media ever resident

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-04 Thread Eran Kornblau
vember 25, 2015 1:56 AM To: FFmpeg development discussions and patches Cc: Eran Kornblau ; Eran Etam Subject: Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files On Tue, 24 Nov 2015 12:10:43 + Eran Kornblau wrote: > Before we start working on this feature, since we really

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-04 Thread Eran Kornblau
> Hi, > > Please do not top post. > Sorry, I hope this one comes out fine, didn't find a reasonable way to do it with Outlook ;-( > > Please send the patches to the mailing list. See > https://github.com/FFmpeg/FFmpeg/pull/153 > Attached, note there are two files, the second commit is just a tiny

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-05 Thread Eran Kornblau
Hi > No, please merge them (without adding trailing whitespace, it cannot > be committed to our repository). > While at it, please fix this nit (several times): > > +} > > +else { > > should be on one line, there is tools/patcheck that should have told > you (and also tells you about tr

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-06 Thread Eran Kornblau
Hi > One more question: Is FFmpeg able to decrypt the files (if the keys are > available)? If not, it would be nice if you could also add the decryption > function... > (I only realize now that the subject promises both.) > In any case, a fate test will be needed (but is not necessarily part of

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-06 Thread Eran Kornblau
Hi, Sorry for spamming, ran some more tests and found a bug in my patch, updated patch file attached. The bug was that in case subsample encryption was enabled (the default for AVC) the subsample size reported in the 'saiz' atom was wrong - it did not include the size of the IV. I originally tes

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-07 Thread Eran Kornblau
> > changes to libavutil and libavformat should likely be in seperate > patches/commits, more generally any independant changes should be > in seperate patches (i dont know if there are any other changes that > should be split off) > Done, new patch files attached, I also included the patch for d

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-14 Thread Eran Kornblau
Hi, Bumping up this thread... please let me if you want me to make any additional changes or this can be merged. Attaching the patch files again (same ones I sent in my last post) Thank you Eran 0001-libavutil-add-aes-ctr-support.patch Description: 0001-libavutil-add-aes-ctr-support.patch 0

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-15 Thread Eran Kornblau
> > using a random IV value would break any regression tests > see AVFMT_FLAG_BITEXACT > Fixed, only generating a random IV when bitexact is not enabled. Updated patch files attached. > > is this filling in a random IV that later is overridden ? > random_seed() can be slow so it would be better

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-15 Thread Eran Kornblau
> are these encrypted mp4 files some kind of standard encryption? > Yes, these files conform to the common encryption specification ISO/IEC 23001-7 > rephrased... will encrypted files created by ffmpeg be able to be > decrypted/decoded and played by quicktime? or any other player? > (assuming oth

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-15 Thread Eran Kornblau
> > > > +struct AVAESCTR; > > Is this needed? > Indeed compiles for me without it, I matched the existing code in aes.h, and in general I prefer to define the structs in advance. If you prefer that I will remove it, please let me know > > +subsample_count = AV_RB16(sc->cenc.auxiliary_info_

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-21 Thread Eran Kornblau
Bumping up this thread, would love to see this getting merged (attaching the same patch files) Thank you Eran 0001-libavutil-add-aes-ctr-support.patch Description: 0001-libavutil-add-aes-ctr-support.patch 0002-movenc-support-cenc-common-encryption.patch Description: 0002-movenc-support-cenc-

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-21 Thread Eran Kornblau
> > Weren't patches 1&2 already applied? > http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=23ac99dc > http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=4469e8eb > You're right, didn't know that. Please let me know if there are any changes you want me to apply in order to push the third o

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-21 Thread Eran Kornblau
r 'enca' please let me know which one you prefer, and I will update the patch. > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > Thanks a lot, Michael ! Eran 0001-add-Eran-Kornblau-to-maintainers.patch Description: 0001-add-

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-22 Thread Eran Kornblau
> you are not subscribed (with this email address you used here at least > it seems) > Right, apparently the subscription confirmation message went to the junk folder... Anyway, glad this one is now resolved :-) and sorry for the trouble. > > > > > > > +id = mov_codec_id(st, format); > > > >

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-27 Thread Eran Kornblau
Bumping up this thread (latest patch attached) Happy holidays ! Eran 0001-mov-support-cenc-common-encryption.patch Description: 0001-mov-support-cenc-common-encryption.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mail

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-28 Thread Eran Kornblau
> > +case MKTAG('e','n','c','v'):// encrypted video > > +case MKTAG('e','n','c','a'):// encrypted audio > > +id = mov_codec_id(st, format); > > +st->codec->codec_id = id; > > this seems missing a check for st->codec->codec_id being "unset" > before setting i

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-29 Thread Eran Kornblau
> > > > +case MKTAG('e','n','c','v'):// encrypted video > > > > +case MKTAG('e','n','c','a'):// encrypted audio > > > > +id = mov_codec_id(st, format); > > > > +st->codec->codec_id = id; > > > > > > this seems missing a check for st->codec->codec_id being "u

Re: [FFmpeg-devel] support for reading / writing encrypted MP4 files

2015-12-30 Thread Eran Kornblau
> > Please let me know if you think that is ok, and I will resubmit the patch > > with all fixes. > > should be ok > Updated patch attached, diff from previous patch is: --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4026,6 +4026,14 @@ static int mov_read_frma(MOVContext *c, AVIOContext *p

Re: [FFmpeg-devel] frma warnings in mov demuxer

2016-02-04 Thread Eran Kornblau
> after having updated our application to latest head, we get tons of > annoying warnings like this one: > > [mov,mp4,m4a,3gp,3g2,mj2 @ 0x102007800] ignoring 'frma' atom of 'mp4a', > stream format is 'mp4a' > Patch attached - it simply doesn't print the warning when the format contained in the

[FFmpeg-devel] qt-faststart bug near 4GB

2018-05-25 Thread Eran Kornblau
Hi all, We encountered a rather extreme edge case with qt-faststart - we transcoded some video with ffmpeg, and the offset of the last video frame in the resulting mp4 was slightly less than 4GB. Since it was less than 4GB, ffmpeg used an 'stco' atom and not a 'co64' atom. When we ran qt-faststa

[FFmpeg-devel] [PATCH 1/2] qt-faststart - stricter input validations

2018-05-29 Thread Eran Kornblau
Hi, The attached patch fixes a couple of input validation issues in fast start that I noticed while going over the code Thanks Eran 0001-qt-faststart-stricter-input-validations.patch Description: 0001-qt-faststart-stricter-input-validations.patch __

[FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the offset change loop

2018-05-29 Thread Eran Kornblau
Hi, The attached is a slightly more optimized (and IMHO elegant) code for updating the stco/co64 offsets Thanks Eran 0002-qt-faststart-optimize-the-offset-change-loop.patch Description: 0002-qt-faststart-optimize-the-offset-change-loop.patch ___ ffm

Re: [FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the offset change loop

2018-05-29 Thread Eran Kornblau
> > > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Wednesday, May 30, 2018 12:37 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the offse

Re: [FFmpeg-devel] [PATCH 2/2] qt-faststart - optimize the offset change loop

2018-05-31 Thread Eran Kornblau
> On Wed, May 30, 2018 at 05:39:50AM +0000, Eran Kornblau wrote: > > > > > > > > > -Original Message- > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > > > Behalf Of Michael Niedermayer > > > Sent: Wedn

Re: [FFmpeg-devel] qt-faststart bug near 4GB

2018-05-31 Thread Eran Kornblau
> > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Eran > Kornblau > Sent: Friday, May 25, 2018 4:40 PM > To: FFmpeg development discussions and patches > Subject: [FFmpeg-devel] qt-faststart bug near 4GB > > Hi

Re: [FFmpeg-devel] qt-faststart bug near 4GB

2018-06-01 Thread Eran Kornblau
> On Thu, May 31, 2018 at 10:11:38AM +0000, Eran Kornblau wrote: > > > > > > -Original Message- > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > > > Behalf Of Eran Kornblau > > > Sent: Friday, May 25, 2018 4:40 PM >

Re: [FFmpeg-devel] qt-faststart bug near 4GB

2018-06-08 Thread Eran Kornblau
Ping -Original Message- From: Eran Kornblau Sent: Friday, June 1, 2018 10:00 AM To: FFmpeg development discussions and patches Subject: RE: [FFmpeg-devel] qt-faststart bug near 4GB > On Thu, May 31, 2018 at 10:11:38AM +0000, Eran Kornblau wrote: > > > > > >

Re: [FFmpeg-devel] qt-faststart bug near 4GB

2018-06-10 Thread Eran Kornblau
> > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Saturday, June 9, 2018 9:17 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] qt-faststart bug near 4GB > > > + > > +if

Re: [FFmpeg-devel] qt-faststart bug near 4GB

2018-06-11 Thread Eran Kornblau
> On Sun, Jun 10, 2018 at 01:20:10PM +0000, Eran Kornblau wrote: > > > > > > -Original Message- > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On > > > Behalf Of Michael Niedermayer > > > Sent: Saturday, June 9, 2018 9:17

Re: [FFmpeg-devel] qt-faststart bug near 4GB

2018-06-13 Thread Eran Kornblau
> > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Wednesday, June 13, 2018 1:41 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] qt-faststart bug near 4GB > > > this is not ma

Re: [FFmpeg-devel] qt-faststart bug near 4GB

2018-06-13 Thread Eran Kornblau
> > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Wednesday, June 13, 2018 12:26 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] qt-faststart bug near 4GB > > fails on mingw64

[FFmpeg-devel] [PATCH] qt-faststart - print errors to stderr

2018-06-14 Thread Eran Kornblau
This patch makes qt-faststart output errors to stderr instead of stdout, following a discussion with Michael on another thread... Thanks! Eran 0001-qt-faststart-print-errors-to-stderr.patch Description: 0001-qt-faststart-print-errors-to-stderr.patch

Re: [FFmpeg-devel] frama-c:ify qt-faststart.c, proof-of-concept (kinda)

2018-06-22 Thread Eran Kornblau
> Hi > > I've recently been looking at formal proof systems for minimizing bugs. > One common example is SPARK, which is an Ada variant which uses contracts, > guaranteed termination and lack of dynamic allocation to make reasoning about > SPARK programs much easier. This allows automatic checki

Re: [FFmpeg-devel] frama-c:ify qt-faststart.c, proof-of-concept (kinda)

2018-06-22 Thread Eran Kornblau
-concept > (kinda) > > > fre 2018-06-22 klockan 14:07 + skrev Eran Kornblau: > > First, regarding the if you added, it's redundant - if you look a few lines > > above, you'll see 'if (atom.size < atom.header_size)'. > > atom.header_size is eithe

[FFmpeg-devel] ccaption_dec: add support for multiple channels

2021-08-21 Thread Eran Kornblau
Hi all, I noticed today that the cc decoder doesn’t support multiple channels – I have some MPEG-TS file with 3 cc languages, when I request ‘-data_field 0’, I’m getting the first two together, while ‘-data_field 1’ returns the third one. This patch adds another optional param ‘channel’ that can