Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality and clamp initial qp value to [1, 51]

2015-12-14 Thread Timo Rothenpieler
> No, it won't affect performance, we did lots of internal tests, mainly > focused on quality improvement. But if it makes performance worse we > won't apply it anyway. Split and applied, thanks. > Agatha Hu > > ___ > ffmpeg-devel mailing list >

Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality and clamp initial qp value to [1, 51]

2015-12-13 Thread Agatha Hu
On 2015/12/11 17:20, Timo Rothenpieler wrote: * PGP Signed by an unknown key Hi all, before switching to the new released nvenc6.0 header, can you take a look at this fix? I'm fine with making it the default, the only concern i have is weather it has any side-effects, like reduced

Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality and clamp initial qp value to [1, 51]

2015-12-11 Thread Timo Rothenpieler
> Hi all, before switching to the new released nvenc6.0 header, can you > take a look at this fix? I'm fine with making it the default, the only concern i have is weather it has any side-effects, like reduced performance that impacts some higher resolutions which can't be encoded in realtime

[FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality and clamp initial qp value to [1, 51]

2015-12-10 Thread Agatha Hu
--- libavcodec/nvenc.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..6365434 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,17 @@ static av_cold int

[FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality and clamp initial qp value to [1, 51]

2015-12-10 Thread Agatha Hu
--- libavcodec/nvenc.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..6365434 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,17 @@ static av_cold int

Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality and clamp initial qp value to [1, 51]

2015-12-10 Thread Agatha Hu
On 2015/12/11 11:10, Agatha Hu wrote: --- libavcodec/nvenc.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..6365434 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,17 @@

[FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-06 Thread Agatha Hu
--- libavcodec/nvenc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..f0e5a19 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,17 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx)

Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-06 Thread Nicolas George
Le septidi 17 frimaire, an CCXXIV, Agatha Hu a écrit : > +switch (avctx->codec->id) { > +case AV_CODEC_ID_H264: > +ctx->encode_config.encodeCodecConfig.h264Config.sliceMode = 3; > +ctx->encode_config.encodeCodecConfig.h264Config.sliceModeData = 1; Should this be an option?

Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-06 Thread Agatha Hu
在 2015/12/5 3:26, Timo Rothenpieler 写道: --- libavcodec/nvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..b8f7f91 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,9 @@ static av_cold int

Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-06 Thread Agatha Hu
在 2015/12/5 3:26, Timo Rothenpieler 写道: --- libavcodec/nvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..b8f7f91 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,9 @@ static av_cold int

[FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-06 Thread Agatha Hu
--- libavcodec/nvenc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..f0e5a19 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,17 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx)

Re: [FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-04 Thread Timo Rothenpieler
> --- libavcodec/nvenc.c | 3 +++ 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index > 43b8e78..b8f7f91 100644 --- a/libavcodec/nvenc.c +++ > b/libavcodec/nvenc.c @@ -762,6 +762,9 @@ static av_cold int > nvenc_encode_init(AVCodecContext *avctx) } } > >

[FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-03 Thread Agatha Hu
--- libavcodec/nvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..b8f7f91 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,9 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx) }

[FFmpeg-devel] [PATCH] nvenc set slice number to 1 to improve encoding quality

2015-12-03 Thread Agatha Hu
--- libavcodec/nvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 43b8e78..b8f7f91 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -762,6 +762,9 @@ static av_cold int nvenc_encode_init(AVCodecContext *avctx) } }