Re: [FFmpeg-devel] [PATCH 2/3] libx265: Return proper invalid data code

2015-03-03 Thread Clément Bœsch
On Tue, Mar 03, 2015 at 04:26:46PM +0100, Alexander Strasser wrote: > On 2015-02-17 22:15 +, Derek Buitenhuis wrote: > > On 2/17/2015 10:10 PM, James Almer wrote: > > > Afaik, if the error is based on user input then EINVAL (Invalid argument) > > > is correct. > > > AVERROR_INVALIDDATA is when

Re: [FFmpeg-devel] [PATCH 2/3] libx265: Return proper invalid data code

2015-03-03 Thread Alexander Strasser
On 2015-02-17 22:15 +, Derek Buitenhuis wrote: > On 2/17/2015 10:10 PM, James Almer wrote: > > Afaik, if the error is based on user input then EINVAL (Invalid argument) > > is correct. > > AVERROR_INVALIDDATA is when the error is in the bitstream/container and not > > an argument the > > use

Re: [FFmpeg-devel] [PATCH 2/3] libx265: Return proper invalid data code

2015-02-17 Thread Derek Buitenhuis
On 2/17/2015 10:10 PM, James Almer wrote: > Afaik, if the error is based on user input then EINVAL (Invalid argument) is > correct. > AVERROR_INVALIDDATA is when the error is in the bitstream/container and not > an argument the > user passed to the library. Right, I conflated the two. Patch dr

Re: [FFmpeg-devel] [PATCH 2/3] libx265: Return proper invalid data code

2015-02-17 Thread James Almer
On 17/02/15 7:02 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libx265.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > index 9f40e95..c35f6c2 100644 > --- a/libavcodec/libx265.c > +++ b/li

[FFmpeg-devel] [PATCH 2/3] libx265: Return proper invalid data code

2015-02-17 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- libavcodec/libx265.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 9f40e95..c35f6c2 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -99,7 +99,7 @@ static av_cold int libx265