Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

2017-12-18 Thread Sasi Inguva
i was on vacation so I missed this. sorry for the trouble and thanks for fixing the test. This test was fixed once before http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=4ccc1ef2a3b1a22d849861423df830e110c9a4ab . I've no idea why only this test needs to have the "-flags +bitexact -idct simple

Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

2017-12-05 Thread Derek Buitenhuis
On 12/6/2017 12:12 AM, Michael Niedermayer wrote: > The test produces different output on qemu arm and x86-64. > From this we know there is a bug, but not where the bug is. > It can be in the test, the newly added code tested or code that was > there before. > > My guess was, its the test, i canno

Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

2017-12-05 Thread Michael Niedermayer
On Tue, Dec 05, 2017 at 08:17:14PM +, Derek Buitenhuis wrote: > >> The commit that broke it should be reverted until the author > >> of that commit can explain why it changed, or fix it. > > > > The commit that added the test was the one that broke fate. It never > > worked. > > So this "sort

Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

2017-12-05 Thread Derek Buitenhuis
>> The commit that broke it should be reverted until the author >> of that commit can explain why it changed, or fix it. > > The commit that added the test was the one that broke fate. It never > worked. > So this "sort of" reverts what caused the issue. Wasn't the code it tests added directly be

Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

2017-12-05 Thread Michael Niedermayer
On Tue, Dec 05, 2017 at 01:54:27PM +, Derek Buitenhuis wrote: > On 12/5/2017 12:38 AM, Michael Niedermayer wrote: > > Noone is known to work on fixing this, so it should be disabled > > > > Signed-off-by: Michael Niedermayer > > --- > > tests/fate/mov.mak | 1 - > > 1 file changed, 1 deletio

Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

2017-12-05 Thread Derek Buitenhuis
On 12/5/2017 12:38 AM, Michael Niedermayer wrote: > Noone is known to work on fixing this, so it should be disabled > > Signed-off-by: Michael Niedermayer > --- > tests/fate/mov.mak | 1 - > 1 file changed, 1 deletion(-) *NAK* Disabling failing tests entirely defeats the point of having test!

Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

2017-12-05 Thread Tobias Rapp
On 05.12.2017 01:38, Michael Niedermayer wrote: Noone is known to work on fixing this, so it should be disabled Signed-off-by: Michael Niedermayer --- tests/fate/mov.mak | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak index 680baea773..869784fd31 10