Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

> > +enabled coreimage_filter && { check_header_objcc QuartzCore/CoreImage.h > || disable coreimage_filter; } > +enabled coreimagesrc_filter && { check_header_objcc > QuartzCore/CoreImage.h || disable coreimagesrc_filter; } > Wouldnt it be simpler to just add an item to HEADERS_LIST for

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 22.03.16 um 11:44 schrieb Thilo Borgmann: > Am 19.03.16 um 18:26 schrieb Michael Niedermayer: >> On Sat, Mar 19, 2016 at 04:31:56PM +0100, Thilo Borgmann wrote: >>> All comments addressed, >> >>> linux compilation fixed. >> >> confirmed, thx > > If there are no more comments I'll apply soon.

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

2016-03-22 19:44 GMT+09:00 Thilo Borgmann : > Am 19.03.16 um 18:26 schrieb Michael Niedermayer: > > If there are no more comments I'll apply soon. i am looking forward to your work. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 19.03.16 um 18:26 schrieb Michael Niedermayer: > On Sat, Mar 19, 2016 at 04:31:56PM +0100, Thilo Borgmann wrote: >> All comments addressed, > >> linux compilation fixed. > > confirmed, thx If there are no more comments I'll apply soon. -Thilo ___

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 16.03.16 um 22:24 schrieb Thilo Borgmann: > Am 16.03.16 um 21:10 schrieb Moritz Barsnick: >> [...] > > All addressed in newest patch, thanks! Any more comments from anyone? @Clement: Do you like it better this way? -Thilo ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Wed, Mar 16, 2016 at 10:24:09PM +0100, Thilo Borgmann wrote: [...] Not sure if I'm commenting on the last version... > From b6b889c06edc7872f0a31fd0482793a199ddd28e Mon Sep 17 00:00:00 2001 > From: Thilo Borgmann > Date: Wed, 16 Mar 2016 22:18:20 +0100 > Subject:

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 16.03.16 um 14:44 schrieb Thilo Borgmann: > Am 16.03.16 um 14:43 schrieb Thilo Borgmann: >> Am 12.03.16 um 15:14 schrieb Thilo Borgmann: >>> Add coreimage filter for OSX. >> >> Included all comments so far. >> Also features a "coreimagesrc" video source like suggested by Nicolas. > > Actually

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

2016-03-20 0:31 GMT+09:00 Thilo Borgmann : > All comments addressed, linux compilation fixed. > fixed. can build. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 12.03.16 um 15:14 schrieb Thilo Borgmann: > Add coreimage filter for OSX. Included all comments so far. Also features a "coreimagesrc" video source like suggested by Nicolas. Updated patch attached, please comment. -Thilo From b269b36cf2c5da15e54c11176aaa71361d0f4520 Mon Sep 17 00:00:00

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 16.03.16 um 21:10 schrieb Moritz Barsnick: > [...] All addressed in newest patch, thanks! > - You have a variable by the same name as a function (list_filters), > but Objective C may not mind. (Does ffmpeg coding style mind?) I've done it in the OSX/iOS devices as well and nobody

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Wed, Mar 16, 2016 at 10:24:09PM +0100, Thilo Borgmann wrote: > Am 16.03.16 um 21:10 schrieb Moritz Barsnick: > > [...] > > All addressed in newest patch, thanks! > > > - You have a variable by the same name as a function (list_filters), > > but Objective C may not mind. (Does ffmpeg coding

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Sat, Mar 19, 2016 at 04:31:56PM +0100, Thilo Borgmann wrote: > All comments addressed, > linux compilation fixed. confirmed, thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

build error under osx1095 and clang37 HTMLdoc/libavutil.html HTMLdoc/libswscale.html doc/filters.texi:13909: misplaced { doc/filters.texi:13909: misplaced } doc/filters.texi:5028: @ref reference to nonexistent node `coreimagesrc' make: *** [doc/ffplay-all.html] Error 1 make: *** Waiting

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Wed, Mar 16, 2016 at 14:43:23 +0100, Thilo Borgmann wrote: > +by a list of space separated float values. Character escaping has to be done. > +A special option name @code{default} is available to use default options for > a > +filter. > +It is required to specify either @code{default} or at

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Mon, Mar 14, 2016 at 19:37:33 +0100, Thilo Borgmann wrote: > > So > > if (x) > > SafeCFRelease(a); > > else > > SafeCFRelease(b); > > > > can work. > > At least the clang preprocessor keeps the outer {} so that this should work. > I'm not arguing - if experience says compilers

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 14.03.16 um 16:31 schrieb Clément Bœsch: > On Mon, Mar 14, 2016 at 03:38:52PM +0100, Thilo Borgmann wrote: >> Am 14.03.16 um 13:56 schrieb Clément Bœsch: >>> On Mon, Mar 14, 2016 at 01:46:52PM +0100, Thilo Borgmann wrote: Am 14.03.16 um 11:22 schrieb Clément Bœsch: > [...] >>

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 14.03.16 um 13:56 schrieb Clément Bœsch: > On Mon, Mar 14, 2016 at 01:46:52PM +0100, Thilo Borgmann wrote: >> Am 14.03.16 um 11:22 schrieb Clément Bœsch: >>> [...] +./ffmpeg -f lavfi -i

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Mon, Mar 14, 2016 at 01:46:52PM +0100, Thilo Borgmann wrote: > Am 14.03.16 um 11:22 schrieb Clément Bœsch: > > [...] > >> +./ffmpeg -f lavfi -i > >> nullsrc=s=100x100,coreimage=filter=CIQRCodeGenerator@@inputMessage=https\://FFmpeg.org/@@inputCorrectionLevel=H > >> -frames:v 1 QRCode.png

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 14.03.16 um 11:22 schrieb Clément Bœsch: > [...] >> +./ffmpeg -f lavfi -i >> nullsrc=s=100x100,coreimage=filter=CIQRCodeGenerator@@inputMessage=https\://FFmpeg.org/@@inputCorrectionLevel=H >> -frames:v 1 QRCode.png > > remove ./ > > also, it's probably better to have 2 filters: one for

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Mon, 14 Mar 2016 11:23:16 +0100 Clément Bœsch wrote: > On Mon, Mar 14, 2016 at 10:19:59AM +0100, Thilo Borgmann wrote: > > Am 13.03.16 um 22:01 schrieb Clément Bœsch: > > > On Sun, Mar 13, 2016 at 09:09:39PM +0100, Thilo Borgmann wrote: > > >> Am 13.03.16 um 20:55 schrieb

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 14.03.16 um 11:23 schrieb Clément Bœsch: > On Mon, Mar 14, 2016 at 10:19:59AM +0100, Thilo Borgmann wrote: >> Am 13.03.16 um 22:01 schrieb Clément Bœsch: >>> On Sun, Mar 13, 2016 at 09:09:39PM +0100, Thilo Borgmann wrote: Am 13.03.16 um 20:55 schrieb Nicolas George: > Le quartidi 24

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Mon, Mar 14, 2016 at 10:19:59AM +0100, Thilo Borgmann wrote: > Am 13.03.16 um 22:01 schrieb Clément Bœsch: > > On Sun, Mar 13, 2016 at 09:09:39PM +0100, Thilo Borgmann wrote: > >> Am 13.03.16 um 20:55 schrieb Nicolas George: > >>> Le quartidi 24 ventôse, an CCXXIV, Thilo Borgmann a écrit : >

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Sun, Mar 13, 2016 at 09:09:39PM +0100, Thilo Borgmann wrote: > Am 13.03.16 um 20:55 schrieb Nicolas George: > > Le quartidi 24 ventôse, an CCXXIV, Thilo Borgmann a écrit : > >> +{ "list_filters", "list available filters", OFFSET(list_filters), > >> AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1,

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 13.03.16 um 22:01 schrieb Clément Bœsch: > On Sun, Mar 13, 2016 at 09:09:39PM +0100, Thilo Borgmann wrote: >> Am 13.03.16 um 20:55 schrieb Nicolas George: >>> Le quartidi 24 ventôse, an CCXXIV, Thilo Borgmann a écrit : +{ "list_filters", "list available filters", OFFSET(list_filters),

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Sun, Mar 13, 2016 at 09:09:39PM +0100, Thilo Borgmann wrote: > Am 13.03.16 um 20:55 schrieb Nicolas George: > > Le quartidi 24 ventôse, an CCXXIV, Thilo Borgmann a écrit : > >> +{ "list_filters", "list available filters", OFFSET(list_filters), > >> AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1,

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 13.03.16 um 20:55 schrieb Nicolas George: > Le quartidi 24 ventôse, an CCXXIV, Thilo Borgmann a écrit : >> +{ "list_filters", "list available filters", OFFSET(list_filters), >> AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, .flags = FLAGS, "list_filters" }, >> +{ "true", "", 0,

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Le quartidi 24 ventôse, an CCXXIV, Thilo Borgmann a écrit : > +{ "list_filters", "list available filters", OFFSET(list_filters), > AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, .flags = FLAGS, "list_filters" }, > +{ "true", "", 0, AV_OPT_TYPE_CONST, {.i64=1}, 0, 0, FLAGS, > "list_filters" }, >

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 12.03.16 um 15:14 schrieb Thilo Borgmann: > Add coreimage filter for OSX. Option type set to bool (Nicolas) Proper Texinfo escaping (comments on trac ticket #4143) New patch attached. -Thilo From 32198ec9a0522f181ac8a4974b7b36de4e08596d Mon Sep 17 00:00:00 2001 From: Thilo Borgmann

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 13.03.16 um 09:41 schrieb Nicolas George: > Le quartidi 24 ventôse, an CCXXIV, Thilo Borgmann a écrit : >> +static const AVOption coreimage_options[] = { >> +{ "list_filters", "list available filters", OFFSET(list_filters), >> AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, .flags = FLAGS,

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Le quartidi 24 ventôse, an CCXXIV, Thilo Borgmann a écrit : > +static const AVOption coreimage_options[] = { > +{ "list_filters", "list available filters", OFFSET(list_filters), > AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, .flags = FLAGS, "list_filters" }, > +{ "true", "", 0,

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 12.03.16 um 15:14 schrieb Thilo Borgmann: > Add coreimage filter for OSX. Should now also work with Linux based configure. -Thilo From af0bbaebb1a04be203338fa7bf199c26a7dfa3df Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Sun, 13 Mar 2016 00:35:25 +0100 Subject:

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 13.03.16 um 00:29 schrieb James Almer: > On 3/12/2016 7:59 PM, Thilo Borgmann wrote: >> Am 12.03.16 um 23:45 schrieb James Almer: On 3/12/2016 7:09 PM, Thilo Borgmann wrote: >> Am 12.03.16 um 21:45 schrieb Michael Niedermayer: >> On Sat, Mar 12, 2016 at 03:19:11PM +0100, Thilo

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On 3/12/2016 7:59 PM, Thilo Borgmann wrote: > Am 12.03.16 um 23:45 schrieb James Almer: >> > On 3/12/2016 7:09 PM, Thilo Borgmann wrote: >>> >> Am 12.03.16 um 21:45 schrieb Michael Niedermayer: > On Sat, Mar 12, 2016 at 03:19:11PM +0100, Thilo Borgmann wrote: >>> >> Am 12.03.16 um

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 12.03.16 um 23:45 schrieb James Almer: > On 3/12/2016 7:09 PM, Thilo Borgmann wrote: >> Am 12.03.16 um 21:45 schrieb Michael Niedermayer: On Sat, Mar 12, 2016 at 03:19:11PM +0100, Thilo Borgmann wrote: >> Am 12.03.16 um 15:14 schrieb Thilo Borgmann: [...] also breaks

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On 3/12/2016 7:09 PM, Thilo Borgmann wrote: > Am 12.03.16 um 21:45 schrieb Michael Niedermayer: >> > On Sat, Mar 12, 2016 at 03:19:11PM +0100, Thilo Borgmann wrote: >>> >> Am 12.03.16 um 15:14 schrieb Thilo Borgmann: >>> Add coreimage filter for OSX. >>> >> >>> >> Corrected patch attached.

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 12.03.16 um 21:45 schrieb Michael Niedermayer: > On Sat, Mar 12, 2016 at 03:19:11PM +0100, Thilo Borgmann wrote: >> Am 12.03.16 um 15:14 schrieb Thilo Borgmann: >>> Add coreimage filter for OSX. >> >> Corrected patch attached. >> >> -Thilo >> > >> Changelog |1 >>

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

On Sat, Mar 12, 2016 at 03:19:11PM +0100, Thilo Borgmann wrote: > Am 12.03.16 um 15:14 schrieb Thilo Borgmann: > > Add coreimage filter for OSX. > > Corrected patch attached. > > -Thilo > > Changelog |1 > MAINTAINERS|1 > configure

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

Am 12.03.16 um 15:14 schrieb Thilo Borgmann: > Add coreimage filter for OSX. Corrected patch attached. -Thilo From 124fb0ce2a30c965ec28c8fbff1c04a872f33bc6 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Sat, 12 Mar 2016 15:18:04 +0100 Subject: [PATCH 2/2] lavf: Add