Re: [FFmpeg-devel] [PATCH 3/4] dict.c: Free non-strduped av_dict_set arguments on error.

2014-08-23 Thread Reimar Döffinger
On Fri, Aug 22, 2014 at 07:47:09AM +0200, Reimar Döffinger wrote: On 22.08.2014, at 07:36, Reimar Döffinger reimar.doeffin...@gmx.de wrote: On 22.08.2014, at 04:06, Michael Niedermayer michae...@gmx.at wrote: On Sat, Aug 16, 2014 at 02:43:46PM +0200, Reimar Döffinger wrote: On Wed, Aug 13,

Re: [FFmpeg-devel] [PATCH 3/4] dict.c: Free non-strduped av_dict_set arguments on error.

2014-08-21 Thread Reimar Döffinger
On 22.08.2014, at 04:06, Michael Niedermayer michae...@gmx.at wrote: On Sat, Aug 16, 2014 at 02:43:46PM +0200, Reimar Döffinger wrote: On Wed, Aug 13, 2014 at 01:57:56PM +0200, Michael Niedermayer wrote: On Mon, Aug 11, 2014 at 09:17:18PM +0200, Reimar Döffinger wrote: Unfortunately this was

Re: [FFmpeg-devel] [PATCH 3/4] dict.c: Free non-strduped av_dict_set arguments on error.

2014-08-16 Thread Reimar Döffinger
On Mon, Aug 11, 2014 at 10:11:59PM +0200, wm4 wrote: On Mon, 11 Aug 2014 21:17:18 +0200 Reimar Döffinger reimar.doeffin...@gmx.de wrote: Unfortunately this was not explicitly documented and thus might be very risky. But basically all uses I saw in FFmpeg had a memleak in these cases.

Re: [FFmpeg-devel] [PATCH 3/4] dict.c: Free non-strduped av_dict_set arguments on error.

2014-08-13 Thread Michael Niedermayer
On Mon, Aug 11, 2014 at 09:17:18PM +0200, Reimar Döffinger wrote: Unfortunately this was not explicitly documented and thus might be very risky. yes maybe a AV_DICT_FREE_ARGS_ON_ERROR could be used, but its not as convenient as getting the behavior by default [...] -- Michael GnuPG