Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Kieran Kunhya
> > > Lets check H264 > claim "They do not have a timestamp" > immedeatly after the pic_struct field which tells you about the repeating > behavior there is a loop for each repeated value with a timestamp. > This timestamp is lost, if at CFR one can call it that way. > > about "Every encoded frame

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Kieran Kunhya
> > "time of origin, capture" is clearly a timecode, not a timestamp in > the sense we're talking about here (plus that the bitstream codes it > in hours/minutes/seconds). I expect you know the difference. > If these timecodes are considered useful it would be trivial to expose > them from the

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Hendrik Leppkes
On Mon, Aug 26, 2019 at 9:38 PM Michael Niedermayer wrote: > > On Mon, Aug 26, 2019 at 01:45:55PM +0200, Hendrik Leppkes wrote: > > On Mon, Aug 26, 2019 at 11:09 AM Michael Niedermayer > > wrote: > > > > > > On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote: > > > > On Mon, Aug 26,

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Michael Niedermayer
On Mon, Aug 26, 2019 at 01:45:55PM +0200, Hendrik Leppkes wrote: > On Mon, Aug 26, 2019 at 11:09 AM Michael Niedermayer > wrote: > > > > On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote: > > > On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer > > > wrote: > > > > > > > > On Sun,

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Baptiste Coudurier
> On Aug 26, 2019, at 11:23 AM, Hendrik Leppkes wrote: > > On Mon, Aug 26, 2019 at 7:47 PM Baptiste Coudurier > mailto:baptiste.coudur...@gmail.com>> wrote: >> >> Hey guys, >> >> >>> On Aug 26, 2019, at 9:25 AM, James Almer wrote: >>> >>> On 8/26/2019 11:35 AM, Hendrik Leppkes wrote:

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Hendrik Leppkes
On Mon, Aug 26, 2019 at 7:47 PM Baptiste Coudurier wrote: > > Hey guys, > > > > On Aug 26, 2019, at 9:25 AM, James Almer wrote: > > > > On 8/26/2019 11:35 AM, Hendrik Leppkes wrote: > >> On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote: > >>> > >>> On 8/25/2019 7:14 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Paul B Mahol
On Mon, Aug 26, 2019 at 7:47 PM Baptiste Coudurier < baptiste.coudur...@gmail.com> wrote: > Hey guys, > > > > On Aug 26, 2019, at 9:25 AM, James Almer wrote: > > > > On 8/26/2019 11:35 AM, Hendrik Leppkes wrote: > >> On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote: > >>> > >>> On 8/25/2019

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Baptiste Coudurier
Hey guys, > On Aug 26, 2019, at 9:25 AM, James Almer wrote: > > On 8/26/2019 11:35 AM, Hendrik Leppkes wrote: >> On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote: >>> >>> On 8/25/2019 7:14 PM, Michael Niedermayer wrote: On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread James Almer
On 8/26/2019 11:35 AM, Hendrik Leppkes wrote: > On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote: >> >> On 8/25/2019 7:14 PM, Michael Niedermayer wrote: >>> On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote: On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote:

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Hendrik Leppkes
On Mon, Aug 26, 2019 at 1:18 AM James Almer wrote: > > On 8/25/2019 7:14 PM, Michael Niedermayer wrote: > > On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote: > >> On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: > >>> On 8/24/2019 3:18 PM, Michael Niedermayer wrote:

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread James Almer
On 8/26/2019 4:32 AM, Michael Niedermayer wrote: > On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote: >> On 8/25/2019 6:46 PM, Michael Niedermayer wrote: >>> On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: On 8/24/2019 3:18 PM, Michael Niedermayer wrote: > Fixes:

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Hendrik Leppkes
On Mon, Aug 26, 2019 at 11:09 AM Michael Niedermayer wrote: > > On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote: > > On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer > > wrote: > > > > > > On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote: > > > > On 8/25/2019 6:46

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Paul B Mahol
On Mon, Aug 26, 2019 at 11:09 AM Michael Niedermayer wrote: > On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote: > > On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer > > wrote: > > > > > > On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote: > > > > On 8/25/2019 6:46

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Michael Niedermayer
On Mon, Aug 26, 2019 at 09:51:45AM +0200, Hendrik Leppkes wrote: > On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer > wrote: > > > > On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote: > > > On 8/25/2019 6:46 PM, Michael Niedermayer wrote: > > > > On Sun, Aug 25, 2019 at 01:22:22PM

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Paul B Mahol
On Mon, Aug 26, 2019 at 9:51 AM Paul B Mahol wrote: > > > On Mon, Aug 26, 2019 at 9:37 AM Michael Niedermayer > wrote: > >> On Sun, Aug 25, 2019 at 11:43:42PM -0300, James Almer wrote: >> > On 8/25/2019 8:18 PM, James Almer wrote: >> > > On 8/25/2019 7:14 PM, Michael Niedermayer wrote: >> > >>

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Paul B Mahol
On Mon, Aug 26, 2019 at 9:37 AM Michael Niedermayer wrote: > On Sun, Aug 25, 2019 at 11:43:42PM -0300, James Almer wrote: > > On 8/25/2019 8:18 PM, James Almer wrote: > > > On 8/25/2019 7:14 PM, Michael Niedermayer wrote: > > >> On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Hendrik Leppkes
On Mon, Aug 26, 2019 at 9:33 AM Michael Niedermayer wrote: > > On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote: > > On 8/25/2019 6:46 PM, Michael Niedermayer wrote: > > > On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: > > >> On 8/24/2019 3:18 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote: > On 8/25/2019 6:46 PM, Michael Niedermayer wrote: > > On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: > >> On 8/24/2019 3:18 PM, Michael Niedermayer wrote: [...] > > if every filter following needs to process frames twice

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 11:43:42PM -0300, James Almer wrote: > On 8/25/2019 8:18 PM, James Almer wrote: > > On 8/25/2019 7:14 PM, Michael Niedermayer wrote: > >> On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote: > >>> On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote:

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 08:04:03PM -0300, James Almer wrote: > On 8/25/2019 6:46 PM, Michael Niedermayer wrote: > > On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: > >> On 8/24/2019 3:18 PM, Michael Niedermayer wrote: > >>> Fixes: Ticket7880 > >>> > >>> Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 11:37:02PM -0300, James Almer wrote: > On 8/24/2019 3:18 PM, Michael Niedermayer wrote: > > Fixes: Ticket7880 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/qtrle.c| 30 ++ > > tests/ref/fate/qtrle-8bit | 1 + > > 2

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-25 Thread James Almer
On 8/25/2019 8:18 PM, James Almer wrote: > On 8/25/2019 7:14 PM, Michael Niedermayer wrote: >> On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote: >>> On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: On 8/24/2019 3:18 PM, Michael Niedermayer wrote: > Fixes:

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-25 Thread James Almer
On 8/24/2019 3:18 PM, Michael Niedermayer wrote: > Fixes: Ticket7880 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/qtrle.c| 30 ++ > tests/ref/fate/qtrle-8bit | 1 + > 2 files changed, 27 insertions(+), 4 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-25 Thread James Almer
On 8/25/2019 7:14 PM, Michael Niedermayer wrote: > On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote: >> On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: >>> On 8/24/2019 3:18 PM, Michael Niedermayer wrote: Fixes: Ticket7880 Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-25 Thread James Almer
On 8/25/2019 6:46 PM, Michael Niedermayer wrote: > On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: >> On 8/24/2019 3:18 PM, Michael Niedermayer wrote: >>> Fixes: Ticket7880 >>> >>> Signed-off-by: Michael Niedermayer >>> --- >>> libavcodec/qtrle.c| 30

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-25 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 11:46:36PM +0200, Michael Niedermayer wrote: > On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: > > On 8/24/2019 3:18 PM, Michael Niedermayer wrote: > > > Fixes: Ticket7880 > > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/qtrle.c

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-25 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 01:22:22PM -0300, James Almer wrote: > On 8/24/2019 3:18 PM, Michael Niedermayer wrote: > > Fixes: Ticket7880 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/qtrle.c| 30 ++ > > tests/ref/fate/qtrle-8bit | 1 + > > 2

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-25 Thread James Almer
On 8/24/2019 3:18 PM, Michael Niedermayer wrote: > Fixes: Ticket7880 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/qtrle.c| 30 ++ > tests/ref/fate/qtrle-8bit | 1 + > 2 files changed, 27 insertions(+), 4 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-25 Thread Paul B Mahol
Very ugly non-solution. NAK. On Sat, Aug 24, 2019 at 8:27 PM Michael Niedermayer wrote: > Fixes: Ticket7880 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/qtrle.c| 30 ++ > tests/ref/fate/qtrle-8bit | 1 + > 2 files changed, 27 insertions(+), 4