Re: [FFmpeg-devel] [PATCHv3] avfilter/vf_chromakey: Add chromakey video filter

2015-09-22 Thread Paul B Mahol
On 9/21/15, Timo Rothenpieler wrote: >> Benefit would be to save 2 branching and 2 div (the div can already be >> replaced by a shift here though - which would have a benefit since x & y >> are signed) and keep the code generic. > > Changed it to a shift and moved the if()

Re: [FFmpeg-devel] [PATCHv3] avfilter/vf_chromakey: Add chromakey video filter

2015-09-22 Thread Timo Rothenpieler
still lgtm If nobody objects, i'll push later today. Timo signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCHv3] avfilter/vf_chromakey: Add chromakey video filter

2015-09-21 Thread Timo Rothenpieler
>> +if (frame->format == AV_PIX_FMT_YUVA420P || frame->format == >> AV_PIX_FMT_YUVA422P) >> +x /= 2; >> + >> +if (frame->format == AV_PIX_FMT_YUVA420P) >> +y /= 2; > > Why not use the usual subsampling mechanism? (using vsub/hsub etc) That seemed more complex to me, as

Re: [FFmpeg-devel] [PATCHv3] avfilter/vf_chromakey: Add chromakey video filter

2015-09-21 Thread Clément Bœsch
On Mon, Sep 21, 2015 at 03:51:37PM +0200, Timo Rothenpieler wrote: > >> +if (frame->format == AV_PIX_FMT_YUVA420P || frame->format == > >> AV_PIX_FMT_YUVA422P) > >> +x /= 2; > >> + > >> +if (frame->format == AV_PIX_FMT_YUVA420P) > >> +y /= 2; > > > > Why not use the usual

Re: [FFmpeg-devel] [PATCHv3] avfilter/vf_chromakey: Add chromakey video filter

2015-09-20 Thread Clément Bœsch
On Fri, Sep 18, 2015 at 04:27:54PM +0200, Timo Rothenpieler wrote: > --- > Changelog | 1 + > MAINTAINERS| 1 + > doc/filters.texi | 45 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/version.h

Re: [FFmpeg-devel] [PATCHv3] avfilter/vf_chromakey: Add chromakey video filter

2015-09-19 Thread Lou Logan
Hi, I know the docs is similar to colorkey, but I have a few short suggestions. On Fri, 18 Sep 2015 16:27:54 +0200, Timo Rothenpieler wrote: [...] > diff --git a/doc/filters.texi b/doc/filters.texi > index 4a55e59..0446204 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -3556,6

Re: [FFmpeg-devel] [PATCHv3] avfilter/vf_chromakey: Add chromakey video filter

2015-09-19 Thread Paul B Mahol
On 9/18/15, Timo Rothenpieler wrote: > --- > Changelog | 1 + > MAINTAINERS| 1 + > doc/filters.texi | 45 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/version.h |