Re: [Flightgear-devel] ATISs upgrade

2007-03-04 Thread Dave
John Denker wrote: > http://www.av8n.com/fly/fgfs/vce-wav.tgz > > *) Louder. This comes at the cost of some distortion, but overall >much more readable (in the presence of other noise). > > *) Many "fake" words added ... words necessary for ATIS. >Strange words are better than silence,

Re: [Flightgear-devel] ATISs upgrade

2007-03-04 Thread Joacim Persson
On Fri, 2 Mar 2007, John Denker wrote: > On 03/01/2007 02:19 PM, AJ MacLeod wrote: >> Was the stuff at line 300 intended to be in there? > > Actually yes, I put the call-trace in there for a reason, and I left > it in there for a reason. I thought that in the future, some folks > might find it he

Re: [Flightgear-devel] ATISs upgrade

2007-03-04 Thread Melchior FRANZ
* John Denker -- Sunday 04 March 2007: > It would be necessary to deal with the fact that there can be N different > "ATC" messages tuned up at the same time, Whereby all are spoken with the same voice, and all are printed to the single one terminal. Using a single message property wouldn't make t

Re: [Flightgear-devel] ATISs upgrade

2007-03-04 Thread John Denker
On 03/04/2007 05:37 AM, Melchior FRANZ wrote: > _setlistener("/sim/messages/atis", func { print(cmdarg().getValue()) }); ... > _setlistener("/sim/messages/atis", func { > setprop("/sim/screen/blue", cmdarg().getValue()); > }); 1) I'm afraid the code would have to be more compl

Re: [Flightgear-devel] ATISs upgrade

2007-03-04 Thread Melchior FRANZ
* John Denker -- Sunday 04 March 2007: > On 03/03/2007 05:18 PM, Durk Talsma wrote: > > Personally, I don't object against commented-out cout / cerr statements > > in the code if the author wants to retain them for ongoing development. > > Agreed! > > There are thousands of such couts in the co

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread Melchior FRANZ
* Durk Talsma -- Saturday 03 March 2007: > Personally, I don't object against commented-out cout / cerr statements > in the code I wasn't talking about commented out debug messages. m. - Take Surveys. Earn Cash. Influence

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread GWMobile
Leave it in! On Sat, 3 Mar 2007 7:07 pm, John Denker wrote: > On 03/03/2007 05:18 PM, Durk Talsma wrote: >> Also note that many cout statements still in the code are >> commented >> out, for potential use in future development / debugging. > > That's exactly what we're talking about today

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread John Denker
On 03/03/2007 05:18 PM, Durk Talsma wrote: > Also note that many cout statements still in the code are commented > out, for potential use in future development / debugging. That's exactly what we're talking about today : couts that output *nothing* unless a developer steps in to request some

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread Durk Talsma
John Denker wrote: > >> Don't use cout/cerr. Use SG_LOG with appropriate log levels. >> > > There are 2017 comparable uses of cout in FlightGear and 376 more > in SimGear. Why don't you remove some of those? When it gets > down to the point where the ones I've put in are, say, 1% of the >

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread John Denker
On 03/03/2007 02:30 PM, Alex Romosan wrote: > virtual void Init()=0; Excellent! Done now. http://www.av8n.com/fly/fgfs/atis.diff That is the Right Way(tm) to express what was intended. Thanks for the suggestion. -

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread Alex Romosan
John Denker writes: > On 03/03/2007 12:32 PM, Melchior FRANZ wrote: > >> hxx: >> +virtual void Init(); >> cxx: >> +void FGATC::Init() { >> +// This should never be called, since each derived class will have its >> own >> +// Init() that overrides this one. >> +} >>

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread Melchior FRANZ
* John Denker -- Saturday 03 March 2007: > On 03/03/2007 12:32 PM, Melchior FRANZ wrote: > > Don't use cout/cerr. Use SG_LOG with appropriate log levels. > > There are 2017 comparable uses of cout in FlightGear and 376 more > in SimGear. Why don't you remove some of those? If you weren't a newco

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread John Denker
On 03/03/2007 12:32 PM, Melchior FRANZ wrote: > hxx: > + virtual void Init(); > cxx: > +void FGATC::Init() { > +// This should never be called, since each derived class will have its > own > +// Init() that overrides this one. > +} > > So, why are you adding it?! Perhaps

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread Melchior FRANZ
* John Denker -- Friday 02 March 2007: > On 03/01/2007 02:19 PM, AJ MacLeod wrote: > > Was the stuff at line 300 intended to be in there? > > Actually yes, I put the call-trace in there for a reason, and I left > it in there for a reason. OK. Please remove it. Things like these have no place in

Re: [Flightgear-devel] ATISs upgrade

2007-03-03 Thread Martin Spott
Hi Didier, Didier Fabert wrote: > will this patch be commited in the both CVS branch? You can track the progress, especially on the atmosphere-stuff, in the two "altimeter"-related threads on this list, Martin. -- Unix _IS_ user friendly - it's just selective about who its friends are ! -

Re: [Flightgear-devel] ATISs upgrade

2007-03-02 Thread Didier Fabert
Le Saturday 03 March 2007 01:59:43 John Denker, vous avez écrit : > It appears to be in the patch. > I just checked >http://www.av8n.com/fly/fgfs/atmo.diff > > You can check for yourself. It starts right after > the following line: > > --- /dev/null > +++ b/src/Environment/atmo.hxx > > Note th

Re: [Flightgear-devel] ATISs upgrade

2007-03-02 Thread John Denker
On 03/02/2007 07:53 PM, Didier Fabert wrote: > Environment/atmo.hxx is not present. > Is it forgot in the patch? It appears to be in the patch. I just checked http://www.av8n.com/fly/fgfs/atmo.diff You can check for yourself. It starts right after the following line: --- /dev/null +++ b/src

Re: [Flightgear-devel] ATISs upgrade

2007-03-02 Thread Didier Fabert
I have a compilation error with the patch atis.cxx:48:32: erreur: Environment/atmo.hxx : Aucun fichier ou répertoire de ce type atis.cxx: In member function 'int FGATIS::GenTransmission(int, int)': atis.cxx:262: error: 'FGatmo' was not declared in this scope atis.cxx:280: error: 'atmodel' has not

Re: [Flightgear-devel] ATISs upgrade

2007-03-02 Thread John Denker
On 03/02/2007 04:28 PM, [EMAIL PROTECTED] wrote: > Would it be possible to modify the ATIS code to provide AWOS and ASOS > weather information only on those frequencies as well? Excellent question. That's the most important item on the TODO list. One important step along the way is to collect t

Re: [Flightgear-devel] ATISs upgrade

2007-03-02 Thread RMcN
Would it be possible to modify the ATIS code to provide AWOS and ASOS weather information only on those frequencies as well? ** AOL now offers free email to everyone. Find out more about what's free from AOL at http://www.aol.com. --

Re: [Flightgear-devel] ATISs upgrade

2007-03-02 Thread John Denker
On 03/01/2007 02:19 PM, AJ MacLeod wrote: > This patch promises to > address quite a few niggles that I've noticed over the past few years, thanks > for working on it... :-) Having a usable ATIS is important, if you're interested in realism. > Was the stuff at line 300 intended to be in th

Re: [Flightgear-devel] ATISs upgrade

2007-03-01 Thread AJ MacLeod
On Thursday 01 March 2007 16:55, John Denker wrote: > http://www.av8n.com/fly/fgfs/atis.diff Was the stuff at line 300 intended to be in there? This patch promises to address quite a few niggles that I've noticed over the past few years, thanks for working on it... Cheers, AJ ---