Re: commenting the Knuth code/centering issue

2004-11-11 Thread Luca Furini
I have tried to add some comments to the Knuth[Element, Box, Glue, Penalty] classes. As I am not sure they are clear enough (I'm not even sure they are written in a proper English! :-) ) I'd like to hear your opinions before committing them. Regards, Luca Index: KnuthBox.java

Re: commenting the Knuth code/centering issue

2004-11-11 Thread Clay Leeds
On Nov 11, 2004, at 10:03 AM, Luca Furini wrote: I have tried to add some comments to the Knuth[Element, Box, Glue, Penalty] classes. As I am not sure they are clear enough (I'm not even sure they are written in a proper English! :-) ) I'd like to hear your opinions before committing them. The

Re: commenting the Knuth code/centering issue

2004-11-11 Thread Glen Mazza
Excellent, although indentation of paragraphs in comments is somewhat less common (but if done, should probably be three or four spaces indent instead of just one). Instead of indenting, it would probably be better (easier to read) if you placed a blank line between paragraphs. Also, if you

Re: commenting the Knuth code/centering issue

2004-11-11 Thread Simon Pepping
Luca, On Thu, Nov 11, 2004 at 07:03:33PM +0100, Luca Furini wrote: I have tried to add some comments to the Knuth[Element, Box, Glue, Penalty] classes. As I am not sure they are clear enough (I'm not even sure they are written in a proper English! :-) ) I'd like to hear your opinions

Re: commenting the Knuth code/centering issue

2004-11-07 Thread Glen Mazza
PM Subject: Re: commenting the Knuth code/centering issue Glen Mazza wrote: [BTW, I'm considering getting that Digital Typography book by Knuth you had mentioned earlier. Do you recommend it? (I was thinking that given all the time I spend on FOP I should start looking a little more

Re: commenting the Knuth code/centering issue

2004-11-06 Thread J.Pietschmann
Glen Mazza wrote: [BTW, I'm considering getting that Digital Typography book by Knuth you had mentioned earlier. Do you recommend it? (I was thinking that given all the time I spend on FOP I should start looking a little more at the scientific aspects of this work.)] Yes, a must read if you are

Re: commenting the Knuth code/centering issue

2004-11-06 Thread Luca Furini
Jeremias Maerki wrote: No, I don't think Luca has write access, yet. I know by now that the CLA is recorded but the account hasn't been created, yet, although I've already sent a reminder. I have just received the e-mail confirming the creation of my account. I am now reading the

Re: commenting the Knuth code/centering issue

2004-11-06 Thread Luca Furini
Glen Mazza wrote: [BTW, I'm considering getting that Digital Typography book by Knuth you had mentioned earlier. Do you recommend it? (I was thinking that given all the time I spend on FOP I should start looking a little more at the scientific aspects of this work.)] I think it's very

Re: commenting the Knuth code/centering issue

2004-11-05 Thread Simon Pepping
On Thu, Nov 04, 2004 at 02:59:52PM -0800, Glen Mazza wrote: --- Luca Furini [EMAIL PROTECTED] wrote: [BTW, I'm considering getting that Digital Typography book by Knuth you had mentioned earlier. Do you recommend it? (I was thinking that given all the time I spend on FOP I should start

Re: commenting the Knuth code/centering issue

2004-11-04 Thread Luca Furini
Glen Mazza wrote: The title centers correctly in 0.20.5, but is left-justified in 1.0. [...] Luca, are you looking at this issue of text alignment in general? Yes, this happens when the text is short and the algorithm is not able to find a set of breaking points: the fallback method can't

Re: commenting the Knuth code/centering issue

2004-11-04 Thread Glen Mazza
--- Luca Furini [EMAIL PROTECTED] wrote: Another way is to use, instead of considerLegalBreak(), a different method to evaluate a possible break point if no breakpoints are found: this alternative method would be much simpler, and would re-create the behaviour of the old getNextBreakPoss

Re: commenting the Knuth code/centering issue

2004-11-04 Thread Jeremias Maerki
No, I don't think Luca has write access, yet. I know by now that the CLA is recorded but the account hasn't been created, yet, although I've already sent a reminder. On 04.11.2004 23:59:52 Glen Mazza wrote: Please do--this solution sounds great! (BTW, you have write access already, correct?)

commenting the Knuth code/centering issue

2004-11-03 Thread Glen Mazza
Luca, Running our embedded.fo example in both FOP 0.20.5 and FOP 1.0 is showing a centering problem for the Embedding SVG title located at the top of the document (this text is located in the fo:block at line 31 of the .fo document.) The title centers correctly in 0.20.5, but is left-justified