DO NOT REPLY [Bug 50635] Incorrect pagesequence passed to renderer

2011-01-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50635 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Status|NEW |NEEDINFO

DO NOT REPLY [Bug 50636] O(n^2) code for adding new pages

2011-01-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50636 --- Comment #2 from Andreas L. Delmelle adelme...@apache.org 2011-01-24 12:05:14 EST --- Thanks for the patch! I will take this on and commit it soon, unless someone beats me to it. (Got some changes to the same package/class that I want

Re: svn commit: r1062901 [1/2] - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/area: ./ inline/

2011-01-24 Thread Andreas Delmelle
On 24 Jan 2011, at 19:06, adelme...@apache.org wrote: Author: adelmelle Date: Mon Jan 24 18:06:25 2011 New Revision: 1062901 URL: http://svn.apache.org/viewvc?rev=1062901view=rev Log: Bugzilla 50593: Mostly add type safety to various collections in the fop.area package. Additionally,

DO NOT REPLY [Bug 50593] [PATCH] Add type safety to collections in fop.area package (e.a.)

2011-01-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50593 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

DO NOT REPLY [Bug 50636] O(n^2) code for adding new pages

2011-01-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50636 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

testing bug fixes - not!

2011-01-24 Thread Glenn Adams
Is there a reason why *all* bug fixes are not accompanied by one or more new test cases that demonstrate the presence and absence of the bug before and after the fix? Adding such test cases should be mandatory for all bug fix commits. I wouldn't quite go that far for performance and clean up

DO NOT REPLY [Bug 50635] Incorrect pagesequence passed to renderer

2011-01-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50635 Andreas L. Delmelle adelme...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

Re: testing bug fixes - not!

2011-01-24 Thread Andreas Delmelle
On 24 Jan 2011, at 23:17, Glenn Adams wrote: Hi Glenn Is there a reason why *all* bug fixes are not accompanied by one or more new test cases that demonstrate the presence and absence of the bug before and after the fix? Adding such test cases should be mandatory for all bug fix commits.

Re: testing bug fixes - not!

2011-01-24 Thread Glenn Adams
Andreas, I wasn't trying to pick on you or anyone for that matter. It is something I've been meaning to bring up for some months actually. What I would hope to see is follows: (1) if there is a bug where a given input FO file causes an unhandled exception, and the bug fix is to fix the