Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-03-02 Thread Alexios Giotis
Patch updated, see https://issues.apache.org/bugzilla/show_bug.cgi?id=46962#c15 Alex Giotis On Mar 1, 2012, at 2:20 PM, Alexios Giotis wrote: > Vincent, > > No need to send more info. I just reproduced it on Windows Server 2008 R2 > Enterprise running the latest, 'non-business', but not supp

Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-03-01 Thread Alexios Giotis
Vincent, No need to send more info. I just reproduced it on Windows Server 2008 R2 Enterprise running the latest, 'non-business', but not supported as of Nov 2009, Sun JRE 1.5.0_22. The production servers are all running JDK6 and I could not test it on a Mac. The bug is indeed related to the

Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-02-29 Thread Alexios Giotis
Hi Vincent, The unit tests where added by Mehdi but I could happily update them to Junit 4 and create the separate methods. Related to the NullPointerException that you found, I tried many times but unfortunately I can't reproduce them on my Macbook running MacOS X 10.7.3 with any JRE and hav

Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-02-29 Thread Vincent Hennebert
Sorry for the delay about this. I had a look at the patch some time ago but didn’t have enough time to apply it. I noticed that a NPE occurs when adding the following piece of code to PropertyCacheTestCase and running it: private final PropertyCache cache = new PropertyCache(); private c

Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-02-29 Thread Chris Bowditch
On 28/02/2012 17:19, Glenn Adams wrote: Hi Benson, Glenn, Alexis, benson, thanks for that clarification, i see in [1] that though an ICLA is not required of a contributor, it is nevertheless desirable to have one submitted; so, Alexios, if you wish to submit an ICLA please do so; however, giv

Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-02-28 Thread Alexios Giotis
Thank you all for your replies. I just printed and will send the ICLA anyway so that it will not be an impediment for applying this or future patches. @Vincent I will be happy to make any clarification related to the patch. But it would be transparent if there is a comment on the issue or an em

Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-02-28 Thread Glenn Adams
benson, thanks for that clarification, i see in [1] that though an ICLA is not required of a contributor, it is nevertheless desirable to have one submitted; so, Alexios, if you wish to submit an ICLA please do so; however, given the limited scope of the patch, I would agree that it is not strictly

Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-02-28 Thread mehdi houshmand
Hi Guys, My apologies for the lack of transparency on this issue, but I didn't actually review the changes you made here, in fact, I barely looked at what PropertyCache actually does. I had some free time, and added a bunch of unit tests. The reason this hasn't been committed yet was because Vinc

Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-02-28 Thread Benson Margulies
an icla is not required for a patch attached to a bz unless it is of unusual size or not coded be the bz submitter. On Feb 28, 2012, at 11:53 AM, Glenn Adams wrote: I support committing this patch, however I don't see an ICLA listed at [1] for Alexios. Alexios, if you have not submitted an ICLA

Re: Bugzilla #46962 - Deadlock in PropertyCache

2012-02-28 Thread Glenn Adams
I support committing this patch, however I don't see an ICLA listed at [1] for Alexios. Alexios, if you have not submitted an ICLA [2], please do so. I would be happy to apply the patch (if Mehdi doesn't have the time). [1] http://people.apache.org/committer-index.html#unlistedclas [2] http://www

Bugzilla #46962 - Deadlock in PropertyCache

2012-02-28 Thread Alexios Giotis
Hi, About 6 months ago, I had a deadlock issue that regularly stopped production servers. While I was opening a bugzilla ticket, I found that this was already reported back in 2009. This issue is still opened as it was difficult to reproduce. On that issue, I added: [1] An explanation of why a