Re: Inline border, padding and alignment commit

2005-10-07 Thread Manuel Mall
On Fri, 7 Oct 2005 08:51 pm, Jeremias Maerki wrote: > Great work That's a lot of new functionality. And lots of new > test cases! You're a prime role model. :-) > > I've got a comment and a question: > - I assume the change in StaticPropertyList was a mistake: > http://svn.apache.org/viewcvs/xm

Re: Inline border, padding and alignment commit

2005-10-07 Thread Jeremias Maerki
Great work That's a lot of new functionality. And lots of new test cases! You're a prime role model. :-) I've got a comment and a question: - I assume the change in StaticPropertyList was a mistake: http://svn.apache.org/viewcvs/xmlgraphics/fop/trunk/src/java/org/apache/fop/fo/StaticPropertyLi

Re: Inline border, padding and alignment commit

2005-10-07 Thread Manuel Mall
On Fri, 7 Oct 2005 08:00 pm, Christian Geisert wrote: > Manuel Mall schrieb: > > I just committed a fairly sizeable patch related to all the work on > > inline objects done over the last weeks. > > Great that you are finally able to commit .. welcome! > > > While I hope it hasn't broken anything,

Re: Inline border, padding and alignment commit

2005-10-07 Thread Christian Geisert
Manuel Mall schrieb: > I just committed a fairly sizeable patch related to all the work on > inline objects done over the last weeks. Great that you are finally able to commit .. welcome! > While I hope it hasn't broken anything, given its size and my > inexperience with the overall FOP softwa