Re: [Vote] for the merge of Temp_RoundedCorners

[Glenn Adams]

My preference would be to provide both the CSS3 named properties and also
writing system relative properties, giving the user the preference of which
to use. But I would suggest using the same pattern as CSS3 for property
names for these latter:

border-top-left-radius
border-top-right-radius
border-bottom-right-radius
border-bottom-left-radius

border-before-start-radius
border-before-end-radius
border-after-start-radius
border-after-end-radius

it would also be useful to support the border-radius shortcut from CSS3
(mapping to the above CSS3 longhand flavors)

On Fri, Oct 12, 2012 at 8:48 PM, Peter Hancock wrote:

> Thanks for taking the time to review this!
>
> On Fri, Oct 12, 2012 at 2:12 PM, Glenn Adams  wrote:
> >...
> > However, I also notice that the fox property name proposed in [1]
> contains
> > uppercase (fox:border-BLOCK-radius-INLINE). That is a definite no-no, and
> > thus warrants a -1 vote until changed to LC. All LC please!
>
> The upper case BLOCK and INLINE were meant to represent variables with
> values before and after, and start and end, respectively.
>
> > I haven't had a chance to look at the details, but does this extension
> > follow the (property name and value) definitions found in CSS3
> Backgrounds
> > and Borders [4]? If it doesn't, then my vote is -1; otherwise, I would
> vote
> > +1.
>
> I do concede that there is a departure from CSS3:
> To specify the top left corner in CSS3 you do
> border-top-left-radius="x y"
> and with the fox extension (assuming a viewport orientated with the page)
> fox:border-start-radius-before="x"
> fox:border-before-radius-start="y"
>
> If this is unsatisfactory then I guess it is back to the drawing board.
>
> Peter
>

Re: [Vote] for the merge of Temp_RoundedCorners

[Christopher R. Maden]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 10/12/2012 10:34 AM, The Web Maestro wrote:
> Yes... We've got two 'standards' to follow here: XSL-FO and CSS3. 
> Where possible, I'd like to err on the side of CSS3, since that is 
> so much more widely used. In fact, where (if?) there are 
> discrepancies between the CSS3 & XSL-FO methods, we may want to 
> consider creating 'aliases' for one, that translates to the
> other... That could introduce bugs, and maintenance might be
> another issue, but it's something to consider.

I don’t get a vote on this... but I think that the established
precedent within XSL shows the way forward.

The proposed patch uses monotonic properties with relative direction
terminology (start, before, etc.); CSS uses absolute position terms
and combines properties.  In XSL properties like margin and border,
this is handled by defining the relative, monotonic properties as
fundamental, and CSS equivalents as synonyms that expand to the XSL
versions.

If I had a vote, I would vote to accept this patch, but to add
mappings from the CSS versions to these monotonic relative properties.

IMO,
Chris
- -- 
Chris Maden, text nerd  http://crism.maden.org/ >
LIVE FREE: vote for Gary Johnson, Libertarian for President.
 http://garyjohnson2012.com/ >  http://lp.org/ >
GnuPG fingerprint: DB08 CF6C 2583 7F55 3BE9  A210 4A51 DBAC 5C5C 3D5E
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQEcBAEBAgAGBQJQeFJiAAoJEEpR26xcXD1eJrwIAL26hb3TNkIWJ7Wth3WA7gqW
P4Xwv30emQLpy+2HNBrv1zYGLBw0oSp61C3GghWqGJymtSVpuph58t0HZ7aWzXSD
sQW9lmglvEXesND2piZNJjvfOMMat/7KIegq/MVW+zqYnaxCnAyZW8T8LgeBqFJ6
dVBp76YP9VefSlkKTYcC6lZIxw102I8CH0rM0vIGpeJxpnCVdDCyLNbp2zaDjKb1
fMhTFYruQdidSRTV0N0Ynzn5yto+io0DSNdsSUWzf9xR35ygVFFL0BgiwJSlDf9Y
r/H3kfQ7SA7WFLiAze4VOeqIsyu4bSVc4w2XUZaxFnE3N7ym4Pu95CGTCx50Dm4=
=f+XN
-END PGP SIGNATURE-

Re: [Vote] for the merge of Temp_RoundedCorners

[The Web Maestro]

On Fri, Oct 12, 2012 at 7:25 AM, Pascal Sancho  wrote:
> Yes, CSS3 naming is easier to understand.
> And like other border-* properties, top, right, bottom, left should be
> mapped to equivalent FO directions in lr-tb mode (respectively before,
> end, after, start).

Yes... We've got two 'standards' to follow here: XSL-FO and CSS3.
Where possible, I'd like to err on the side of CSS3, since that is so
much more widely used. In fact, where (if?) there are discrepancies
between the CSS3 & XSL-FO methods, we may want to consider creating
'aliases' for one, that translates to the other... That could
introduce bugs, and maintenance might be another issue, but it's
something to consider.

Clay

Re: [Vote] for the merge of Temp_RoundedCorners

[Pascal Sancho]

Yes, CSS3 naming is easier to understand.
And like other border-* properties, top, right, bottom, left should be
mapped to equivalent FO directions in lr-tb mode (respectively before,
end, after, start).

2012/10/12 Clay Leeds :
> I would prefer CSS3 naming conventions as well.
>
> Clay
>
> "My religion is simple. My religion is kindness."
> - HH The Dalai Lama of Tibet
>
> On Oct 12, 2012, at 6:48 AM, Peter Hancock  wrote:
>
>> Thanks for taking the time to review this!
>>
>> On Fri, Oct 12, 2012 at 2:12 PM, Glenn Adams  wrote:
>>> ...
>>> However, I also notice that the fox property name proposed in [1] contains
>>> uppercase (fox:border-BLOCK-radius-INLINE). That is a definite no-no, and
>>> thus warrants a -1 vote until changed to LC. All LC please!
>>
>> The upper case BLOCK and INLINE were meant to represent variables with
>> values before and after, and start and end, respectively.
>>
>>> I haven't had a chance to look at the details, but does this extension
>>> follow the (property name and value) definitions found in CSS3 Backgrounds
>>> and Borders [4]? If it doesn't, then my vote is -1; otherwise, I would vote
>>> +1.
>>
>> I do concede that there is a departure from CSS3:
>> To specify the top left corner in CSS3 you do
>> border-top-left-radius="x y"
>> and with the fox extension (assuming a viewport orientated with the page)
>> fox:border-start-radius-before="x"
>> fox:border-before-radius-start="y"
>>
>> If this is unsatisfactory then I guess it is back to the drawing board.
>>
>> Peter



-- 
pascal

Re: [Vote] for the merge of Temp_RoundedCorners

[Clay Leeds]

I would prefer CSS3 naming conventions as well. 

Clay 

"My religion is simple. My religion is kindness."
- HH The Dalai Lama of Tibet

On Oct 12, 2012, at 6:48 AM, Peter Hancock  wrote:

> Thanks for taking the time to review this!
> 
> On Fri, Oct 12, 2012 at 2:12 PM, Glenn Adams  wrote:
>> ...
>> However, I also notice that the fox property name proposed in [1] contains
>> uppercase (fox:border-BLOCK-radius-INLINE). That is a definite no-no, and
>> thus warrants a -1 vote until changed to LC. All LC please!
> 
> The upper case BLOCK and INLINE were meant to represent variables with
> values before and after, and start and end, respectively.
> 
>> I haven't had a chance to look at the details, but does this extension
>> follow the (property name and value) definitions found in CSS3 Backgrounds
>> and Borders [4]? If it doesn't, then my vote is -1; otherwise, I would vote
>> +1.
> 
> I do concede that there is a departure from CSS3:
> To specify the top left corner in CSS3 you do
> border-top-left-radius="x y"
> and with the fox extension (assuming a viewport orientated with the page)
> fox:border-start-radius-before="x"
> fox:border-before-radius-start="y"
> 
> If this is unsatisfactory then I guess it is back to the drawing board.
> 
> Peter

Re: [Vote] for the merge of Temp_RoundedCorners

[Peter Hancock]

Thanks for taking the time to review this!

On Fri, Oct 12, 2012 at 2:12 PM, Glenn Adams  wrote:
>...
> However, I also notice that the fox property name proposed in [1] contains
> uppercase (fox:border-BLOCK-radius-INLINE). That is a definite no-no, and
> thus warrants a -1 vote until changed to LC. All LC please!

The upper case BLOCK and INLINE were meant to represent variables with
values before and after, and start and end, respectively.

> I haven't had a chance to look at the details, but does this extension
> follow the (property name and value) definitions found in CSS3 Backgrounds
> and Borders [4]? If it doesn't, then my vote is -1; otherwise, I would vote
> +1.

I do concede that there is a departure from CSS3:
To specify the top left corner in CSS3 you do
border-top-left-radius="x y"
and with the fox extension (assuming a viewport orientated with the page)
fox:border-start-radius-before="x"
fox:border-before-radius-start="y"

If this is unsatisfactory then I guess it is back to the drawing board.

Peter

Re: [Vote] for the merge of Temp_RoundedCorners

[Glenn Adams]

I haven't had a chance to look at the details, but does this extension
follow the (property name and value) definitions found in CSS3 Backgrounds
and Borders [4]? If it doesn't, then my vote is -1; otherwise, I would vote
+1.

However, I also notice that the fox property name proposed in [1] contains
uppercase (fox:border-BLOCK-radius-INLINE). That is a definite no-no, and
thus warrants a -1 vote until changed to LC. All LC please!

In general, the property names and values should exactly match what are
proposed in CSS3 unless there is *a really good reason* why that shouldn't
be the case.

[4] http://www.w3.org/TR/css3-background/#corners

On Fri, Oct 12, 2012 at 5:40 PM, Peter Hancock wrote:

> Hi,
>
> Luis Benardo and Myself have just done some clean up to the branch
> Temp_RoundedCorners.  This branch implements support for 'fox'
> extension properties  for specifying borders with rounded corners.
> Please refer to [1] and [2] for details.
>
> There is an example fo [3] that demonstrates the feature.
>
> Currently we are supporting:
>   PDF, PS and AFP outputs
>   'border-style' property with values of  'solid', 'none', 'hidden'
> and, to a limited degree, 'dashed'
>
> I would like to start a vote to merge feature branch to trunk, with my +1.
>
> Thanks,
>
> Peter
>
> [1] http://wiki.apache.org/xmlgraphics-fop/RoundedBorders
> [2] http://xmlgraphics.staging.apache.org/fop/trunk/extensions.html
> [2] examples/fo/advanced/rounded-corners.fo in the Temp_RoundedCorners
> branch
>

Re: [Vote] for the merge of Temp_RoundedCorners

[The Web Maestro]

Sounds good!

+1 from me!

Kind regards,

Web Maestro Clay
--
 - 
My religion is simple. My religion is kindness.
- HH The 14th Dalai Lama of Tibet


On Fri, Oct 12, 2012 at 2:40 AM, Peter Hancock  wrote:
> Hi,
>
> Luis Benardo and Myself have just done some clean up to the branch
> Temp_RoundedCorners.  This branch implements support for 'fox'
> extension properties  for specifying borders with rounded corners.
> Please refer to [1] and [2] for details.
>
> There is an example fo [3] that demonstrates the feature.
>
> Currently we are supporting:
>   PDF, PS and AFP outputs
>   'border-style' property with values of  'solid', 'none', 'hidden'
> and, to a limited degree, 'dashed'
>
> I would like to start a vote to merge feature branch to trunk, with my +1.
>
> Thanks,
>
> Peter
>
> [1] http://wiki.apache.org/xmlgraphics-fop/RoundedBorders
> [2] http://xmlgraphics.staging.apache.org/fop/trunk/extensions.html
> [2] examples/fo/advanced/rounded-corners.fo in the Temp_RoundedCorners branch

Re: [Vote] for the merge of Temp_RoundedCorners

[Pascal Sancho]

Hi,
Very good job!
+1

2012/10/12 Peter Hancock :
> Hi,
>
> Luis Benardo and Myself have just done some clean up to the branch
> Temp_RoundedCorners.  This branch implements support for 'fox'
> extension properties  for specifying borders with rounded corners.
> Please refer to [1] and [2] for details.
>
> There is an example fo [3] that demonstrates the feature.
>
> Currently we are supporting:
>   PDF, PS and AFP outputs
>   'border-style' property with values of  'solid', 'none', 'hidden'
> and, to a limited degree, 'dashed'
>
> I would like to start a vote to merge feature branch to trunk, with my +1.
>
> Thanks,
>
> Peter
>
> [1] http://wiki.apache.org/xmlgraphics-fop/RoundedBorders
> [2] http://xmlgraphics.staging.apache.org/fop/trunk/extensions.html
> [2] examples/fo/advanced/rounded-corners.fo in the Temp_RoundedCorners branch



-- 
pascal

Re: [Vote] for the merge of Temp_RoundedCorners

[mehdi houshmand]

+1

On 12 October 2012 10:40, Peter Hancock  wrote:

> Hi,
>
> Luis Benardo and Myself have just done some clean up to the branch
> Temp_RoundedCorners.  This branch implements support for 'fox'
> extension properties  for specifying borders with rounded corners.
> Please refer to [1] and [2] for details.
>
> There is an example fo [3] that demonstrates the feature.
>
> Currently we are supporting:
>   PDF, PS and AFP outputs
>   'border-style' property with values of  'solid', 'none', 'hidden'
> and, to a limited degree, 'dashed'
>
> I would like to start a vote to merge feature branch to trunk, with my +1.
>
> Thanks,
>
> Peter
>
> [1] http://wiki.apache.org/xmlgraphics-fop/RoundedBorders
> [2] http://xmlgraphics.staging.apache.org/fop/trunk/extensions.html
> [2] examples/fo/advanced/rounded-corners.fo in the Temp_RoundedCorners
> branch
>

[Vote] for the merge of Temp_RoundedCorners

[Peter Hancock]

Hi,

Luis Benardo and Myself have just done some clean up to the branch
Temp_RoundedCorners.  This branch implements support for 'fox'
extension properties  for specifying borders with rounded corners.
Please refer to [1] and [2] for details.

There is an example fo [3] that demonstrates the feature.

Currently we are supporting:
  PDF, PS and AFP outputs
  'border-style' property with values of  'solid', 'none', 'hidden'
and, to a limited degree, 'dashed'

I would like to start a vote to merge feature branch to trunk, with my +1.

Thanks,

Peter

[1] http://wiki.apache.org/xmlgraphics-fop/RoundedBorders
[2] http://xmlgraphics.staging.apache.org/fop/trunk/extensions.html
[2] examples/fo/advanced/rounded-corners.fo in the Temp_RoundedCorners branch