[jira] [Commented] (FOP-2044) [PATCH] Hyphenation of Uppercase Words, Combined with Underlines
[ https://issues.apache.org/jira/browse/FOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13904671#comment-13904671 ] Luis Bernardo commented on FOP-2044: The burden of forcing uncommon hyphenation should be on the user, not on FOP. But FOP provides the means to do it through customized hyphenation patterns. See https://xmlgraphics.apache.org/fop/trunk/hyphenation.html. An example, for one of the cases used here: PROFILING_PC_STATUS_NO_COUNTER_AVAILABLE_FOR_TYPE From svn://tug.org/texhypen get the file trunk/collaboration/repository/offo/en.xml (or the file for whatever language you are using). Place the file in the hyph directory of FOP, and edit it by adding these two lines inside the patterns element: .counte5r .t5ype These mean that COUNTE-R and T-YPE are valid hyphenations, and even likely (given the value of 5). Run ant jar-hyphenation. This updates the fop-hyph.jar in the build directory. Then run FOP with the example uppercase-hyphen-2.fo provided here. The result should be uppercase-hyphen-2-fixed.pdf. [PATCH] Hyphenation of Uppercase Words, Combined with Underlines Key: FOP-2044 URL: https://issues.apache.org/jira/browse/FOP-2044 Project: Fop Issue Type: Improvement Components: general Affects Versions: 1.0 Environment: Operating System: All Platform: All Reporter: Thomas Schraitle Assignee: Robert Meyer Fix For: trunk Attachments: fop-trunk-jan02-2014-test-fop-2044.fo, fop-trunk-jan02-2014.log, fop-trunk-jan92-2914-test-fop-2044.pdf, output.pdf, patch.diff, patch2.diff, uppercase-hyphen.fo, uppercase-hyphen.pdf Consider the attached FO file which combines words of lowercase and uppercase letters. As it is expected, the word expected is hyphenated correctly (example 2). Also the uppercase SUCCESS. Even combined with underlines before and after the word (see example 4 and 5). However, if there is another word (like OCF_SUCCESS) the word isn't hyphenated at all anymore. I don't know if this is an expected behaviour or an issue in the hyphenation patterns. Interestingly, XEP from RenderX hyphenates it as OCF_SUC-CESS. As far as I know, they use also the TeX hyphenation patterns as FOP. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (FOP-2044) [PATCH] Hyphenation of Uppercase Words, Combined with Underlines
[ https://issues.apache.org/jira/browse/FOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13875614#comment-13875614 ] Lennart Johansson commented on FOP-2044: Highly appreciate the actions. Tips: Personally I would vote for an extra hardcoded break as a last effort if nothing else helps, to ensure that text in a table cell NEVER overflows into another cell, destroying other texts, due to hyphenation problems. Actually I have also seen that XEP tries another type of last-effort solution, to decrease the space-between-characters on the troublesome line causing horizontally dense text, rather than overflowing a table-cell. If the last effort is successful, use an INFO: instead of a WARNING message. Still it might be OK for text-that-could-not-be-broken to slightly overflow the text area into the page margin of a PDF-page (at least as long as it does not reach outside the page edge and disappears) - it is only in table cells that an overflow can destroys other text. However, maybe it is difficult for the FOP hyphenation code to know, if it is in a table cell or somewhere else, especially if if needs to consider also right-to-left text direction or similar? Best Regards / Lennart [PATCH] Hyphenation of Uppercase Words, Combined with Underlines Key: FOP-2044 URL: https://issues.apache.org/jira/browse/FOP-2044 Project: Fop Issue Type: Improvement Components: general Affects Versions: 1.0 Environment: Operating System: All Platform: All Reporter: Thomas Schraitle Assignee: Robert Meyer Fix For: trunk Attachments: fop-trunk-jan02-2014-test-fop-2044.fo, fop-trunk-jan02-2014.log, fop-trunk-jan92-2914-test-fop-2044.pdf, output.pdf, patch.diff, patch2.diff, uppercase-hyphen.fo, uppercase-hyphen.pdf Consider the attached FO file which combines words of lowercase and uppercase letters. As it is expected, the word expected is hyphenated correctly (example 2). Also the uppercase SUCCESS. Even combined with underlines before and after the word (see example 4 and 5). However, if there is another word (like OCF_SUCCESS) the word isn't hyphenated at all anymore. I don't know if this is an expected behaviour or an issue in the hyphenation patterns. Interestingly, XEP from RenderX hyphenates it as OCF_SUC-CESS. As far as I know, they use also the TeX hyphenation patterns as FOP. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (FOP-2044) [PATCH] Hyphenation of Uppercase Words, Combined with Underlines
[ https://issues.apache.org/jira/browse/FOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13873498#comment-13873498 ] Lennart Johansson commented on FOP-2044: I am very greatful for the updates which have solved most hyphenation problems. It is amazing how good FOP works. But I found still 11 long words that fop-trunk Jan 1, 2014 can not handle and which we have trouble with, due to autogenerated XML, where it is difficult to use workarounds. FOP issues WARNING: messages for those listed below and there are overflows in PDF. QUEST: Is it possible to do something about these, with the help of our test results, even though this issue FOP-2044 has been set to resolved? Most of these seem to be of the same nature as what is discussed above in the 27/Jan/13 00:36 comment. There are only one or two characters overflow or in some cases less than a character. This is fatal when overflowing the text in the next column in a table, even though a similar small overflow is OK if it only overflows into the right page edge. A few others seem different. The first remaining problem is similar to what is described above, where there are very few characters overflowing, just one or two characters or in some cases even less that a full character. -1- ip6_ctlun.ip6_un1.ip6_un1_flowoverflows ow -2- ip6_ctlun.ip6_un1.ip6_un1_plenoverflows en -3- ip6_ctlun.ip6_un1.ip6_un1_nxt overflows t Comment: ip6_ctlun.ip6_un1.ip6_un1_hlim is CORRECTLY broken at _h- lim -4- EPM_REQUEST_TO_CLEAR_NONEXISTING_BP overflows tailing P even though it is hyphenated EPM_RE- much too early -5- OSE_BSP_EKRN_EVT_MISALIGNED_MSG_QUEUE gives WARNING but is very close to the column right edge, very slightly overflowing. Should be hyphenated somewhere -6- PROFILING_PC_STATUS_NO_COUNTER_AVAILABLE_FOR_TYPE overflows even though it breaks in one place PROFILING_PC_S- Should either be hyphenated later or twice, because the remaining part is very slightly too long -7- FOP breaks too early: SCTP_PARTIAL_DELIVERY_EVENT becomes SCT- followed by P_PARTIAL_DELIVERY_EVENT which overflows into next column Comment: A quick-test shows that in case of manually created XML, a soft-hyphen shy can solve SCTP_PARTIAL_DELIVERY_EVENT. -8- LINX_CM_ETH_EDESTROY_IN_PROGRESS overflows and also has a hyphenation break far out inside the overflow area, causing it to be displayed as follows. The ROY_IN_PRO- is overflowing the right column text with unreadable result. This table column is narrower than in the HV_ examples below: LINX_CM_ETH_EDESTROY_IN_PRO- (where ROY_IN_PRO- is overflow) GRESS The second problem is the following three words, which I do not understand why they are not hyphenated at all? -9- HV_GUEST_RESULT_EGUEST_NOT_INITIALIZED overflows NITIALIZED -10- HV_GUEST_TRANSITION_GUEST_USER_MODEoverflows ER_MODE -11- HV_GUEST_TRANSITION_GUEST_SU_MODE overflows MODE Comment: Much longer words are correctly hyphenated in same column, e.g. HV_GUEST_RESULT_EGUEST_AL- READY_INITIALIZED) A third problem in MINOR, because we can use WORKAROUND with soft-hyphen, because it only appears in a book where we manually create the XML files: -12- MINOR: FOP can not break numerical IPv6 addresses with only digits, causing overflow into next column. ff01:::::::0101 overflows :0101 INFO: In this case XEP uses denser font to squeeze it in if it can, or break it if needed! WORKAROUND - we make more space or use zero-width-space #8203 Note that soft-hyphen does not work here! Best Regards and Good Luck / Lennart [PATCH] Hyphenation of Uppercase Words, Combined with Underlines Key: FOP-2044 URL: https://issues.apache.org/jira/browse/FOP-2044 Project: Fop Issue Type: Improvement Components: general Affects Versions: 1.0 Environment: Operating System: All Platform: All Reporter: Thomas Schraitle Assignee: Robert Meyer Fix For: trunk Attachments: output.pdf, patch.diff, patch2.diff, uppercase-hyphen.fo, uppercase-hyphen.pdf Consider the attached FO file which combines words of lowercase and uppercase letters. As it is expected, the word expected is hyphenated correctly (example 2). Also the uppercase SUCCESS. Even combined with underlines before and after the word (see example 4 and 5). However, if there is another word (like OCF_SUCCESS) the word isn't hyphenated at all anymore. I don't know if this is an expected behaviour or an issue in the hyphenation patterns. Interestingly, XEP from RenderX hyphenates it
[jira] [Commented] (FOP-2044) [PATCH] Hyphenation of Uppercase Words, Combined with Underlines
[ https://issues.apache.org/jira/browse/FOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874231#comment-13874231 ] Luis Bernardo commented on FOP-2044: can you please provide an FO file with your examples? even though your description of the problems is very clear it will be difficult to reproduce without knowing the precise width that is constraining your content, and what font you are using. [PATCH] Hyphenation of Uppercase Words, Combined with Underlines Key: FOP-2044 URL: https://issues.apache.org/jira/browse/FOP-2044 Project: Fop Issue Type: Improvement Components: general Affects Versions: 1.0 Environment: Operating System: All Platform: All Reporter: Thomas Schraitle Assignee: Robert Meyer Fix For: trunk Attachments: output.pdf, patch.diff, patch2.diff, uppercase-hyphen.fo, uppercase-hyphen.pdf Consider the attached FO file which combines words of lowercase and uppercase letters. As it is expected, the word expected is hyphenated correctly (example 2). Also the uppercase SUCCESS. Even combined with underlines before and after the word (see example 4 and 5). However, if there is another word (like OCF_SUCCESS) the word isn't hyphenated at all anymore. I don't know if this is an expected behaviour or an issue in the hyphenation patterns. Interestingly, XEP from RenderX hyphenates it as OCF_SUC-CESS. As far as I know, they use also the TeX hyphenation patterns as FOP. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (FOP-2044) [PATCH] Hyphenation of Uppercase Words, Combined with Underlines
[ https://issues.apache.org/jira/browse/FOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582654#comment-13582654 ] Luis Bernardo commented on FOP-2044: patch 12563269 (above) applied: http://svn.apache.org/viewvc?view=revisionrevision=1448469. not resolving issue yet since I think comment from 2013-01-27 should be addressed. [PATCH] Hyphenation of Uppercase Words, Combined with Underlines Key: FOP-2044 URL: https://issues.apache.org/jira/browse/FOP-2044 Project: Fop Issue Type: Improvement Components: general Affects Versions: 1.0 Environment: Operating System: All Platform: All Reporter: Thomas Schraitle Assignee: Robert Meyer Attachments: output.pdf, patch.diff, uppercase-hyphen.fo, uppercase-hyphen.pdf Consider the attached FO file which combines words of lowercase and uppercase letters. As it is expected, the word expected is hyphenated correctly (example 2). Also the uppercase SUCCESS. Even combined with underlines before and after the word (see example 4 and 5). However, if there is another word (like OCF_SUCCESS) the word isn't hyphenated at all anymore. I don't know if this is an expected behaviour or an issue in the hyphenation patterns. Interestingly, XEP from RenderX hyphenates it as OCF_SUC-CESS. As far as I know, they use also the TeX hyphenation patterns as FOP. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FOP-2044) [PATCH] Hyphenation of Uppercase Words, Combined with Underlines
[ https://issues.apache.org/jira/browse/FOP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13563699#comment-13563699 ] Luis Bernardo commented on FOP-2044: the patch is a bit involved but seems to work well. but I am not sure the behavior implemented is the desired one in some corner cases. the implementation applies the remainCharCount and pushCharCount values (the minimum number of characters to allow before and after a break point) to all words when in my view should only apply to the beginning of the first and the end of the last words. an example: INFLATED_EGOS. I think INFLATED_E-GOS should be allowed but the patch does not allow because E-GOS is not allowed (if remainCharCount is 2). comments? [PATCH] Hyphenation of Uppercase Words, Combined with Underlines Key: FOP-2044 URL: https://issues.apache.org/jira/browse/FOP-2044 Project: Fop Issue Type: Improvement Components: general Affects Versions: 1.0 Environment: Operating System: All Platform: All Reporter: Thomas Schraitle Assignee: Robert Meyer Attachments: output.pdf, patch.diff, uppercase-hyphen.fo, uppercase-hyphen.pdf Consider the attached FO file which combines words of lowercase and uppercase letters. As it is expected, the word expected is hyphenated correctly (example 2). Also the uppercase SUCCESS. Even combined with underlines before and after the word (see example 4 and 5). However, if there is another word (like OCF_SUCCESS) the word isn't hyphenated at all anymore. I don't know if this is an expected behaviour or an issue in the hyphenation patterns. Interestingly, XEP from RenderX hyphenates it as OCF_SUC-CESS. As far as I know, they use also the TeX hyphenation patterns as FOP. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
