RE: [VOTE] Move all hyphenation patterns to offo.sourceforge.net
-Original Message-
From: Simon Pepping [mailto:[EMAIL PROTECTED]
When the jar is built by ant it should end up as
'${FOP_HOME}/build/fop-hyph.jar'. When it is downloaded from
elsewhere, '${FOP_HOME}/lib/fop-hyph.jar' would be a good place. All
jars in lib are added to the classpath by fop.sh.
Yes, in fop.sh this is achieved by looping over all the jars present in the
lib directory. In the Windows batch script, however, all the jars to be
picked up are specified individually... and just having attempted to mimic
the loop in the Win batch script, I can see why this is the case... the
environment variable's value is resolved only once, at the start of the
for-loop, so the different jars each get appended to the original value of
LOCALCLASSPATH.
Not that big a deal, but this means that Windows users can't rename this jar
into whatever they fancy. Unless they use Cygwin, they should either stick
to the name 'fop-hyph.jar', or add the jar to the classpath themselves
(maybe by using the FOP_HYPHENATION_PATH variable: see below)
If the user has a variable FOP_HYPHENATION_PATH, then that
should be added to the classpath.
Good idea. I've conveniently supposed that this environment variable should
contain all custom locations of the jars (not merely the directories to look
in, but the full paths to the jars themselves).
Cheers,
Andreas
RE: [VOTE] Move all hyphenation patterns to offo.sourceforge.net
-Original Message-
From: Andreas L. Delmelle [mailto:[EMAIL PROTECTED]
snip /
As for the build targets: so we don't remove these, but it
seems we definitely could/should tweak these to accomodate
the creation of the JAR that will be offered through OFFO,
What I did so far (locally):
Modified the 'package' build target to deliver two separate JARs, say
fop.jar and fop-hyph.jar (added 'hyphenation-jar' target to its
dependencies)
The latter JAR can be rebuilt separately by putting the desired hyphenation
source files into ${FOP_HOME}/hyph and running Ant with the
'hyphenation-jar' build target.
Have the scripts --.bat and .sh-- append '${FOP_HOME}/build/fop-hyph.jar' to
the local CLASSPATH. I'm not too sure about the location here: is 'build'
OK, or should we dump it in the 'lib' folder, or just the 'hyph' folder?
In any case, we no longer provide hyphenation out-of-the-box, but using it
becomes fairly straightforward...
The instructions toward the end-user:
- either download precompiled 'fop-hyph.jar' from OFFO
and place it in the build-dir (or the lib-dir? or hyph-dir?)
- or download the separate XML sources for the needed patterns,
and run 'ant hyphenation-jar' which will create the JAR in
the right place so it's picked up on the next run
If they really want to, they can use multiple hyphenation JARs as long as
they make sure they are all included in the CLASSPATH when running FOP. The
base 'fop-hyph.jar' can be used as a reference for the users to point out
what needs to be done.
We can still provide the option of using uncompiled patterns directly at
runtime, but IMO it would be better to present this as an option for
one-time usage, or to test a particular pattern before adding it to a JAR in
its compiled form.
Further comments always welcome.
Cheers,
Andreas
Re: [VOTE] Move all hyphenation patterns to offo.sourceforge.net
On Fri, 18 Mar 2005 11:50:31 +, Chris Bowditch
[EMAIL PROTECTED] wrote:
Andreas L. Delmelle wrote:
snip/
Have the scripts --.bat and .sh-- append '${FOP_HOME}/build/fop-hyph.jar' to
the local CLASSPATH. I'm not too sure about the location here: is 'build'
OK, or should we dump it in the 'lib' folder, or just the 'hyph' folder?
I think this should be the hyph folder. ll files relating to hypenation are
then kept in the one directory.
snip/
Chris
RE: [VOTE] Move all hyphenation patterns to offo.sourceforge.net
-Original Message-
From: Chris Bowditch [mailto:[EMAIL PROTECTED]
Andreas L. Delmelle wrote:
snip/
Have the scripts --.bat and .sh-- append
'${FOP_HOME}/build/fop-hyph.jar' to
the local CLASSPATH. I'm not too sure about the location here:
is 'build'
OK, or should we dump it in the 'lib' folder, or just the 'hyph' folder?
I think this should be the hyph folder. ll files relating to
hypenation are then kept in the one directory.
Seems the better option indeed. (Currently the files relating to hyphenation
are kept in the 'src/hyph' directory, but this directory and its contents
will be removed. The 'hyph' directory will be present but empty in the
distributions and the repository, as the contents will be provided through
OFFO)
Andreas
Re: [VOTE] Move all hyphenation patterns to offo.sourceforge.net
On 17.03.2005 11:00:15 Andreas L. Delmelle wrote: -Original Message- From: Andreas L. Delmelle [mailto:[EMAIL PROTECTED] -Original Message- From: Simon Pepping [mailto:[EMAIL PROTECTED] ... The work to be done is: adapt the page hyphenation.html to the new situation, I'll have a closer look at FOP's hyphenation page later tonight. Proposal, IIC, is to remove the distinction between 'Standard' and 'Custom' hyphenation support, leading to a structure: - Hyphenation Support - Introduction: small adjustment to the paragraph, offering a link to OFFO here - Licensing Issues: not sure, but I'd keep this just as a reminder... Good thinking. Users should be reminded that they have to be careful, although it's less a problem for them than for the ASF. - Sources: no change required - Installing: should basically come down to a) making sure the JAR containing the hyphenation patterns is accessible to FOP, I read: make sure hyphenation patterns in an additional JAR is detected by FOP. Right? or b) making the XML available via the userconfig. You mean the uncompiled hyphenation XMLs? Not sure here. The principles will remain the same for the OOo patterns. In any case, the option of having the patterns picked up when rebuilding FOP is no longer the general use case (only if the distribution jar is out of sync with the checked out version of FOP, and even then... see below: build targets) - Hyphenation Patterns A few modifications required + when support is available, add some details about the specifics of the OOo patterns... As for the build targets: so we don't remove these, but it seems we definitely could/should tweak these to accomodate the creation of the JAR that will be offered through OFFO, via a command like 'ant hyphenation-jar', so that eventually, end-users can use this build target to compile their own hyphenation-only JARs containing only the patterns they need and want to use... Sounds better, agreed? Yes. I'll see what I can get done before the weekend (see yesterday's mail from infrastructure@), else the commits will have to wait until next week. Sounds good to me. Thanks for taking the ball! And BTW, it's good to have you active again!!! Jeremias Maerki
Re: [VOTE] Move all hyphenation patterns to offo.sourceforge.net
On Thu, Mar 17, 2005 at 04:02:00PM +0100, Jeremias Maerki wrote: On 17.03.2005 15:02:02 Andreas L. Delmelle wrote: or b) making the XML available via the userconfig. You mean the uncompiled hyphenation XMLs? Not sure here. Yes, I wasn't sure of it myself... Ultimately, a hyph-only JAR containing only compiled patterns would render this approach obsolete --suboptimal at the very least. In that case, the userconfig page might need a small update too; the hyphenation-dir setting can be dropped. I don't think it would render it obsolete. Automatic compilation of the hyphenation patterns could be seen as user-friendly. Fewer things to do. Just a thought. It's secondary anyway. FOP is able to compile FOP-format hyphenation patterns at run time, and use the result during that run. No compiled file is written. The HEAD code does currently not listen to any user configuration to find those files. hyphenation-dir is observed in fop-0.20. In principle it would be nice to restore this behaviour, and to extend it to OOo-format patterns. But it is certainly secondary. Regards, Simon -- Simon Pepping home page: http://www.leverkruid.nl
