[Bug 53502] [PATCH] AFP images without a matching end-structured field ID would cause errors

https://issues.apache.org/bugzilla/show_bug.cgi?id=53502 Mehdi Houshmand changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 53502] [PATCH] AFP images without a matching end-structured field ID would cause errors

https://issues.apache.org/bugzilla/show_bug.cgi?id=53502 --- Comment #4 from Mehdi Houshmand --- Robert, could you take a look at the commit, if you're happy with it could you close this bug. Thanks -- You are receiving this mail because: You are the assignee for the bug.

Re: [VOTE] Merge Temp_URI_Unification

On 3 July 2012 15:48, Vincent Hennebert wrote: > I had started to build up a list of questions and comments but didn’t > get round to finishing it in time. Anyway, here it is, hopefully it will > still provide valuable feedback. The most important items to address are > the possible regression re

[Bug 53502] [PATCH] AFP images without a matching end-structured field ID would cause errors

https://issues.apache.org/bugzilla/show_bug.cgi?id=53502 Robert Meyer changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #5 from Robert M

Re: [VOTE] Merge Temp_URI_Unification

Just a few amendments: - File.createTempFile(...) failed the unit tests and I didn't have time to investigate why, this could be done in the future, though I'm not sure the pros/cons of doing so. - The method signature change getBaseURI -> getBaseDirectoryURI wasn't done. After speaking to PH, it

Re: svn commit: r1357110 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/afp/util/ test/java/org/apache/fop/afp/

Mehdi, When applying a patch submitted by a contributor, you must put his name in the log message. Also, it’s good practice to refer to the Bugzilla number. And also add an entry to the status.xml file. Thanks, Vincent On 04/07/12 08:04, mehdi wrote: > Author: mehdi > Date: Wed Jul 4 07:04:03

Re: svn propchange: r1357110 - svn:log

Sorry for the spam guys, I didn't realise an svn prop change didn't require a commit. On 4 July 2012 11:41, wrote: > Author: mehdi > Revision: 1357110 > Modified property: svn:log > > Modified: svn:log at Wed Jul 4 10:41:54 2012 > > --

Re: svn commit: r1356757 - /infrastructure/site-tools/trunk/projects/files.xml

Firefox now complains: Error loading stylesheet: A network error occurred loading an XSLT stylesheet:http://xmlgraphics.apache.org/xsl/p2.xsl This probably won't affect the project build, but it does affect users wishing to examine the DOAP link. When you have fixed this, you can re-enable the e

Re: svn commit: r1356757 - /infrastructure/site-tools/trunk/projects/files.xml

The file http://xmlgraphics.apache.org/fop/doap.rdf is still showing as broken when I view it in Firefox and Opera. (Chrome just downloads it). When that works, it may be worth re-enabling the entry. On 3 July 2012 20:57, Glenn Adams wrote: > I've applied a fix at > http://svn.apache.org/viewv

Re: [VOTE] Merge Temp_URI_Unification

One thing I forgot to mention: this work deserves its entry in the status.xml file, with importance set to ‘high’. On 04/07/12 08:38, mehdi houshmand wrote: > On 3 July 2012 15:48, Vincent Hennebert wrote: >> The new classes FopConfParser, FopFactoryBuilder and FopFactoryConfig >> should be rena

Re: svn commit: r1356757 - /infrastructure/site-tools/trunk/projects/files.xml

On 04/07/2012 05:30, Glenn Adams wrote: Sebb- Thanks for reporting. Glenn - Thanks for fixing. On Tue, Jul 3, 2012 at 6:52 PM, sebb AT ASF wrote: Firefox now complains: Error loading stylesheet: A network error occurred loading an XSLT stylesheet:http://xmlgraphics.apache.org/xsl/p2.xsl Thi

Re: [VOTE] Merge Temp_URI_Unification

On 4 July 2012 12:32, Vincent Hennebert wrote: > One thing I forgot to mention: this work deserves its entry in the > status.xml file, with importance set to ‘high’. > > Let me insist on that one. The inconsistency is actually introduced by > Fop classes. Before the merge there were 14 classes h

Re: [VOTE] Merge Temp_URI_Unification

On Wed, Jul 4, 2012 at 9:25 AM, mehdi houshmand wrote: > On 4 July 2012 12:32, Vincent Hennebert wrote: > >> >> There does seem to be a regression. Before, the FopFactoryConfigurator >> object was getting the strict-validation element from the config file >> and calling FopFactory.setStrictValid

Re: [VOTE] Merge Temp_URI_Unification

On 04/07/2012 17:15, Glenn Adams wrote: On Wed, Jul 4, 2012 at 9:25 AM, mehdi houshmand > wrote: On 4 July 2012 12:32, Vincent Hennebert mailto:vhenneb...@gmail.com>> wrote: There does seem to be a regression. Before, the FopFactoryConfigurator

Re: [VOTE] Merge Temp_URI_Unification

I'm a bit confused... Am I correct that this [VOTE] relates to merging the Temp_URI_Unification to fop/trunk and not to FOP-1.1rc*? If so, then +1 and if not then +0 since I don't quite understand... (not blocker, but not enough info for me to +1... ;-) Kind regards, Clay Leeds -- -

Re: [VOTE] Merge Temp_URI_Unification

I wouldn't worry Clay, I'm not sure I really know what this thread is about any more either. Either way, it's been merged but thanks for your support. The fix of this regression is easy, I'll fix it in the morning. On 4 July 2012 18:32, The Web Maestro wrote: > I'm a bit confused... Am I correc

Re: [VOTE] Merge Temp_URI_Unification

Thanks! Happy Fourth (it's still the 4th even outside the U.S. ;-)! Thanks for your efforts all! "My religion is simple. My religion is kindness." - HH The Dalai Lama of Tibet On Jul 4, 2012, at 11:35 AM, mehdi houshmand wrote: > I wouldn't worry Clay, I'm not sure I really know what this thre

git-svn doesn't update svn:mergeinfo

Thanks Vincent for pointing out the problem with performing merges on git side then using git-svn dcommit back to SVN repo. I've investigated this further, and indeed, git-svn does not update svn:mergeinfo or any other SVN properties, so doing merges on the git side will be problematic. I will use

new deprecation warnings in trunk

Mehdi, Please fix the following new deprecation warnings in trunk: junit-compile-java: [mkdir] Created dir: /Users/glenn/Work/xmlgraphics/fop/trunk/build/test-classes [mkdir] Created dir: /Users/glenn/Work/xmlgraphics/fop/trunk/build/test-gensrc [mkdir] Created dir: /Users/glenn/Work/x

new javadoc warnings in trunk

I'm now getting 98 new warnings when running "ant javadocs" on trunk: [javadoc] Building tree for all the packages and classes... [javadoc] /Users/glenn/Work/xmlgraphics/fop/trunk/src/java/org/apache/fop/afp/AFPResourceLevel.java:89: warning - @param argument "level" is not a parameter name.

Re: [VOTE] Merge Temp_URI_Unification

> > Let me insist on that one. The inconsistency is actually introduced by > Fop classes. Before the merge there were 14 classes having FOP in their > names, vs 6 having Fop. Also, the product name is FOP, not Fop, and that > should be reflected in the class names. > > I still don't agree, it's n

Re: git-svn doesn't update svn:mergeinfo

Hi Glenn, Well actually git-svn has an option to update the svn:mergeinfo. It might be worth giving it a try. There are some restrictions and I suggest to test it first. The following is part of $ man git-svn --mergeinfo= Add the given merge information during the dcom

Re: git-svn doesn't update svn:mergeinfo

On Wed, Jul 4, 2012 at 3:54 PM, Alexios Giotis wrote: > Well actually git-svn has an option to update the svn:mergeinfo. It might > be worth giving it a try. There are some restrictions and I suggest to test > it first. The following is part of $ man git-svn > > > --mergeinfo= >

Re: [VOTE] Merge Temp_URI_Unification

Hi Chris/Glenn/Anyone else, You say command-line options should override the fop.xconf values, which makes sense. But should not-given command-line options override fop.xconf values too? Bare with me here, there is sense in the folly of that sentence. Ok, so let's take the example above, with stri