RE: Area tree format improvements
On 2016-08-07 Glenn Adams wrote: > On 2016-08-07 Jan Tosovsky wrote: > > On 2016-08-05 Glenn Adams wrote: > > > On 2016-08-04 Jan Tosovsky wrote: > > > > > > > > when implementing change bars I encountered problem with > > > > proper storing the change bar info using the current Area > > > > Tree vocabulary: > > > > https://issues.apache.org/jira/browse/FOP-2640 > > > > > > > > Is it Ok to extend the curent element set? > > > > > > Firstly, the AT (area tree) output format is really only > > > used for testing these days... > > > > I've implemented a new element named inlineBlock extending > > InlineParent which wraps the standard Block element. It is > > parsed without errors and still generates a proper IF format. > > > > However, as it can be tested on change bar element only, not > > yet in the trunk, I prefer incorporating this change to change > > bar patch https://issues.apache.org/jira/browse/FOP-1760 > > You would need to submit the patch as an attachment, then it will > require an FOP committer to evaluate it. > I've updated patch for change bars (FOP-1760) incorporating proposed changes. Jan
Re: Area tree format improvements
On Sun, Aug 7, 2016 at 12:40 PM, Jan Tosovsky wrote: > On 2016-08-05 Glenn Adams wrote: > > On 2016-08-04 Jan Tosovsky wrote: > > > > > > when implementing change bars I encountered problem with > > > proper storing the change bar info using the current Area Tree > > > vocabulary: https://issues.apache.org/jira/browse/FOP-2640 > > > > > > Is it Ok to extend the curent element set? > > > > Firstly, the AT (area tree) output format is really only used > > for testing these days... > > > > I've implemented a new element named inlineBlock extending InlineParent > which wraps the standard Block element. It is parsed without errors and > still generates a proper IF format. > > However, as it can be tested on change bar element only, not yet in the > trunk, I prefer incorporating this change to change bar patch > https://issues.apache.org/jira/browse/FOP-1760 (the current patch without > this change will fail anyway when tests are properly run). > > Is it Ok? > You would need to submit the patch as an attachment, then it will require an FOP committer to evaluate it. > > Jan > > > > >
RE: Area tree format improvements
On 2016-08-05 Glenn Adams wrote: > On 2016-08-04 Jan Tosovsky wrote: > > > > when implementing change bars I encountered problem with > > proper storing the change bar info using the current Area Tree > > vocabulary: https://issues.apache.org/jira/browse/FOP-2640 > > > > Is it Ok to extend the curent element set? > > Firstly, the AT (area tree) output format is really only used > for testing these days... > I've implemented a new element named inlineBlock extending InlineParent which wraps the standard Block element. It is parsed without errors and still generates a proper IF format. However, as it can be tested on change bar element only, not yet in the trunk, I prefer incorporating this change to change bar patch https://issues.apache.org/jira/browse/FOP-1760 (the current patch without this change will fail anyway when tests are properly run). Is it Ok? Jan
Re: Area tree format improvements
Firstly, the AT (area tree) output format is really only used for testing these days. You should be looking at the IF (intermediate format) output format, which presently drives all the rendering modules. Whether a proposed patch is accepted or not depends a great deal on its quality, appropriateness, completeness (e.g., whether testing is included), and architectural soundness. If it fails these in a significant way, it would likely not be accepted into trunk. On Thu, Aug 4, 2016 at 3:40 PM, Jan Tosovsky wrote: > Dear All, > > when implementing change bars I encountered problem with proper storing the > change bar info using the current Area Tree vocabulary: > > https://issues.apache.org/jira/browse/FOP-2640 > > Is it Ok to extend the curent element set? Can I propose a patch or does > any > changes to Area Tree need any approval in advance? > > Thanks, > > Jan > >
Area tree format improvements
Dear All, when implementing change bars I encountered problem with proper storing the change bar info using the current Area Tree vocabulary: https://issues.apache.org/jira/browse/FOP-2640 Is it Ok to extend the curent element set? Can I propose a patch or does any changes to Area Tree need any approval in advance? Thanks, Jan