DO NOT REPLY [Bug 45113] [PATCH] Adding PDF Launch Action
https://issues.apache.org/bugzilla/show_bug.cgi?id=45113 Glenn Adams changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #8 from Glenn Adams 2012-04-01 06:50:06 UTC --- batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 45113] [PATCH] Adding PDF Launch Action
https://issues.apache.org/bugzilla/show_bug.cgi?id=45113 --- Comment #7 from Andreas L. Delmelle <[EMAIL PROTECTED]> 2008-10-26 09:35:19 PST --- Forgot to include the link to the SVN revision: http://svn.apache.org/viewvc?rev=708012&view=rev -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 45113] [PATCH] Adding PDF Launch Action
https://issues.apache.org/bugzilla/show_bug.cgi?id=45113 Andreas L. Delmelle <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #6 from Andreas L. Delmelle <[EMAIL PROTECTED]> 2008-10-26 09:33:54 PST --- Patch (finally) applied to FOP Trunk. Thanks for the input, Alexander! Hope to receive some more in the future. ;-) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 45113] [PATCH] Adding PDF Launch Action
https://issues.apache.org/bugzilla/show_bug.cgi?id=45113 --- Comment #5 from Jeremias Maerki <[EMAIL PROTECTED]> 2008-10-22 01:03:42 PST --- (In reply to comment #4) > I sent my ICLA to [EMAIL PROTECTED] as a scan. > Confirmed. ICLA is on file. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 45113] [PATCH] Adding PDF Launch Action
https://issues.apache.org/bugzilla/show_bug.cgi?id=45113 --- Comment #4 from Alexander Stamenov <[EMAIL PROTECTED]> 2008-10-22 00:58:40 PST --- I sent my ICLA to [EMAIL PROTECTED] as a scan. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 45113] [PATCH] Adding PDF Launch Action
https://issues.apache.org/bugzilla/show_bug.cgi?id=45113 --- Comment #3 from Andreas L. Delmelle <[EMAIL PROTECTED]> 2008-09-19 12:22:51 PST --- Hi Alexander, Apologies for the rather long delay. I'm afraid I lost track of this... :-( I finally found some time to play with it, and it seems that the following would fail: file:///path/to/link_target.pdf#dest=name OTOH, looking closer, this has nothing to do with your patch, I believe. Using an absolute file-URI with a destination appended simply fails. Using a relative URI with a destination always works. Using an absolute URI without a destination didn't work before your patch, but using the /Launch action seems to correct this. I'm inclined to go ahead with the commit. Since it contains one new file, however small, as I mentioned earlier, an ICLA should best be submitted (see: http://www.apache.org/licenses/#clas). That is, if you intend on continuing to supply us with patches in the future... I promise, it does not always take this long to process a bug. ;-) Can you let us know when this is done, so we can follow up? Thanks Andreas -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 45113] [PATCH] Adding PDF Launch Action
https://issues.apache.org/bugzilla/show_bug.cgi?id=45113 --- Comment #2 from Alexander Stamenov <[EMAIL PROTECTED]> 2008-06-02 11:13:09 PST --- (In reply to comment #1) > Interesting! Thanks for the patch. > > The only thing I'm wondering about is the order of the tests in PDFFactory: > after your change, /all/ URIs using the file-protocol will generate a /Launch > action. If I'm correct, the test for the .pdf extension should happen first > (?) I am glad you find this patch useful. At first I added this check as penultimate in order to honor the special treatment of PDFs. After that I decided that specifying the protocol has to be with more weight. But I think this is the place for people more involved in the project to decide that particular order. > Since it does include one new file, we have to ask: > Does Apache already have your ICLA on file from contributions to other > projects? The short answer is no. Actually it is now that I understand for the ICLA. I found this addition very small so if it is ok with the community I have no objections to contribute this code without the ICLA. If any further documenting is needed to meet any criteria I am willing to do it. After all this will be my first contribution to an open source project. :) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
DO NOT REPLY [Bug 45113] [PATCH] Adding PDF Launch Action
https://issues.apache.org/bugzilla/show_bug.cgi?id=45113 Andreas L. Delmelle <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Andreas L. Delmelle <[EMAIL PROTECTED]> 2008-06-02 10:50:01 PST --- Interesting! Thanks for the patch. The only thing I'm wondering about is the order of the tests in PDFFactory: after your change, /all/ URIs using the file-protocol will generate a /Launch action. If I'm correct, the test for the .pdf extension should happen first (?) Since it does include one new file, we have to ask: Does Apache already have your ICLA on file from contributions to other projects? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug.
