Re: [VOTE] Merge Temp_TrueTypeInPostScript branch into trunk
+1 On Mon, Jun 18, 2012 at 12:02 PM, Chris Bowditch wrote: > On 15/06/2012 11:25, Vincent Hennebert wrote: >> >> As you may have noticed, I’ve recently spent some time updating the >> Temp_TrueTypeInPostScript branch to the latest trunk and doing some >> clean-up (thanks to Robert for updating the testcases to JUnit 4). >> >> We have been using the code from this branch for quite a while now and >> it has proven to work reasonably well. I won’t hide the fact that some >> parts of the code are truly ugly (in PSFontUtils mainly), but it’s not >> possible to clean that up without heavily refactoring the font >> sub-system, which I unfortunately can’t spend time on right now. At >> least the ugliness is fairly self-contained. Meanwhile some users may >> find the additional functionality useful. >> >> So I’d like to propose a vote for merging that branch back to Trunk. The >> vote will run until Thursday 21st, 8:00GMT. >> >> Here’s my +1. > > > +1. Good work Vincent and Rob on cleaning up this old branch. The > functionality is long overdue in a publicly released version of FOP. > > Chris > >> >> Thanks, >> Vincent >> >> >
Re: [VOTE] Merge Temp_TrueTypeInPostScript branch into trunk
On 15/06/2012 11:25, Vincent Hennebert wrote: As you may have noticed, I’ve recently spent some time updating the Temp_TrueTypeInPostScript branch to the latest trunk and doing some clean-up (thanks to Robert for updating the testcases to JUnit 4). We have been using the code from this branch for quite a while now and it has proven to work reasonably well. I won’t hide the fact that some parts of the code are truly ugly (in PSFontUtils mainly), but it’s not possible to clean that up without heavily refactoring the font sub-system, which I unfortunately can’t spend time on right now. At least the ugliness is fairly self-contained. Meanwhile some users may find the additional functionality useful. So I’d like to propose a vote for merging that branch back to Trunk. The vote will run until Thursday 21st, 8:00GMT. Here’s my +1. +1. Good work Vincent and Rob on cleaning up this old branch. The functionality is long overdue in a publicly released version of FOP. Chris Thanks, Vincent
Re: [VOTE] Merge Temp_TrueTypeInPostScript branch into trunk
+1 On 15 June 2012 16:15, Clay Leeds wrote: > I was going to say that Pascal had a good point, and that it was really up > to Glenn. > > +1 from me > > "My religion is simple. My religion is kindness." > - HH The Dalai Lama of Tibet > > On Jun 15, 2012, at 6:00 AM, Pascal Sancho wrote: > > > Ok, > > then... > > +1 for me > > > > 2012/6/15 Glenn Adams : > >> If Vincent would like this in the 1.1 release, then I'm in favor of a > merge > >> to trunk. So I'd say +1. > >> > >> > >> On Fri, Jun 15, 2012 at 5:29 AM, Pascal Sancho > >> wrote: > >>> > >>> Hi, > >>> > >>> Since Glenn is in the process to release the FOP v1.1, I'm not sure > >>> it's time to merge such branch to trunk. > >>> I guess this new feature will not be part of the 1.1 release. > >>> > >>> If merging have to be done quickly, then we should create a 1.1 > >>> maintenance branch to ensure that merging will not affect the > >>> releasing process. > >>> > >>> Or if this new feature have to be part of the 1.1 release, then > >>> perhaps we have to delay the release process *after* this merge. > >>> > >>> any thought? > >>> > >>> 2012/6/15 Vincent Hennebert : > As you may have noticed, I’ve recently spent some time updating the > Temp_TrueTypeInPostScript branch to the latest trunk and doing some > clean-up (thanks to Robert for updating the testcases to JUnit 4). > > We have been using the code from this branch for quite a while now and > it has proven to work reasonably well. I won’t hide the fact that some > parts of the code are truly ugly (in PSFontUtils mainly), but it’s not > possible to clean that up without heavily refactoring the font > sub-system, which I unfortunately can’t spend time on right now. At > least the ugliness is fairly self-contained. Meanwhile some users may > find the additional functionality useful. > > So I’d like to propose a vote for merging that branch back to Trunk. > The > vote will run until Thursday 21st, 8:00GMT. > > Here’s my +1. > > Thanks, > Vincent > > > > -- > > pascal >
Re: [VOTE] Merge Temp_TrueTypeInPostScript branch into trunk
I was going to say that Pascal had a good point, and that it was really up to Glenn. +1 from me "My religion is simple. My religion is kindness." - HH The Dalai Lama of Tibet On Jun 15, 2012, at 6:00 AM, Pascal Sancho wrote: > Ok, > then... > +1 for me > > 2012/6/15 Glenn Adams : >> If Vincent would like this in the 1.1 release, then I'm in favor of a merge >> to trunk. So I'd say +1. >> >> >> On Fri, Jun 15, 2012 at 5:29 AM, Pascal Sancho >> wrote: >>> >>> Hi, >>> >>> Since Glenn is in the process to release the FOP v1.1, I'm not sure >>> it's time to merge such branch to trunk. >>> I guess this new feature will not be part of the 1.1 release. >>> >>> If merging have to be done quickly, then we should create a 1.1 >>> maintenance branch to ensure that merging will not affect the >>> releasing process. >>> >>> Or if this new feature have to be part of the 1.1 release, then >>> perhaps we have to delay the release process *after* this merge. >>> >>> any thought? >>> >>> 2012/6/15 Vincent Hennebert : As you may have noticed, I’ve recently spent some time updating the Temp_TrueTypeInPostScript branch to the latest trunk and doing some clean-up (thanks to Robert for updating the testcases to JUnit 4). We have been using the code from this branch for quite a while now and it has proven to work reasonably well. I won’t hide the fact that some parts of the code are truly ugly (in PSFontUtils mainly), but it’s not possible to clean that up without heavily refactoring the font sub-system, which I unfortunately can’t spend time on right now. At least the ugliness is fairly self-contained. Meanwhile some users may find the additional functionality useful. So I’d like to propose a vote for merging that branch back to Trunk. The vote will run until Thursday 21st, 8:00GMT. Here’s my +1. Thanks, Vincent > > -- > pascal
Re: [VOTE] Merge Temp_TrueTypeInPostScript branch into trunk
Ok, then... +1 for me 2012/6/15 Glenn Adams : > If Vincent would like this in the 1.1 release, then I'm in favor of a merge > to trunk. So I'd say +1. > > > On Fri, Jun 15, 2012 at 5:29 AM, Pascal Sancho > wrote: >> >> Hi, >> >> Since Glenn is in the process to release the FOP v1.1, I'm not sure >> it's time to merge such branch to trunk. >> I guess this new feature will not be part of the 1.1 release. >> >> If merging have to be done quickly, then we should create a 1.1 >> maintenance branch to ensure that merging will not affect the >> releasing process. >> >> Or if this new feature have to be part of the 1.1 release, then >> perhaps we have to delay the release process *after* this merge. >> >> any thought? >> >> 2012/6/15 Vincent Hennebert : >> > As you may have noticed, I’ve recently spent some time updating the >> > Temp_TrueTypeInPostScript branch to the latest trunk and doing some >> > clean-up (thanks to Robert for updating the testcases to JUnit 4). >> > >> > We have been using the code from this branch for quite a while now and >> > it has proven to work reasonably well. I won’t hide the fact that some >> > parts of the code are truly ugly (in PSFontUtils mainly), but it’s not >> > possible to clean that up without heavily refactoring the font >> > sub-system, which I unfortunately can’t spend time on right now. At >> > least the ugliness is fairly self-contained. Meanwhile some users may >> > find the additional functionality useful. >> > >> > So I’d like to propose a vote for merging that branch back to Trunk. The >> > vote will run until Thursday 21st, 8:00GMT. >> > >> > Here’s my +1. >> > >> > Thanks, >> > Vincent -- pascal
Re: [VOTE] Merge Temp_TrueTypeInPostScript branch into trunk
If Vincent would like this in the 1.1 release, then I'm in favor of a merge to trunk. So I'd say +1. On Fri, Jun 15, 2012 at 5:29 AM, Pascal Sancho wrote: > Hi, > > Since Glenn is in the process to release the FOP v1.1, I'm not sure > it's time to merge such branch to trunk. > I guess this new feature will not be part of the 1.1 release. > > If merging have to be done quickly, then we should create a 1.1 > maintenance branch to ensure that merging will not affect the > releasing process. > > Or if this new feature have to be part of the 1.1 release, then > perhaps we have to delay the release process *after* this merge. > > any thought? > > 2012/6/15 Vincent Hennebert : > > As you may have noticed, I’ve recently spent some time updating the > > Temp_TrueTypeInPostScript branch to the latest trunk and doing some > > clean-up (thanks to Robert for updating the testcases to JUnit 4). > > > > We have been using the code from this branch for quite a while now and > > it has proven to work reasonably well. I won’t hide the fact that some > > parts of the code are truly ugly (in PSFontUtils mainly), but it’s not > > possible to clean that up without heavily refactoring the font > > sub-system, which I unfortunately can’t spend time on right now. At > > least the ugliness is fairly self-contained. Meanwhile some users may > > find the additional functionality useful. > > > > So I’d like to propose a vote for merging that branch back to Trunk. The > > vote will run until Thursday 21st, 8:00GMT. > > > > Here’s my +1. > > > > Thanks, > > Vincent > > > > -- > pascal >
Re: [VOTE] Merge Temp_TrueTypeInPostScript branch into trunk
Hi, Since Glenn is in the process to release the FOP v1.1, I'm not sure it's time to merge such branch to trunk. I guess this new feature will not be part of the 1.1 release. If merging have to be done quickly, then we should create a 1.1 maintenance branch to ensure that merging will not affect the releasing process. Or if this new feature have to be part of the 1.1 release, then perhaps we have to delay the release process *after* this merge. any thought? 2012/6/15 Vincent Hennebert : > As you may have noticed, I’ve recently spent some time updating the > Temp_TrueTypeInPostScript branch to the latest trunk and doing some > clean-up (thanks to Robert for updating the testcases to JUnit 4). > > We have been using the code from this branch for quite a while now and > it has proven to work reasonably well. I won’t hide the fact that some > parts of the code are truly ugly (in PSFontUtils mainly), but it’s not > possible to clean that up without heavily refactoring the font > sub-system, which I unfortunately can’t spend time on right now. At > least the ugliness is fairly self-contained. Meanwhile some users may > find the additional functionality useful. > > So I’d like to propose a vote for merging that branch back to Trunk. The > vote will run until Thursday 21st, 8:00GMT. > > Here’s my +1. > > Thanks, > Vincent -- pascal