Re: [VOTE] Release XML Graphics FOP 2.0 (2nd attempt)

2015-05-26 Thread Andreas Delmelle
+1 from me, too. ... and, you are all very welcome. :) Andreas > On 26 May 2015, at 15:31, Glenn Adams wrote: > > +1. Thanks for all the work on FB fixes. > > On Tue, May 26, 2015 at 2:33 AM, Simon Steiner > wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi, >> >> Thi

Re: [VOTE] Release XML Graphics FOP 2.0 (2nd attempt)

2015-05-26 Thread Glenn Adams
+1. Thanks for all the work on FB fixes. On Tue, May 26, 2015 at 2:33 AM, Simon Steiner wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > This is a vote to release XML Graphics FOP 2.0. Findbugs is passing. > > Artifacts can be found there: > https://people.apache.org/~ssteine

Re: [VOTE] Release XML Graphics FOP 2.0 (2nd attempt)

2015-05-26 Thread Clay Leeds
+1 Cheers! Clay -- "My religion is simple. My religion is kindness." - HH The Dalai Lama of Tibet > On May 26, 2015, at 1:33 AM, Simon Steiner wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > This is a vote to release XML Graphics FOP 2.0. Findbugs is passing. > > Ar

Re: [VOTE] Release XML Graphics FOP 2.0 (2nd attempt)

2015-05-26 Thread Chris Bowditch
+1 On 26/05/2015 09:33, Simon Steiner wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, This is a vote to release XML Graphics FOP 2.0. Findbugs is passing. Artifacts can be found there: https://people.apache.org/~ssteiner/fop-2.0 The release is signed with the key: https://people.apa

Re: Fix FB warnings (was: Re: [VOTE] Release XML Graphics FOP 2.0)

2015-05-24 Thread Andreas Delmelle
> On 23 May 2015, at 23:15, Andreas Delmelle > wrote: > FYI - High and medium priority warnings addressed in r1681384, and absent an > answer to my question, assumed the lazy approach there, for now. > > Will try to have a look at the low priority ones tomorrow. ... and low priority warning

Fix FB warnings (was: Re: [VOTE] Release XML Graphics FOP 2.0)

2015-05-23 Thread Andreas Delmelle
> On 22 May 2015, at 22:36, Andreas Delmelle > wrote: > Is the convention then to insert the commented annotation once for every > field or does it suffice to add one per class? > > I am fine with both. Just thought I'd ask before committing to trunk. FYI - High and medium priority warnings

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-22 Thread Andreas Delmelle
> On 22 May 2015, at 17:04, Andreas Delmelle > wrote: > > Hi Simon > >> On 22 May 2015, at 12:59, Simon Steiner wrote: >> >> We have an old branch with findbugs passing I was going to port this to >> trunk. I realise now Simon's remark may have been referring to XGC, not to FOP (?) Or do w

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-22 Thread Andreas Delmelle
> On 21 May 2015, at 22:20, Andreas Delmelle > wrote: > > FWIW - Those 17 'high' priority "Reliance on default encoding" warnings are > definitely worth checking out. So far, I think the handful that I already > looked at can be safely added to the exclusions list, but this is *exactly* > the

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-22 Thread Andreas Delmelle
Hi Simon > On 22 May 2015, at 12:59, Simon Steiner wrote: > > We have an old branch with findbugs passing I was going to port this to > trunk. OK, sure. That works for me too. > > Findbugs 3 requires java 7 so we shouldn’t move to that yet. > Oh, I realize we cannot move to that, due to the

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-22 Thread Glenn Adams
nges, which one hopes does not introduce any regressions. > > Thanks > > -Original Message- > From: Andreas Delmelle [mailto:andreas.delme...@telenet.be] > Sent: 21 May 2015 19:48 > To: fop-dev@xmlgraphics.apache.org > Subject: Re: [VOTE] Release XML Graphics FOP 2.0

RE: [VOTE] Release XML Graphics FOP 2.0

2015-05-22 Thread Simon Steiner
Hi, We have an old branch with findbugs passing I was going to port this to trunk. Thanks -Original Message- From: Andreas Delmelle [mailto:andreas.delme...@telenet.be] Sent: 21 May 2015 19:48 To: fop-dev@xmlgraphics.apache.org Subject: Re: [VOTE] Release XML Graphics FOP 2.0 Hi guys

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Andreas Delmelle
> On 21 May 2015, at 20:47, Andreas Delmelle > wrote: > > > @Simon - > To relieve you of some of the burden, I am definitely willing to assist with > combing through those. How do I proceed? Do I commit related changes directly > to trunk, so that you can merge them into the branch later? F

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Andreas Delmelle
> On 21 May 2015, at 20:47, Andreas Delmelle > wrote: > > If everyone had committed to using it in the past, there would not be 143 > warnings to address right before the release... Correction: 124 warnings... Mixing up 167 - 124 = 43. :)

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Andreas Delmelle
Hi guys > On 21 May 2015, at 20:00, Glenn Adams wrote: > > I would prefer no findbugs warnings going into the release. I'm finding > more and more commercial uses of code have policies that require no > findbugs warnings. You can simply add entries to the findbugs-exclude.xml > file to disable t

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Glenn Adams
gt;> > >> FOP has 124 findbugs warnings: > >> > >> > >> > https://builds.apache.org/view/XMLGraphics/job/xmlgraphics-fop/ws/build/report_findbugs.html > >> > >> > >> > >> Thanks > >> > >> > >> >

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Clay Leeds
as 6 compiler warnings. >> >> >> >> FOP has 124 findbugs warnings: >> >> >> https://builds.apache.org/view/XMLGraphics/job/xmlgraphics-fop/ws/build/report_findbugs.html >> >> >> >> Thanks >> >> >> >> *From:* Glen

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Glenn Adams
> > > https://builds.apache.org/view/XMLGraphics/job/xmlgraphics-fop/ws/build/report_findbugs.html > > > > Thanks > > > > *From:* Glenn Adams [mailto:gl...@skynav.com] > *Sent:* 21 May 2015 18:06 > *To:* FOP Developers; XML Graphics Project > *Subject:* Re:

RE: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Simon Steiner
/report_findbugs.html Thanks From: Glenn Adams [mailto:gl...@skynav.com] Sent: 21 May 2015 18:06 To: FOP Developers; XML Graphics Project Subject: Re: [VOTE] Release XML Graphics FOP 2.0 Before you create the final artifact, please ensure there are no compiler, checkstyle, or findbugs warnings. Same

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Glenn Adams
Before you create the final artifact, please ensure there are no compiler, checkstyle, or findbugs warnings. Same applies for XGC 2.0.1. On Thu, May 21, 2015 at 7:39 AM, Glenn Adams wrote: > +1 > > On Thu, May 21, 2015 at 7:21 AM, Simon Steiner > wrote: > >> -BEGIN PGP SIGNED MESSAGE- >

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Andreas Delmelle
I forget whether this type of vote is for all committers or only the PMC, but saw Robert vote as well, so just to be sure +1 from me as well. Thanks, Simon! KR Andreas > On 21 May 2015, at 15:21, Simon Steiner wrote: > > Signed PGP part > Hi, > > This is a vote to release XML Graphics FO

RE: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Robert Meyer
+1 > Date: Thu, 21 May 2015 15:23:22 +0100 > From: bowditch_ch...@hotmail.com > To: gene...@xmlgraphics.apache.org > CC: fop-dev@xmlgraphics.apache.org > Subject: Re: [VOTE] Release XML Graphics FOP 2.0 > > +1. Thanks Simon > > On 21/05/2015 14:21, Simon Steiner wrote

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Chris Bowditch
+1. Thanks Simon On 21/05/2015 14:21, Simon Steiner wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, This is a vote to release XML Graphics FOP 2.0. Artifacts can be found there: https://people.apache.org/~ssteiner/fop-2.0 The release is signed with the key: https://people.apache.org

Re: [VOTE] Release XML Graphics FOP 2.0

2015-05-21 Thread Glenn Adams
+1 On Thu, May 21, 2015 at 7:21 AM, Simon Steiner wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hi, > > This is a vote to release XML Graphics FOP 2.0. > > Artifacts can be found there: > https://people.apache.org/~ssteiner/fop-2.0 > > The release is signed with the key: > https:/