Re: svn commit: r757382 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/layoutmgr/ElementListUtils.java test/layoutengine/standard-testcases/page-position-last_break-before_bugzilla46489.xml
On 23 Mar 2009, at 19:44, Vincent Hennebert wrote: It should have been indented 8 spaces instead of 4, like indicated a bit further down in the same document. ... and then it doesn't 'look' nice anymore. I agree. But since FOP’s checkstyle conventions allow lines of up to 100 characters, the line break could simply be removed. 100 chars makes sense. Just noticed that this is still comfortable in an IDE (if the font-size is not too large). Just hate horizontal scrolling... :-) 80 chars perhaps still points to old terminal screens or program- listings, where you get line-wrapping, which makes it all very difficult to read. Not that I can remember ever having sent a FOP source file to the printer, but anyway... Admitted, that's a bit of a stretch, since after your change the line is only 81 chars... :-) Just want to avoid that commits are done and redone, and redone... Since I was going to make the commit for the eol-style property anyway, I thought I’d include this small fix as well. OK, thanks. Checked in the meantime, and I had only set 'svn:keywords' for XML sources. Changed now, so shouldn't happen anymore. Later Andreas
Re: svn commit: r757382 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/layoutmgr/ElementListUtils.java test/layoutengine/standard-testcases/page-position-last_break-before_bugzilla46489.xml
Hi Andreas, Andreas Delmelle wrote: > On 23 Mar 2009, at 13:12, vhennebert wrote: > >> Author: vhennebert >> Date: Mon Mar 23 12:12:36 2009 >> New Revision: 757382 >> >> URL: http://svn.apache.org/viewvc?rev=757382&view=rev >> Log: >> Set svn:eol-style property on >> page-position-last_break-before_bugzilla46489.xml test case. >> Simplified it by removing superfluous content and references to fonts >> that are not available by default. > > Oops missed the property setting. Will have to check my SVN settings > (thought I had this configured correctly here...) > >> >> Fixed small indentation issue in ElementListUtils. > > Not to be a pest, but what's the issue exactly? I'm always trying to > keep the lines below a length of 80 characters (as recommended here: > http://java.sun.com/docs/codeconv/html/CodeConventions.doc3.html#313) It should have been indented 8 spaces instead of 4, like indicated a bit further down in the same document. But since FOP’s checkstyle conventions allow lines of up to 100 characters, the line break could simply be removed. > Admitted, that's a bit of a stretch, since after your change the line is > only 81 chars... :-) > > Just want to avoid that commits are done and redone, and redone... Since I was going to make the commit for the eol-style property anyway, I thought I’d include this small fix as well. Vincent
Re: svn commit: r757382 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/layoutmgr/ElementListUtils.java test/layoutengine/standard-testcases/page-position-last_break-before_bugzilla46489.xml
On 23 Mar 2009, at 13:12, vhenneb...@apache.org wrote: Author: vhennebert Date: Mon Mar 23 12:12:36 2009 New Revision: 757382 URL: http://svn.apache.org/viewvc?rev=757382&view=rev Log: Set svn:eol-style property on page-position-last_break- before_bugzilla46489.xml test case. Simplified it by removing superfluous content and references to fonts that are not available by default. Oops missed the property setting. Will have to check my SVN settings (thought I had this configured correctly here...) Fixed small indentation issue in ElementListUtils. Not to be a pest, but what's the issue exactly? I'm always trying to keep the lines below a length of 80 characters (as recommended here: http://java.sun.com/docs/codeconv/html/CodeConventions.doc3.html#313) Admitted, that's a bit of a stretch, since after your change the line is only 81 chars... :-) Just want to avoid that commits are done and redone, and redone... Cheers Andreas
