Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Jan Nijtmans
2014-03-05 7:51 GMT+01:00 Andy Bradford amb-fos...@bradfords.org: Also, clicking the button to reveal the non-whitespace change is no more ``correct'' than if Joel had instead changed ``Listening'' to ``listening'' on one of those lines. It would still show Joel as the ``author'' of that

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Stephan Beal
On Wed, Mar 5, 2014 at 10:08 AM, Jan Nijtmans jan.nijtm...@gmail.comwrote: 2014-03-05 7:51 GMT+01:00 Andy Bradford amb-fos...@bradfords.org: Also, clicking the button to reveal the non-whitespace change is no more ``correct'' than if Joel had instead changed ``Listening'' to

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Jan Nijtmans
2014-03-05 12:39 GMT+01:00 Stephan Beal sgb...@googlemail.com: On Wed, Mar 5, 2014 at 10:08 AM, Jan Nijtmans jan.nijtm...@gmail.com wrote: 2014-03-05 7:51 GMT+01:00 Andy Bradford amb-fos...@bradfords.org: Also, clicking the button to reveal the non-whitespace change is no more

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Martin Gagnon
Le 2014-03-05 04:08, Jan Nijtmans a écrit : 2014-03-05 7:51 GMT+01:00 Andy Bradford amb-fos...@bradfords.org: Also, clicking the button to reveal the non-whitespace change is no more ``correct'' than if Joel had instead changed ``Listening'' to ``listening'' on one of those lines. It

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Doug Franklin
On 2014-03-05 6:39, Stephan Beal wrote: By removing the if, Joel changed the semantics (not only the indentation) of the code. i would argue that he is indeed the one who should be blamed in that case. In Python, changing that indentation does indeed change the semantics. It changes which

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Andy Bradford
Thus said Jan Nijtmans on Wed, 05 Mar 2014 10:08:00 +0100: Sorry, I respectfully disagree. Changing Listening to listening is a real change inside the string, indentation (sol-whitespace) and eol-whitespace (such as \r preceding \n) is generally considered irrelevant for

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Stephan Beal
On Wed, Mar 5, 2014 at 4:44 PM, Andy Bradford amb-fos...@bradfords.orgwrote: With respect to what Fossil blame/annotate should be concerned about, I don't see any difference. Blame/annotate show a list of checkins that ...is designed to track changes ignore some changes by default?

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Joel Bruick
Jan Nijtmans wrote: Therefore I reverted the diff-eolws branch diffFlags to what they are in trunk now: DIFF_IGNORE_EOLWS. Sounds good. Let's get this bug-fix-turned-feature branch into trunk! :) Question to anyone interested: What should be the diffFlags used for blame/annotate

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Stephan Beal
On Wed, Mar 5, 2014 at 8:37 PM, Joel Bruick j...@joelface.com wrote: Jan Nijtmans wrote: Question to anyone interested: What should be the diffFlags used for blame/annotate My personal preference is for (1), as EOL whitespace is practically never worth caring about in any way

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Ramon Ribó
I can agree to treat space at the end of line as a difference. However, the end of line marker, be it \n or \r\n should be treated as equal. I really cannot imagine a situation where this difference can be significative. Please note that languages like C, C++ or TCL do not distinguish between

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Jan Nijtmans
2014-03-05 21:26 GMT+01:00 Stephan Beal sgb...@googlemail.com: On the principal of least surprise, i've got to go with #3 (any change is-a change). i suspect that doing otherwise will lead to confusion downstream at point. Since that seems to be the mostly preferred option, that's on trunk

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Jan Nijtmans
2014-03-05 22:39 GMT+01:00 Ramon Ribó ram...@compassis.com: I can agree to treat space at the end of line as a difference. However, the end of line marker, be it \n or \r\n should be treated as equal. I really cannot imagine a situation where this difference can be significative. I can: It

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Jan Nijtmans
2014-03-05 22:39 GMT+01:00 Ramon Ribó ram...@compassis.com: I can agree to treat space at the end of line as a difference. However, the end of line marker, be it \n or \r\n should be treated as equal. http://fossil-scm.org/index.html/info/4e6cfaf8f8 Rather easy to implement, I couldn't resist

Re: [fossil-users] importing/forking from Git

2014-03-05 Thread Ron Wilson
On Wed, Mar 5, 2014 at 2:21 AM, Chad Perrin c...@apotheon.net wrote: I'm talking about a distributed team, where not everyone has SSH shell access or the ability to directly change anything on the filesystem, but they all have commit access to a specific set of repositories. This means, for

Re: [fossil-users] nginx fronting fossil best practices?

2014-03-05 Thread Jon
I'll tinker with scgi tomorrow, but even if I get it working, I don't yet see how scgi ensures fossil generates correct links to it's gui and route back user url's similar to http://somewhere.mydomain.com/partner/repo-name/... ...SNIP... I've only used nginx once, and that was to test

Re: [fossil-users] importing/forking from Git

2014-03-05 Thread Chad Perrin
On Wed, Mar 05, 2014 at 07:25:31PM -0500, Ron Wilson wrote: On Wed, Mar 5, 2014 at 2:21 AM, Chad Perrin c...@apotheon.net wrote: I'm talking about a distributed team, where not everyone has SSH shell access or the ability to directly change anything on the filesystem, but they all have

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Andy Bradford
Thus said Jan Nijtmans on Wed, 05 Mar 2014 22:52:04 +0100: Happy continued testing. I've been testing on the diff-eolws branch and it all looks and works very nice. Thanks for fixing the button that I introduced and didn't realize it didn't honor the Show Log button. Andy -- TAI64

Re: [fossil-users] fossil/stunnel question

2014-03-05 Thread Ron Aaron
It looks like the relevant portion of the stunnel log is: 2014.03.06 06:40:52 LOG6[18041:3073944384]: Local mode child started (PID=18055) 2014.03.06 06:40:52 LOG7[18041:3073944384]: Remote FD=1 initialized 2014.03.06 06:40:52 LOG3[18041:3073944384]: TCP_NODELAY: Socket operation on non-socket

Re: [fossil-users] Missing highlighted space changes in diff?

2014-03-05 Thread Jan Nijtmans
2014-03-06 5:12 GMT+01:00 Andy Bradford amb-fos...@bradfords.org: Thus said Jan Nijtmans on Wed, 05 Mar 2014 22:52:04 +0100: Happy continued testing. I've been testing on the diff-eolws branch and it all looks and works very nice. Well, it was your idea adding this button! I'm +1 for