Re: [fossil-users] Code review (reloaded)

2013-08-05 Thread Ron Wilson
Laurens Van Houtven _...@lvh.io wrote: Hi, I'd like to know what sort of code review practices Fossil users employ. I believe this has come up at least twice: I've asked about it myself back in 2010, and Russ Paielli from the Scala team in 2011. All the projects I currently work on have

Re: [fossil-users] Code review (reloaded)

2013-08-03 Thread Stephan Beal
On Sat, Aug 3, 2013 at 5:55 PM, Andy Bradford amb-fos...@bradfords.orgwrote: fossil tag find experimental It doesn't appear to have a way to limit the number of results to return, so it isn't exactly the same. Sure, it does! http://fossil-scm.org/index.html/info/73135ec22a --

Re: [fossil-users] Code review (reloaded)

2013-08-03 Thread Stephan Beal
On Sat, Aug 3, 2013 at 6:23 PM, Stephan Beal sgb...@googlemail.com wrote: Sure, it does! http://fossil-scm.org/index.html/info/73135ec22a Caveat: when using the --raw flag the ordering is undefined (those elements have no time information, apparently), so the limit is not all that useful

Re: [fossil-users] Code review (reloaded)

2013-08-03 Thread Andy Bradford
Thus said Stephan Beal on Sat, 03 Aug 2013 18:23:46 +0200: http://fossil-scm.org/index.html/info/73135ec22a Wow that was quick! I suppose an alternate approach could have been to modify ``fossil timeline'' to accept a TAG to restrict its search to just those artifacts with the

Re: [fossil-users] Code review (reloaded)

2013-08-03 Thread Stephan Beal
On Sat, Aug 3, 2013 at 6:44 PM, Andy Bradford amb-sendok-1378140242.poacifknllljkhgok...@bradfords.org wrote: Thus said Stephan Beal on Sat, 03 Aug 2013 18:23:46 +0200: http://fossil-scm.org/index.html/info/73135ec22a Wow that was quick! Only because it was easy to do and i'm belly-deep

Re: [fossil-users] Code review (reloaded)

2013-08-03 Thread Andy Bradford
Thus said Stephan Beal on Sat, 03 Aug 2013 19:48:07 +0200: Ah, right, that's the www interface and you want the CLI... that one's a bit more difficult, so i won't be patching that tonight. The timeline is probably the most complicated single piece of functionality in the

[fossil-users] Code review (reloaded)

2013-05-28 Thread Laurens Van Houtven
Hi, I'd like to know what sort of code review practices Fossil users employ. I believe this has come up at least twice: I've asked about it myself back in 2010, and Russ Paielli from the Scala team in 2011. All the projects I currently work on have some explicit form of code review, be it: -

Re: [fossil-users] Code review (reloaded)

2013-05-28 Thread Stephan Beal
On Tue, May 28, 2013 at 12:10 PM, Laurens Van Houtven _...@lvh.io wrote: It is my understanding that Fossil doesn't come with such a tool for code reviews. Correct. Additionally, the entire point of autosync by default is to prevent having to branch and merge all the time. Not entirely.

Re: [fossil-users] Code review (reloaded)

2013-05-28 Thread Richard Hipp
On Tue, May 28, 2013 at 6:10 AM, Laurens Van Houtven _...@lvh.io wrote: Hi, I'd like to know what sort of code review practices Fossil users employ. I believe this has come up at least twice: I've asked about it myself back in 2010, and Russ Paielli from the Scala team in 2011. All the

Re: [fossil-users] Code review (reloaded)

2013-05-28 Thread Laurens Van Houtven
On May 28, 2013 12:39 PM, Richard Hipp d...@sqlite.org wrote: There is a pending review branch ( http://www.fossil-scm.org/fossil/timeline?c=pending-reviewy=ci) on the Fossil self-hosting repository now! I'm not sure I understand the workflow here. It seems the branch name itself is

Re: [fossil-users] Code review (reloaded)

2013-05-28 Thread Richard Hipp
On Tue, May 28, 2013 at 6:50 AM, Laurens Van Houtven _...@lvh.io wrote: On May 28, 2013 12:39 PM, Richard Hipp d...@sqlite.org wrote: There is a pending review branch ( http://www.fossil-scm.org/fossil/timeline?c=pending-reviewy=ci) on the Fossil self-hosting repository now! I'm not sure

Re: [fossil-users] Code review (reloaded)

2013-05-28 Thread Richard Hipp
On Tue, May 28, 2013 at 11:46 AM, Laurens Van Houtven _...@lvh.io wrote: A tangent: Note that when you edit a check-in, you are not really changing the check-in. You are, instead, adding additional information. Fossil does not erase or modify, it only augments. The original check-in

Re: [fossil-users] Code review (reloaded)

2013-05-28 Thread Nico Williams
On Tue, May 28, 2013 at 10:25 AM, Richard Hipp d...@sqlite.org wrote: If you forget to do it then, you can always visit a check-in after it is committed and click on the Edit link to do things like revise the check-in comment, update the check-in time, or move the check-in to a different