Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Scott Robison
On Fri, Jun 10, 2016 at 7:10 PM, Joe Mistachkin wrote: > > Scott Robison wrote: > > > > Okay, thanks for all the help. I've committed some new test cases that > > demonstrate errors in the trunk invalid_utf8. 16 tests fail on trunk, > > none fail on invalid_utf8_table

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Joe Mistachkin
Scott Robison wrote: > > Okay, thanks for all the help. I've committed some new test cases that > demonstrate errors in the trunk invalid_utf8. 16 tests fail on trunk, > none fail on invalid_utf8_table branch (which of course doesn't mean > there aren't bugs, just that the sample data doesn't

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Scott Robison
On Fri, Jun 10, 2016 at 5:24 PM, Joe Mistachkin wrote: > > Scott Robison wrote: > > > > So my expectation that it would automatically update the utf.test file is > > incorrect? I'm supposed to manually integrate that file back to utf.test? > > > > Yes and yes. > > > > > If

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Joe Mistachkin
Scott Robison wrote: > > So my expectation that it would automatically update the utf.test file is > incorrect? I'm supposed to manually integrate that file back to utf.test? > Yes and yes. > > If I want to specify a new test that should fail but does not currently, > am I just supposed to

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Scott Robison
On Fri, Jun 10, 2016 at 4:23 PM, Joe Mistachkin wrote: > > Scott Robison wrote: > > > > Also: Simply uncommenting the "createTestResults $tempPath 100" call > doesn't > > seem to be doing anything for me. Here is what I'm doing: > > > > Here are the steps I just used here

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Joe Mistachkin
Scott Robison wrote: > > Also: Simply uncommenting the "createTestResults $tempPath 100" call doesn't > seem to be doing anything for me. Here is what I'm doing: > Here are the steps I just used here locally: 1. Uncomment the "createTestResults" line. 2. Run "tclsh

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Scott Robison
On Fri, Jun 10, 2016 at 3:27 PM, Scott Robison wrote: > On Fri, Jun 10, 2016 at 12:26 PM, Scott Robison > wrote: > >> On Jun 10, 2016 6:04 AM, "Jan Nijtmans" wrote: >> > >> > 2016-06-10 10:12 GMT+02:00 Scott Robison: >>

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Scott Robison
On Fri, Jun 10, 2016 at 12:26 PM, Scott Robison wrote: > On Jun 10, 2016 6:04 AM, "Jan Nijtmans" wrote: > > > > 2016-06-10 10:12 GMT+02:00 Scott Robison: > > > FYI, my test code here (C++ harness) consisted of passing every > possible > > > four

[fossil-users] fossil ci -branch private

2016-06-10 Thread Sergei Gavrikov
Hi! Could Fossil warn about spurious "private" check-ins? I rarely use private branches but I use and a few times I did wrong check-ins as fossil ci -branch private ... IMO, it would be nice if Fossil warn that he/she (possible) misuses privacy. Excuse my stupid request (wish you never

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Scott Robison
On Jun 10, 2016 6:04 AM, "Jan Nijtmans" wrote: > > 2016-06-10 10:12 GMT+02:00 Scott Robison: > > FYI, my test code here (C++ harness) consisted of passing every possible > > four byte buffer to the old function and my new function. My function > > identifies the expected

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Jan Nijtmans
2016-06-10 10:12 GMT+02:00 Scott Robison: > FYI, my test code here (C++ harness) consisted of passing every possible > four byte buffer to the old function and my new function. My function > identifies the expected number of "strings" as valid UTF-8. I didn't eyeball > each one to make sure the

[fossil-users] SET option usability bug

2016-06-10 Thread Tony Papadimitriou
When giving the set command to change some option and you’re outside an open repo directory, the global setting is affected instead, even though the –-global option is not given. So, one can very easily mess up their global setup by accidentally attempting to set a local option but either from

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Scott Robison
On Fri, Jun 10, 2016 at 2:04 AM, Scott Robison wrote: > On Fri, Jun 10, 2016 at 1:37 AM, Joe Mistachkin > wrote: > >> >> Scott Robison >> > >> > Glad to be able to get to something before everyone else for a change. >> :) >> > >> >> Yes, thank you

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Scott Robison
On Fri, Jun 10, 2016 at 1:37 AM, Joe Mistachkin wrote: > > Scott Robison > > > > Glad to be able to get to something before everyone else for a change. :) > > > > Yes, thank you very much. > > Also, I know it's not a lot of fun, but... > > It would be nice if some new

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Jan Nijtmans
2016-06-10 9:24 GMT+02:00 Scott Robison: > On Fri, Jun 10, 2016 at 1:15 AM, Jan Nijtmans > wrote: >> >> 2016-06-10 2:01 GMT+02:00 Scott Robison: >> > I just committed >> > a one line fix (with multiple lines of comments to clarify what the code >> > is >> > doing in the

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Joe Mistachkin
Scott Robison > > Glad to be able to get to something before everyone else for a change. :) > Yes, thank you very much. Also, I know it's not a lot of fun, but... It would be nice if some new tests covering these edge cases were added to the "utf.test" file. The "generated section" in the

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Scott Robison
On Fri, Jun 10, 2016 at 1:15 AM, Jan Nijtmans wrote: > 2016-06-10 2:01 GMT+02:00 Scott Robison: > > I just committed > > a one line fix (with multiple lines of comments to clarify what the code > is > > doing in the tricky part). > > Scott, I owe you. Many thanks! You are

Re: [fossil-users] how to report bug in fossil

2016-06-10 Thread Jan Nijtmans
2016-06-10 2:01 GMT+02:00 Scott Robison: > I just committed > a one line fix (with multiple lines of comments to clarify what the code is > doing in the tricky part). Scott, I owe you. Many thanks! You are completely right, this was an edge-case not covered for. Regards, Jan Nijtmans