Re: [Framework-Team] PLIP 197 ready for review: feedparser as external dependency

2009-01-20 Thread Martijn Pieters
On Wed, Dec 31, 2008 at 17:19, Maurits van Rees m.van.r...@zestsoftware.nl wrote: PLIP 197: Add FeedParser as external requirement instead of shipping with it See http://plone.org/products/plone/roadmap/197

[Framework-Team] Re: PLIP 197 ready for review: feedparser as external dependency

2009-01-20 Thread Maurits van Rees
Martijn Pieters, on 2009-01-20: On Wed, Dec 31, 2008 at 17:19, Maurits van Rees I could not reproduce that later, but I say we call the dependency ``FeedFeeder`` and everything should work. I take it you meant 'FeedParser' in that last sentence ;-) D'oh! You are right. Products.feedfeeder

[Framework-Team] Re: PLIP review deadline has passed - time to review!

2009-01-20 Thread Florian Schulze
On Mon, 19 Jan 2009 13:43:47 +0100, Andreas Zeidler a...@zitc.de wrote: #232: Resource Registries Improvements — i've included the authors of these PLIPs via cc: hoping they might be able to clarify here. otherwise we'll have to skip reviewing them, which means they can't be considered

Re: [Framework-Team] PLIP review deadline has passed - time to review!

2009-01-20 Thread Andreas Zeidler
On Jan 19, 2009, at 4:42 PM, Wichert Akkerman wrote: Realistically I probably won't be able to finish PLIP 228 on time. bummer! but then again it's hard to wrap it up so quickly after you thought it had been rejected... I'll probably roll that and the implementation of the PLIP I

Re: [Framework-Team] PLIP review deadline has passed - time to review!

2009-01-20 Thread Andreas Zeidler
On Jan 19, 2009, at 4:41 PM, Sidnei da Silva wrote: On Mon, Jan 19, 2009 at 1:32 PM, Andreas Zeidler a...@zitc.de wrote: i'm sorry to say, but i think you'd at least need to make sure the review bundle is up-to-date and post a few review notes along with it. otherwise i don't think we can

Re: [Framework-Team] Re: PLIP review deadline has passed - time to review!

2009-01-20 Thread Andreas Zeidler
On Jan 20, 2009, at 6:03 PM, Florian Schulze wrote: On Mon, 19 Jan 2009 13:43:47 +0100, Andreas Zeidler a...@zitc.de wrote: #232: Resource Registries Improvements — i've included the authors of these PLIPs via cc: hoping they might be able to clarify here. otherwise we'll have to skip

Re: [Framework-Team] Re: PLIP review deadline has passed - time to review!

2009-01-20 Thread Martijn Pieters
On Tue, Jan 20, 2009 at 21:43, Andreas Zeidler a...@zitc.de wrote: Do whatever you feel is right considering that I missed the deadline. personally i think it'd be stupid to not consider changes that were ready for a while now. i mean, yes technically you missed the deadline, but to me i

Re: [Framework-Team] PLIP #240 ready for review

2009-01-20 Thread David Glick
On Jan 16, 2009, at 3:04 PM, Andrew Burkhalter wrote: Other - There is a weird edge case in the following scenario: 1. Manager turns off locking. 2. User A starts editing a document 3. Manager turns locking back on 4. User A clicks the edit tab again 5. User B views the document The

Re: [Framework-Team] Re: PLIP review deadline has passed - time to review!

2009-01-20 Thread Raphael Ritz
Andreas Zeidler wrote: [..] personally i think it'd be stupid to not consider changes that were ready for a while now. i mean, yes technically you missed the deadline, but to me i makes a subtle difference if you the code isn't quite ready yet or if only the notification mail went missing —

Re: [Framework-Team] PLIP #240 ready for review

2009-01-20 Thread Raphael Ritz
David Glick wrote: [..] Hey, just wanted to note that Andrew and I investigated this, discovered it was due to a previously existing bug in the unlockOnFormUnload.js script, and implemented a fix in the branch for PLIP #240. In the process we also discovered a related bug which results in