Re: [Framework-Team] PLIP145 Locking - Review

2006-09-26 Thread Helge Tesdal
On Tue, 26 Sep 2006 11:13:30 +0200, Raphael Ritz [EMAIL PROTECTED] wrote: 2. Test setup = I wasn't actually able to test the review bundle now with Zope 2.10 from SVN, so I'm basing this review on the demonstration during Archipelago sprint and looking at code. I wasn't able

Re: [Framework-Team] PLIP145 Locking - Review

2006-09-26 Thread Martin Aspeli
Hi Sidnei, On 9/26/06, Sidnei da Silva [EMAIL PROTECTED] wrote: On Tue, Sep 26, 2006 at 02:17:56PM +0100, Martin Aspeli wrote: | - If we can make AT fire generic events then maybe the locking can | live outside AT? That would be great. | The hard part is obviously the UI, since base_edit |

Re: [Framework-Team] PLIP145 Locking - Review

2006-09-26 Thread Martin Aspeli
Hi guys, I'm +0 for now because of my reservations about adding so much usecase specific code directly into the Archetypes framework. I think its very important that we begin to consider the potential importance of non-AT content, and not hinder plone by tying more core functionality, which

Re: [Framework-Team] PLIP145 Locking - Review

2006-09-26 Thread Raphael Ritz
Sidnei da Silva schrieb: On Tue, Sep 26, 2006 at 02:40:20PM +0100, Martin Aspeli wrote: | Well, the way the PLIP145 bundle works, you get a warning message when | you go to the edit tab, but with an option of stealing the lock. If | there is no lock, when you go the edit tab, a lock is

Re: [Framework-Team] PLIP145 Locking - Review

2006-09-26 Thread Martin Aspeli
Hi Raphael, While Sidnei is right in principle I again want to stress that the hardest part here is to get some event triggered the moment the user starts to work on something. With external edit its easy, with a staging scenario its easy (as yuo do an explicit check out) but for any Plone

[Framework-Team] Re: PLIP145 Locking - Review

2006-09-26 Thread Alexander Limi
On Tue, 26 Sep 2006 06:17:56 -0700, Martin Aspeli [EMAIL PROTECTED] wrote: Regarding iterate and the locking bundle: There is obviously some overlap, but they are not exactly the same thing. Iterate is about in-place staging aka check-out/check-in versioning. The locking bundle is about