Re: [Framework-Team] My review status
On 18 feb 2008, at 01:28, Andreas Zeidler wrote: On Feb 16, 2008, at 8:52 PM, Danny Bloemendaal wrote: As you guys know I'm here to review plips when it requires UI attention. So I did 201 (and still working on that next week). As far as I can tell there aren't other plips that need that attention from me (please correct me if I'm wrong). well, i'd like to say that it was never really sort of officially communicated to me that your role in the team is just to stand by and give feedback when requested to. you've said initially that you couldn't say much about technical details, which is fair, but imho that doesn't really exclude you from doing other review tasks. like raphael said in one of his posts, most of the time looking at code alone isn't all that matters. Ok, I'm sorry if that wasn't communicated better or maybe it was my misunderstanding. Point is that back in the days, Wichert asked me if I wanted to join the team as a UI designer/tester to make sure that we could keep the standard high regarding usability. I said that I would like to do that but that people shouldn't expect from me that I would participate heavily in 'true' framework discussions. That wasn't a problem so I volunteered. But.. you may be right that I still could be of more help than what I did so far. so when you said you were gonna review things after that week you were unavailable, i.e. starting from february 11th, i was indeed expecting you to do as many reviews as everybody else. these could or rather should have included click-tests as well as some thinking about corner-cases and trying to break things etc. until wichert updated the schedule (yesterday, i.e. sunday) the review deadline was on saturday. until then you've only commented on two plips afaik, but should have on at least seven (as posted several times)... :( So, yes, I could certainly do click-tests. Maybe my reluctance so far was because if me not being able to foresee in which plips I can be of any help regarding this. So, I guess that's my status. hmm, that kinda sounds like you didn't think the above also applied to you. i wonder what went wrong here. at the very best, we've had some pretty severe miscommunication here. quite frankly, hardly replying to any mails and most importantly not making this point of view very clear when seeing several posts with obviously wrong numbers in terms of review per team member is not acceptable to me. You are right here I'm affraid. I'll try to do better in the near future :( that said and considering the current status of the reviews, i'm gonna ask you to please do secondary reviews on 202 (formlib inline validation / editing), 212 (jquery) and — most importantly — 215 (kss update) tomorrow. there's no need to look at any code, but the review should include manual click-tests for more or less all affected / replaced js functionality in plone. Ok, I will do that today and again, sorry for the miscommunication. cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] My review status
On Feb 18, 2008, at 9:18 AM, Danny Bloemendaal wrote: So, yes, I could certainly do click-tests. Maybe my reluctance so far was because if me not being able to foresee in which plips I can be of any help regarding this. i would have thought you know plone well enough to tell which parts it makes sense to test manually... ;) You are right here I'm affraid. I'll try to do better in the near future :( glad you agree, and thanks for the quick reply. that said and considering the current status of the reviews, i'm gonna ask you to please do secondary reviews on 202 (formlib inline validation / editing), 212 (jquery) and — most importantly — 215 (kss update) tomorrow. Ok, I will do that today and again, sorry for the miscommunication. thanks, that should help us get to a halfway decent review coverage, so we can finally wrap this up. cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] my review status
On Feb 17, 2008, at 3:21 PM, Tom Lazar wrote: sorry for the delay, i went out with hannosch and lurker yesterday evening, instead of finishing my last review ;-) way to go. i finished 201 but still couldn't get 209 to work (despite the hint from graham) since 209 has already been reviewed twice, i think it'd be sufficient to resolve the issue you were describing. other than that there's probably no need to dig deeper here... now what? like i said, imho we should still get secondary reviews for at least 187 and 215. seeing that you've done only six reviews so far (out of the required 7.2), could you please still review 187? wichert's extended the deadline until monday night, so there should be enough time left... cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] My review status
On Feb 16, 2008, at 8:52 PM, Danny Bloemendaal wrote: As you guys know I'm here to review plips when it requires UI attention. So I did 201 (and still working on that next week). As far as I can tell there aren't other plips that need that attention from me (please correct me if I'm wrong). well, i'd like to say that it was never really sort of officially communicated to me that your role in the team is just to stand by and give feedback when requested to. you've said initially that you couldn't say much about technical details, which is fair, but imho that doesn't really exclude you from doing other review tasks. like raphael said in one of his posts, most of the time looking at code alone isn't all that matters. so when you said you were gonna review things after that week you were unavailable, i.e. starting from february 11th, i was indeed expecting you to do as many reviews as everybody else. these could or rather should have included click-tests as well as some thinking about corner- cases and trying to break things etc. until wichert updated the schedule (yesterday, i.e. sunday) the review deadline was on saturday. until then you've only commented on two plips afaik, but should have on at least seven (as posted several times)... :( So, I guess that's my status. hmm, that kinda sounds like you didn't think the above also applied to you. i wonder what went wrong here. at the very best, we've had some pretty severe miscommunication here. quite frankly, hardly replying to any mails and most importantly not making this point of view very clear when seeing several posts with obviously wrong numbers in terms of review per team member is not acceptable to me. that said and considering the current status of the reviews, i'm gonna ask you to please do secondary reviews on 202 (formlib inline validation / editing), 212 (jquery) and — most importantly — 215 (kss update) tomorrow. there's no need to look at any code, but the review should include manual click-tests for more or less all affected / replaced js functionality in plone. cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] my review status
On Feb 18, 2008, at 12:56 AM, Andreas Zeidler wrote: On Feb 17, 2008, at 3:21 PM, Tom Lazar wrote: sorry for the delay, i went out with hannosch and lurker yesterday evening, instead of finishing my last review ;-) way to go. i finished 201 but still couldn't get 209 to work (despite the hint from graham) since 209 has already been reviewed twice, i think it'd be sufficient to resolve the issue you were describing. other than that there's probably no need to dig deeper here... that sounds reasonable and as long as the issue does get resolved i'm ready to vote 209 in based on the existing reviews. now what? like i said, imho we should still get secondary reviews for at least 187 and 215. seeing that you've done only six reviews so far (out of the required 7.2), could you please still review 187? wichert's extended the deadline until monday night, so there should be enough time left... sure thing, i'll review 187 during the day and post back. cheers, tom cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] my review status
Tom Lazar wrote: On Feb 18, 2008, at 12:56 AM, Andreas Zeidler wrote: On Feb 17, 2008, at 3:21 PM, Tom Lazar wrote: sorry for the delay, i went out with hannosch and lurker yesterday evening, instead of finishing my last review ;-) way to go. i finished 201 but still couldn't get 209 to work (despite the hint from graham) since 209 has already been reviewed twice, i think it'd be sufficient to resolve the issue you were describing. other than that there's probably no need to dig deeper here... that sounds reasonable and as long as the issue does get resolved i'm ready to vote 209 in based on the existing reviews. Just to mention this here as well: I cannot reproduce the issue you are seeing. Are you sure you used the tarball and not a svn checkout? Raphael now what? like i said, imho we should still get secondary reviews for at least 187 and 215. seeing that you've done only six reviews so far (out of the required 7.2), could you please still review 187? wichert's extended the deadline until monday night, so there should be enough time left... sure thing, i'll review 187 during the day and post back. cheers, tom cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.5 released! -- http://plone.org/products/plone ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] my review status
just FYI since the review deadline is *today*, as of now i have reviewed and submitted the following plips: #195: Support product dependencies #212: Use jQuery Javascript Library #213: Prepare for better Syndication #215: Include new KSS versions the following is still in progress, as i couldn't get it to work (have posted feedback to list, steve and trac): #209: Add buildout to Unified Installer the last remaining one i will do later tonight (after the kids are in bed...) #201: Improve the UberSelectionWidget UI cheers, tom ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] My review status
As you guys know I'm here to review plips when it requires UI attention. So I did 201 (and still working on that next week). As far as I can tell there aren't other plips that need that attention from me (please correct me if I'm wrong). So, I guess that's my status. Danny. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
