Re: [Framework-Team] PLIP review deadline has passed - time to review!
On Jan 19, 2009, at 4:41 PM, Sidnei da Silva wrote: On Mon, Jan 19, 2009 at 1:32 PM, Andreas Zeidler wrote: i'm sorry to say, but i think you'd at least need to make sure the review bundle is up-to-date and post a few review notes along with it. otherwise i don't think we can consider a review (simply because we cannot hunt down the pieces ourselves as we cannot be sure to have the latest version that way). I'm sorry to say too, but the review date has passed as you guys said. I don't expect being treated differently than others, so don't consider #187 as up for review. hmm, too bad this has to be rejected a second time then. :( thanks for your quick answer, though. i hope you'll give it another try with 3.4! cheers, andi -- zeidler it consulting - http://zitc.de/ - i...@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.1.7 released! -- http://plone.org/products/plone/ PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP review deadline has passed - time to review!
On Jan 19, 2009, at 4:42 PM, Wichert Akkerman wrote: Realistically I probably won't be able to finish PLIP 228 on time. bummer! but then again it's hard to wrap it up so quickly after you thought it had been rejected... I'll probably roll that and the implementation of the PLIP I submitted that were rejected into a separate package somewhere in the next couple of months. or else try to improve things in those areas for 4.0! andi -- zeidler it consulting - http://zitc.de/ - i...@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.1.7 released! -- http://plone.org/products/plone/ PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP review deadline has passed - time to review!
On 1/19/09 4:32 PM, Andreas Zeidler wrote: the notes don't have to be extensive, but some basic instructions as well as an overview what has changed since the 3.1 review bundle should be included. if you don't have time yourself, please ask somebody else with the necessary insights. anyway, the bundle should be ready for review by tomorrow. the same goes for florian (wrt PLIP 232) and wichert (wrt PLIP 228), btw. Realistically I probably won't be able to finish PLIP 228 on time. I'll probably roll that and the implementation of the PLIP I submitted that were rejected into a separate package somewhere in the next couple of months. Wichert. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP review deadline has passed - time to review!
On Mon, Jan 19, 2009 at 1:32 PM, Andreas Zeidler wrote: > i'm sorry to say, but i think you'd at least need to make sure the review > bundle is up-to-date and post a few review notes along with it. otherwise i > don't think we can consider a review (simply because we cannot hunt down the > pieces ourselves as we cannot be sure to have the latest version that way). I'm sorry to say too, but the review date has passed as you guys said. I don't expect being treated differently than others, so don't consider #187 as up for review. -- Sidnei da Silva Canonical Ltd. T. +1 713 568 5638 (main) Landscape - Changing the way you manage your systems http://landscape.canonical.com ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP review deadline has passed - time to review!
On Jan 19, 2009, at 4:14 PM, Sidnei da Silva wrote: On Mon, Jan 19, 2009 at 10:43 AM, Andreas Zeidler wrote: #187: "Working Out-of-the-box WebDAV" — as this PLIP was already submitted for inclusion in Plone 3.1, i suppose it's not quite clear if it should be considered for review now (without another announcement of the bundle's availability to the list). i haven't checked if there have been any updates to the code, or if a review bundle has been created without notification, though. perhaps sidnei can provide us with a quick status update here? I suspect the code just needs some polishing, if any. There's two new eggs to be included and other than that it's just configuration. I don't have any time to look at this at the moment, swamped in first weeks of new job. i'm sorry to say, but i think you'd at least need to make sure the review bundle is up-to-date and post a few review notes along with it. otherwise i don't think we can consider a review (simply because we cannot hunt down the pieces ourselves as we cannot be sure to have the latest version that way). the notes don't have to be extensive, but some basic instructions as well as an overview what has changed since the 3.1 review bundle should be included. if you don't have time yourself, please ask somebody else with the necessary insights. anyway, the bundle should be ready for review by tomorrow. the same goes for florian (wrt PLIP 232) and wichert (wrt PLIP 228), btw. cheers, andi -- zeidler it consulting - http://zitc.de/ - i...@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.1.7 released! -- http://plone.org/products/plone/ PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP review deadline has passed - time to review!
On Mon, Jan 19, 2009 at 10:43 AM, Andreas Zeidler wrote: > #187: "Working Out-of-the-box WebDAV" — as this PLIP was already submitted > for inclusion in Plone 3.1, i suppose it's not quite clear if it should be > considered for review now (without another announcement of the bundle's > availability to the list). i haven't checked if there have been any updates > to the code, or if a review bundle has been created without notification, > though. perhaps sidnei can provide us with a quick status update here? I suspect the code just needs some polishing, if any. There's two new eggs to be included and other than that it's just configuration. I don't have any time to look at this at the moment, swamped in first weeks of new job. -- Sidnei da Silva Canonical Ltd. T. +1 713 568 5638 (main) Landscape - Changing the way you manage your systems http://landscape.canonical.com ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP review deadline has passed - time to review!
On Jan 19, 2009, at 2:39 PM, Martijn Pieters wrote:
On Mon, Jan 19, 2009 at 13:51, Wichert Akkerman
wrote:
#228: "Restore 'Add Item..' menu on all pages" — as this was only
sort of
conditionally accepted during the proposal phase, i'd take the
fact that no
bundle was submitted as an indication that wichert considered this
not worth
it?
I thought it was rejected? I might have misremembered. It's trivial
enough
that I can make a quicky implementation of it though.
No, it was indeed rejected. Not sure why Andi included it. ;-)
steve's mail ("Plone 3.3 PLIP Recommendations") said:
228: "Restore 'Add Item..' menu on all pages"
Rejected for default: Violates continuity of UI within 3.x series.
Acceptable as add-on or switch with current behavior as default.
which reflected the status rather accurately iirc. and, as a personal
note and also as already mentioned in http://plone.org/products/plone/roadmap/228
, i still think it would make sense to include this to allow our users
to easily switch back to the old behaviour.
andi
--
zeidler it consulting - http://zitc.de/ - i...@zitc.de
friedelstraße 31 - 12047 berlin - telefon +49 30 25563779
pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/
plone 3.1.7 released! -- http://plone.org/products/plone/
PGP.sig
Description: This is a digitally signed message part
___
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP review deadline has passed - time to review!
On Mon, Jan 19, 2009 at 13:51, Wichert Akkerman wrote: >> #228: "Restore 'Add Item..' menu on all pages" — as this was only sort of >> conditionally accepted during the proposal phase, i'd take the fact that no >> bundle was submitted as an indication that wichert considered this not worth >> it? > > I thought it was rejected? I might have misremembered. It's trivial enough > that I can make a quicky implementation of it though. No, it was indeed rejected. Not sure why Andi included it. ;-) -- Martijn Pieters ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP review deadline has passed - time to review!
On 1/19/09 1:43 PM, Andreas Zeidler wrote: #228: "Restore 'Add Item..' menu on all pages" — as this was only sort of conditionally accepted during the proposal phase, i'd take the fact that no bundle was submitted as an indication that wichert considered this not worth it? I thought it was rejected? I might have misremembered. It's trivial enough that I can make a quicky implementation of it though. Wichert. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] PLIP review deadline has passed - time to review!
On Jan 18, 2009, at 5:20 PM, Wichert Akkerman wrote: The deadline for PLIP submissions was yesterday, so as we agreed no more PLIPs should be accepted at this point. in that regard, here's the list of PLIPs for which review bundles were submitted: #126: "Link type should automatically redirect when accessed directly" #197: "Add FeedParser as external requirement" #234: "Standardizing our use of INavigationRoot" #237: "Minor i18n upgrades" #238: "Disable inline editing by default" #239: "Adapterise the Extensible Indexable Object Wrapper" #240: "Improve locking configurability" #241: "Clean up auto-sort: auto-order code" #243: "Replace workflow history viewlet with content history viewlet" #246: "View for rendering events as an iCalendar file" #247: "Automate ZCML Loading for Plone Plug-ins" technically #237, #238 and #241 were submitted late, but the mails to the fwt only missed the deadline for a few minutes (well except for hanno :)). so i don't think the framework team has an intention to reject them. i certainly haven't. PLIPs that were not submitted are: #187: "Working Out-of-the-box WebDAV" — as this PLIP was already submitted for inclusion in Plone 3.1, i suppose it's not quite clear if it should be considered for review now (without another announcement of the bundle's availability to the list). i haven't checked if there have been any updates to the code, or if a review bundle has been created without notification, though. perhaps sidnei can provide us with a quick status update here? #228: "Restore 'Add Item..' menu on all pages" — as this was only sort of conditionally accepted during the proposal phase, i'd take the fact that no bundle was submitted as an indication that wichert considered this not worth it? #232: "Resource Registries Improvements" — i've included the authors of these PLIPs via cc: hoping they might be able to clarify here. otherwise we'll have to skip reviewing them, which means they can't be considered for inclusion into Plone 3.3 either. The deadline for the implementation review is two weeks from now: January 30. Where possible please try to give feedback to the PLIP implementors as soon as possible instead of waiting for the deadline so they will have more time to make any required changes. the first step towards this is to coordinate the reviews. raphael's question re distributing them remained mostly unanswered, but i'll follow up on this in a separate mail... cheers, andi -- zeidler it consulting - http://zitc.de/ - i...@zitc.de friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.1.7 released! -- http://plone.org/products/plone/ PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
[Framework-Team] PLIP review deadline has passed - time to review!
The deadline for PLIP submissions was yesterday, so as we agreed no more PLIPs should be accepted at this point. The deadline for the implementation review is two weeks from now: January 30. Where possible please try to give feedback to the PLIP implementors as soon as possible instead of waiting for the deadline so they will have more time to make any required changes. Wichert. -- Wichert Akkerman It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
