Re: [Framework-Team] Two more PLIPs
On Dec 14, 2007 8:44 AM, Andreas Zeidler <[EMAIL PROTECTED]> wrote: > On Dec 14, 2007, at 9:11 AM, Alec Mitchell wrote: > > Hi framework team members, > > hi framework team pioneer, > > > A couple more PLIPs to keep you guys busy: > > thank you very much. :) > > > Adapterized local role lookup (borg.localrole): > > http://plone.org/products/plone/roadmap/208 > > also very nicely written and convincing, +1 on the plip from me. > benchmark results would be much appreciated during the review phase. > oh, and btw, the example adapter should probably return a copy in > `getAllRoles`, no? Possibly, but the borg.localrole adapter which calls this method just uses each of these results inside a mapping.update() call, so the copying is implicit. However, I just noticed that that implementation is wrong because the method is supposed to return an iterator of tuples, not a dict. Will fix immediately. Alec ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Two more PLIPs
On Dec 14, 2007 9:11 AM, Alec Mitchell <[EMAIL PROTECTED]> wrote: > Adapterized local role lookup (borg.localrole): > http://plone.org/products/plone/roadmap/208 > > Adapterized workflow lookup: > http://plone.org/products/plone/roadmap/217 Thanks for the great PLIPs :-) +1 on both from me. -- Martijn Pieters ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Two more PLIPs
On Dec 14, 2007, at 9:11 AM, Alec Mitchell wrote: Hi framework team members, hi framework team pioneer, A couple more PLIPs to keep you guys busy: thank you very much. :) Adapterized local role lookup (borg.localrole): http://plone.org/products/plone/roadmap/208 also very nicely written and convincing, +1 on the plip from me. benchmark results would be much appreciated during the review phase. oh, and btw, the example adapter should probably return a copy in `getAllRoles`, no? Adapterized workflow lookup: http://plone.org/products/plone/roadmap/217 same here, no objections at all... +1. cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.4 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Two more PLIPs
On Dec 11, 2007, at 1:35 PM, Laurence Rowe wrote: #211: Enable dashboard to be locked down +1 from me in general. imho it makes sense to separate those permissions as well as create a ui for group assignment (since these are already supported anyway). what about migration issues, though? already existing dashboard portlet registrations on users should probably be removed when they're set for the "authenticated" group. otherwise they might be un-shadowed should they ever be removed for the group again. and wouldn't we also have to take care of replicating local settings of 'Portlets: Manage own portlets' with regard to the added permission? otherwise it might be possible to accidentally loosen security in some cases if the settings had been made more strict before. the same goes for workflows i guess — they would need to be checked to see if they manage the portlets permission. all pretty unlikely i suppose, but it could be an issue, imho. thoughts? cheers, andi -- zeidler it consulting - http://zitc.de/ - [EMAIL PROTECTED] friedelstraße 31 - 12047 berlin - telefon +49 30 25563779 pgp key at http://zitc.de/pgp - http://wwwkeys.de.pgp.net/ plone 3.0.4 released! -- http://plone.org/products/plone PGP.sig Description: This is a digitally signed message part ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Two more PLIPs
now that i've understood what it's about: +1 from me, too ;-) thanks raphael! cheers, tom On 13.12.2007, at 08:41, Raphael Ritz wrote: Tom Lazar wrote: On 11.12.2007, at 13:35, Laurence Rowe wrote: I'd like to see the following for 3.1: #210: Improve UI support for objects on multiple workflows DCWorkflow allows for a chain of workflows to be specified for a type. please explain. does chaining mean, that an object/type can have multiple workflows associated sequentially? or does each given state have the sum of all of the workflows transitions available? More the latter than the former. Objects can be subject to several workflows at once. This implies multiple state variables of course. Indeed you get a sum of all possible transitions offered. I used to use this feature to provide locking functionality before Plone itself did it (but in a different way now). If you want to see an example in action check out my LockingWorkflow product in a Plone 2.5 site. And to drive home the point here: the CMF workflow tool and DCWorkflow have supported this from the onset. It is only Plone's UI that's kind of hiding this from you. and BTW: +1 from me on the issue or does one simply chose one workflow for different instances of a content type? i.e. "the frontpage has a restrictive workflow and the faq page has a more permissive one."? This mostly works with Plone, but there are a few (mostly UI) warts to be fixed. http://plone.org/products/plone/roadmap/210 #211: Enable dashboard to be locked down Portlets may be registered to the dashboard for groups, this makes the dashboard useful even when users should not be able to modify their own dashboard. http://plone.org/products/plone/roadmap/211 definitely +1 on "Protect the dashboard with a 'Portlets: View own portlets' permission" but also to the switch to registering portlets to AuthenticatedUsers group +1 here as well Raphael Laurence ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Two more PLIPs
On 13 dec 2007, at 08:41, Raphael Ritz wrote: Tom Lazar wrote: On 11.12.2007, at 13:35, Laurence Rowe wrote: I'd like to see the following for 3.1: #210: Improve UI support for objects on multiple workflows DCWorkflow allows for a chain of workflows to be specified for a type. please explain. does chaining mean, that an object/type can have multiple workflows associated sequentially? or does each given state have the sum of all of the workflows transitions available? More the latter than the former. Objects can be subject to several workflows at once. This implies multiple state variables of course. Indeed you get a sum of all possible transitions offered. I used to use this feature to provide locking functionality before Plone itself did it (but in a different way now). If you want to see an example in action check out my LockingWorkflow product in a Plone 2.5 site. And to drive home the point here: the CMF workflow tool and DCWorkflow have supported this from the onset. It is only Plone's UI that's kind of hiding this from you. and BTW: +1 from me on the issue I truely think that this isn't as trivial as it may seem. Is it only a UI issue? I know plone relies on several locations for the review_state attribute. What if an object has several states (which is possible if you have multiple workflows assigned)? Aren't there configlets that allow you to do things with this attribute like the navtree? What about worklists? I think that when we agree that an object can have more than one states, we have to support it everywhere in a concise way. I want to see a list of all the locations and situations where this may be an issue. Is the code truely multiple- state/transition aware? It's not only changing content_status_modify in my opinion. The state change drop-down should also show that there are more workflows and perhaps group the transitions per-state. So, my point is: we either do it right or we don't do it at all :) And for now: +0 Danny. ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Two more PLIPs
Tom Lazar wrote: On 11.12.2007, at 13:35, Laurence Rowe wrote: I'd like to see the following for 3.1: #210: Improve UI support for objects on multiple workflows DCWorkflow allows for a chain of workflows to be specified for a type. please explain. does chaining mean, that an object/type can have multiple workflows associated sequentially? or does each given state have the sum of all of the workflows transitions available? More the latter than the former. Objects can be subject to several workflows at once. This implies multiple state variables of course. Indeed you get a sum of all possible transitions offered. I used to use this feature to provide locking functionality before Plone itself did it (but in a different way now). If you want to see an example in action check out my LockingWorkflow product in a Plone 2.5 site. And to drive home the point here: the CMF workflow tool and DCWorkflow have supported this from the onset. It is only Plone's UI that's kind of hiding this from you. and BTW: +1 from me on the issue or does one simply chose one workflow for different instances of a content type? i.e. "the frontpage has a restrictive workflow and the faq page has a more permissive one."? This mostly works with Plone, but there are a few (mostly UI) warts to be fixed. http://plone.org/products/plone/roadmap/210 #211: Enable dashboard to be locked down Portlets may be registered to the dashboard for groups, this makes the dashboard useful even when users should not be able to modify their own dashboard. http://plone.org/products/plone/roadmap/211 definitely +1 on "Protect the dashboard with a 'Portlets: View own portlets' permission" but also to the switch to registering portlets to AuthenticatedUsers group +1 here as well Raphael Laurence ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
Re: [Framework-Team] Two more PLIPs
On 11.12.2007, at 13:35, Laurence Rowe wrote: I'd like to see the following for 3.1: #210: Improve UI support for objects on multiple workflows DCWorkflow allows for a chain of workflows to be specified for a type. please explain. does chaining mean, that an object/type can have multiple workflows associated sequentially? or does each given state have the sum of all of the workflows transitions available? or does one simply chose one workflow for different instances of a content type? i.e. "the frontpage has a restrictive workflow and the faq page has a more permissive one."? This mostly works with Plone, but there are a few (mostly UI) warts to be fixed. http://plone.org/products/plone/roadmap/210 #211: Enable dashboard to be locked down Portlets may be registered to the dashboard for groups, this makes the dashboard useful even when users should not be able to modify their own dashboard. http://plone.org/products/plone/roadmap/211 definitely +1 on "Protect the dashboard with a 'Portlets: View own portlets' permission" but also to the switch to registering portlets to AuthenticatedUsers group Laurence ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team ___ Framework-Team mailing list Framework-Team@lists.plone.org http://lists.plone.org/mailman/listinfo/framework-team
