Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by esteele): (In [51167]) Merge changes for PLIP #11300. Refs #11300. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:74 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by esteele): (In [51170]) Merge PLIP branch. Refs #11300. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:75 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by esteele): (In [51171]) Merge PLIP branch. Refs #11300. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:76 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by esteele): (In [51173]) Merge PLIP branch. Refs #11300. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:77 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by esteele): (In [51179]) Merge PLIP branch. Refs #11300. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:80 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter|Owner: spliter Type: PLIP | Status: closed Priority: major |Milestone: 4.2 Component: Templates/CSS | Resolution: fixed Keywords: | ---+ Changes (by esteele): * status: assigned = closed * resolution: = fixed Comment: (In [51180]) Add new checkouts. Remove PLIP cfg. Closes #11300. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:81 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): Replying to [comment:68 alecm]: (In [51036]) Update review for PLIP 11300. Refs #11300 Thanks for the prompt update, Alec. But, there are still two issues that bother me. First of all, the conditional comments around the html. I am sure we are using the most recent and the most bullet-proof way of doing this. In the original post, mentioned in the comment in main_template.pt (the one, you reference to in your review, Alec), there is information about the (!IE) comment indeed. But, the thing is that this comment was meant to deal with Dreamweaver being too silly. At the end of that blog post, there is another, more recent, update: '2011.04.11: The HTML5 Boilerplate community dug into this and [https://github.com/paulirish/html5-boilerplate/issues/425/# figured out a lot more details] around the syntax. Hopefully I'll get a chance to update this post with those learning...' The link in the comment leads to the issue entry of the HTML5 boilerplate. And the conclusion after resolving that issue was exactly the markup we are having in main_template now without any (!IE) thing that doesn't make sense at all - https://github.com/paulirish/html5-boilerplate/blob/master/index.html. I agree it looks a little bit messy, but it gives much better ground for writing hacks-less styles in the main stylesheets. And I have already put those in the stylesheets to preserve the information we had in the deprecated IEFixes.css. So, let's close this issue — the markup we have in main_template now is *the* markup and follows the best practices for dealing with IE-specific styles. Second, I don't get mdash; validation error on the official w3c validator. May I ask you, how do you validate the page so that I could reproduce? -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:69 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by alecm): (In [51039]) Update review for PLIP 11300 after feedback. Refs #11300. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:70 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by alecm): OK, I've updated the review to reflect the fact that the conditional comment is the latest version and probably the best we can do, even if it is a little ugly :-) Regarding the mdash validation error. I'm using the validator here: http://validator.w3.org/#validate_by_input which is of course experimental for HTML5, but I suspect other people will use it. I view the source for the front-page in my browser and copying and pasting it into the text box. The validator automatically detects that the page is HTML5 and utf8. It has an issue with the mdash that Plone puts in the title tag, as well as with the http-equiv=Content-Type meta tag. I don't think these are terribly important since the validator.nu validator appears to be the better one. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:71 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): Replying to [comment:71 alecm]: Regarding the mdash validation error. I'm using the validator here: http://validator.w3.org/#validate_by_input which is of course experimental for HTML5, but I suspect other people will use it. I view the source for the front-page in my browser and copying and pasting it into the text box. The validator automatically detects that the page is HTML5 and utf8. It has an issue with the mdash that Plone puts in the title tag, as well as with the http-equiv=Content-Type meta tag. I don't think these are terribly important since the validator.nu validator appears to be the better one. Thanks for the explanation, Alec. Then, I suppose this is very minor issue. I validate from Firefox, using WebDeveloper Tools' Validate local HTML feature. It sends the local site's (in our case running on localhost:8080/Plone) output to the official w3c validator as well. In this case there are no validation errors and the document is validated as fully valid HTML5 document. Dunno, maybe the ways they process the direct input is different, but since validator.nu doesn't raise an error as well, I tend to think the 'direct input' feature of the official validator has issues. So, I suppose, we can conclude that the ticket is really ready for merge :) -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:72 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50995]) Removed GenerciSetup from the configuration file. References #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:60 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): Replying to [comment:59 alecm]: (In [50941]) Added PLIP review for 11300. Refs #11300 Thanks for the review, Alec. Would like to comment on some moments. 1. I am not sure about the mess with kss.core and Products.ResourceRegistries. Corresponding branches of the both packages are included in the plip11300-switch-to-html5.cfg file's auto-checkout section and should not require anything extra on your side. You can see this at https://svn.plone.org/svn/plone/buildouts/plone- coredev/branches/4.1/plip11300-switch-to-html5.cfg. I didn't change this file after your review except removing mistaken pinning of GenericSetup's version. 2. The HTML tag being inside a conditional comment. We are using the most recent version of assigning IE-specific classes on the HTML element according to the HTML5 Boilerplate as it can be checked here — https://github.com/paulirish/html5-boilerplate/blob/master/index.html . If more information on this topic needed, here is the discussion behind this decision in the HTML5 boilerplate — https://github.com/paulirish/html5-boilerplate/issues/425 3. Validation passed with the exception of the kinetic-stylesheet custom rel attribute. should not be an issue, since obviously there is some conflict with pulling the correct branch of kss.core. The branch has this fixed and, configuration file for this plip should be pulling that branch without a problem. 4. The w3c validator complains about the http-equiv=Content-Type meta tag, the KSS link rel attributes, and the use of an undeclared mdash; entity in the page title. Clearly there is something wrong happening and the proper bracnhes are not pulled on your side. I can not reproduce these with the standard w3c validator. 5. … plone.app.kss trunk should have been included in the configuration This is not needed. I don't change anything in that package. Only kss.core. I am almost sure that the problem you have with KSS features not working are related to the fact you are pulling that package from some place that doesn't work. I have all the KSS features, including inline editing, re-ordering of the items in the folder_contents etc. working just fine. No issues or errors in the console. So, in my opinion all the critical issues mentioned in your review are related to some issues with the instance being built with some othr configuration, different from the most recent one. Alec, may I ask you to check this PLIP once again and make sure the issues mentioned by you are still valid? -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:61 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): Ah! Found the place where I actually do make changes to plone.app.kss. And it's not included in the auto-checkout indeed. Will fix this. The problem is that I have made changes on p.a.kss trunk instead of branch. Stupid me! So, will clear this mess asap. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:62 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50997]) Reverting r50336 as it belongs to the branch and not to the trunk… at least for now ;). References #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:63 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): Checked the things now and now there has to be no validation errors. The required packages (incl. plone.app.kss) should be pulled from the branches. But after switching p.a.kss to the branch I can reproduce the issues with KSS functionality as well. So, fighting with that. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:64 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5
---+
Reporter: spliter| Owner: spliter
Type: PLIP | Status: assigned
Priority: major | Milestone: 4.2
Component: Templates/CSS |Keywords:
---+
Comment(by spliter):
(In [51001]) After playing with base-url for KSS, seems like removing that
link is not gonna work fine - all KSS functionality is gone and kss.core
needs to be updated in the way that might be not backwards-compatible.
Instead, we update the link / element providing base-url for KSS with
valid rel keyword ('alternate') and additional HTML5 attribute data-*.
References #11300
--
Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:65
Plone http://plone.org
Plone Enterprise Content Management System
___
PLIP-Advisories mailing list
plip-advisor...@lists.plone.org
https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [[https://dev.plone.org/collective/changeset/241877/kukit/kukit.js/trunk/kukit 241877]]) Updated utils.js to take data-kss-base-url='kss-base-url' attribute into account, when on the link / element, providing base-url for KSS. References #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:66 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): All the critical issues should be fixed by now. Alec, Rob, may I ask you, or anybody else, to review the PLIP once again and make the decision about the inclusion into the core? -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:67 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by alecm): (In [51036]) Update review for PLIP 11300. Refs #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:68 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by alecm): (In [50941]) Added PLIP review for 11300. Refs #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:59 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): Replying to [comment:57 robgietema]: (In [50595]) Added review for plip 11300. refs #11300 Thanks for the review, Rob. Would like to give some comments and explanations on it. Replying to [comment:57 robgietema]: The conditional html tag at the end uses if gt IE 8 better would be if (gt IE 8)|!(IE). No other browser understands conditional comments except IE, so !(IE) part doesn't make sense to me. Rob, do you know why that addition would be useful? Replying to [comment:57 robgietema]: The code changes look good. What I don't understand is why modernizr is used. The comments in the css suggest that modernizr adds the ie6, ie7 etc classes to the html document but that is not the case, they are added using conditional html comments. The PLIP states modernizr is used to strip out HTML5 specific tags but as far as I can see none are used right now. Please explain why we need modernizr at this time. First of all, the task of this PLIP was not to introduce the new HTML5 elements, but to give a kick-start to that process by just switching to the new doctype and let end-integrators do more if they need. Modernizr, doesn't add those classes indeed and they are added with the conditional comments. That's right. Maybe I was not clear in my explanations of what Modernizr does for IE. Will try again. The issue is that Internet Explorer, when seeing unknown element, ignores it completely and does not allow one to apply any styling to such elements. Since new HTML5 elements are aliens at the moment, they fail under this exact case — end-integrators wish to go further in HTML5 implementation in their Plone theme, do add new HTML5 elements. Out of the box, they will not be able to style those in IE since the browser simply will not be able to understand what are those. So, for Internet Explorer we do one of the following: * manually write JS that would add fake instances of all new HTML5 elements and then remove them. In this case, IE will be triggered to this-guy-looks-familiar mode when the new elements are added in the HTML. It will not give them any structural meaning of course, but at least end-users will be able to style new HTML5 elements. * use one of the shims (shivs) available out there that do this automatically for IE like http://code.google.com/p/html5shim/ Modernizr has such shim built-in. So, Modernizr in this case is used to convince IE that the new elements are not aliens and it's ok to style those. More on this — http://www.modernizr.com/docs/#html5inie Next question is why Modernizr and not some shim-only solution. Modernizr is *the* feature detection solution these days. It's the only library that can detect certain features, a browser understands from HTML5/CSS3 and related technologies (like HTML5 javascript APIs, for example). In order to build a future-proof (for the browsers of the future) and backwards- compatible (with less capable browsers) HTML5 solution these days, one has to rely on feature detection. So, if we switch to HTML5, we need to give those, who is working with HTML5 sites a more or less solid ground to build their applications. If we don't add Modernizr, the whole switch would not make a lot of sense, since end-integrators will need to add it to their themes anyway if they care about more than just cutting-edge browsers. In addition, once we start transition to HTML5 in Plone, we, ourselves, need the basis for extending this integration to include new elements and new attributes to Plone itself. Once again, we will have to add Modernizr later in this case. But Modernizr has even more http://www.modernizr.com/docs/. The good thing is that with all it's features it is packed in a quite small file size (13.4KB). In my other PLIP #9352 I have already assumed we have Modernizr available in Plone that let's me fork the code for contemporary and not-so browsers in [50545] line 62. Well, the fallback for less capable browsers is still not there but you get the idea, I hope. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:58 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50347]) No need to have IEFixes.css anymore — we are using Modernizr, so we move styles from IEFixes.css. References #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:47 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50348]) Deprecate IEFixes.css from plonetheme.sunburst -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:48 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50349]) No need for cssregistry.xml in plonetheme.sunburst anymore — we deprecated IEFixes.css -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:49 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50351]) Move iefixes.js of plonetheme.classic to deprecated/ -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:50 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50355]) Added Modernizr to Products.CMFPlone tests -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:53 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50357]) updated CHANGES.txt for the branched packages. References #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:54 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): The PLIP is ready for review. Everything should be logged here. There is also an upgrade step in the branched bersion of plone.app.upgrade. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:55 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50331]) Removed plone.links.navigation viewlet (link rel='home'/ and link rel='contents'/) since the keywords using in those links are not valid in HTML5 according to the validator. References #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:39 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by mj): Replying to [comment:39 spliter]: (In [50331]) Removed plone.links.navigation viewlet (link rel='home'/ and link rel='contents'/) since the keywords using in those links are not valid in HTML5 according to the validator. References #11300 I say the validator is wrong. The HTML5 specification specifically allows for new types of link (new keywords for the rel attribute) to be defined: http://www.w3.org/TR/html5/links.html#other-link-types This part of the specification points to a wiki page: http://microformats.org/wiki/existing-rel-values and that wiki page most definitely includes the types 'home' and 'contents'. Can we file a bug with the HTML5 validator? -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:40 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): Replying to [comment:40 mj]: This part of the specification points to a wiki page: http://microformats.org/wiki/existing-rel-values This is correct Martijn. But while validator implements keywords for rel attribute it will take a while. The removed elements don't change anything significantly for Plone. It is ok to remove those. and that wiki page most definitely includes the types 'home' and 'contents'. The problem is that 'home' is still in proposals table. Means I don't see it being added to the validator any time soon. Can we file a bug with the HTML5 validator? No need to in my opinion. They know about these things and update validator with the new keywords. The last update (that broke our validation) was at the end of May. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:41 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by ldr): I don't think these links are actually used for anything anymore, I believe Opera used to have some support but I believe it has been dropped now (maybe someone who uses that browser can chime in.) I think the validator has a number of issues surrounding strict conformance to the specification, and while the pedantic part of me would like us to link directly to the specification and a defence of why Plone is already HTML5 compliant, the practical part of me thinks there are more interesting battles to fight ;) -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:42 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50335]) switched link rel=kinetic-stylesheet type=text/css / to link rel=stylesheet data-rel=kinetic-stylesheet type=text/kss / to fix HTML5 validation. References #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:43 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50336]) Removed plone.htmlhead.kss-base-url viewlet in order to get rid of link rel='kss-base-url' / that has not valid keyword for rel attribute. KSS should pick up standard base/ tag in Plone instead. References #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:44 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): (In [50338]) Actual Modernizr 2 library, it's registration and main_template updates for Plone Classic and Plone Default. References #11300 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:46 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by alecm): Thanks Denys, that's great news. Let me know if there's anything you need from the FT to make sure your work is ready in time. The one concern the framework team had during our last meeting was that it would be best if Modernizr were actually used explicitly within Plone if we're going to include it. To that end it would be a good idea to replace the current IE specific CSS/JS using Modernizr techniques. This would provide the following advantages: 1) Eating our own dog food and providing basic guidance for how to use Modernizr in a Plone context 2) Possibly reducing the number of resources served to IE clients. Does that seem like something you could include as part of the implementation? Also, do you feel there's a particular subset of Modernizr that we could/should use to minimize payload, or would it be best to include the full library? -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:37 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): I think starting using Modernizr right away is a good idea. If using it as an HTML shim in order to make IE able to style new HTML5 elements is not enough, I will deprecate our IE-specific stylesheet/js with Modernizr techniques. On the other hand, I suppose Modernizr would be a great helper for me in my other PLIP #9352, where I could use native browsers' support for some HTML5 javascript APIs and cater a fallback for less capable browsers using Modernizr's yepnope.js integration. On the other hand while these 2 are still separate PLIPs I think it would make sense to, sort of, prepare a basis for this but do actual work of Modernizr's usage for #9352 in the next Plone version. Concerning the sub-set, I think including full Modernizr is the smartest thing to do for such a generic thing as Plone. We will also need to document what features of Modernizr we are using, how and where exactly. I could do this, since I am the one who is going to integrate the library. '''Important Note.''' Currently I figured out some issues with the custom rel='' attributes we have in Plone's head on some link elements. Somehow validator suddenly stopped validating them as they are not really part of the specification, but XHTML1.1 is more loyal to them. Those custom rel attributes are used as the hooks mainly for JS and majority of those is related to KSS. I am thinking about a workaround for this atm. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:38 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): This will be ready for the feature freeze on June 30th. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:36 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by elvix): A tiny comment advocating why the move to html5 is useful: http://buytaert.net/html5-in-drupal-8 -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:33 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by ldr): It seems difficult to justify adding extra javascript if we're not going to be using any of the new HTML5 elements in vanilla Plone - it would just add unnecessary page weight for most users. Moving to modernizr.js seems justifiable if we can remove the IE conditional css/js as that will reduce the number of requests for those users. It weighs in at 3.7kb compressed, about 10% of our existing javascript for anonymous users. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:34 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Changes (by spliter): * cc: plip-advisories@… (added) Comment: So, I supose the conclusion about HTML5/Diazo can be made as: plone.app.theming should give HTML5 doctype in the output. I suppose we can postpone tinkering with core Diazo, when served from Apache or Nginx, for now. This is great. Ideal situation would be, of course, as Alec mentions to serve whatever doctype is defined in the theme though. But it's for p.a.theming PLIP. About the current PLIP. In order to have this PLIP finished, I actually, need to introduce some JS shim for Internet Explorer. I would definitely want to have Modernizr in Plone and don't agree with Laurence that it is not suitable for a point release. Modernizr should not break backwards- compatibility in Plone but instead should let authors write HTML5 and, what can be important as well, eliminates any separate stylesheets for IE- only styles. Modernizr applies special CSS class like ie-6 or ie-7, etc. on html element. Also no need in conditional comments for IE-specific stylesheets in head. Alec, I suppose I need to submit a new PLIP for Modernizr's integration. Is it correct? -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:29 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by alecm): Having looked at the Modernizr docs, it looks like a pretty good idea to me. However, if it's not required for implementing some aspect of the HTML5 transition, I'm not sure that it belongs here instead of in a separate PLIP. Similarly, I'm not sure it makes sense to PLIP it on its own unless the PLIP provides some specific ways that Plone can make direct and immediate use of Modernizr features. If it's just something people can use to help implement better HTML5 themes and content (e.g. compatible across browsers), then it may be best to just create an add-on that installs it in Plone (similar to collective.js.jqueryui). -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:30 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by spliter): Replying to [comment:30 alecm]: Having looked at the Modernizr docs, it looks like a pretty good idea to me. However, if it's not required for implementing some aspect of the HTML5 transition, I'm not sure that it belongs here instead of in a separate PLIP. In order to complete this PLIP, we need to introduce support for HTML5 elements in Internet Explorer. More reading on the topic — http://html5doctor.com/how-to-get-html5-working-in-ie-and-firefox-2/. Even though we are not going to introduce any new HTML5 elements now, the end integrators will do so and Plone should support the elements out of the box. Hence we need a shim to provide the support in IE. There are 2 ways: * we add shim-only JS (like http://remysharp.com/2009/01/07/html5 -enabling-script/) * we add Modernizr that has shim integrated together with other features. At some point Modernizr should be part of Plone in my opinion. So, integrating separate shim and then, hopefully, Modernizr doesn't really make sense to me if we can integrate Modernizr now and get the shim. Similarly, I'm not sure it makes sense to PLIP it on its own unless the PLIP provides some specific ways that Plone can make direct and immediate use of Modernizr features. If it's just something people can use to help implement better HTML5 themes and content (e.g. compatible across browsers), then it may be best to just create an add-on that installs it in Plone (similar to collective.js.jqueryui). Modernizr does provide features that Plone might start using right away: * aforementioned HTML5 elements support in IE * special CSS classes on html element for writing IE-specific styles that are valid CSS (not, silly * html hacks). With this we could deprecate ie.css an ie.js (or whatever they are called) since both of those can take advantage of the CSS classes. * In addition we get the main feature of Modernizr — feature detection. This lets us build future proof application that just get better and better over time when browsers support more and more of HTML5 natively. Second point requires main_template.pt changes so, integration of Modernizr through an add-on doesn't feel like the right thing to do. -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:31 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
Re: [PLIP-Advisories] [Plone] #11300: Switch to HTML5
#11300: Switch to HTML5 ---+ Reporter: spliter| Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Templates/CSS |Keywords: ---+ Comment(by alecm): Sounds like a good set of reasons to keep it a part of this PLIP then! -- Ticket URL: http://dev.plone.org/plone/ticket/11300#comment:32 Plone http://plone.org Plone Enterprise Content Management System ___ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories
