Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-19 Thread Anthony Jenkins
On 03/19/2015 09:49 AM, Ian Smith wrote: > On Thu, 19 Mar 2015 09:11:08 -0400, Anthony Jenkins wrote: > > On 03/19/2015 04:10 AM, Ian Smith wrote: > > > On Wed, 18 Mar 2015 15:30:23 -0600, Warner Losh wrote: > > > > > On Mar 18, 2015, at 10:06 AM, Anthony Jenkins > wrote: > > > > > > > >

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-19 Thread Ian Smith
On Thu, 19 Mar 2015 09:11:08 -0400, Anthony Jenkins wrote: > On 03/19/2015 04:10 AM, Ian Smith wrote: > > On Wed, 18 Mar 2015 15:30:23 -0600, Warner Losh wrote: > > > > On Mar 18, 2015, at 10:06 AM, Anthony Jenkins > > wrote: > > > > > > > > On 03/18/2015 11:29 AM, Warner Losh wrote: >

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-19 Thread Anthony Jenkins
On 03/18/2015 05:32 PM, Warner Losh wrote: >> On Mar 18, 2015, at 9:59 AM, Anthony Jenkins >> wrote: >> >> On 03/18/2015 11:26 AM, Warner Losh wrote: >>> Looking at patch 5: >>> >>> You need to rework this so there’s an atrtc_acpi.c. Put all the ACPI >>> attachment in there. >> Okay, shouldn't b

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-19 Thread Anthony Jenkins
On 03/19/2015 04:10 AM, Ian Smith wrote: > On Wed, 18 Mar 2015 15:30:23 -0600, Warner Losh wrote: > > > On Mar 18, 2015, at 10:06 AM, Anthony Jenkins > wrote: > > > > > > On 03/18/2015 11:29 AM, Warner Losh wrote: > > >>> On Mar 17, 2015, at 7:02 AM, Anthony Jenkins > wrote: > > \Whe

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-19 Thread Ian Smith
On Wed, 18 Mar 2015 15:30:23 -0600, Warner Losh wrote: > > On Mar 18, 2015, at 10:06 AM, Anthony Jenkins > > wrote: > > > > On 03/18/2015 11:29 AM, Warner Losh wrote: > >>> On Mar 17, 2015, at 7:02 AM, Anthony Jenkins > >>> wrote: > \Where else might ATRTC_VERBOSE be set otherwise?

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-18 Thread Warner Losh
> On Mar 18, 2015, at 9:59 AM, Anthony Jenkins > wrote: > > On 03/18/2015 11:26 AM, Warner Losh wrote: >> Looking at patch 5: >> >> You need to rework this so there’s an atrtc_acpi.c. Put all the ACPI >> attachment in there. > > Okay, shouldn't be a problem. > >> You should also split off t

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-18 Thread Warner Losh
> On Mar 18, 2015, at 10:06 AM, Anthony Jenkins > wrote: > > On 03/18/2015 11:29 AM, Warner Losh wrote: >>> On Mar 17, 2015, at 7:02 AM, Anthony Jenkins >>> wrote: \Where else might ATRTC_VERBOSE be set otherwise? >>> I'm picturing a (future?) config(5) knob, e.g. >>> >>> device atrtc

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-18 Thread Jung-uk Kim
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/17/2015 08:28, Ian Smith wrote: > I still wonder if there isn't a global acpi_loaded_and_running > variable so you could avoid even attempting ACPI init calls, > perhaps making this not so dependent on ACPI, at least at runtime. For runtime, p

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-18 Thread Anthony Jenkins
On 03/18/2015 11:29 AM, Warner Losh wrote: >> On Mar 17, 2015, at 7:02 AM, Anthony Jenkins >> wrote: >>> \Where else might ATRTC_VERBOSE be set otherwise? >> I'm picturing a (future?) config(5) knob, e.g. >> >>device atrtc >>options ATRTC_VERBOSE=1 >> >> >> so it can be set at compile tim

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-18 Thread Anthony Jenkins
On 03/18/2015 11:26 AM, Warner Losh wrote: > Looking at patch 5: > > You need to rework this so there’s an atrtc_acpi.c. Put all the ACPI > attachment in there. Okay, shouldn't be a problem. > You should also split off the little bit that’s ISA-specific into atrtc_isa. You mean rtcin() and writ

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-18 Thread Warner Losh
> On Mar 17, 2015, at 7:02 AM, Anthony Jenkins > wrote: >> \Where else might ATRTC_VERBOSE be set otherwise? > > I'm picturing a (future?) config(5) knob, e.g. > >device atrtc >options ATRTC_VERBOSE=1 > > > so it can be set at compile time. Why not just boot verbose? history has sho

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-18 Thread Warner Losh
Looking at patch 5: You need to rework this so there’s an atrtc_acpi.c. Put all the ACPI attachment in there. You should also split off the little bit that’s ISA-specific into atrtc_isa. Once you do that, we can talk. Warner signature.asc Description: Message signed with OpenPGP using GPGMai

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-17 Thread Anthony Jenkins
On 03/17/2015 08:28 AM, Ian Smith wrote: > On Mon, 16 Mar 2015 15:51:30 -0400, Anthony Jenkins wrote: > > On 03/16/2015 01:49 PM, Ian Smith wrote: > > > On Mon, 16 Mar 2015 11:50:59 -0400, Anthony Jenkins wrote: > > > > On 03/16/2015 11:00 AM, Anthony Jenkins wrote: > > > > > On 03/16/2015 09

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-17 Thread Ian Smith
On Mon, 16 Mar 2015 15:51:30 -0400, Anthony Jenkins wrote: > On 03/16/2015 01:49 PM, Ian Smith wrote: > > On Mon, 16 Mar 2015 11:50:59 -0400, Anthony Jenkins wrote: > > > On 03/16/2015 11:00 AM, Anthony Jenkins wrote: > > > > On 03/16/2015 09:59 AM, Ian Smith wrote: > > > >> On Sat, 14 Mar

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-16 Thread Anthony Jenkins
On 03/16/15 19:36, Jung-uk Kim wrote: > On 03/16/2015 15:51, Anthony Jenkins wrote: > > On 03/16/2015 01:49 PM, Ian Smith wrote: > >> On Mon, 16 Mar 2015 11:50:59 -0400, Anthony Jenkins wrote: > >>> On 03/16/2015 11:00 AM, Anthony Jenkins wrote: > On 03/16/2015 09:59 AM, Ian Smith wrote: > >

Re: [PATCH] ACPI CMOS region support rev. 5

2015-03-16 Thread Jung-uk Kim
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/16/2015 15:51, Anthony Jenkins wrote: > On 03/16/2015 01:49 PM, Ian Smith wrote: >> On Mon, 16 Mar 2015 11:50:59 -0400, Anthony Jenkins wrote: >>> On 03/16/2015 11:00 AM, Anthony Jenkins wrote: On 03/16/2015 09:59 AM, Ian Smith wrote: