Re: VM_METER no longer defined?

2003-01-19 Thread Matthew Dillon
: #define VM_METER VM_TOTAL This change was part of a larger patch set. I have no particular objection to adding the #define or renaming VM_TOTAL back to VM_METER, but I *WILL* point out that even without a name change the VM cnt structure has changed so often that for all

Re: VM_METER no longer defined?

2003-01-18 Thread Hiten Pandya
On Fri, Jan 17, 2003 at 04:39:42PM -0700, Scott Long wrote the words in effect of: Craig Rodrigues wrote: On Fri, Jan 17, 2003 at 10:26:10AM -0800, Will Andrews wrote: Of course, these things can be fixed. But I consider this change gratuitous and it breaks standard compatability rules:

Re: VM_METER no longer defined?

2003-01-18 Thread Scott Long
Hiten Pandya wrote: On Fri, Jan 17, 2003 at 04:39:42PM -0700, Scott Long wrote the words in effect of: Craig Rodrigues wrote: On Fri, Jan 17, 2003 at 10:26:10AM -0800, Will Andrews wrote: Of course, these things can be fixed. But I consider this change gratuitous and it breaks standard

Re: VM_METER no longer defined?

2003-01-18 Thread Joe Marcus Clarke
On Sat, 2003-01-18 at 15:20, Scott Long wrote: Hiten Pandya wrote: On Fri, Jan 17, 2003 at 04:39:42PM -0700, Scott Long wrote the words in effect of: Craig Rodrigues wrote: On Fri, Jan 17, 2003 at 10:26:10AM -0800, Will Andrews wrote: Of course, these things can be

Re: VM_METER no longer defined?

2003-01-18 Thread Will Andrews
On Sat, Jan 18, 2003 at 04:02:00PM -0500, Joe Marcus Clarke wrote: Ok, I agree that the naming could cause confusion since there is a vmmeter struct and a vmtotal struct. However, the Release Engineering policy that was set out at the start of RELENG_5_0 is that public API changes need

Re: VM_METER no longer defined?

2003-01-18 Thread David O'Brien
On Fri, Jan 17, 2003 at 05:23:30AM -0600, Conrad Sabatier wrote: Pardon me if I missed something, but what's become of the definition of VM_METER? It is nowhere to be found under /usr/include. This breaks a few ports, kdebase3 being one of the most notable. I committed a work around --

Re: VM_METER no longer defined?

2003-01-18 Thread Scott Long
Joe Marcus Clarke wrote: On Sat, 2003-01-18 at 15:20, Scott Long wrote: Hiten Pandya wrote: On Fri, Jan 17, 2003 at 04:39:42PM -0700, Scott Long wrote the words in effect of: Craig Rodrigues wrote: On Fri, Jan 17, 2003 at 10:26:10AM -0800, Will Andrews wrote: Of course, these things

Re: VM_METER no longer defined?

2003-01-18 Thread Mark Murray
[ Very large SNIP ] Scott Long wrote: I'm fully aware of that. As I state in the previous email, I'd like to see 5.0-5.1 happen as smoothly as possible. For background, go re-read my email to developers@ when the RELENG_5_0 branch happened. Fair enough. Also, it's common practice to

Re: VM_METER no longer defined?

2003-01-18 Thread Scott Long
Mark Murray wrote: [ Very large SNIP ] Scott Long wrote: I'm fully aware of that. As I state in the previous email, I'd like to see 5.0-5.1 happen as smoothly as possible. For background, go re-read my email to developers@ when the RELENG_5_0 branch happened. Fair enough. Also, it's

Re: VM_METER no longer defined?

2003-01-18 Thread David O'Brien
On Sat, Jan 18, 2003 at 02:40:45PM -0700, Scott Long wrote: a line like #warning VM_METER is deprecated and will be removed on kluctember 43, 2861 would be nice to, of course. =-) I wanted this, but I don't know who to implement it so that it only prints out IIF VM_METER is used somewhere

Re: VM_METER no longer defined?

2003-01-18 Thread Juli Mallett
* De: David O'Brien [EMAIL PROTECTED] [ Data: 2003-01-18 ] [ Subjecte: Re: VM_METER no longer defined? ] On Sat, Jan 18, 2003 at 02:40:45PM -0700, Scott Long wrote: a line like #warning VM_METER is deprecated and will be removed on kluctember 43, 2861 would be nice

Re: VM_METER no longer defined?

2003-01-18 Thread Bruce Evans
On Sat, 18 Jan 2003, Mark Murray wrote: [ Very large SNIP ] Scott Long wrote: I'm fully aware of that. As I state in the previous email, I'd like to see 5.0-5.1 happen as smoothly as possible. For background, go re-read my email to developers@ when the RELENG_5_0 branch happened.

VM_METER no longer defined?

2003-01-17 Thread Conrad Sabatier
Pardon me if I missed something, but what's become of the definition of VM_METER? It is nowhere to be found under /usr/include. This breaks a few ports, kdebase3 being one of the most notable. -- Conrad Sabatier [EMAIL PROTECTED] - In Unix veritas To Unsubscribe: send mail to [EMAIL

Re: VM_METER no longer defined?

2003-01-17 Thread Scott Long
Conrad Sabatier wrote: Pardon me if I missed something, but what's become of the definition of VM_METER? It is nowhere to be found under /usr/include. This breaks a few ports, kdebase3 being one of the most notable. I've got to admit that this one slipped in under my radar. Would the

Re: VM_METER no longer defined?

2003-01-17 Thread Craig Rodrigues
On Fri, Jan 17, 2003 at 10:42:27AM -0700, Scott Long wrote: I've got to admit that this one slipped in under my radar. Would the committer and submitter please give an explanation of why VM_METER was changed? The commit which removed VM_METER is here:

Re: VM_METER no longer defined?

2003-01-17 Thread Joe Marcus Clarke
On Fri, 2003-01-17 at 12:42, Scott Long wrote: Conrad Sabatier wrote: Pardon me if I missed something, but what's become of the definition of VM_METER? It is nowhere to be found under /usr/include. This breaks a few ports, kdebase3 being one of the most notable. I've got to admit

Re: VM_METER no longer defined?

2003-01-17 Thread Will Andrews
On Fri, Jan 17, 2003 at 01:02:07PM -0500, Joe Marcus Clarke wrote: It looks like Matt did this to fix vm.vmtotal. From sys/vm/vm_param.h: Make 'sysctl vm.vmtotal' work properly using updated patch from Hiten. (the patch in the PR was stale). It looks to have been replaced by VM_TOTAL. I

Re: VM_METER no longer defined?

2003-01-17 Thread Craig Rodrigues
On Fri, Jan 17, 2003 at 10:26:10AM -0800, Will Andrews wrote: Of course, these things can be fixed. But I consider this change gratuitous and it breaks standard compatability rules: deprecate for one major version and remove in the second. I haven't seen any reason why this couldn't be added

Re: VM_METER no longer defined?

2003-01-17 Thread Scott Long
Craig Rodrigues wrote: On Fri, Jan 17, 2003 at 10:26:10AM -0800, Will Andrews wrote: Of course, these things can be fixed. But I consider this change gratuitous and it breaks standard compatability rules: deprecate for one major version and remove in the second. I haven't seen any reason why

Re: VM_METER no longer defined?

2003-01-17 Thread Bruce Evans
On Fri, 17 Jan 2003, Scott Long wrote: Craig Rodrigues wrote: Index: vm_param.h === RCS file: /home/ncvs/src/sys/vm/vm_param.h,v retrieving revision 1.16 diff -u -r1.16 vm_param.h --- vm_param.h 2003/01/11 07:29:46