Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-12-02 Thread Andriy Gapon
on 02/12/2011 03:04 Arnaud Lacombe said the following: Hi, On Mon, Nov 14, 2011 at 5:14 AM, Andriy Gapon a...@freebsd.org wrote: on 14/11/2011 02:38 Arnaud Lacombe said the following: you (committers) I wonder how it would work out if you were made a committer and couldn't say you

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-12-02 Thread Julian Elischer
On 12/1/11 5:04 PM, Arnaud Lacombe wrote: Hi, On Mon, Nov 14, 2011 at 5:14 AM, Andriy Gapona...@freebsd.org wrote: on 14/11/2011 02:38 Arnaud Lacombe said the following: you (committers) I wonder how it would work out if you were made a committer and couldn't say you (committers) any

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-12-01 Thread Arnaud Lacombe
Hi, On Mon, Nov 14, 2011 at 5:14 AM, Andriy Gapon a...@freebsd.org wrote: on 14/11/2011 02:38 Arnaud Lacombe said the following: you (committers) I wonder how it would work out if you were made a committer and couldn't say you (committers) any more... :-) The real question is rather whether

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Attilio Rao
2011/11/18 Attilio Rao atti...@freebsd.org: 2011/11/18 Attilio Rao atti...@freebsd.org: 2011/11/18 Kostik Belousov kostik...@gmail.com: On Fri, Nov 18, 2011 at 11:40:28AM +0100, Attilio Rao wrote: 2011/11/16 Kostik Belousov kostik...@gmail.com: On Tue, Nov 15, 2011 at 07:15:01PM +0100,

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Kostik Belousov
On Sun, Nov 20, 2011 at 05:37:33PM +0100, Attilio Rao wrote: 2011/11/18 Attilio Rao atti...@freebsd.org: Please consider: http://www.freebsd.org/~attilio/mutexfileline2.patch This is now committed as r227758,227759, you can update your patch now. Here is it. diff --git a/sys/vm/vm_page.c

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Attilio Rao
2011/11/20 Kostik Belousov kostik...@gmail.com: On Sun, Nov 20, 2011 at 05:37:33PM +0100, Attilio Rao wrote: 2011/11/18 Attilio Rao atti...@freebsd.org: Please consider: http://www.freebsd.org/~attilio/mutexfileline2.patch This is now committed as r227758,227759, you can update your patch

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Kostik Belousov
On Sun, Nov 20, 2011 at 07:02:14PM +0100, Attilio Rao wrote: 2011/11/20 Kostik Belousov kostik...@gmail.com: +#define        vm_page_lock_assert(m, a)       \ +    vm_page_lock_assert_KBI((m), (a), LOCK_FILE, LOCK_LINE) I think you should put the \ in the last tab and also, for

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Attilio Rao
It looks good to me. Attilio 2011/11/20 Kostik Belousov kostik...@gmail.com: On Sun, Nov 20, 2011 at 07:02:14PM +0100, Attilio Rao wrote: 2011/11/20 Kostik Belousov kostik...@gmail.com: +#define        vm_page_lock_assert(m, a)       \ +    vm_page_lock_assert_KBI((m), (a), LOCK_FILE,

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Attilio Rao
2011/11/20 Attilio Rao atti...@freebsd.org: 2011/11/18 Attilio Rao atti...@freebsd.org: 2011/11/18 Attilio Rao atti...@freebsd.org: 2011/11/18 Kostik Belousov kostik...@gmail.com: On Fri, Nov 18, 2011 at 11:40:28AM +0100, Attilio Rao wrote: 2011/11/16 Kostik Belousov kostik...@gmail.com: On

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Kostik Belousov
On Sun, Nov 20, 2011 at 08:04:21PM +0100, Attilio Rao wrote: This other patch converts sx to a similar interface which cleans up vm_map.c: http://www.freebsd.org/~attilio/sxfileline.patch What do you think about it? This one only changes the KBI ? Note that _sx suffix is not reserved.

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Attilio Rao
2011/11/20 Kostik Belousov kostik...@gmail.com: On Sun, Nov 20, 2011 at 08:04:21PM +0100, Attilio Rao wrote: This other patch converts sx to a similar interface which cleans up vm_map.c: http://www.freebsd.org/~attilio/sxfileline.patch What do you think about it? This one only changes the

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Kostik Belousov
On Sun, Nov 20, 2011 at 08:22:38PM +0100, Attilio Rao wrote: 2011/11/20 Kostik Belousov kostik...@gmail.com: On Sun, Nov 20, 2011 at 08:04:21PM +0100, Attilio Rao wrote: This other patch converts sx to a similar interface which cleans up vm_map.c:

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-20 Thread Attilio Rao
2011/11/20 Kostik Belousov kostik...@gmail.com: On Sun, Nov 20, 2011 at 08:22:38PM +0100, Attilio Rao wrote: 2011/11/20 Kostik Belousov kostik...@gmail.com: On Sun, Nov 20, 2011 at 08:04:21PM +0100, Attilio Rao wrote: This other patch converts sx to a similar interface which cleans up

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-18 Thread Attilio Rao
2011/11/16 Kostik Belousov kostik...@gmail.com: On Tue, Nov 15, 2011 at 07:15:01PM +0100, Attilio Rao wrote: 2011/11/7 Kostik Belousov kostik...@gmail.com: On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok.  I'll offer one final suggestion.  Please consider an alternative suffix

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-18 Thread Kostik Belousov
On Fri, Nov 18, 2011 at 11:40:28AM +0100, Attilio Rao wrote: 2011/11/16 Kostik Belousov kostik...@gmail.com: On Tue, Nov 15, 2011 at 07:15:01PM +0100, Attilio Rao wrote: 2011/11/7 Kostik Belousov kostik...@gmail.com: On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok.  I'll

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-18 Thread Attilio Rao
2011/11/18 Kostik Belousov kostik...@gmail.com: On Fri, Nov 18, 2011 at 11:40:28AM +0100, Attilio Rao wrote: 2011/11/16 Kostik Belousov kostik...@gmail.com: On Tue, Nov 15, 2011 at 07:15:01PM +0100, Attilio Rao wrote: 2011/11/7 Kostik Belousov kostik...@gmail.com: On Mon, Nov 07, 2011 at

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-18 Thread Kostik Belousov
On Fri, Nov 18, 2011 at 11:56:55AM +0100, Attilio Rao wrote: 2011/11/18 Kostik Belousov kostik...@gmail.com: On Fri, Nov 18, 2011 at 11:40:28AM +0100, Attilio Rao wrote: 2011/11/16 Kostik Belousov kostik...@gmail.com: On Tue, Nov 15, 2011 at 07:15:01PM +0100, Attilio Rao wrote:

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-18 Thread Attilio Rao
2011/11/18 Attilio Rao atti...@freebsd.org: 2011/11/18 Kostik Belousov kostik...@gmail.com: On Fri, Nov 18, 2011 at 11:40:28AM +0100, Attilio Rao wrote: 2011/11/16 Kostik Belousov kostik...@gmail.com: On Tue, Nov 15, 2011 at 07:15:01PM +0100, Attilio Rao wrote: 2011/11/7 Kostik Belousov

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-16 Thread Kostik Belousov
On Tue, Nov 15, 2011 at 07:15:01PM +0100, Attilio Rao wrote: 2011/11/7 Kostik Belousov kostik...@gmail.com: On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok.  I'll offer one final suggestion.  Please consider an alternative suffix to func.  Perhaps, kbi or KBI.  In other words,

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-15 Thread Attilio Rao
2011/11/7 Kostik Belousov kostik...@gmail.com: On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok.  I'll offer one final suggestion.  Please consider an alternative suffix to func.  Perhaps, kbi or KBI.  In other words, something that hints at the function's reason for existing.

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-15 Thread mdf
On Tue, Nov 15, 2011 at 10:15 AM, Attilio Rao atti...@freebsd.org wrote: 2011/11/7 Kostik Belousov kostik...@gmail.com: On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok.  I'll offer one final suggestion.  Please consider an alternative suffix to func.  Perhaps, kbi or KBI.  In

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-15 Thread Attilio Rao
2011/11/15 m...@freebsd.org: On Tue, Nov 15, 2011 at 10:15 AM, Attilio Rao atti...@freebsd.org wrote: 2011/11/7 Kostik Belousov kostik...@gmail.com: On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok.  I'll offer one final suggestion.  Please consider an alternative suffix to func.

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-15 Thread John Baldwin
On Sunday, November 06, 2011 11:42:04 am Kostik Belousov wrote: On Sun, Nov 06, 2011 at 07:22:51AM -0800, m...@freebsd.org wrote: On Sun, Nov 6, 2011 at 4:43 AM, Kostik Belousov kostik...@gmail.com wrote: Regarding the _vm_page_lock() vs. vm_page_lock_func(), the mutex.h has a lot of

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-14 Thread Andriy Gapon
on 14/11/2011 02:38 Arnaud Lacombe said the following: you (committers) I wonder how it would work out if you were made a committer and couldn't say you (committers) any more... :-) I.e. is it possible to change your mindset from me (and us) versus you to just us? The lines between committers

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-13 Thread Arnaud Lacombe
Hi, On Wed, Nov 9, 2011 at 12:39 PM, Julian Elischer jul...@freebsd.org wrote: On 11/8/11 9:29 PM, Arnaud Lacombe wrote: [...] However, if you want to know, my heart tends to be with BSDs. Unfortunately, it's a sad love-story where your Beloved keeps deceiving you day after day. You want to

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-09 Thread Oliver Pinter
On 11/9/11, Arnaud Lacombe lacom...@gmail.com wrote: Hi, On Tue, Nov 8, 2011 at 9:35 PM, Julian Elischer jul...@freebsd.org wrote: On 11/8/11 5:52 PM, Arnaud Lacombe wrote: Hi, On Tue, Nov 8, 2011 at 7:08 PM, Julian Elischerjul...@freebsd.org wrote: On 11/8/11 10:49 AM, Arnaud Lacombe

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-09 Thread Julian Elischer
On 11/8/11 9:29 PM, Arnaud Lacombe wrote: Hi, On Tue, Nov 8, 2011 at 9:35 PM, Julian Elischerjul...@freebsd.org wrote: On 11/8/11 5:52 PM, Arnaud Lacombe wrote: Hi, On Tue, Nov 8, 2011 at 7:08 PM, Julian Elischerjul...@freebsd.org wrote: On 11/8/11 10:49 AM, Arnaud Lacombe wrote: Hi, To

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-09 Thread Daniel O'Connor
On 10/11/2011, at 4:09, Julian Elischer wrote: well write a driver for it.. what do you think I'm doing with the driver I'm talking about? I wrote several bypass network card drivers when I was at cisco/ironport.. it's not rocket science, though it would be nice if we were to come up with

Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Arnaud Lacombe
Hi, On Mon, Nov 7, 2011 at 2:03 PM, Arnaud Lacombe lacom...@gmail.com wrote: On Mon, Nov 7, 2011 at 4:36 AM, Attilio Rao atti...@freebsd.org wrote: 2011/11/7 Arnaud Lacombe lacom...@gmail.com: Hi, On Sat, Nov 5, 2011 at 10:13 AM, Kostik Belousov kostik...@gmail.com wrote: On Fri, Nov 04,

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Attilio Rao
2011/11/8 Arnaud Lacombe lacom...@gmail.com: Hi, On Mon, Nov 7, 2011 at 2:03 PM, Arnaud Lacombe lacom...@gmail.com wrote: On Mon, Nov 7, 2011 at 4:36 AM, Attilio Rao atti...@freebsd.org wrote: 2011/11/7 Arnaud Lacombe lacom...@gmail.com: Hi, On Sat, Nov 5, 2011 at 10:13 AM, Kostik Belousov

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Andriy Gapon
[cc list trimmed] on 08/11/2011 22:34 Attilio Rao said the following: 2011/11/8 Arnaud Lacombe lacom...@gmail.com: To avoid future complaints about the fact that I would be only talk without action, I did implement what I suggested above. As it is quite a large patch-set, I will not post it

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Julian Elischer
On 11/8/11 10:49 AM, Arnaud Lacombe wrote: Hi, To avoid future complaints about the fact that I would be only talk without action, I did implement what I suggested above. As it is quite a large patch-set, I will not post it directly here, however, it is available on github:

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Arnaud Lacombe
Hi, On Tue, Nov 8, 2011 at 7:08 PM, Julian Elischer jul...@freebsd.org wrote: On 11/8/11 10:49 AM, Arnaud Lacombe wrote: Hi, To avoid future complaints about the fact that I would be only talk without action, I did implement what I suggested above. As it is quite a large patch-set, I will

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Arnaud Lacombe
Hi, On Tue, Nov 8, 2011 at 3:55 PM, Andriy Gapon a...@freebsd.org wrote: [cc list trimmed] on 08/11/2011 22:34 Attilio Rao said the following: 2011/11/8 Arnaud Lacombe lacom...@gmail.com: To avoid future complaints about the fact that I would be only talk without action, I did implement

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Arnaud Lacombe
Hi, On Tue, Nov 8, 2011 at 3:34 PM, Attilio Rao atti...@freebsd.org wrote: 2011/11/8 Arnaud Lacombe lacom...@gmail.com: Hi, On Mon, Nov 7, 2011 at 2:03 PM, Arnaud Lacombe lacom...@gmail.com wrote: On Mon, Nov 7, 2011 at 4:36 AM, Attilio Rao atti...@freebsd.org wrote: 2011/11/7 Arnaud

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Arnaud Lacombe
Hi, On Tue, Nov 8, 2011 at 8:09 PM, Arnaud Lacombe lacom...@gmail.com wrote: Hi, On Tue, Nov 8, 2011 at 3:55 PM, Andriy Gapon a...@freebsd.org wrote: [cc list trimmed] on 08/11/2011 22:34 Attilio Rao said the following: 2011/11/8 Arnaud Lacombe lacom...@gmail.com: To avoid future

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Arnaud Lacombe
Hi, On Tue, Nov 8, 2011 at 7:08 PM, Julian Elischer jul...@freebsd.org wrote: On 11/8/11 10:49 AM, Arnaud Lacombe wrote: Hi, To avoid future complaints about the fact that I would be only talk without action, I did implement what I suggested above. As it is quite a large patch-set, I will

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Julian Elischer
On 11/8/11 5:22 PM, Arnaud Lacombe wrote: Hi, On Tue, Nov 8, 2011 at 3:34 PM, Attilio Raoatti...@freebsd.org wrote: 2011/11/8 Arnaud Lacombelacom...@gmail.com: Hi, On Mon, Nov 7, 2011 at 2:03 PM, Arnaud Lacombelacom...@gmail.com wrote: On Mon, Nov 7, 2011 at 4:36 AM, Attilio

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Julian Elischer
On 11/8/11 5:52 PM, Arnaud Lacombe wrote: Hi, On Tue, Nov 8, 2011 at 7:08 PM, Julian Elischerjul...@freebsd.org wrote: On 11/8/11 10:49 AM, Arnaud Lacombe wrote: Hi, To avoid future complaints about the fact that I would be only talk without action, I did implement what I suggested above. As

Re: Using Instruction Pointer address in debug interfaces [Was: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]]

2011-11-08 Thread Arnaud Lacombe
Hi, On Tue, Nov 8, 2011 at 9:35 PM, Julian Elischer jul...@freebsd.org wrote: On 11/8/11 5:52 PM, Arnaud Lacombe wrote: Hi, On Tue, Nov 8, 2011 at 7:08 PM, Julian Elischerjul...@freebsd.org  wrote: On 11/8/11 10:49 AM, Arnaud Lacombe wrote: Hi, To avoid future complaints about the fact

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-07 Thread Attilio Rao
2011/11/7 Arnaud Lacombe lacom...@gmail.com: Hi, On Sat, Nov 5, 2011 at 10:13 AM, Kostik Belousov kostik...@gmail.com wrote: On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote: Below is the KBI patch after vm_page_bits_t merge is done. Again, I did not spent time converting all

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-07 Thread Attilio Rao
2011/11/7 Attilio Rao atti...@freebsd.org: 2011/11/7 Arnaud Lacombe lacom...@gmail.com: Hi, On Sat, Nov 5, 2011 at 10:13 AM, Kostik Belousov kostik...@gmail.com wrote: On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote: Below is the KBI patch after vm_page_bits_t merge is done.

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-07 Thread Alan Cox
On 11/06/2011 06:43, Kostik Belousov wrote: On Sat, Nov 05, 2011 at 03:00:58PM -0500, Alan Cox wrote: On 11/05/2011 10:15, Kostik Belousov wrote: On Sat, Nov 05, 2011 at 07:37:48AM -0700, m...@freebsd.org wrote: On Sat, Nov 5, 2011 at 7:13 AM, Kostik Belousovkostik...@gmail.com wrote: On

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-07 Thread Arnaud Lacombe
On Mon, Nov 7, 2011 at 4:36 AM, Attilio Rao atti...@freebsd.org wrote: 2011/11/7 Arnaud Lacombe lacom...@gmail.com: Hi, On Sat, Nov 5, 2011 at 10:13 AM, Kostik Belousov kostik...@gmail.com wrote: On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote: Below is the KBI patch after

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-07 Thread Arnaud Lacombe
Hi, On Wed, Nov 2, 2011 at 6:32 AM, Andriy Gapon a...@freebsd.org wrote: [restored cc: to the original poster] on 02/11/2011 08:10 Benjamin Kaduk said the following: I am perhaps confused.  Last I checked, bsd.kmod.mk caused '-include opt_global.h' to be passed on the command line.  Is the

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-07 Thread Kostik Belousov
On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok. I'll offer one final suggestion. Please consider an alternative suffix to func. Perhaps, kbi or KBI. In other words, something that hints at the function's reason for existing. Sure. Below is the extraction of only

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-07 Thread Arnaud Lacombe
Hi, On Mon, Nov 7, 2011 at 2:03 PM, Arnaud Lacombe lacom...@gmail.com wrote: On Mon, Nov 7, 2011 at 4:36 AM, Attilio Rao atti...@freebsd.org wrote: I'm unsure if this replies to your concerns because you just criticize without making a real technical question in this post. I made comments on

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-07 Thread mdf
On Mon, Nov 7, 2011 at 11:35 AM, Kostik Belousov kostik...@gmail.com wrote: On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok.  I'll offer one final suggestion.  Please consider an alternative suffix to func.  Perhaps, kbi or KBI.  In other words, something that hints at the

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-07 Thread Kostik Belousov
On Mon, Nov 07, 2011 at 11:47:59AM -0800, m...@freebsd.org wrote: On Mon, Nov 7, 2011 at 11:35 AM, Kostik Belousov kostik...@gmail.com wrote: On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok.  I'll offer one final suggestion.  Please consider an alternative suffix to func.  

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-07 Thread Arnaud Lacombe
Hi, On Mon, Nov 7, 2011 at 2:35 PM, Kostik Belousov kostik...@gmail.com wrote: On Mon, Nov 07, 2011 at 11:45:38AM -0600, Alan Cox wrote: Ok.  I'll offer one final suggestion.  Please consider an alternative suffix to func.  Perhaps, kbi or KBI.  In other words, something that hints at the

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-06 Thread Kostik Belousov
On Sat, Nov 05, 2011 at 03:00:58PM -0500, Alan Cox wrote: On 11/05/2011 10:15, Kostik Belousov wrote: On Sat, Nov 05, 2011 at 07:37:48AM -0700, m...@freebsd.org wrote: On Sat, Nov 5, 2011 at 7:13 AM, Kostik Belousovkostik...@gmail.com wrote: On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-06 Thread mdf
On Sun, Nov 6, 2011 at 4:43 AM, Kostik Belousov kostik...@gmail.com wrote: Regarding the _vm_page_lock() vs. vm_page_lock_func(), the mutex.h has a lot of violations in regard of the namespaces, IMO. The __* namespace is reserved for the language implementation, so our freestanding program

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-06 Thread Kostik Belousov
On Sun, Nov 06, 2011 at 07:22:51AM -0800, m...@freebsd.org wrote: On Sun, Nov 6, 2011 at 4:43 AM, Kostik Belousov kostik...@gmail.com wrote: Regarding the _vm_page_lock() vs. vm_page_lock_func(), the mutex.h has a lot of violations in regard of the namespaces, IMO. The __* namespace is

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-06 Thread Arnaud Lacombe
Hi, On Sat, Nov 5, 2011 at 10:13 AM, Kostik Belousov kostik...@gmail.com wrote: On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote: Below is the KBI patch after vm_page_bits_t merge is done. Again, I did not spent time converting all in-tree consumers from the (potentially)

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-06 Thread Arnaud Lacombe
Hi, On Sun, Nov 6, 2011 at 11:42 AM, Kostik Belousov kostik...@gmail.com wrote: On Sun, Nov 06, 2011 at 07:22:51AM -0800, m...@freebsd.org wrote: On Sun, Nov 6, 2011 at 4:43 AM, Kostik Belousov kostik...@gmail.com wrote: Regarding the _vm_page_lock() vs. vm_page_lock_func(), the mutex.h has

vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-05 Thread Kostik Belousov
On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote: Below is the KBI patch after vm_page_bits_t merge is done. Again, I did not spent time converting all in-tree consumers from the (potentially) loadable modules to the new KPI until it is agreed upon. diff --git

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-05 Thread mdf
On Sat, Nov 5, 2011 at 7:13 AM, Kostik Belousov kostik...@gmail.com wrote: On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote: Below is the KBI patch after vm_page_bits_t merge is done. Again, I did not spent time converting all in-tree consumers from the (potentially) loadable

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-05 Thread Kostik Belousov
On Sat, Nov 05, 2011 at 07:37:48AM -0700, m...@freebsd.org wrote: On Sat, Nov 5, 2011 at 7:13 AM, Kostik Belousov kostik...@gmail.com wrote: On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote: Below is the KBI patch after vm_page_bits_t merge is done. Again, I did not spent

Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3]

2011-11-05 Thread Alan Cox
On 11/05/2011 10:15, Kostik Belousov wrote: On Sat, Nov 05, 2011 at 07:37:48AM -0700, m...@freebsd.org wrote: On Sat, Nov 5, 2011 at 7:13 AM, Kostik Belousovkostik...@gmail.com wrote: On Fri, Nov 04, 2011 at 06:03:39PM +0200, Kostik Belousov wrote: Below is the KBI patch after vm_page_bits_t

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-04 Thread Kostik Belousov
On Thu, Nov 03, 2011 at 12:51:10PM -0500, Alan Cox wrote: On 11/03/2011 08:24, Kostik Belousov wrote: On Thu, Nov 03, 2011 at 12:40:08AM -0500, Alan Cox wrote: On 11/02/2011 05:32, Andriy Gapon wrote: [restored cc: to the original poster] As Bruce Evans has pointed to me privately [I am not

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-04 Thread Alan Cox
On 11/04/2011 05:08, Kostik Belousov wrote: On Thu, Nov 03, 2011 at 12:51:10PM -0500, Alan Cox wrote: On 11/03/2011 08:24, Kostik Belousov wrote: On Thu, Nov 03, 2011 at 12:40:08AM -0500, Alan Cox wrote: On 11/02/2011 05:32, Andriy Gapon wrote: [restored cc: to the original poster] As Bruce

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-04 Thread Kostik Belousov
On Fri, Nov 04, 2011 at 10:09:09AM -0500, Alan Cox wrote: On 11/04/2011 05:08, Kostik Belousov wrote: On Thu, Nov 03, 2011 at 12:51:10PM -0500, Alan Cox wrote: I would suggest introducing the vm_page_bits_t change first. If, at the same time, you change the return type from the function

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-04 Thread Alan Cox
On 11/04/2011 10:30, Kostik Belousov wrote: On Fri, Nov 04, 2011 at 10:09:09AM -0500, Alan Cox wrote: On 11/04/2011 05:08, Kostik Belousov wrote: On Thu, Nov 03, 2011 at 12:51:10PM -0500, Alan Cox wrote: I would suggest introducing the vm_page_bits_t change first. If, at the same time, you

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-04 Thread Kostik Belousov
On Fri, Nov 04, 2011 at 10:48:45AM -0500, Alan Cox wrote: On 11/04/2011 10:30, Kostik Belousov wrote: for (b = i = 0; i= PAGE_SIZE / DEV_BSIZE; ++i) { if (i == (PAGE_SIZE / DEV_BSIZE) || -(m-valid (1 i)) +(m-valid ((vm_page_bits_t)1 i))

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-03 Thread Kostik Belousov
On Thu, Nov 03, 2011 at 12:40:08AM -0500, Alan Cox wrote: On 11/02/2011 05:32, Andriy Gapon wrote: [restored cc: to the original poster] As Bruce Evans has pointed to me privately [I am not sure why privately], there is already an example in i386 and amd64 atomic.h, where operations are

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-03 Thread Alan Cox
On 11/03/2011 08:24, Kostik Belousov wrote: On Thu, Nov 03, 2011 at 12:40:08AM -0500, Alan Cox wrote: On 11/02/2011 05:32, Andriy Gapon wrote: [restored cc: to the original poster] As Bruce Evans has pointed to me privately [I am not sure why privately], there is already an example in i386 and

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-02 Thread Benjamin Kaduk
On Tue, 1 Nov 2011, Penta Upa wrote: Yes that seems to be the problem. It will is for out of tree modules. http://www.freebsd.org/cgi/query-pr.cgi?pr=161887 . I have to verify if moving the module to /usr/src/ tree fixes the problem. Thanks, Penta On Tue, Nov 1, 2011 at 2:04 AM, K. Macy

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-02 Thread Andriy Gapon
[restored cc: to the original poster] on 02/11/2011 08:10 Benjamin Kaduk said the following: I am perhaps confused. Last I checked, bsd.kmod.mk caused '-include opt_global.h' to be passed on the command line. Is the issue just that the opt_global.h used for the kmod could be different from

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-02 Thread Alan Cox
On 11/02/2011 05:32, Andriy Gapon wrote: [restored cc: to the original poster] on 02/11/2011 08:10 Benjamin Kaduk said the following: I am perhaps confused. Last I checked, bsd.kmod.mk caused '-include opt_global.h' to be passed on the command line. Is the issue just that the opt_global.h

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-11-01 Thread Penta Upa
Yes that seems to be the problem. It will is for out of tree modules. http://www.freebsd.org/cgi/query-pr.cgi?pr=161887 . I have to verify if moving the module to /usr/src/ tree fixes the problem. Thanks, Penta On Tue, Nov 1, 2011 at 2:04 AM, K. Macy km...@freebsd.org wrote: Someone was seeing

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-10-31 Thread K. Macy
Someone was seeing the same issue with the vmtools kmod. The only thing that might make sense is that the page lock array is defined as being a different size in your kmod as in the kernel itself so the lock corresponding to the page you're locking differs between the two files. Cheers On Fri,

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-10-29 Thread Penta Upa
I created a bug report since there wasn't a response to this email. http://www.freebsd.org/cgi/query-pr.cgi?pr=161887 The test code is attached to the bug report. Regards, Penta On Sat, Oct 29, 2011 at 2:23 AM, Sean Bruno sean...@yahoo-inc.com wrote: On Fri, 2011-10-21 at 08:25 -0700, Penta

Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-10-28 Thread Sean Bruno
On Fri, 2011-10-21 at 08:25 -0700, Penta Upa wrote: Attached is a test module (vmtest) and the makefile used. Uname output from the system is I only see a Makefile attached here. Can you attach the code you are using? Sean ___

panic at vm_page_wire with FreeBSD 9.0 Beta 3

2011-10-21 Thread Penta Upa
Hi, I'm facing a kernel panic at vm_page_wire(). Page is locked with vm_page_lock() yet i get the following panic panic: mutex page lock not owned at /usr/src/sys/vm/vm_page:1845 Code sequence is as below vm_page_lock(pp); vm_page_lock_assert(pp, MA_OWNED); /* No panic here */ vm_page_wire(pp);