[Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
Subject says it all. I need a review on the attached patch. Come on, you know you want to... -- Devin _ The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Allan Jude
On 2013-11-06 13:32, Teske, Devin wrote: Subject says it all. I need a review on the attached patch. Come on, you know you want to... I think you missed something, you attached a 1 line diff -- Allan Jude signature.asc Description: OpenPGP digital signature

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
On Nov 6, 2013, at 3:02 PM, Allan Jude wrote: On 2013-11-06 13:32, Teske, Devin wrote: Subject says it all. I need a review on the attached patch. Come on, you know you want to... I think you missed something, you attached a 1 line diff Oh I see... too much to review. Hey, don't

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Allan Jude
On 2013-11-06 18:15, Teske, Devin wrote: On Nov 6, 2013, at 3:02 PM, Allan Jude wrote: On 2013-11-06 13:32, Teske, Devin wrote: Subject says it all. I need a review on the attached patch. Come on, you know you want to... I think you missed something, you attached a 1 line diff Oh I

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
On Nov 6, 2013, at 3:19 PM, Allan Jude wrote: On 2013-11-06 18:15, Teske, Devin wrote: On Nov 6, 2013, at 3:02 PM, Allan Jude wrote: On 2013-11-06 13:32, Teske, Devin wrote: Subject says it all. I need a review on the attached patch. Come on, you know you want to... I think you

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Glen Barber
On Wed, Nov 06, 2013 at 11:28:25PM +, Teske, Devin wrote: We do not ever want to display the contents of the SVR record in the list. There are multiple pkg*.freebsd.org SVR zones. You do not need to show any servers except pkg.FreeBSD.org. In fact, you can use that by default, and not

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
On Nov 6, 2013, at 3:32 PM, Glen Barber wrote: On Wed, Nov 06, 2013 at 11:28:25PM +, Teske, Devin wrote: We do not ever want to display the contents of the SVR record in the list. There are multiple pkg*.freebsd.org SVR zones. You do not need to show any servers except

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Glen Barber
On Wed, Nov 06, 2013 at 11:37:43PM +, Teske, Devin wrote: You do not need to show any servers except pkg.FreeBSD.org. Bapt *just* got finished telling me in IRC that we should also list: pkg.eu pkg.us-* Why? Which I assume to be the same make/model of pkg.f.o (does not return an

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
On Nov 6, 2013, at 3:44 PM, Glen Barber wrote: On Wed, Nov 06, 2013 at 11:37:43PM +, Teske, Devin wrote: You do not need to show any servers except pkg.FreeBSD.org. Bapt *just* got finished telling me in IRC that we should also list: pkg.eu pkg.us-* Why? Which I assume to be

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Glen Barber
On Wed, Nov 06, 2013 at 11:53:28PM +, Teske, Devin wrote: And if we need to change something with the infrastructure, we now have to tell people that this was done. You are putting hard-coded limitations on us. Don't. I disagree. You're making the argument for what if a CDN

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
On Nov 6, 2013, at 3:53 PM, Teske, Devin wrote: On Nov 6, 2013, at 3:44 PM, Glen Barber wrote: On Wed, Nov 06, 2013 at 11:37:43PM +, Teske, Devin wrote: You do not need to show any servers except pkg.FreeBSD.org. Bapt *just* got finished telling me in IRC that we should also list:

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
On Nov 6, 2013, at 4:01 PM, Glen Barber wrote: On Wed, Nov 06, 2013 at 11:53:28PM +, Teske, Devin wrote: And if we need to change something with the infrastructure, we now have to tell people that this was done. You are putting hard-coded limitations on us. Don't. I disagree.

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Glen Barber
On Thu, Nov 07, 2013 at 12:13:49AM +, Teske, Devin wrote: So what hard-coding are you talking about? You are trying to hard-code hostnames for a service in the FreeBSD src/ tree, when it is *absolutely* unnecessary. You talk about how if a node goes down we take it out of DNS but that

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
On Nov 6, 2013, at 4:22 PM, Glen Barber wrote: On Thu, Nov 07, 2013 at 12:13:49AM +, Teske, Devin wrote: So what hard-coding are you talking about? You are trying to hard-code hostnames for a service in the FreeBSD src/ tree, when it is *absolutely* unnecessary. Not all hostnames

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Glen Barber
On Thu, Nov 07, 2013 at 12:48:02AM +, Teske, Devin wrote: I think that you're thinking that: pkg.eu.freebsd.org pkg.us-east.freebsd.org pkg.us-west.freebsd.org Will somehow change? I think you're thinking they *won't* change. Don't assume. Glen pgpYvjMEXknes.pgp Description: PGP

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
On Nov 6, 2013, at 5:02 PM, Glen Barber wrote: On Thu, Nov 07, 2013 at 12:48:02AM +, Teske, Devin wrote: I think that you're thinking that: pkg.eu.freebsd.org pkg.us-east.freebsd.org pkg.us-west.freebsd.org Will somehow change? I think you're thinking they *won't* change. Don't

Re: [Review] bsdconfig pkgng integration

2013-11-06 Thread Teske, Devin
On Nov 6, 2013, at 5:13 PM, Teske, Devin wrote: On Nov 6, 2013, at 5:02 PM, Glen Barber wrote: On Thu, Nov 07, 2013 at 12:48:02AM +, Teske, Devin wrote: I think that you're thinking that: pkg.eu.freebsd.org pkg.us-east.freebsd.org pkg.us-west.freebsd.org Will somehow change?