Re: Apple Trackpad driver

2014-02-04 Thread Hans Petter Selasky
On 02/01/14 08:18, Hans Petter Selasky wrote: On 02/01/14 08:07, Hans Petter Selasky wrote: On 01/31/14 21:30, Danilo E. Gondolfo wrote: I noticed that your driver is based on the Linux driver [1] and some pieces of code are copied, are you sure that we won't have any problems with license?

Re: Apple Trackpad driver

2014-01-31 Thread Danilo E. Gondolfo
On 01/31/14 05:16, Hans Petter Selasky wrote: On 01/31/14 02:46, Huang Wen Hui wrote: Hi Hans, pos_x[] is not non-inialized, it may be previous pos_x, it is still ok for getting dx. n var is trying to reduce untouch sensor data for post proccessing. I attach a new patch may be more

Re: Apple Trackpad driver

2014-01-31 Thread Hans Petter Selasky
On 01/31/14 21:30, Danilo E. Gondolfo wrote: On 01/31/14 05:16, Hans Petter Selasky wrote: On 01/31/14 02:46, Huang Wen Hui wrote: Hi Hans, pos_x[] is not non-inialized, it may be previous pos_x, it is still ok for getting dx. n var is trying to reduce untouch sensor data for post

Re: Apple Trackpad driver

2014-01-31 Thread 黄文辉@Gmail
Hi Hans, Yes, I wrote wsp base on atp(4) and bcm5974.c from Linux. Of course we can add a notice about that. Table and some structure bt_data, tp_finger from Linux, I only wrote wsp_intr_callback base on usbdump, all other part should be belong to Hans. Cheers, Huang Wen Hui 在

Re: Apple Trackpad driver

2014-01-31 Thread Danilo E. Gondolfo
On 01/31/14 21:45, 黄文辉@Gmail wrote: Hi Hans, Yes, I wrote wsp base on atp(4) and bcm5974.c from Linux. Of course we can add a notice about that. Table and some structure bt_data, tp_finger from Linux, I only wrote wsp_intr_callback base on usbdump, all other part should be belong to Hans.

Re: Apple Trackpad driver

2014-01-31 Thread Huang Wen Hui
Hi, I tried to add to support modem macbooks into atp(4) at the beginning, but realized that atp(4) is very different from new touchpad hardware, so I give up, I think some one can do that. Cheers, Huang Wen Hui 2014-02-01 Danilo E. Gondolfo dan...@freebsd.org: On 01/31/14 21:45, 黄文辉@Gmail

Re: Apple Trackpad driver

2014-01-31 Thread Hans Petter Selasky
On 01/31/14 21:30, Danilo E. Gondolfo wrote: I noticed that your driver is based on the Linux driver [1] and some pieces of code are copied, are you sure that we won't have any problems with license? Hi, Hence Huang has only copied so-called header file contents, I think this should be fine.

Re: Apple Trackpad driver

2014-01-31 Thread Hans Petter Selasky
On 02/01/14 08:07, Hans Petter Selasky wrote: On 01/31/14 21:30, Danilo E. Gondolfo wrote: I noticed that your driver is based on the Linux driver [1] and some pieces of code are copied, are you sure that we won't have any problems with license? Hi, Hence Huang has only copied so-called

Re: Apple Trackpad driver

2014-01-30 Thread Huang Wen Hui
Hi Hans, pos_x[] is not non-inialized, it may be previous pos_x, it is still ok for getting dx. n var is trying to reduce untouch sensor data for post proccessing. I attach a new patch may be more clear, also fixed unexpected movement when button status or ntouch changing. Cheers, Huang Wen

Re: Apple Trackpad driver

2014-01-30 Thread Hans Petter Selasky
On 01/31/14 02:46, Huang Wen Hui wrote: Hi Hans, pos_x[] is not non-inialized, it may be previous pos_x, it is still ok for getting dx. n var is trying to reduce untouch sensor data for post proccessing. I attach a new patch may be more clear, also fixed unexpected movement when button status

Re: Apple Trackpad driver

2014-01-29 Thread Lundberg, Johannes
Hi I tested the driver on a 2012 Macbook Air 11 and it works great! Good job! Is there a way to disable click-by-touch? I always preferred clicking with the physical button that is built in to the pad. Best regards -- Johannes Lundberg BRILLIANTSERVICE CO., LTD. On Wed, Jan 29, 2014 at 2:24

Re: Apple Trackpad driver

2014-01-29 Thread Hans Petter Selasky
On 01/29/14 09:49, Lundberg, Johannes wrote: Hi I tested the driver on a 2012 Macbook Air 11 and it works great! Good job! Is there a way to disable click-by-touch? I always preferred clicking with the physical button that is built in to the pad. Hi, I've added an #if 0 around the 1 finger

Re: Apple Trackpad driver

2014-01-29 Thread Hans Petter Selasky
Hi, Can you also write a manual page for the wsp driver? --HPS ___ freebsd-current@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to freebsd-current-unsubscr...@freebsd.org

Re: Apple Trackpad driver

2014-01-29 Thread Mark Felder
On Tue, Jan 28, 2014, at 23:13, Adrian Chadd wrote: holy crap, cool! Hans? Any chance we could get this into -HEAD? Wow, this is nice. I'll gladly provide the USB device ID for the trackpad in the 2013 Late MBP if someone can point me to a way to boot FreeBSD from an external drive :-)

Re: Apple Trackpad driver

2014-01-29 Thread Huang Wen Hui
Hans, Thanks for you take care of it and commit it! I found two problems: 1. The selection is not expected when selection with 2 fingers sometimes. 2. Unexpected scrolling when Click with 2 fingers. This patch can fix that. The var n modify to ntouch seems to be necessary. Cheers, Huang Wen

Re: Apple Trackpad driver

2014-01-29 Thread Hans Petter Selasky
Hi Huang, On 01/30/14 06:56, Huang Wen Hui wrote: Hans, Thanks for you take care of it and commit it! I found two problems: 1. The selection is not expected when selection with 2 fingers sometimes. 2. Unexpected scrolling when Click with 2 fingers. This patch can fix that. The var n modify

Apple Trackpad driver

2014-01-28 Thread Huang Wen Hui
Hi, I have a working trackpad driver for my MBP 2013, I am not C programmer usually, so the code may ugly. If someone like to test, you can download it from http://sw.gddsn.org.cn/freebsd/wsp-140129.tar.gz, I only test it on MBP2012 and MBP2013. Right now the driver have these feature: 1.

Re: Apple Trackpad driver

2014-01-28 Thread Adrian Chadd
holy crap, cool! Hans? Any chance we could get this into -HEAD? -a On 28 January 2014 17:43, Huang Wen Hui huang...@gmail.com wrote: Hi, I have a working trackpad driver for my MBP 2013, I am not C programmer usually, so the code may ugly. If someone like to test, you can download it

Re: Apple Trackpad driver

2014-01-28 Thread Lundberg, Johannes
This is really good news :) I will try it on my 2012 and 2013 MBAs soon! (hopefully it is same hardware as in the pros) -- Johannes Lundberg BRILLIANTSERVICE CO., LTD. On Wed, Jan 29, 2014 at 2:13 PM, Adrian Chadd adr...@freebsd.org wrote: holy crap, cool! Hans? Any chance we could get